XoopsModules\Oledrion\DeliveryPaymentHandler::getDeliveryPaymantId()

Complexity

Conditions	4
Paths	3

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getDeliveryPaymantId($parameters)
    {
        $ret = [];
        if (!$parameters['delivery']) {
            return $ret;
        }
        $critere = new \CriteriaCompo();
        $critere->add(new \Criteria('dp_delivery', $parameters['delivery']));
        $obj = $this->getObjects($critere);
        if ($obj) {

The expression $obj of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($obj as $root) {
                $tab                              = [];

The assignment to $tab is dead and can be removed.

                $tab                              = $root->toArray();
                $ret[$root->getVar('dp_payment')] = $tab;
            }
        }

        return $ret;
    }