XoopsModules25x / news

blocks/news_topics.php

<?php declare(strict_types=1);
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright      {@link https://xoops.org/ XOOPS Project}
 * @license        {@link https://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @author         XOOPS Development Team
 */

use XoopsModules\News\{
    Helper,
    NewsTopic,
    ObjectTree,
    Utility
};

/**
 * @return mixed
 */
function b_news_topics_show()
{
    global $storytopic; // Don't know why this is used and where it's coming from ....
    //    require_once XOOPS_ROOT_PATH . '/modules/news/class/class.newstopic.php';
    //    require_once XOOPS_ROOT_PATH . '/modules/news/class/tree.php';

    $moduleDirName = \basename(\dirname(__DIR__));

The assignment to $moduleDirName is dead and can be removed.

    /** @var Helper $helper */
    if (!class_exists(Helper::class)) {
        return false;
    }

    $helper = Helper::getInstance();

The assignment to $helper is dead and can be removed.

    $jump       = XOOPS_URL . '/modules/news/index.php?storytopic=';
    $storytopic = !empty($storytopic) ? $storytopic : 0;
    $restricted = Utility::getModuleOption('restrictindex');

    $xt         = new NewsTopic();
    $allTopics  = $xt->getAllTopics($restricted);
    $topic_tree = new ObjectTree($allTopics, 'topic_id', 'topic_pid');
    $additional = " onchange='location=\"" . $jump . "\"+this.options[this.selectedIndex].value'";

    if (Utility::checkVerXoops($GLOBALS['xoopsModule'], '2.5.9')) {
        //                $block['selectbox'] = $topic_tree->makeSelBox('storytopic', 'topic_title', '-- ', '', true, 0, $additional);
        $topicSelect        = $topic_tree->makeSelectElement('storytopic', 'topic_title', '--', '', true, 0, $additional);
        $block['selectbox'] = $topicSelect->render();

$block was never initialized. Although not strictly required by PHP, it is generally a good practice to add $block = array(); before regardless.

    } else {
        $block['selectbox'] = $topic_tree->makeSelBox('storytopic', 'topic_title', '-- ', '', true, 0, $additional);

The function XoopsModules\News\ObjectTree::makeSelBox() has been deprecated: since 2.5.9, please use makeSelectElement()

    }

    return $block;
}

/**
 * @param $options
 */
function b_news_topics_onthefly($options): void
{
    $options = explode('|', $options);
    $block   = b_news_topics_show($options);

The call to b_news_topics_show() has too many arguments starting with $options.

    $tpl = new \XoopsTpl();
    $tpl->assign('block', $block);
    $tpl->display('db:news_block_topics.tpl');
}