XoopsModules25x /
news
| Conditions | 4 |
| Paths | 8 |
| Total Lines | 194 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 88 | function PrintPage() |
||
| 89 | { |
||
| 90 | global $xoopsConfig, $xoopsModule, $story, $xoops_meta_keywords, $xoops_meta_description; |
||
| 91 | $myts = \MyTextSanitizer::getInstance(); |
||
|
Unused Code
introduced
by
|
|||
| 92 | $datetime = formatTimestamp($story->published(), News\Utility::getModuleOption('dateformat')); ?> |
||
| 93 | <!DOCTYPE html> |
||
| 94 | <html xml:lang="<?php echo _LANGCODE; ?>" lang="<?php echo _LANGCODE; ?>"> |
||
| 95 | <?php |
||
| 96 | echo "<head>\n"; |
||
| 97 | echo '<title>' . htmlspecialchars($story->title(), ENT_QUOTES | ENT_HTML5) . ' - ' . _NW_PRINTER . ' - ' . htmlspecialchars($story->topic_title(), ENT_QUOTES | ENT_HTML5) . ' - ' . $xoopsConfig['sitename'] . '</title>'; |
||
| 98 | echo '<meta http-equiv="Content-Type" content="text/html; charset=' . _CHARSET . '">'; |
||
| 99 | echo '<meta name="author" content="XOOPS">'; |
||
| 100 | echo '<meta name="keywords" content="' . $xoops_meta_keywords . '">'; |
||
| 101 | echo '<meta name="COPYRIGHT" content="Copyright (c) 2014 by ' . $xoopsConfig['sitename'] . '">'; |
||
| 102 | echo '<meta name="DESCRIPTION" content="' . $xoops_meta_description . '">'; |
||
| 103 | echo '<meta name="generator" content="XOOPS">'; |
||
| 104 | echo '<meta name="robots" content="noindex,nofollow">'; |
||
| 105 | if (file_exists(XOOPS_ROOT_PATH . '/language/' . $GLOBALS['xoopsConfig']['language'] . '/style.css')) { |
||
| 106 | echo '<link rel="stylesheet" type="text/css" media="all" title="Style sheet" href="' . XOOPS_URL . '/language/' . $GLOBALS['xoopsConfig']['language'] . '/style.css">'; |
||
| 107 | } else { |
||
| 108 | echo '<link rel="stylesheet" type="text/css" media="all" title="Style sheet" href="' . XOOPS_URL . '/language/english/style.css">'; |
||
| 109 | } |
||
| 110 | echo '<link rel="stylesheet" type="text/css" media="all" title="Style sheet" href="' . XOOPS_URL . '/modules/news/assets/css/print.css">'; |
||
| 111 | $supplemental = ''; |
||
| 112 | if (News\Utility::getModuleOption('footNoteLinks')) { |
||
| 113 | $supplemental = "footnoteLinks('content','content'); "; ?> |
||
| 114 | <script type="text/javascript"> |
||
| 115 | // <![CDATA[ |
||
| 116 | /*------------------------------------------------------------------------------ |
||
| 117 | Function: footnoteLinks() |
||
| 118 | Author: Aaron Gustafson (aaron at easy-designs dot net) |
||
| 119 | Creation Date: 8 May 2005 |
||
| 120 | Version: 1.3 |
||
| 121 | Homepage: http://www.easy-designs.net/code/footnoteLinks/ |
||
| 122 | License: Creative Commons Attribution-ShareAlike 2.0 License |
||
| 123 | http://creativecommons.org/licenses/by-sa/2.0/ |
||
| 124 | Note: This version has reduced functionality as it is a demo of |
||
| 125 | the script's development |
||
| 126 | ------------------------------------------------------------------------------*/ |
||
| 127 | function footnoteLinks(containerID, targetID) { |
||
| 128 | if (!document.getElementById || !document.getElementsByTagName || !document.createElement) return false; |
||
| 129 | if (!document.getElementById(containerID) || !document.getElementById(targetID)) return false; |
||
| 130 | var container = document.getElementById(containerID); |
||
| 131 | var target = document.getElementById(targetID); |
||
| 132 | var h2 = document.createElement('h2'); |
||
| 133 | addClass.apply(h2, ['printOnly']); |
||
| 134 | var h2_txt = document.createTextNode('<?php echo _NW_LINKS; ?>'); |
||
| 135 | h2.appendChild(h2_txt); |
||
| 136 | var coll = container.getElementsByTagName('*'); |
||
| 137 | var ol = document.createElement('ol'); |
||
| 138 | addClass.apply(ol, ['printOnly']); |
||
| 139 | var myArr = []; |
||
| 140 | var thisLink; |
||
| 141 | var num = 1; |
||
| 142 | for (var i = 0; i < coll.length; i++) { |
||
| 143 | if (coll[i].getAttribute('href') || |
||
| 144 | coll[i].getAttribute('cite')) { |
||
| 145 | thisLink = coll[i].getAttribute('href') ? coll[i].href : coll[i].cite; |
||
| 146 | var note = document.createElement('sup'); |
||
| 147 | addClass.apply(note, ['printOnly']); |
||
| 148 | var note_txt; |
||
| 149 | var j = inArray.apply(myArr, [thisLink]); |
||
| 150 | if (j || j === 0) { // if a duplicate |
||
| 151 | // get the corresponding number from |
||
| 152 | // the array of used links |
||
| 153 | note_txt = document.createTextNode(j + 1); |
||
| 154 | } else { // if not a duplicate |
||
| 155 | var li = document.createElement('li'); |
||
| 156 | var li_txt = document.createTextNode(thisLink); |
||
| 157 | li.appendChild(li_txt); |
||
| 158 | ol.appendChild(li); |
||
| 159 | myArr.push(thisLink); |
||
| 160 | note_txt = document.createTextNode(num); |
||
| 161 | num++; |
||
| 162 | } |
||
| 163 | note.appendChild(note_txt); |
||
| 164 | if (coll[i].tagName.toLowerCase() === 'blockquote') { |
||
| 165 | var lastChild = lastChildContainingText.apply(coll[i]); |
||
| 166 | lastChild.appendChild(note); |
||
| 167 | } else { |
||
| 168 | coll[i].parentNode.insertBefore(note, coll[i].nextSibling); |
||
| 169 | } |
||
| 170 | } |
||
| 171 | } |
||
| 172 | target.appendChild(h2); |
||
| 173 | target.appendChild(ol); |
||
| 174 | |||
| 175 | return true; |
||
| 176 | } |
||
| 177 | |||
| 178 | // ]]> |
||
| 179 | </script> |
||
| 180 | <script type="text/javascript"> |
||
| 181 | // <![CDATA[ |
||
| 182 | /*------------------------------------------------------------------------------ |
||
| 183 | Excerpts from the jsUtilities Library |
||
| 184 | Version: 2.1 |
||
| 185 | Homepage: http://www.easy-designs.net/code/jsUtilities/ |
||
| 186 | License: Creative Commons Attribution-ShareAlike 2.0 License |
||
| 187 | http://creativecommons.org/licenses/by-sa/2.0/ |
||
| 188 | Note: If you change or improve on this script, please let us know. |
||
| 189 | ------------------------------------------------------------------------------*/ |
||
| 190 | if (Array.prototype.push === null) { |
||
| 191 | Array.prototype.push = function (item) { |
||
| 192 | this[this.length] = item; |
||
| 193 | |||
| 194 | return this.length; |
||
| 195 | }; |
||
| 196 | } |
||
| 197 | // --------------------------------------------------------------------- |
||
| 198 | // function.apply (if unsupported) |
||
| 199 | // Courtesy of Aaron Boodman - http://youngpup.net |
||
| 200 | // --------------------------------------------------------------------- |
||
| 201 | if (!Function.prototype.apply) { |
||
| 202 | Function.prototype.apply = function (oScope, args) { |
||
| 203 | var sarg = []; |
||
| 204 | var rtrn, call; |
||
| 205 | if (!oScope) oScope = window; |
||
| 206 | if (!args) args = []; |
||
| 207 | for (var i = 0; i < args.length; i++) { |
||
| 208 | sarg[i] = "args[" + i + "]"; |
||
| 209 | } |
||
| 210 | call = "oScope.__applyTemp__(" + sarg.join(",") + ");"; |
||
| 211 | oScope.__applyTemp__ = this; |
||
| 212 | rtrn = eval(call); |
||
| 213 | oScope.__applyTemp__ = null; |
||
| 214 | |||
| 215 | return rtrn; |
||
| 216 | }; |
||
| 217 | } |
||
| 218 | |||
| 219 | function inArray(needle) { |
||
| 220 | for (var i = 0; i < this.length; i++) { |
||
| 221 | if (this[i] === needle) { |
||
| 222 | return i; |
||
| 223 | } |
||
| 224 | } |
||
| 225 | |||
| 226 | return false; |
||
| 227 | } |
||
| 228 | |||
| 229 | function addClass(theClass) { |
||
| 230 | if (this.className !== '') { |
||
| 231 | this.className += ' ' + theClass; |
||
| 232 | } else { |
||
| 233 | this.className = theClass; |
||
| 234 | } |
||
| 235 | } |
||
| 236 | |||
| 237 | function lastChildContainingText() { |
||
| 238 | var testChild = this.lastChild; |
||
| 239 | var contentCntnr = ['p', 'li', 'dd']; |
||
| 240 | while (testChild.nodeType != 1) { |
||
| 241 | testChild = testChild.previousSibling; |
||
| 242 | } |
||
| 243 | var tag = testChild.tagName.toLowerCase(); |
||
| 244 | var tagInArr = inArray.apply(contentCntnr, [tag]); |
||
| 245 | if (!tagInArr && tagInArr !== 0) { |
||
| 246 | testChild = lastChildContainingText.apply(testChild); |
||
| 247 | } |
||
| 248 | |||
| 249 | return testChild; |
||
| 250 | } |
||
| 251 | |||
| 252 | // ]]> |
||
| 253 | </script> |
||
| 254 | <style type="text/css" media="screen"> |
||
| 255 | .printOnly { |
||
| 256 | display: none; |
||
| 257 | } |
||
| 258 | </style> |
||
| 259 | <?php |
||
| 260 | } |
||
| 261 | echo '</head>'; |
||
| 262 | echo '<body bgcolor="#ffffff" text="#000000" onload="' . $supplemental . ' window.print()"> |
||
| 263 | <div id="content"> |
||
| 264 | <table border="0"><tr><td align="center"> |
||
| 265 | <table border="0" width="100%" cellpadding="0" cellspacing="1" bgcolor="#000000"><tr><td> |
||
| 266 | <table border="0" width="100%" cellpadding="20" cellspacing="1" bgcolor="#ffffff"><tr><td align="center"> |
||
| 267 | <img src="' . XOOPS_URL . '/images/logo.png" border="0" alt=""><br><br> |
||
| 268 | <h3>' . $story->title() . '</h3> |
||
| 269 | <small><b>' . _NW_DATE . '</b> ' . $datetime . ' | <b>' . _NW_TOPICC . '</b> ' . htmlspecialchars($story->topic_title(), ENT_QUOTES | ENT_HTML5) . '</small><br><br></td></tr>'; |
||
| 270 | echo '<tr valign="top" style="font:12px;"><td>' . $story->hometext() . '<br>'; |
||
| 271 | $bodytext = $story->bodytext(); |
||
| 272 | $bodytext = str_replace('[pagebreak]', '<br style="page-break-after:always;">', $bodytext); |
||
| 273 | if ('' !== $bodytext) { |
||
| 274 | echo $bodytext . '<br><br>'; |
||
| 275 | } |
||
| 276 | echo '</td></tr></table></td></tr></table> |
||
| 277 | <br><br>'; |
||
| 278 | printf(_NW_THISCOMESFROM, htmlspecialchars($xoopsConfig['sitename'], ENT_QUOTES)); |
||
| 279 | echo '<br><a href="' . XOOPS_URL . '/">' . XOOPS_URL . '</a><br><br> |
||
| 280 | ' . _NW_URLFORSTORY . ' <!-- Tag below can be used to display Permalink image --><!--img src="' . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/assets/images/x.gif" /--><br> |
||
| 281 | <a class="ignore" href="' . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/article.php?storyid=' . $story->storyid() . '">' . XOOPS_URL . '/modules/news/article.php?storyid=' . $story->storyid() . '</a> |
||
| 282 | </td></tr></table></div> |
||
| 289 |
Loading history...