include/search.inc.php ➔ news_search()

Complexity

Conditions	27
Paths	420

Size

Total Lines	113
Code Lines	79

Duplication

Lines	10
Ratio	8.85 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function news_search($queryarray, $andor, $limit, $offset, $userid)
{
    global $xoopsDB, $xoopsUser;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    include_once XOOPS_ROOT_PATH . '/modules/news/include/functions.php';
    $restricted = news_getmoduleoption('restrictindex');
    $highlight  = false;

$highlight is not used, you could remove the assignment.

    $highlight  = news_getmoduleoption('keywordshighlight'); // keywords highlighting

    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname('news');
    $modid         = $module->getVar('mid');
    $searchparam   = '';

    $gperm_handler = xoops_getHandler('groupperm');
    if (is_object($xoopsUser)) {
        $groups = $xoopsUser->getGroups();
    } else {
        $groups = XOOPS_GROUP_ANONYMOUS;
    }

    $sql =
        'SELECT storyid, topicid, uid, title, created FROM ' . $xoopsDB->prefix('news_stories') . ' WHERE (published>0 AND published<=' . time() . ') AND (expired = 0 OR expired > ' . time() . ') ';

    if ($userid != 0) {
        $sql .= ' AND uid=' . $userid . ' ';
    }
    // because count() returns 1 even if a supplied variable
    // is not an array, we must check if $querryarray is really an array
    if (is_array($queryarray) && $count = count($queryarray)) {
        $sql .= " AND ((hometext LIKE '%$queryarray[0]%' OR bodytext LIKE '%$queryarray[0]%' OR title LIKE '%$queryarray[0]%' OR keywords LIKE '%$queryarray[0]%' OR description LIKE '%$queryarray[0]%')";
        for ($i = 1; $i < $count; ++$i) {
            $sql .= " $andor ";
            $sql .= "(hometext LIKE '%$queryarray[$i]%' OR bodytext LIKE '%$queryarray[$i]%' OR title LIKE '%$queryarray[$i]%' OR keywords LIKE '%$queryarray[$i]%' OR description LIKE '%$queryarray[$i]%')";
        }
        $sql .= ') ';
        // keywords highlighting
        if ($highlight) {
            $searchparam = '&keywords=' . urlencode(trim(implode(' ', $queryarray)));
        }
    }

    $sql .= 'ORDER BY created DESC';
    $result = $xoopsDB->query($sql, $limit, $offset);
    $ret    = array();
    $i      = 0;
    while ($myrow = $xoopsDB->fetchArray($result)) {
        $display = true;
        if ($modid && $gperm_handler) {

This code seems to be duplicated across your project.

            if ($restricted && !$gperm_handler->checkRight('news_view', $myrow['topicid'], $groups, $modid)) {
                $display = false;
            }
        }

        if ($display) {
            $ret[$i]['image'] = 'assets/images/news.png';
            $ret[$i]['link']  = 'article.php?storyid=' . $myrow['storyid'] . '' . $searchparam;
            $ret[$i]['title'] = $myrow['title'];
            $ret[$i]['time']  = $myrow['created'];
            $ret[$i]['uid']   = $myrow['uid'];
            ++$i;
        }
    }

    include_once XOOPS_ROOT_PATH . '/modules/news/config.php';
    $searchincomments = $cfg['config_search_comments'];

The variable $cfg does not exist. Did you forget to declare it?

    if ($searchincomments && (isset($limit) && $i <= $limit)) {
        include_once XOOPS_ROOT_PATH . '/include/comment_constants.php';
        $ind = $i;
        $sql = 'SELECT com_id, com_modid, com_itemid, com_created, com_uid, com_title, com_text, com_status FROM '
               . $xoopsDB->prefix('xoopscomments')
               . " WHERE (com_id>0) AND (com_modid=$modid) AND (com_status="
               . XOOPS_COMMENT_ACTIVE
               . ') ';
        if ($userid != 0) {
            $sql .= ' AND com_uid=' . $userid . ' ';
        }

        if (is_array($queryarray) && $count = count($queryarray)) {
            $sql .= " AND ((com_title LIKE '%$queryarray[0]%' OR com_text LIKE '%$queryarray[0]%')";
            for ($i = 1; $i < $count; ++$i) {
                $sql .= " $andor ";
                $sql .= "(com_title LIKE '%$queryarray[$i]%' OR com_text LIKE '%$queryarray[$i]%')";
            }
            $sql .= ') ';
        }
        $i = $ind;
        $sql .= 'ORDER BY com_created DESC';
        $result = $xoopsDB->query($sql, $limit, $offset);
        while ($myrow = $xoopsDB->fetchArray($result)) {
            $display = true;
            if ($modid && $gperm_handler) {

This code seems to be duplicated across your project.

                if ($restricted && !$gperm_handler->checkRight('news_view', $myrow['com_itemid'], $groups, $modid)) {
                    $display = false;
                }
            }
            if ($i + 1 > $limit) {
                $display = false;
            }

            if ($display) {
                $ret[$i]['image'] = 'assets/images/news.png';
                $ret[$i]['link']  = 'article.php?storyid=' . $myrow['com_itemid'] . '' . $searchparam;
                $ret[$i]['title'] = $myrow['com_title'];
                $ret[$i]['time']  = $myrow['com_created'];
                $ret[$i]['uid']   = $myrow['com_uid'];
                ++$i;
            }
        }
    }

    return $ret;
}