admin/index.php ➔ addTopic()

Complexity

Conditions	19
Paths	1282

Size

Total Lines	78
Code Lines	56

Duplication

Lines	39
Ratio	50 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function addTopic()

addTopic uses the super-global variable $_POST which is generally not recommended.

addTopic uses the super-global variable $_SESSION which is generally not recommended.

addTopic uses the super-global variable $_FILES which is generally not recommended.

{
    global $xoopsDB, $xoopsModule, $xoopsModuleConfig;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    $topicpid = isset($_POST['topic_pid']) ? (int)$_POST['topic_pid'] : 0;
    $xt       = new NewsTopic();
    if (!$xt->topicExists($topicpid, $_POST['topic_title'])) {
        $xt->setTopicPid($topicpid);
        if (empty($_POST['topic_title']) || xoops_trim($_POST['topic_title']) == '') {
            redirect_header('index.php?op=topicsmanager', 2, _AM_ERRORTOPICNAME);
        }
        $xt->setTopicTitle($_POST['topic_title']);
        //$xt->Settopic_rssurl($_POST['topic_rssfeed']);

90% of this comment could be valid code. Did you maybe forget this after debugging?

        $xt->setTopic_color($_POST['topic_color']);
        if (isset($_POST['topic_imgurl']) && $_POST['topic_imgurl'] !== '') {

This code seems to be duplicated across your project.

            $xt->setTopicImgurl($_POST['topic_imgurl']);
        }
        $xt->setMenu((int)$_POST['submenu']);
        $xt->setTopicFrontpage((int)$_POST['topic_frontpage']);
        if (isset($_SESSION['items_count'])) {
            $_SESSION['items_count'] = -1;
        }
        if (isset($_POST['xoops_upload_file'])) {

This code seems to be duplicated across your project.

            $fldname = $_FILES[$_POST['xoops_upload_file'][0]];
            $fldname = $fldname['name'];
            if (xoops_trim($fldname !== '')) {
                $sfiles         = new sFiles();
                $dstpath        = XOOPS_ROOT_PATH . '/uploads/news/image';
                $destname       = $sfiles->createUploadName($dstpath, $fldname, true);
                $permittedtypes = array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png');
                $uploader       = new XoopsMediaUploader($dstpath, $permittedtypes, $xoopsModuleConfig['maxuploadsize']);
                $uploader->setTargetFileName($destname);
                if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
                    if ($uploader->upload()) {
                        $xt->setTopicImgurl(basename($destname));
                    } else {
                        echo _AM_UPLOAD_ERROR . ' ' . $uploader->getErrors();
                    }
                } else {
                    echo $uploader->getErrors();
                }
            }
        }
        if (isset($_POST['topic_description'])) {
            $xt->setTopicDescription($_POST['topic_description']);
        } else {
            $xt->setTopicDescription('');
        }
        $xt->store();
        // Permissions
        $gperm_handler = xoops_getHandler('groupperm');
        if (isset($_POST['groups_news_can_approve'])) {

This code seems to be duplicated across your project.

            foreach ($_POST['groups_news_can_approve'] as $onegroup_id) {
                $gperm_handler->addRight('news_approve', $xt->topic_id(), $onegroup_id, $xoopsModule->getVar('mid'));
            }
        }

        if (isset($_POST['groups_news_can_submit'])) {

This code seems to be duplicated across your project.

            foreach ($_POST['groups_news_can_submit'] as $onegroup_id) {
                $gperm_handler->addRight('news_submit', $xt->topic_id(), $onegroup_id, $xoopsModule->getVar('mid'));
            }
        }

        if (isset($_POST['groups_news_can_view'])) {

This code seems to be duplicated across your project.

            foreach ($_POST['groups_news_can_view'] as $onegroup_id) {
                $gperm_handler->addRight('news_view', $xt->topic_id(), $onegroup_id, $xoopsModule->getVar('mid'));
            }
        }
        news_updateCache();

        $notification_handler = xoops_getHandler('notification');
        $tags                 = array();
        $tags['TOPIC_NAME']   = $_POST['topic_title'];
        $notification_handler->triggerEvent('global', 0, 'new_category', $tags);
        redirect_header('index.php?op=topicsmanager', 1, _AM_DBUPDATED);
    } else {
        redirect_header('index.php?op=topicsmanager', 2, _AM_ADD_TOPIC_ERROR);
    }
}