include/update_function.php ➔ xoops_module_update_news()

Complexity

Conditions	31
Paths	> 20000

Size

Total Lines	168
Code Lines	93

Duplication

Lines	81
Ratio	48.21 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function xoops_module_update_news()
{
    include_once XOOPS_ROOT_PATH . '/modules/news/include/functions.php';
    global $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    $errors = 0;

    //0) Rename all tables

    if (news_TableExists($xoopsDB->prefix('stories_files'))) {
        $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('stories_files') . ' RENAME ' . $xoopsDB->prefix('news_stories_files'));
        $result = $xoopsDB->queryF($sql);
        if (!$result) {
            echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED2;
            ++$errors;
        }
    } else {

This code seems to be duplicated across your project.

        // 1) Create, if it does not exists, the stories_files table
        if (!news_TableExists($xoopsDB->prefix('news_stories_files'))) {
            $sql = 'CREATE TABLE ' . $xoopsDB->prefix('news_stories_files') . " (
              fileid int(8) unsigned NOT NULL auto_increment,
              filerealname varchar(255) NOT NULL default '',
              storyid int(8) unsigned NOT NULL default '0',
              date int(10) NOT NULL default '0',
              mimetype varchar(64) NOT NULL default '',
              downloadname varchar(255) NOT NULL default '',
              counter int(8) unsigned NOT NULL default '0',
              PRIMARY KEY  (fileid),
              KEY storyid (storyid)
            ) ENGINE=MyISAM;";
            if (!$xoopsDB->queryF($sql)) {
                echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED1;
                ++$errors;
            }
        }
    }

    if (news_TableExists($xoopsDB->prefix('stories'))) {

This code seems to be duplicated across your project.

        $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('stories') . ' RENAME ' . $xoopsDB->prefix('news_stories'));
        $result = $xoopsDB->queryF($sql);
        if (!$result) {
            echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (news_TableExists($xoopsDB->prefix('topics'))) {

This code seems to be duplicated across your project.

        $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('topics') . ' RENAME ' . $xoopsDB->prefix('news_topics'));
        $result = $xoopsDB->queryF($sql);
        if (!$result) {
            echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED2;
            ++$errors;
        }
    }

    if (news_TableExists($xoopsDB->prefix('stories_files'))) {

This code seems to be duplicated across your project.

        $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('stories_files') . ' RENAME ' . $xoopsDB->prefix('news_stories_files'));
        $result = $xoopsDB->queryF($sql);
        if (!$result) {
            echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED2;
            ++$errors;
        }
    }

    // 2) Change the topic title's length, in the topics table
    $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('news_topics') . ' CHANGE topic_title topic_title VARCHAR( 255 ) NOT NULL;');
    $result = $xoopsDB->queryF($sql);
    if (!$result) {
        echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED2;
        ++$errors;
    }

    // 2.1) Add the new fields to the topic table
    if (!news_FieldExists('menu', $xoopsDB->prefix('news_topics'))) {
        news_AddField("menu TINYINT( 1 ) DEFAULT '0' NOT NULL", $xoopsDB->prefix('news_topics'));
    }
    if (!news_FieldExists('topic_frontpage', $xoopsDB->prefix('news_topics'))) {
        news_AddField("topic_frontpage TINYINT( 1 ) DEFAULT '1' NOT NULL", $xoopsDB->prefix('news_topics'));
    }
    if (!news_FieldExists('topic_rssurl', $xoopsDB->prefix('news_topics'))) {
        news_AddField('topic_rssurl VARCHAR( 255 ) NOT NULL', $xoopsDB->prefix('news_topics'));
    }
    if (!news_FieldExists('topic_description', $xoopsDB->prefix('news_topics'))) {
        news_AddField('topic_description TEXT NOT NULL', $xoopsDB->prefix('news_topics'));
    }
    if (!news_FieldExists('topic_color', $xoopsDB->prefix('news_topics'))) {
        news_AddField("topic_color varchar(6) NOT NULL default '000000'", $xoopsDB->prefix('news_topics'));
    }

    // 3) If it does not exists, create the table stories_votedata
    if (!news_TableExists($xoopsDB->prefix('news_stories_votedata'))) {

This code seems to be duplicated across your project.

        $sql = 'CREATE TABLE ' . $xoopsDB->prefix('news_stories_votedata') . " (
              ratingid int(11) unsigned NOT NULL auto_increment,
              storyid int(8) unsigned NOT NULL default '0',
              ratinguser int(11) NOT NULL default '0',
              rating tinyint(3) unsigned NOT NULL default '0',
              ratinghostname varchar(60) NOT NULL default '',
              ratingtimestamp int(10) NOT NULL default '0',
              PRIMARY KEY  (ratingid),
              KEY ratinguser (ratinguser),
              KEY ratinghostname (ratinghostname),
              KEY storyid (storyid)
            ) ENGINE=MyISAM;";
        if (!$xoopsDB->queryF($sql)) {
            echo '<br>' . _AM_NEWS_UPGRADEFAILED . ' ' . _AM_NEWS_UPGRADEFAILED3;
            ++$errors;
        }
    }

    // 4) Create the four new fields for the votes in the story table
    if (!news_FieldExists('rating', $xoopsDB->prefix('news_stories'))) {
        news_AddField("rating DOUBLE( 6, 4 ) DEFAULT '0.0000' NOT NULL", $xoopsDB->prefix('news_stories'));
    }
    if (!news_FieldExists('votes', $xoopsDB->prefix('news_stories'))) {
        news_AddField("votes INT( 11 ) UNSIGNED DEFAULT '0' NOT NULL", $xoopsDB->prefix('news_stories'));
    }
    if (!news_FieldExists('keywords', $xoopsDB->prefix('news_stories'))) {
        news_AddField('keywords VARCHAR(255) NOT NULL', $xoopsDB->prefix('news_stories'));
    }
    if (!news_FieldExists('description', $xoopsDB->prefix('news_stories'))) {
        news_AddField('description VARCHAR(255) NOT NULL', $xoopsDB->prefix('news_stories'));
    }
    if (!news_FieldExists('pictureinfo', $xoopsDB->prefix('news_stories'))) {
        news_AddField('pictureinfo VARCHAR(255) NOT NULL', $xoopsDB->prefix('news_stories'));
    }
    if (!news_FieldExists('subtitle', $xoopsDB->prefix('news_stories'))) {
        news_AddField('subtitle VARCHAR(255) NOT NULL', $xoopsDB->prefix('news_stories'));
    }

    // 5) Add some indexes to the topics table
    $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('news_topics') . ' ADD INDEX ( `topic_title` );');
    $result = $xoopsDB->queryF($sql);

$result is not used, you could remove the assignment.

    $sql    = sprintf('ALTER TABLE ' . $xoopsDB->prefix('news_topics') . ' ADD INDEX ( `menu` );');
    $result = $xoopsDB->queryF($sql);

$result is not used, you could remove the assignment.

    // 6) Make files and folders
    $dir = XOOPS_ROOT_PATH . '/uploads/news';
    if (!is_dir($dir)) {

This code seems to be duplicated across your project.

        mkdir($dir);
        chmod($dir, 0777);
    } elseif (!is_writable($dir)) {
        chmod($dir, 0777);
    }

    $dir = XOOPS_ROOT_PATH . '/uploads/news/file';
    if (!is_dir($dir)) {

This code seems to be duplicated across your project.

        mkdir($dir);
        chmod($dir, 0777);
    } elseif (!is_writable($dir)) {
        chmod($dir, 0777);
    }

    $dir = XOOPS_ROOT_PATH . '/uploads/news/image';
    if (!is_dir($dir)) {

This code seems to be duplicated across your project.

        mkdir($dir);
        chmod($dir, 0777);
    } elseif (!is_writable($dir)) {
        chmod($dir, 0777);
    }

    // Copy index.html files on uploads folders
    $indexFile = XOOPS_ROOT_PATH . '/modules/news/include/index.html';
    copy($indexFile, XOOPS_ROOT_PATH . '/uploads/news/index.html');
    copy($indexFile, XOOPS_ROOT_PATH . '/uploads/news/file/index.html');
    copy($indexFile, XOOPS_ROOT_PATH . '/uploads/news/image/index.html');

    return true;
}