Conditions | 27 |
Paths | 420 |
Total Lines | 109 |
Lines | 10 |
Ratio | 9.17 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
31 | function news_search($queryarray, $andor, $limit, $offset, $userid) |
||
32 | { |
||
33 | global $xoopsDB, $xoopsUser; |
||
34 | $restricted = News\Utility::getModuleOption('restrictindex'); |
||
35 | $highlight = false; |
||
|
|||
36 | $highlight = News\Utility::getModuleOption('keywordshighlight'); // keywords highlighting |
||
37 | |||
38 | /** @var \XoopsModuleHandler $moduleHandler */ |
||
39 | $moduleHandler = xoops_getHandler('module'); |
||
40 | $module = $moduleHandler->getByDirname('news'); |
||
41 | $modid = $module->getVar('mid'); |
||
42 | $searchparam = ''; |
||
43 | |||
44 | /** @var \XoopsGroupPermHandler $grouppermHandler */ |
||
45 | $grouppermHandler = xoops_getHandler('groupperm'); |
||
46 | if (is_object($xoopsUser)) { |
||
47 | $groups = $xoopsUser->getGroups(); |
||
48 | } else { |
||
49 | $groups = XOOPS_GROUP_ANONYMOUS; |
||
50 | } |
||
51 | |||
52 | $sql = 'SELECT storyid, topicid, uid, title, created FROM ' . $xoopsDB->prefix('news_stories') . ' WHERE (published>0 AND published<=' . time() . ') AND (expired = 0 OR expired > ' . time() . ') '; |
||
53 | |||
54 | if (0 != $userid) { |
||
55 | $sql .= ' AND uid=' . $userid . ' '; |
||
56 | } |
||
57 | // because count() returns 1 even if a supplied variable |
||
58 | // is not an array, we must check if $querryarray is really an array |
||
59 | if (is_array($queryarray) && $count = count($queryarray)) { |
||
60 | $sql .= " AND ((hometext LIKE '%$queryarray[0]%' OR bodytext LIKE '%$queryarray[0]%' OR title LIKE '%$queryarray[0]%' OR keywords LIKE '%$queryarray[0]%' OR description LIKE '%$queryarray[0]%')"; |
||
61 | for ($i = 1; $i < $count; ++$i) { |
||
62 | $sql .= " $andor "; |
||
63 | $sql .= "(hometext LIKE '%$queryarray[$i]%' OR bodytext LIKE '%$queryarray[$i]%' OR title LIKE '%$queryarray[$i]%' OR keywords LIKE '%$queryarray[$i]%' OR description LIKE '%$queryarray[$i]%')"; |
||
64 | } |
||
65 | $sql .= ') '; |
||
66 | // keywords highlighting |
||
67 | if ($highlight) { |
||
68 | $searchparam = '&keywords=' . urlencode(trim(implode(' ', $queryarray))); |
||
69 | } |
||
70 | } |
||
71 | |||
72 | $sql .= 'ORDER BY created DESC'; |
||
73 | $result = $xoopsDB->query($sql, $limit, $offset); |
||
74 | $ret = []; |
||
75 | $i = 0; |
||
76 | while (false !== ($myrow = $xoopsDB->fetchArray($result))) { |
||
77 | $display = true; |
||
78 | if ($modid && $grouppermHandler) { |
||
79 | if ($restricted && !$grouppermHandler->checkRight('news_view', $myrow['topicid'], $groups, $modid)) { |
||
80 | $display = false; |
||
81 | } |
||
82 | } |
||
83 | |||
84 | if ($display) { |
||
85 | $ret[$i]['image'] = 'assets/images/news.png'; |
||
86 | $ret[$i]['link'] = 'article.php?storyid=' . $myrow['storyid'] . '' . $searchparam; |
||
87 | $ret[$i]['title'] = $myrow['title']; |
||
88 | $ret[$i]['time'] = $myrow['created']; |
||
89 | $ret[$i]['uid'] = $myrow['uid']; |
||
90 | ++$i; |
||
91 | } |
||
92 | } |
||
93 | |||
94 | require_once XOOPS_ROOT_PATH . '/modules/news/config.php'; |
||
95 | $searchincomments = $cfg['config_search_comments']; |
||
96 | |||
97 | if ($searchincomments && (isset($limit) && $i <= $limit)) { |
||
98 | require_once XOOPS_ROOT_PATH . '/include/comment_constants.php'; |
||
99 | $ind = $i; |
||
100 | $sql = 'SELECT com_id, com_modid, com_itemid, com_created, com_uid, com_title, com_text, com_status FROM ' . $xoopsDB->prefix('xoopscomments') . " WHERE (com_id>0) AND (com_modid=$modid) AND (com_status=" . XOOPS_COMMENT_ACTIVE . ') '; |
||
101 | if (0 != $userid) { |
||
102 | $sql .= ' AND com_uid=' . $userid . ' '; |
||
103 | } |
||
104 | |||
105 | if (is_array($queryarray) && $count = count($queryarray)) { |
||
106 | $sql .= " AND ((com_title LIKE '%$queryarray[0]%' OR com_text LIKE '%$queryarray[0]%')"; |
||
107 | for ($i = 1; $i < $count; ++$i) { |
||
108 | $sql .= " $andor "; |
||
109 | $sql .= "(com_title LIKE '%$queryarray[$i]%' OR com_text LIKE '%$queryarray[$i]%')"; |
||
110 | } |
||
111 | $sql .= ') '; |
||
112 | } |
||
113 | $i = $ind; |
||
114 | $sql .= 'ORDER BY com_created DESC'; |
||
115 | $result = $xoopsDB->query($sql, $limit, $offset); |
||
116 | while (false !== ($myrow = $xoopsDB->fetchArray($result))) { |
||
117 | $display = true; |
||
118 | if ($modid && $grouppermHandler) { |
||
119 | if ($restricted && !$grouppermHandler->checkRight('news_view', $myrow['com_itemid'], $groups, $modid)) { |
||
120 | $display = false; |
||
121 | } |
||
122 | } |
||
123 | if ($i + 1 > $limit) { |
||
124 | $display = false; |
||
125 | } |
||
126 | |||
127 | if ($display) { |
||
128 | $ret[$i]['image'] = 'assets/images/news.png'; |
||
129 | $ret[$i]['link'] = 'article.php?storyid=' . $myrow['com_itemid'] . '' . $searchparam; |
||
130 | $ret[$i]['title'] = $myrow['com_title']; |
||
131 | $ret[$i]['time'] = $myrow['com_created']; |
||
132 | $ret[$i]['uid'] = $myrow['com_uid']; |
||
133 | ++$i; |
||
134 | } |
||
135 | } |
||
136 | } |
||
137 | |||
138 | return $ret; |
||
139 | } |
||
140 |