XoopsModules\News\NewsStory::countPublishedByTopic()

Complexity

Conditions	8
Paths	22

Size

Total Lines	67
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

<?php declare(strict_types=1);
    public static function countPublishedByTopic(?int $topicid = null, int $checkRight = 0): int
    {
        $topicid ??= 0;
        $count = 0;

        /** @var \XoopsMySQLDatabase $db */
        $db = \XoopsDatabaseFactory::getDatabaseConnection();

        // Base SQL query with placeholders for prepared statement
        $sql = 'SELECT COUNT(*) FROM ' . $db->prefix('news_stories') . ' WHERE published > 0 AND published <= ? AND (expired = 0 OR expired > ?)';
        $params = [\time(), \time()];
        $types = 'ii'; // integer, integer

        // Append topicid condition if provided
        if ($topicid > 0) {
            $sql .= ' AND topicid = ?';
            $params[] = $topicid;
            $types .= 'i'; // Add another integer type
        } else {
            $sql .= ' AND ihome = 0';
        }

        // Check user's rights if necessary
        if ($checkRight) {
            $topics = Utility::getMyItemIds('news_view');
            if (\count($topics) > 0) {
                $topicsList = \implode(',', \array_map('intval', $topics));
                $sql .= ' AND topicid IN (' . $topicsList . ')';
            } else {
                return $count;
            }
        }

        // Prepare the statement using the underlying mysqli connection
        $stmt = $db->conn->prepare($sql);

The method prepare() does not exist on XoopsDatabase.

        if ($stmt === false) {
            \XoopsLogger::getInstance()->handleError(E_USER_ERROR, "Error preparing query in countPublishedByTopic: " . $db->error(), __FILE__, __LINE__);
            return $count;
        }

        // Bind parameters
        if (!$stmt->bind_param($types, ...$params)) {
            \XoopsLogger::getInstance()->handleError(E_USER_ERROR, "Error binding parameters in countPublishedByTopic: " . $stmt->error, __FILE__, __LINE__);
            $stmt->close();
            return $count;
        }

        // Execute the prepared statement
        if (!$stmt->execute()) {
            \XoopsLogger::getInstance()->handleError(E_USER_ERROR, "Error executing query in countPublishedByTopic: " . $stmt->error, __FILE__, __LINE__);
            $stmt->close();
            return $count;
        }

        // Bind the result
        $stmt->bind_result($count);

        // Fetch the result
        if (!$stmt->fetch()) {

The expression $stmt->fetch() of type null|true is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            \XoopsLogger::getInstance()->handleError(E_USER_ERROR, "Error fetching result in countPublishedByTopic: " . $stmt->error, __FILE__, __LINE__);
            $count = 0;
        }

        // Close the statement
        $stmt->close();

        return $count;
    }