Issues in news_moderate.php - New Issues - Inspection of "1.71 Beta 2" - XoopsModules25x/news - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Michael

created 2016-04-04 13:46 UTC

blocks/news_moderate.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
// 
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                  Copyright (c) 2000-2016 XOOPS.org                        //
//                       <http://xoops.org/>                             //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Dispay a block where news moderators can show news that need to be moderated.
 */
function b_news_topics_moderate()
{
    include_once XOOPS_ROOT_PATH . '/modules/news/class/class.newsstory.php';
    include_once XOOPS_ROOT_PATH . '/modules/news/include/functions.php';
    $block      = array();
    $dateformat = news_getmoduleoption('dateformat');
    $infotips   = news_getmoduleoption('infotips');

    $storyarray = NewsStory:: getAllSubmitted(0, true, news_getmoduleoption('restrictindex'));
    if (count($storyarray) > 0) {
        $block['lang_story_title']  = _MB_TITLE;
        $block['lang_story_date']   = _MB_POSTED;
        $block['lang_story_author'] = _MB_POSTER;
        $block['lang_story_action'] = _MB_ACTION;
        $block['lang_story_topic']  = _MB_TOPIC;
        $myts                       = MyTextSanitizer::getInstance();
        foreach ($storyarray as $newstory) {
            $title     = $newstory->title();
            $htmltitle = '';
            if ($infotips > 0) {
                $story['infotips'] = news_make_infotips($newstory->hometext());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
                $htmltitle         = ' title="' . $story['infotips'] . '"';
            }

            if (!isset($title) || ($title == '')) {
                $linktitle = "<a href='" . XOOPS_URL . '/modules/news/index.php?op=edit&amp;storyid=' . $newstory->storyid() . "' target='_blank'" . $htmltitle . '>' . _MD_NEWS_NOSUBJECT . '</a>';
            } else {
                $linktitle = "<a href='" . XOOPS_URL . '/modules/news/submit.php?op=edit&amp;storyid=' . $newstory->storyid() . "' target='_blank'" . $htmltitle . '>' . $title . '</a>';
            }
            $story                = array();
            $story['title']       = $linktitle;
            $story['date']        = formatTimestamp($newstory->created(), $dateformat);
            $story['author']      = "<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $newstory->uid() . "'>" . $newstory->uname() . '</a>';
            $story['action']      = "<a href='" . XOOPS_URL . '/modules/news/admin/index.php?op=edit&amp;storyid=' . $newstory->storyid() . "'>" . _EDIT . "</a> - <a href='" . XOOPS_URL . '/modules/news/admin/index.php?op=delete&amp;storyid=' . $newstory->storyid() . "'>" . _MB_DELETE . '</a>';
            $story['topic_title'] = $newstory->topic_title();
            $story['topic_color'] = '#' . $myts->displayTarea($newstory->topic_color);
            $block['picture']     = XOOPS_URL . '/uploads/news/image/' . $story->picture();
            $block['pictureinfo'] = $story->pictureinfo();
            $block['stories'][]   =& $story;
            unset($story);
        }
    }

    return $block;
}

/**
 * @param $options
 */
function b_news_topics_moderate_onthefly($options)
{
    $options = explode('|', $options);
    $block   = &b_news_topics_moderate($options);

    $tpl = new XoopsTpl();
    $tpl->assign('block', $block);
    $tpl->display('db:news_block_moderate.tpl');
}


1		<?php
2		//
3		// ------------------------------------------------------------------------ //
4		// XOOPS - PHP Content Management System //
5		// Copyright (c) 2000-2016 XOOPS.org //
6		// <http://xoops.org/> //
7		// ------------------------------------------------------------------------- //
8		// This program is free software; you can redistribute it and/or modify //
9		// it under the terms of the GNU General Public License as published by //
10		// the Free Software Foundation; either version 2 of the License, or //
11		// (at your option) any later version. //
12		// //
13		// You may not change or alter any portion of this comment or credits //
14		// of supporting developers from this source code or any supporting //
15		// source code which is considered copyrighted (c) material of the //
16		// original comment or credit authors. //
17		// //
18		// This program is distributed in the hope that it will be useful, //
19		// but WITHOUT ANY WARRANTY; without even the implied warranty of //
20		// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
21		// GNU General Public License for more details. //
22		// //
23		// You should have received a copy of the GNU General Public License //
24		// along with this program; if not, write to the Free Software //
25		// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
26		// ------------------------------------------------------------------------ //
27		// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
28
29		/**
30		* Dispay a block where news moderators can show news that need to be moderated.
31		*/
32		function b_news_topics_moderate()
33		{
34		include_once XOOPS_ROOT_PATH . '/modules/news/class/class.newsstory.php';
35		include_once XOOPS_ROOT_PATH . '/modules/news/include/functions.php';
36		$block = array();
37		$dateformat = news_getmoduleoption('dateformat');
38		$infotips = news_getmoduleoption('infotips');
39
40		$storyarray = NewsStory:: getAllSubmitted(0, true, news_getmoduleoption('restrictindex'));
41		if (count($storyarray) > 0) {
42		$block['lang_story_title'] = _MB_TITLE;
43		$block['lang_story_date'] = _MB_POSTED;
44		$block['lang_story_author'] = _MB_POSTER;
45		$block['lang_story_action'] = _MB_ACTION;
46		$block['lang_story_topic'] = _MB_TOPIC;
47		$myts = MyTextSanitizer::getInstance();
48		foreach ($storyarray as $newstory) {
49		$title = $newstory->title();
50		$htmltitle = '';
51		if ($infotips > 0) {
52		$story['infotips'] = news_make_infotips($newstory->hometext());
		0 ignored issues – show Bug introduced 2016-04-04 13:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$story['infotips']` is correct as `news_make_infotips($newstory->hometext())` (which targets `news_make_infotips()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
53		$htmltitle = ' title="' . $story['infotips'] . '"';
54		}
55
56		if (!isset($title) \|\| ($title == '')) {
57		$linktitle = "<a href='" . XOOPS_URL . '/modules/news/index.php?op=edit&storyid=' . $newstory->storyid() . "' target='_blank'" . $htmltitle . '>' . _MD_NEWS_NOSUBJECT . '</a>';
58		} else {
59		$linktitle = "<a href='" . XOOPS_URL . '/modules/news/submit.php?op=edit&storyid=' . $newstory->storyid() . "' target='_blank'" . $htmltitle . '>' . $title . '</a>';
60		}
61		$story = array();
62		$story['title'] = $linktitle;
63		$story['date'] = formatTimestamp($newstory->created(), $dateformat);
64		$story['author'] = "<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $newstory->uid() . "'>" . $newstory->uname() . '</a>';
65		$story['action'] = "<a href='" . XOOPS_URL . '/modules/news/admin/index.php?op=edit&storyid=' . $newstory->storyid() . "'>" . _EDIT . "</a> - <a href='" . XOOPS_URL . '/modules/news/admin/index.php?op=delete&storyid=' . $newstory->storyid() . "'>" . _MB_DELETE . '</a>';
66		$story['topic_title'] = $newstory->topic_title();
67		$story['topic_color'] = '#' . $myts->displayTarea($newstory->topic_color);
68		$block['picture'] = XOOPS_URL . '/uploads/news/image/' . $story->picture();
69		$block['pictureinfo'] = $story->pictureinfo();
70		$block['stories'][] =& $story;
71		unset($story);
72		}
73		}
74
75		return $block;
76		}
77
78		/**
79		* @param $options
80		*/
81	View Code Duplication	function b_news_topics_moderate_onthefly($options)
82		{
83		$options = explode('\|', $options);
84		$block = &b_news_topics_moderate($options);
85
86		$tpl = new XoopsTpl();
87		$tpl->assign('block', $block);
88		$tpl->display('db:news_block_moderate.tpl');
89		}
90

XoopsModules25x / news

Pull Request — master (#4)

blocks/news_moderate.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like