XoopsModules\News\Registryfile

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setfile()	0	4	2
A	__construct()	0	3	1
A	getfile()	0	13	3
A	savefile()	0	17	4

<?php declare(strict_types=1);

namespace XoopsModules\News;

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    XOOPS Project (https://xoops.org)
 * @license      GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author       XOOPS Development Team
 */

/**
 * Class Registryfile
 */
class Registryfile
{
    public $filename; // filename to manage

    /**
     * @param null $fichier

Are you sure the doc-type for parameter $fichier is correct as it would always require null to be passed?

     */
    public function __construct($fichier = null)
    {
        $this->setfile($fichier);
    }

    /**
     * @param null $fichier

Are you sure the doc-type for parameter $fichier is correct as it would always require null to be passed?

     */
    public function setfile($fichier = null): void
    {
        if ($fichier) {

$fichier is of type null, thus it always evaluated to false.

            $this->filename = XOOPS_UPLOAD_PATH . '/' . $fichier;
        }
    }

    /**
     * @param null $fichier

Are you sure the doc-type for parameter $fichier is correct as it would always require null to be passed?

     *
     * @return bool|string
     */
    public function getfile($fichier = null)
    {
        $fw = '';
        if (!$fichier) {

$fichier is of type null, thus it always evaluated to false.

            $fw = $this->filename;
        } else {
            $fw = XOOPS_UPLOAD_PATH . '/' . $fichier;
        }
        if (\file_exists($fw)) {
            return file_get_contents($fw);
        }

        return '';
    }

    /**
     * @param      $content
     * @param null $fichier

Are you sure the doc-type for parameter $fichier is correct as it would always require null to be passed?

     *
     * @return bool
     */
    public function savefile($content, $fichier = null)
    {
        $fw = '';
        if (!$fichier) {

$fichier is of type null, thus it always evaluated to false.

            $fw = $this->filename;
        } else {
            $fw = XOOPS_UPLOAD_PATH . '/' . $fichier;
        }
        if (\is_file($fw)) {
            @\unlink($fw);

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        }
        /** @var resource $fp */
        $fp = \fopen($fw, 'wb') || exit(_ERRORS);

Using exit here is not recommended.

        \fwrite($fp, $content);
        \fclose($fp);

        return true;
    }
}