XoopsModules25x / mymenus

class/Plugins/Dynamic/PluginItem.php

<?php namespace XoopsModules\Mymenus\Plugins\Dynamic;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright       XOOPS Project (https://xoops.org)
 * @license         http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
 * @package         Mymenus
 * @since           1.0
 * @author          trabis <lusopoemas@gmail.com>
 */

use XoopsModules\Mymenus;

defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class PluginItem
 */
class PluginItem extends Mymenus\PluginItem
{
    public static function eventEnd()
    {
        $newmenus = [];
        $registry = Mymenus\Registry::getInstance();
        $menus    = $registry->getEntry('menus');

Are you sure the assignment to $menus is correct as $registry->getEntry('menus') targeting XoopsModules\Mymenus\Registry::getEntry() seems to always return null.

        foreach ($menus as $menu) {

The expression $menus of type null is not traversable.

            if (!preg_match('/{(MODULE\|.*)}/i', $menu['title'], $reg)) {
                $newmenus[] = $menu;
                continue;
            }
            $result      = array_map('mb_strtolower', explode('|', $reg[1]));
            $moduleMenus = self::getModuleMenus($result[1], $menu['pid']);
            foreach ($moduleMenus as $mMenu) {
                $newmenus[] = $mMenu;
            }
        }
        $registry->setEntry('menus', $newmenus);
    }

    /**
     * @param $module
     * @param $pid
     *
     * @return array
     */
    protected static function getModuleMenus($module, $pid)
    {
        global $xoopsModule;
        static $id = -1;
        /** @var \XoopsModules\Mymenus\Helper $helper */
        $helper = \XoopsModules\Mymenus\Helper::getInstance();


        $ret = [];
        //Sanitizing $module
        if (preg_match('/[^a-z0-9\\/\\\\_.:-]/i', $module)) {
            return $ret;
        }

        $path = "modules/{$module}";
        $file = $GLOBALS['xoops']->path("{$path}/xoops_version.php");

        if (!file_exists($file)) {
            return $ret;
        }
        $helper->loadLanguage('modinfo');


        $overwrite = false;
        if (true === $force) {  //can set to false for debug

The variable $force seems to be never defined.

            if (!($xoopsModule instanceof \XoopsModule) || ($xoopsModule->getVar('dirname') != $module)) {
                // @TODO: check the following 2 statements, they're basically just assigns - is this intended?
                $_xoopsModule       = ($xoopsModule instanceof \XoopsModule) ? $xoopsModule : $xoopsModule;
                $_xoopsModuleConfig = is_object($xoopsModuleConfig) ? $xoopsModuleConfig : $xoopsModuleConfig;

The variable $xoopsModuleConfig does not exist. Did you maybe mean $_xoopsModuleConfig?

                /** @var \XoopsModuleHandler $moduleHandler */
                $moduleHandler          = xoops_getHandler('module');

The function xoops_getHandler was not found. Maybe you did not declare it correctly or list all dependencies?

                $xoopsModule            = $moduleHandler->getByDirname($module);
                $GLOBALS['xoopsModule'] = $xoopsModule;
                if ($xoopsModule instanceof \XoopsModule) {
                    /** @var \XoopsConfigHandler $configHandler */
                    $configHandler                = xoops_getHandler('config');
                    $xoopsModuleConfig            = $configHandler->getConfigsByCat(0, $xoopsModule->getVar('mid'));
                    $GLOBALS['xoopsModuleConfig'] = $xoopsModuleConfig;
                }
                $overwrite = true;
            }
        }
        $modversion['sub'] = [];

$modversion was never initialized. Although not strictly required by PHP, it is generally a good practice to add $modversion = array(); before regardless.

        require $file;

        /** @var  \XoopsModules\Mymenus\LinksHandler $linksHandler */
        $linksHandler = $helper->getHandler('Links');
        foreach ($modversion['sub'] as $links) {
            $obj = $linksHandler->create();
            $obj->setVars([
                              'title'     => $links['name'],
                              'alt_title' => $links['name'],
                              'link'      => $GLOBALS['xoops']->url("{$path}/{$links['url']}"),
                              'id'        => $id,
                              'pid'       => (int)$pid
                          ]);
            $ret[] = $obj->getValues();
            $id--;
        }

        if ($overwrite) {
            $xoopsModule                  = $_xoopsModule;

The variable $_xoopsModule does not seem to be defined for all execution paths leading up to this point.

            $GLOBALS['xoopsModule']       = $xoopsModule;
            $xoopsModuleConfig            = $_xoopsModuleConfig;

The variable $_xoopsModuleConfig does not seem to be defined for all execution paths leading up to this point.

            $GLOBALS['xoopsModuleConfig'] = $xoopsModuleConfig;
        }

        return $ret;
    }
}