MymenusMenus

Complexity

Total Complexity

5

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getForm()	0	54	4

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 27 and the first side effect is on line 20.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright       The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license         http://www.gnu.org/licenses/gpl-2.0.html GNU Public License
 * @package         Mymenus
 * @since           1.0
 * @author          trabis <lusopoemas@gmail.com>
 */

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

include_once dirname(__DIR__) . '/include/common.php';

/**
 * Class MymenusMenus
 */
class MymenusMenus extends XoopsObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var MymenusMenus
     * @access private
     */
    private $mymenus = null;

    /**
     * constructor
     */
    public function __construct()
    {
        $this->mymenus = MymenusMymenus::getInstance();
        $this->db      = XoopsDatabaseFactory::getDatabaseConnection();
        $this->initVar('id', XOBJ_DTYPE_INT);
        $this->initVar('title', XOBJ_DTYPE_TXTBOX);
        $this->initVar('css', XOBJ_DTYPE_TXTBOX);
    }

    /**
     * Get {@link XoopsThemeForm} for adding/editing items
     *
     * @param  bool|string $action
     * @return XoopsThemeForm {@link XoopsThemeForm}
     */
    public function getForm($action = false)
    {
        //        $grouppermHandler = xoops_gethandler('groupperm');

50% of this comment could be valid code. Did you maybe forget this after debugging?

        //
        xoops_load('XoopsFormLoader');
        //
        if ($action === false) {
            //            $action = $_SERVER['REQUEST_URI'];

60% of this comment could be valid code. Did you maybe forget this after debugging?

            $action = XoopsRequest::getString('REQUEST_URI', '', 'SERVER');
        }
        //
        //        $isAdmin = mymenusUserIsAdmin();

45% of this comment could be valid code. Did you maybe forget this after debugging?

        //        $groups  = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getGroups() : array(0 => XOOPS_GROUP_ANONYMOUS);

63% of this comment could be valid code. Did you maybe forget this after debugging?

        //
        $title = $this->isNew() ? _AM_MYMENUS_MENUS_ADD : _AM_MYMENUS_MENUS_EDIT;
        //
        $form = new XoopsThemeForm($title, 'moneusform', $action, 'post', true);
        $form->setExtra('enctype="multipart/form-data"');
        // menus: title
        $menusTitleText = new XoopsFormText(_AM_MYMENUS_MENU_TITLE, 'title', 50, 255, $this->getVar('title', 'e'));
        $menusTitleText->setDescription(_AM_MYMENUS_MENU_TITLE_DESC);
        $form->addElement($menusTitleText, true);
        // menus: css
        $menusCssText = new XoopsFormText(_AM_MYMENUS_MENU_CSS, 'css', 50, 255, $this->getVar('css', 'e'));
        $menusCssText->setDescription(_AM_MYMENUS_MENU_CSS_DESC);
        $form->addElement($menusCssText, false);
        // form: button tray
        $buttonTray = new XoopsFormElementTray('', '');
        $buttonTray->addElement(new XoopsFormHidden('op', 'save'));
        //
        $buttonSubmit = new XoopsFormButton('', '', _SUBMIT, 'submit');
        $buttonSubmit->setExtra('onclick="this.form.elements.op.value=\'save\'"');
        $buttonTray->addElement($buttonSubmit);
        if ($this->isNew()) {

This if statement is empty and can be removed.

            // NOP
        } else {
            $form->addElement(new XoopsFormHidden('id', (int)$this->getVar('id')));
            //
            $buttonDelete = new XoopsFormButton('', '', _DELETE, 'submit');
            $buttonDelete->setExtra('onclick="this.form.elements.op.value=\'delete\'"');
            $buttonTray->addElement($buttonDelete);
        }
        $buttonReset = new XoopsFormButton('', '', _RESET, 'reset');
        $buttonTray->addElement($buttonReset);
        //
        $buttonCancel = new XoopsFormButton('', '', _CANCEL, 'button');
        $buttonCancel->setExtra('onclick="history.go(-1)"');
        $buttonTray->addElement($buttonCancel);
        //
        $form->addElement($buttonTray);

        //
        return $form;
    }
}

/**
 * Class MymenusMenusHandler
 */
class MymenusMenusHandler extends XoopsPersistableObjectHandler

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var MymenusMymenus
     * @access private
     */
    private $mymenus = null;

    /**
     * @param null|XoopsDatabase $db
     */
    public function __construct(XoopsDatabase $db)
    {
        parent::__construct($db, 'mymenus_menus', 'MymenusMenus', 'id', 'title', 'css');
        $this->mymenus = MymenusMymenus::getInstance();
    }
}