CategoryHandler::getCatTitles() - Code Metrics - Inspection of "namespaces" - XoopsModules25x/mylinks - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by Michael

created 2020-04-16 16:25 UTC

CategoryHandler::getCatTitles() B

↳ Parent: CategoryHandler

Complexity

Conditions	10
Paths	12

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	15
dl	0
loc	22
rs	7.6666
c	1
b	0
f	0
cc	10
nc	12
nop	1

How to fix Complexity

<?php

namespace XoopsModules\Mylinks;

/**
 * MyLinks category.php
 *
 * Xoops mylinks - a multicategory links module
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright ::  &copy; ZySpec Incorporated
 * @license   ::    {@link https://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
 * @package   ::    mylinks
 * @subpackage:: class
 * @since     ::      File available since version 3.11
 * @author    ::     zyspec ([email protected])
 */



$mylinksDir = basename(dirname(__DIR__));

/**
 * Class mylinksCategoryHandler_base
 */
class CategoryHandler extends \XoopsPersistableObjectHandler
{
    /**
     * @param \XoopsDatabase|null $db
     */
    public function mylinksCategoryHandler(\XoopsDatabase $db = null)
    {
        $this->__construct($db);
    }

    /**
     * mylinksCategoryHandler_base constructor.
     * @param \XoopsDatabase|null $db
     */
    public function __construct(\XoopsDatabase $db = null)
    {
        $mylinksDir = basename(dirname(__DIR__));

        parent::__construct($db, 'mylinks_cat', Category::class, 'cid');
    }

    /**
     * Retrieve category names from Database
     * @param unknown $cats  - integer, returns single category name,
filter:
    dependency_paths: ["lib/*"]
     *                       array returns array of category names
     *                       NULL return all category names
     * @return array   return category titles with category ID as key
     */
    public function getCatTitles($cats = null)
    {
        $catTitles = [];

        $criteria  = new \CriteriaCompo();
        if (isset($cats) && is_array($cats)) {

            $catIdString = !empty($cats) ? '(' . implode(',', $cats) . ')' : '';
            if ($catIdString) {
                $criteria->add(new \Criteria('cid', $catIdString, 'IN'));
            }
        } elseif (isset($cats) && ((int)$cats > 0)) {
            $criteria->add(new \Criteria('cid', (int)$cats, '='));
        }
        $catFields     = ['title'];
        $categoryArray = $this->getAll($criteria, $catFields, false);
        $catTitles     = [];
        if (is_array($categoryArray) && count($categoryArray)) {
            foreach ($categoryArray as $catItem) {
                $catTitles[$catItem['cid']] = $catItem['title'];
            }
        }

        return $catTitles;
    }
}

//eval('class ' . $mylinksDir . 'Category extends CategoryBase
//        {
//        }
//
//        class ' . $mylinksDir . 'CategoryHandler extends mylinksCategoryHandler_base
//        {
//        }
//    ');


1			<?php
2
3			namespace XoopsModules\Mylinks;
4
5			/**
6			* MyLinks category.php
7			*
8			* Xoops mylinks - a multicategory links module
9			*
10			* You may not change or alter any portion of this comment or credits
11			* of supporting developers from this source code or any supporting source code
12			* which is considered copyrighted (c) material of the original comment or credit authors.
13			* This program is distributed in the hope that it will be useful,
14			* but WITHOUT ANY WARRANTY; without even the implied warranty of
15			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
16			*
17			* @copyright :: © ZySpec Incorporated
18			* @license :: {@link https://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
19			* @package :: mylinks
20			* @subpackage:: class
21			* @since :: File available since version 3.11
22			* @author :: zyspec ([email protected])
23			*/
24
25
26
27			$mylinksDir = basename(dirname(__DIR__));
28
29			/**
30			* Class mylinksCategoryHandler_base
31			*/
32			class CategoryHandler extends \XoopsPersistableObjectHandler
33			{
34			/**
35			* @param \XoopsDatabase\|null $db
36			*/
37			public function mylinksCategoryHandler(\XoopsDatabase $db = null)
38			{
39			$this->__construct($db);
40			}
41
42			/**
43			* mylinksCategoryHandler_base constructor.
44			* @param \XoopsDatabase\|null $db
45			*/
46			public function __construct(\XoopsDatabase $db = null)
47			{
48			$mylinksDir = basename(dirname(__DIR__));
			0 ignored issues – show Unused Code introduced 2020-04-16 16:28 UTC by Report Bug Copy Issue Report The assignment to `$mylinksDir` is dead and can be removed. Loading history...
49			parent::__construct($db, 'mylinks_cat', Category::class, 'cid');
50			}
51
52			/**
53			* Retrieve category names from Database
54			* @param unknown $cats - integer, returns single category name,
			0 ignored issues – show Bug introduced 2020-04-16 16:28 UTC by Report Bug Copy Issue Report The type `XoopsModules\Mylinks\unknown` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
55			* array returns array of category names
56			* NULL return all category names
57			* @return array return category titles with category ID as key
58			*/
59			public function getCatTitles($cats = null)
60			{
61			$catTitles = [];
			0 ignored issues – show Unused Code introduced 2020-04-16 16:28 UTC by Report Bug Copy Issue Report The assignment to `$catTitles` is dead and can be removed. Loading history...
62			$criteria = new \CriteriaCompo();
63			if (isset($cats) && is_array($cats)) {
			0 ignored issues – show introduced 2020-04-16 16:28 UTC by Report Bug Copy Issue Report The condition `is_array($cats)` is always `false`. Loading history...
64			$catIdString = !empty($cats) ? '(' . implode(',', $cats) . ')' : '';
65			if ($catIdString) {
66			$criteria->add(new \Criteria('cid', $catIdString, 'IN'));
67			}
68			} elseif (isset($cats) && ((int)$cats > 0)) {
69			$criteria->add(new \Criteria('cid', (int)$cats, '='));
70			}
71			$catFields = ['title'];
72			$categoryArray = $this->getAll($criteria, $catFields, false);
73			$catTitles = [];
74			if (is_array($categoryArray) && count($categoryArray)) {
75			foreach ($categoryArray as $catItem) {
76			$catTitles[$catItem['cid']] = $catItem['title'];
77			}
78			}
79
80			return $catTitles;
81			}
82			}
83
84			//eval('class ' . $mylinksDir . 'Category extends CategoryBase
85			// {
86			// }
87			//
88			// class ' . $mylinksDir . 'CategoryHandler extends mylinksCategoryHandler_base
89			// {
90			// }
91			// ');
92

XoopsModules25x / mylinks

Pull Request — master (#9)

CategoryHandler::getCatTitles() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like