bookmark.php ➔ GoogleCH() - Code Metrics - Inspection of "Merge pull request #8 from mambax7/master" - XoopsModules25x/mylinks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b236d1...786b6e )

by Michael

created 2017-05-25 06:58 UTC

bookmark.php ➔ GoogleCH() C

↳ Parent: Project

Complexity

Conditions	14
Paths	48

Size

Total Lines	50
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	14
eloc	43
nc	48
nop	3
dl	0
loc	50
rs	5.3716
c	0
b	0
f	0

How to fix Complexity

<?php


include __DIR__ . '/header.php';
include_once __DIR__ . '/class/utility.php';
//xoops_load('utility', $xoopsModule->getVar('dirname'));

$lid = MylinksUtility::mylinks_cleanVars($_GET, 'lid', 0, 'int', array('min' => 0));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
$cid = MylinksUtility::mylinks_cleanVars($_GET, 'cid', 0, 'int', array('min' => 0));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
if (empty($lid) || empty($cid)) {
    redirect_header('index.php', 3, _MD_MYLINKS_IDERROR);
}
/*

$lid = isset($_GET['lid']) ? intval($_GET['lid']) : 0;
$cid = isset($_GET['cid']) ? intval($_GET['cid']) : 0;
if ( empty($lid) ) {
  die("No lid!");
} elseif ( empty($cid) ) {
  die("No cid!");
}
*/
$result = $xoopsDB->query('SELECT l.lid, l.cid, l.title, l.url FROM ' . $xoopsDB->prefix('mylinks_links') . ' l, ' . $xoopsDB->prefix('mylinks_text') . " t where l.lid={$lid} AND l.lid=t.lid AND status>0");
if (!$result) {
    redirect_header('index.php', 3, _MD_MYLINKS_NORECORDFOUND);
    exit();
}
list($lid, $cid, $ltitle, $url) = $xoopsDB->fetchRow($result);

//bookmark func
switch ($mylinks_can_bookmark) {

    case _MD_MYLINKS_MEMBERONLY:
        $can_bookmark = $xoopsUser ? _MD_MYLINKS_ALLOW : _MD_MYLINKS_DISALLOW;
        break;
    case _MD_MYLINKS_ALLOW:
        $can_bookmark = _MD_MYLINKS_ALLOW;
        break;
    case _MD_MYLINKS_DISALLOW:
    default:
        $can_bookmark = _MD_MYLINKS_DISALLOW;
        break;
}
if (_MD_MYLINKS_DISALLOW == $can_bookmark) {
    redirect_header('index.php', 3, _MD_MYLINKS_BOOKMARKDISALLOWED);
    exit();
}

/*

$can_bookmark = 0;
if ( $mylinks_can_bookmark == 0 ) {
  $can_bookmark = 0;
}
else if ( $mylinks_can_bookmark == 1) {
  $can_bookmark = 1;
}
else if ( $mylinks_can_bookmark == 2) {
  if ( $xoopsUser ) {
  $can_bookmark =1;
  }
  else {
  $can_bookmark =0;
  }
}
else {
  $can_bookmark = 0;
}

if ( empty($can_bookmark) ) {
  die("Not allowed now!");
}

$can_qrcode = 0;
if ( $mylinks_can_qrcode == 0 ) {
  $can_qrcode = 0;
}
else if ( $mylinks_can_qrcode == 1) {
  $can_qrcode = 1;
}
else if ( $mylinks_can_qrcode == 2) {
  if ( $xoopsUser ) {
  $can_qrcode =1;
  }
  else {
  $can_qrcode =0;
  }
}
else {
  $can_qrcode = 0;
}

if ( empty($can_qrcode) ) {
  die("Not allowed now!");
}
*/

xoops_header(false);

$myts = MyTextSanitizer::getInstance();

$sitetitle = $myts->htmlSpecialChars($myts->stripSlashesGPC($ltitle));
$siteurl   = $myts->htmlSpecialChars($url);

$siteurl_en   = urlencode(mb_convert_encoding($siteurl, 'UTF-8', _CHARSET));
$sitetitle_en = urlencode(mb_convert_encoding($sitetitle, 'UTF-8', _CHARSET));

/**
 * @param        $str
 * @param string $to
 * @param string $from
 * @return array|string
 */
function bookmark_convert_encoding($str, $to = 'SJIS', $from = _CHARSET)

{
    if (function_exists('mb_convert_encoding')) {
        if (is_array($str)) {
            foreach ($str as $key => $val) {
                $str[$key] = bookmark_convert_encoding($val, $to, $from);
            }

            return $str;
        } else {
            return mb_convert_encoding($str, $to, $from);
        }
    } else {
        return $str;
    }
}

/**
 * @param string $data
 * @return array|mixed|string
 */
function bookmark_qrcode_encoding($data = '')
{
    $data = bookmark_convert_encoding($data);
    $data = rawurlencode($data);
    $data = str_replace('%20', '+', $data);

    return $data;
}

$qrcodedata_url = bookmark_qrcode_encoding($siteurl);
$siteqrcode     = "<img alt='" . $siteurl . "' title='" . $siteurl . "'src='" . XOOPS_URL . "/modules/qrcode/qrcode_image.php?d=$qrcodedata_url&amp;e=M&amp;s=4&amp;v=0&amp;t=P&amp;rgb=000000'>\n";

/*

$qrcodedata_docomo_bookmark = bookmark_qrcode_encoding("MEBKM:TITLE:".$sitetitle.";URL:".$siteurl.";;");
$bookmarkqrcode_docomo = "<img alt='docomo' title='docomo'src='".XOOPS_URL."/modules/qrcode/qrcode_image.php?d=$qrcodedata_docomo_bookmark&amp;e=M&amp;s=4&amp;v=0&amp;t=P&amp;rgb=000000'>\n";

$qrcodedata_softbank_bookmark = bookmark_qrcode_encoding("TITLE:".$sitetitle."\r\nURL:".$siteurl."\r\n");
$bookmarkqrcode_softbank = "<img alt='softbank and au' title='softbank and au'src='".XOOPS_URL."/modules/qrcode/qrcode_image.php?d=$qrcodedata_softbank_bookmark&amp;e=M&amp;s=4&amp;v=0&amp;t=P&amp;rgb=000000'>\n";

$qrcodedata_bookmark = bookmark_qrcode_encoding("TITLE:\r\n".$sitetitle."\r\nURL:\r\n".$siteurl."\r\n");
$bookmarkqrcode = "<img alt='title and url' title='title and url'src='".XOOPS_URL."/modules/qrcode/qrcode_image.php?d=$qrcodedata_bookmark&amp;e=M&amp;s=4&amp;v=0&amp;t=P&amp;rgb=000000'>\n";
*/

//google pagerank
define('GOOGLE_MAGIC', 0xE6359A60);

/**
 * @param $a
 * @param $b
 * @return int|number
 */
function zeroFill($a, $b)
{
    $z = hexdec(80000000);
    if ($z & $a) {
        $a = ($a >> 1);
        $a &= (~$z);
        $a |= 0x40000000;
        $a = ($a >> ($b - 1));
    } else {
        $a = ($a >> $b);
    }

    return $a;
}

/**
 * @param $a
 * @param $b
 * @param $c
 * @return array
 */
function mix($a, $b, $c)
{
    $a -= $b;
    $a -= $c;
    $a ^= zeroFill($c, 13);
    $b -= $c;
    $b -= $a;
    $b ^= ($a << 8);
    $c -= $a;
    $c -= $b;
    $c ^= zeroFill($b, 13);
    $a -= $b;
    $a -= $c;
    $a ^= zeroFill($c, 12);
    $b -= $c;
    $b -= $a;
    $b ^= ($a << 16);
    $c -= $a;
    $c -= $b;
    $c ^= zeroFill($b, 5);
    $a -= $b;
    $a -= $c;
    $a ^= zeroFill($c, 3);
    $b -= $c;
    $b -= $a;
    $b ^= ($a << 10);
    $c -= $a;
    $c -= $b;
    $c ^= zeroFill($b, 15);

    return array($a, $b, $c);
}

/**
 * @param      $url
 * @param null $length
 * @param int  $init
 * @return mixed
 */
function GoogleCH($url, $length = null, $init = GOOGLE_MAGIC)
{
    if (null === $length) {
        $length = count($url);
    }
    $a   = $b = 0x9E3779B9;
    $c   = $init;
    $k   = 0;
    $len = $length;
    while ($len >= 12) {
        $a += ($url[$k + 0] + ($url[$k + 1] << 8) + ($url[$k + 2] << 16) + ($url[$k + 3] << 24));
        $b += ($url[$k + 4] + ($url[$k + 5] << 8) + ($url[$k + 6] << 16) + ($url[$k + 7] << 24));
        $c += ($url[$k + 8] + ($url[$k + 9] << 8) + ($url[$k + 10] << 16) + ($url[$k + 11] << 24));
        $mix = mix($a, $b, $c);
        $a   = $mix[0];
        $b   = $mix[1];
        $c   = $mix[2];
        $k += 12;
        $len -= 12;
    }

    $c += $length;
    switch ($len) {
        case 11:

            $c += ($url[$k + 10] << 24);
        case 10:

            $c += ($url[$k + 9] << 16);
        case 9 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $c += ($url[$k + 8] << 8);
        case 8 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $b += ($url[$k + 7] << 24);
        case 7 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $b += ($url[$k + 6] << 16);
        case 6 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $b += ($url[$k + 5] << 8);
        case 5 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $b += $url[$k + 4];
        case 4 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $a += ($url[$k + 3] << 24);
        case 3 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $a += ($url[$k + 2] << 16);
        case 2 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $a += ($url[$k + 1] << 8);
        case 1 :
switch ($selector) {
    case "A": //right
        doSomething();
        break;
    case "B" : //wrong
        doSomethingElse();
        break;
}
            $a += $url[$k + 0];
    }
    $mix = mix($a, $b, $c);

    return $mix[2];
}

/**
 * @param $string
 * @return mixed
 */
function strord($string)
{
    for ($i = 0; $i < strlen($string); $i++) {
        $result[$i] = ord($string{$i});
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    }

    return $result;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

/**
 * @param $url
 * @return string
 */
function getrank($url)
{
    $pagerank = '0';
    $ch       = '6' . GoogleCH(strord('info:' . $url));

    $fp = fsockopen('www.google.com', 80, $errno, $errstr, 30);
    if (!$fp) {
        $pagerank = '-1';
        //echo "$errstr ($errno)<br>\n";
    } else {
        $out = 'GET /search?client=navclient-auto&ch=' . $ch . '&features=Rank&q=info:' . $url . " HTTP/1.1\r\n";
        $out .= "Host: www.google.com\r\n";
        $out .= "Connection: Close\r\n\r\n";

        fwrite($fp, $out);

        while (!feof($fp)) {
            $data = fgets($fp, 128);
            $pos  = strpos($data, 'Rank_');
            if ($pos === false) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            } else {
                $pagerank = substr($data, $pos + 9);
            }
        }
        fclose($fp);
    }

    return $pagerank;
}

//

echo '
<script type="text/javascript">
<!--//
/***********************************************
* Bookmark site script-Dynamic Drive DHTML code library (www.dynamicdrive.com)
* This notice MUST stay intact for legal use
* Visit Dynamic Drive at http://www.dynamicdrive.com/ for full source code
***********************************************/
/* Modified to support Opera */
function bookmarksite(title,url){
if (window.sidebar) // firefox
  window.sidebar.addPanel(title, url, "");
else if(window.opera && window.print){ // opera
  var elem = document.createElement("a");
  elem.setAttribute("href",url);
  elem.setAttribute("title",title);
  elem.setAttribute("rel","sidebar");
  elem.click();
}
else if(document.all)// ie
  window.external.AddFavorite(url, title);
}
//-->
</script>
</head>
<body>
<script type="text/javascript">
<!--//
var addtoMethod=0;
//-->
</script>
<script src="' . XOOPSMYLINKINCURL . '/addto-multi.js" type="text/javascript"></script>

  <table style="width: 95%; margin: auto;" class="outer">
    <tr><td colspan="2" style="text-align: center;"><h3>' . _MD_MYLINKS_BOOKMARK_SERVICE . '</h3></td></tr>
    <tr><td class="head" style="text-align: center; font-weight: bold;">' . _MD_MYLINKS_SITETITLE . '</td><td class="even" style="text-align: center;">' . $sitetitle . '</td></tr>
    <tr><td class="head" style="text-align: center; font-weight: bold;">' . _MD_MYLINKS_SITEURL . '</td><td class="even" style="text-align: center;"><a href="' . $siteurl . '" target="_blank">' . $siteurl . '</a><br>(&nbsp;<strong>Google PageRank :</strong>&nbsp;<img src="' . XOOPSMYLINKIMGURL
     . '/addto/pr' . getrank($siteurl) . '.gif" alt="pagerank">&nbsp;)</td></tr>';
if ($mylinks_can_qrcode) {
    echo '<tr><td  class="head" style="text-align: center; font-weight: bold;">' . _MD_MYLINKS_QRCODE . '<br>(' . _MD_MYLINKS_SITEURL . ')</td><td class="even" style="text-align: center;">' . $siteqrcode . '</td></tr>';
}
echo '
    <tr><td class="head" style="text-align: center; font-weight: bold;">' . _MD_MYLINKS_WEBBROWSER . '</td><td  class="even" style="text-align: center;">
      <a href="javascript:void(0);" onclick="bookmarksite(\'' . $sitetitle . '\', \'' . $siteurl . '\');">' . _MD_MYLINKS_BROWSERBOOKMARK . '</a>
    </td></tr>
  </table>
  <br><br>
<table style="width: 90%; margin: auto;">
<tr class="foot"><td colspan="2" style="text-align: center; font-weight: bold;">' . _MD_MYLINKS_BOOKMARK_ADDTO . '...</td></tr>
<tr><td class="even">
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Blink"><a style="cursor:pointer;" onclick="addto(1,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Blink.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Blink"> Blink</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Delicious"><a style="cursor:pointer;" onclick="addto(2,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Delicious.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Del.icio.us"> Del.icio.us</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Digg"><a style="cursor:pointer;" onclick="addto(3,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Digg.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Digg"> Digg</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Furl"><a style="cursor:pointer;" onclick="addto(4,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Furl.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Furl"> Furl</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Blue Dot"><a style="cursor:pointer;" onclick="addto(9,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Bluedot.png" style="width: 16px; height: 16px; border-width: 0px;" alt="Bluedot"> Blue Dot</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' BookmarkTracker"><a style="cursor:pointer;" onclick="addto(11,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Bookmarktracker.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Bookmarktracker"> BookmarkTracker</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Hatena"><a style="cursor:pointer;" onclick="addto(13,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Hatena.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Hatena"> Hatena</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Magnolia"><a style="cursor:pointer;" onclick="addto(15,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Magnolia.png" style="width: 16px; height: 16px; border-width: 0px;" alt="Magnolia"> Magnolia</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Nifty Clip"><a style="cursor:pointer;" onclick="addto(17,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Niftyclip.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Nifty Clip"> Nifty Clip</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Pookmark"><a style="cursor:pointer;" onclick="addto(19,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Pookmark.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Pookmark"> Pookmark</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Tailrank"><a style="cursor:pointer;" onclick="addto(21,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Tailrank.png" style="width: 16px; height: 16px; border-width: 0px;" alt="Tailrank"> Tailrank</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Technorati"><a style="cursor:pointer;" onclick="addto(23,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Technorati.png" style="width: 16px; height: 16px; border-width: 0px;" alt="Technorati"> Technorati</a></span>

  </td>
  <td class="odd">
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Google"><a style="cursor:pointer;" onclick="addto(5,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Google.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Google"> Google</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Simpy"><a style="cursor:pointer;" onclick="addto(6,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Simpy.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Simpy"> Simpy</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Spurl"><a style="cursor:pointer;" onclick="addto(8,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Spurl.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Spurl"> Spurl</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Yahoo! MyWeb"><a style="cursor:pointer;" onclick="addto(7,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Yahoo.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Y!MyWeb"> Y! MyWeb</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Blogmarks"><a style="cursor:pointer;" onclick="addto(10,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Blogmarks.png" style="width: 16px; height: 16px; border-width: 0px;" alt="Blogmarks"> Blogmarks</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' FC2"><a style="cursor:pointer;" onclick="addto(12,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_FC2.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="FC2"> FC2 Bookmark</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Livedoor Clip"><a style="cursor:pointer;" onclick="addto(14,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Livedoorclip.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Livedoor Clip"> Livedoor Clip</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Netscape"><a style="cursor:pointer;" onclick="addto(16,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Netscape.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Netscape"> Netscape</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Newsvine"><a style="cursor:pointer;" onclick="addto(18,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Newsvine.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Newsvine"> Newsvine</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Reddit"><a style="cursor:pointer;" onclick="addto(20,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Reddit.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Reddit"> Reddit</a></span>
<br>
<span title="' . _MD_MYLINKS_BOOKMARK_ADDTO . ' Windows Live"><a style="cursor:pointer;" onclick="addto(22,\'' . $siteurl_en . '\', \'' . $sitetitle_en . '\')">
<img src="' . XOOPSMYLINKIMGURL . '/addto/AddTo_Windowslive.gif" style="width: 16px; height: 16px; border-width: 0px;" alt="Windows Live"> Windows Live</a></span>
  </td>
  </tr></table>
<br><br>
';

xoops_footer();


Push — master ( b236d1...786b6e )

bookmark.php ➔ GoogleCH() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 109 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		include __DIR__ . '/header.php';
4		include_once __DIR__ . '/class/utility.php';
5		//xoops_load('utility', $xoopsModule->getVar('dirname'));
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report `77%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
6		$lid = MylinksUtility::mylinks_cleanVars($_GET, 'lid', 0, 'int', array('min' => 0));
		0 ignored issues – show Documentation introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report `'lid'` is of type `string`, but the function expects a `object<unknown_type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
7		$cid = MylinksUtility::mylinks_cleanVars($_GET, 'cid', 0, 'int', array('min' => 0));
		0 ignored issues – show Documentation introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report `'cid'` is of type `string`, but the function expects a `object<unknown_type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
8		if (empty($lid) \|\| empty($cid)) {
9		redirect_header('index.php', 3, _MD_MYLINKS_IDERROR);
10		}
11		/*
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
12		$lid = isset($_GET['lid']) ? intval($_GET['lid']) : 0;
13		$cid = isset($_GET['cid']) ? intval($_GET['cid']) : 0;
14		if ( empty($lid) ) {
15		die("No lid!");
16		} elseif ( empty($cid) ) {
17		die("No cid!");
18		}
19		*/
20		$result = $xoopsDB->query('SELECT l.lid, l.cid, l.title, l.url FROM ' . $xoopsDB->prefix('mylinks_links') . ' l, ' . $xoopsDB->prefix('mylinks_text') . " t where l.lid={$lid} AND l.lid=t.lid AND status>0");
21		if (!$result) {
22		redirect_header('index.php', 3, _MD_MYLINKS_NORECORDFOUND);
23		exit();
24		}
25		list($lid, $cid, $ltitle, $url) = $xoopsDB->fetchRow($result);
26
27		//bookmark func
28	View Code Duplication	switch ($mylinks_can_bookmark) {
		0 ignored issues – show Duplication introduced 2016-04-26 04:17 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		case _MD_MYLINKS_MEMBERONLY:
30		$can_bookmark = $xoopsUser ? _MD_MYLINKS_ALLOW : _MD_MYLINKS_DISALLOW;
31		break;
32		case _MD_MYLINKS_ALLOW:
33		$can_bookmark = _MD_MYLINKS_ALLOW;
34		break;

XoopsModules25x / mylinks

Push — master ( b236d1...786b6e )

bookmark.php ➔ GoogleCH() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like