MylinksThumbPlugin

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
	getProviderUrl()	0	1	?
	getProviderName()	0	1	?
	setShotSize()	0	1	?
	getShotSize()	0	1	?
	setSiteUrl()	0	1	?
	getSiteUrl()	0	1	?
	setAttribution()	0	1	?
	getAttribution()	0	1	?
	setProviderPublicKey()	0	1	?
	getProviderPublicKey()	0	1	?
	setProviderPrivateKey()	0	1	?
	getProviderPrivateKey()	0	1	?

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 24 and the first side effect is on line 13.

/**
 *  mylinks Thumb Provider Plugin Interface Class Elements
 *
 * @copyright ::  {@link http://xoops.org/ XOOPS Project}
 * @copyright ::  ZySpec Incorporated
 * @license   ::    {@link http://www.gnu.org/licenses/gpl-2.0.html GNU Public License}
 * @package   ::    mylinks
 * @subpackage:: class
 * @author    ::     zyspec (owners@zyspec.com)
 */

defined('XOOPS_ROOT_PATH') or die('Restricted access');

Using logical operators such as or instead of || is generally not recommended.

/**
 * MylinksThumbPluginInterface
 *
 * @package   ::   mylinks
 * @author    ::    zyspec (owners@zyspec.com), Herve Thouzard
 * @copyright ::  {@link http://xoops.org/ XOOPS Project}
 * @copyright :: Copyright (c) 2012 ZySpec Incorporated, Herve Thouzard
 * @access::    public
 */
interface MylinksThumbPlugin

Each interface must be in a namespace of at least one level (a top-level vendor name)

{
    public function getProviderUrl();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    public function getProviderName();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @param $szarray
     * @return mixed
     */
    public function setShotSize($szarray);

    public function getShotSize();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @param $url
     * @return mixed
     */
    public function setSiteUrl($url);

    public function getSiteUrl();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    public function setAttribution();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    public function getAttribution();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @param $key
     * @return mixed
     */
    public function setProviderPublicKey($key);

    public function getProviderPublicKey();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    /**
     * @param $key
     * @return mixed
     */
    public function setProviderPrivateKey($key);

    public function getProviderPrivateKey();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

}