admin/main.php ➔ delCat()

Complexity

Conditions	10
Paths	17

Size

Total Lines	79
Code Lines	43

Duplication

Lines	8
Ratio	10.13 %

Importance

Changes

0

<?php
function delCat()

delCat uses the super-global variable $_REQUEST which is generally not recommended.

delCat uses the super-global variable $_POST which is generally not recommended.

{
    global $xoopsDB, $myCatTree, $xoopsModule, $xoopsUser;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    $cid = mylinksUtility::mylinks_cleanVars($_REQUEST, 'cid', 0, 'int', array('min'=>0));

'cid' is of type string, but the function expects a object<unknown_type>.

    $ok  = mylinksUtility::mylinks_cleanVars($_POST, 'ok', 0, 'int', array('min'=>0, 'max'=>1));

'ok' is of type string, but the function expects a object<unknown_type>.

    if ( 1 == $ok ) {
        /**
         * nickname code:
         *
         *    get all subcategories
         *  get all links in these categories/subcategories
         *    get all links in category & subcategories
         *    delete all links in links, text, votedata, broken, & mod db tables that are in any of these categories
         *    delete all comments and notifications for the links that have been deleted
         *    delete category and all subcategories from category db table
         *    delete all notifications for the categories that have been deleted
         */
        $mylinksCatHandler =& xoops_getmodulehandler('category', $xoopsModule->getVar('dirname'));

        //get all subcategories under the specified category
        $catObjArr = $myCatTree->getAllChild($cid);
        $cidArray  = array();
        foreach ($catObjArr as $catObj) {
            $cidArray[] = $catObj->getVar('cid');
        }

        array_push($cidArray, $cid); //add this category id to the array
        $catIDs = implode(',', $cidArray);
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('cid', '(' . intval($cid) . ',' . $catIDs . ')', 'IN'));

        // get list ids in any of these categories
        $sql = sprintf('SELECT lid FROM %s WHERE cid IN %s', $xoopsDB->prefix('mylinks_links'), "({$catIDs})");
        $result = $xoopsDB->query($sql);
        if (!$result) {
            mylinksUtility::show_message(_MD_MYLINKS_NORECORDFOUND);

The method mylinksUtility::show_message() has been deprecated.

            exit();

The function delCat() contains an exit expression.

        }
        $lidArray = $xoopsDB->fetchArray($result);

        // delete any links, link notifications and link comments from the database tables
        if ( $lidArray ) {
            $linkIDs = '(' . implode(',', $lidArray) . ')';
            $dbTables = array( 'links', 'text', 'votedata', 'broken', 'mod' );
            foreach ($dbTables as $thisTable) {

This code seems to be duplicated across your project.

                $sql = sprintf('DELETE FROM %s WHERE lid IN %s', $xoopsDB->prefix("mylinks_{$thisTable}"), $linkIDs);
                $result = $xoopsDB->query($sql);

$result is not used, you could remove the assignment.

                if (!result) {
                    mylinksUtility::show_message(_MD_MYLINKS_NORECORDFOUND);

The method mylinksUtility::show_message() has been deprecated.

                    exit();

The function delCat() contains an exit expression.

                }
            }
            // remove any notifications and comments for these listings
            foreach ($lidArray as $this_lid) {
                xoops_comment_delete($xoopsModule->getVar('mid'), $this_lid);
                xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'link', $this_lid);
            }
        }
        // delete category and all subcategories from database
        if (!$mylinksCatHandler->deleteAll($criteria)) {
            redirect_header('main.php', 2, _MD_MYLINKS_NORECORDFOUND);
            exit();

The function delCat() contains an exit expression.

        }

        // delete the notification settings for each (sub)category
        foreach( $cidArray as $key=>$id) {
            xoops_notification_deletebyitem($xoopsModule->getVar('mid'), 'category', $id);
        }

        redirect_header('index.php', 2, _MD_MYLINKS_CATDELETED);
        exit();

The function delCat() contains an exit expression.

    } else {
        xoops_cp_header();
        xoops_confirm(array('op' => 'delCat', 'cid' => $cid, 'ok' => 1), 'main.php', _MD_MYLINKS_WARNING);
        include 'admin_footer.php';
    }
}