extras/waiting/plugins/mylinks.php ➔ b_waiting_mylinks()

Complexity

Conditions	4
Paths	8

Size

Total Lines

43

Duplication

Lines	11
Ratio	25.58 %

Importance

Changes

0

<?php
function b_waiting_mylinks()
{
    $xoopsDB = XoopsDatabaseFactory::getDatabaseConnection();
    $ret     = array();

    // mylinks links
    $block  = array();
    $result = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('mylinks_links') . ' WHERE status=0');
    if ($result) {

This code seems to be duplicated across your project.

        $block['adminlink'] = XOOPS_URL . '/modules/mylinks/admin/main.php?op=listNewLinks';
        list($block['pendingnum']) = $xoopsDB->fetchRow($result);
        $block['lang_linkname'] = _PI_WAITING_WAITINGS;
    }
    $ret[] = $block;

    // mylinks broken
    $block       = array();
    $bknHandler = xoops_getModuleHandler('broken', 'mylinks');
    $result      = $bknHandler->getCount();
    //    $result = $xoopsDB->query("SELECT COUNT(*) FROM ".$xoopsDB->prefix("mylinks_broken"));
    if ($result) {
        $block['adminlink'] = $xoops->url('modules/mylinks/admin/main.php?op=listBrokenLinks');

The variable $xoops does not exist. Did you forget to declare it?

        //        list($block['pendingnum']) = $xoopsDB->fetchRow($result);
        $block['pendingnum']    = $result;
        $block['lang_linkname'] = _PI_WAITING_BROKENS;
    }
    $ret[] = $block;

    // mylinks modreq
    $block          = array();
    $modreqHandler = xoops_getModuleHandler('modification', 'mylinks');
    $result         = $modreqHandler->getCount();
    //    $result = $xoopsDB->query("SELECT COUNT(*) FROM ".$xoopsDB->prefix("mylinks_mod"));
    if ($result) {

This code seems to be duplicated across your project.

        $block['adminlink'] = XOOPS_URL . '/modules/mylinks/admin/main.php?op=listModReq';
        //        list($block['pendingnum']) = $xoopsDB->fetchRow($result);
        $block['pendingnum']    = $result;
        $block['lang_linkname'] = _PI_WAITING_MODREQS;
    }
    $ret[] = $block;

    return $ret;
}