XoopsModules25x / myiframe

blocks/myiframe_iframe.php

<?php declare(strict_types=1);

/**
 * ****************************************************************************
 * MYIFRAME - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard of Instant Zero (https://www.instant-zero.com)
 * ****************************************************************************
 */

use XoopsModules\Newbb;

The type XoopsModules\Newbb was not found. Maybe you did not declare it correctly or list all dependencies?

use XoopsModules\Myiframe\{
    Constants,
    Helper
};

/** @var Helper $helper */

require_once XOOPS_ROOT_PATH . '/modules/myiframe/include/functions.php';

/**
 * @param $options
 * @return array
 */
function b_myiframe_iframe_show($options)
{
    if (!class_exists(Helper::class)) {
        return false;

The expression return false returns the type false which is incompatible with the documented return type array.

    }
    $frame         = null;

The assignment to $frame is dead and can be removed.

    $helper        = Helper::getInstance();
    $block         = [];
    $tblalign      = [
        'top',
        'middle',
        'bottom',
        'left',
        'rigth',
    ];
    $tblscrolling  = [
        'yes',
        'no',
        'auto',
    ];
    $iframeHandler = $helper->getHandler('MyiframeBase');
    $frame         = $iframeHandler->get($options[0]);

    if (is_object($frame)) {
        $block['longdesc']     = $frame->getVar('frame_description');
        $block['width']        = $frame->getVar('frame_width');
        $block['height']       = $frame->getVar('frame_height');
        $block['align']        = $tblalign[$frame->getVar('frame_align') - 1];
        $block['frameborder']  = $frame->getVar('frame_frameborder');
        $block['marginwidth']  = $frame->getVar('frame_marginwidth');
        $block['marginheight'] = $frame->getVar('frame_marginheight');
        $block['scrolling']    = $tblscrolling[$frame->getVar('frame_scrolling') - 1];
        $block['url']          = $frame->getVar('frame_url');
    }

    return $block;
}

/**
 * @param $options
 * @return string
 */
function b_myiframe_iframe_edit($options)
{
    if (!class_exists(Helper::class)) {
        return false;

The expression return false returns the type false which is incompatible with the documented return type string.

    }
    $helper = Helper::getInstance();

    /** @var \MyiframeBaseHandler $iframeHandler */
    $iframeHandler = $helper->getHandler('MyiframeBase');
    $frarray       = [];

The assignment to $frarray is dead and can be removed.

    $critere       = new \Criteria('1', '1', '=');
    $critere->setSort('frame_description');
    $frarray = $iframeHandler->getObjects($critere);

    $form = '' . _MB_MYIFRAME_IFRAME . "&nbsp;<select name='options[0]'>";
    /** @var Myiframe $oneframe */
    foreach ($frarray as $oneframe) {
        $form .= "<option value='" . $oneframe->getVar('frame_frameid') . "'";
        if ($options[0] == $oneframe->getVar('frame_frameid')) {
            $form .= " selected='selected'";
        }
        $form .= '>' . $oneframe->getVar('frame_description') . '</option>';
    }
    $form .= "</select>\n";

    return $form;
}

/**
 * @param $options
 */
function b_myiframe_iframe_onthefly($options): void
{
    $options = explode('|', $options);
    $block   = b_myiframe_iframe_show($options);

    $tpl = new \XoopsTpl();
    $tpl->assign('block', $block);
    $tpl->display('db:myiframe_block_show.tpl');
}