Inspection of "updates from aerograf" - XoopsModules25x/myiframe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Michael

created 2017-08-29 10:15 UTC

Status

Switch Indentation +155 added lines, -155 removed lines patch added patch discarded remove patch

@@ -103,167 +103,167 @@
 block discarded – undo
 }
 
 switch ($op) {
-    case 'verifybeforeedit':
-        if (isset($_POST['submit']) && $_POST['submit'] !== '') {
-            if ($_POST['longdesc'] === '') {
-                xoops_cp_header();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-                echo '<tr><td class="odd">';
-                echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-                echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-                echo '</td></tr></table>';
-                include_once __DIR__ . '/admin_footer.php';
-                xoops_cp_footer();
-                exit();
-            }
+    	case 'verifybeforeedit':
+        	if (isset($_POST['submit']) && $_POST['submit'] !== '') {
+            	if ($_POST['longdesc'] === '') {
+                	xoops_cp_header();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+                	echo '<tr><td class="odd">';
+                	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+                	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+                	echo '</td></tr></table>';
+                	include_once __DIR__ . '/admin_footer.php';
+                	xoops_cp_footer();
+                	exit();
+            	}
 
-            $frameid = $_POST['frameid'];
-            $frame   = $iframeHandler->get($frameid);
-            $frame->unsetNew();
-            $frame->setVar('frame_description', $_POST['longdesc']);
-            $frame->setVar('frame_width', $_POST['width']);
-            $frame->setVar('frame_height', $_POST['height']);
-            $frame->setVar('frame_align', $_POST['align']);
-            $frame->setVar('frame_frameborder', $_POST['frameborder']);
-            $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
-            $frame->setVar('frame_marginheight', $_POST['marginheight']);
-            $frame->setVar('frame_scrolling', $_POST['scrolling']);
-            $frame->setVar('frame_url', $_POST['url']);
-            $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
-            $res = $iframeHandler->insert($frame);
-            if (!$res) {
-                redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
-            }
-            redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
-        }
-        break;
+            	$frameid = $_POST['frameid'];
+            	$frame   = $iframeHandler->get($frameid);
+            	$frame->unsetNew();
+            	$frame->setVar('frame_description', $_POST['longdesc']);
+            	$frame->setVar('frame_width', $_POST['width']);
+            	$frame->setVar('frame_height', $_POST['height']);
+            	$frame->setVar('frame_align', $_POST['align']);
+            	$frame->setVar('frame_frameborder', $_POST['frameborder']);
+            	$frame->setVar('frame_marginwidth', $_POST['marginwidth']);
+            	$frame->setVar('frame_marginheight', $_POST['marginheight']);
+            	$frame->setVar('frame_scrolling', $_POST['scrolling']);
+            	$frame->setVar('frame_url', $_POST['url']);
+            	$frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
+            	$res = $iframeHandler->insert($frame);
+            	if (!$res) {
+                	redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
+            	}
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
+        	}
+        	break;
 
-    case 'edit':
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        if (isset($_GET['frameid'])) {
-            $frameid = (int)$_GET['frameid'];
-            $frame   = $iframeHandler->get($frameid);
-            AddEditForm($frameid, 'verifybeforeedit', _AM_MYIFRAME_CONFIG, $frame->getVar('frame_description', 'e'), $frame->getVar('frame_width', 'e'), $frame->getVar('frame_height', 'e'), $frame->getVar('frame_align', 'e'),
-                        $frame->getVar('frame_frameborder', 'e'), $frame->getVar('frame_marginwidth', 'e'), $frame->getVar('frame_marginheight', 'e'), $frame->getVar('frame_scrolling', 'e'), $frame->getVar('frame_url', 'e'), _AM_MYIFRAME_UPDATE);
-        } else {
-            xoops_cp_header();
-            $adminObject = \Xmf\Module\Admin::getInstance();
-            $adminObject->displayNavigation(basename(__FILE__));
-            echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-            echo '<tr><td class="odd">';
-            echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-            echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-            echo "</td></tr></table>\n";
-            include_once __DIR__ . '/admin_footer.php';
-            xoops_cp_footer();
-            exit();
-        }
-        break;
+    	case 'edit':
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	if (isset($_GET['frameid'])) {
+            	$frameid = (int)$_GET['frameid'];
+            	$frame   = $iframeHandler->get($frameid);
+            	AddEditForm($frameid, 'verifybeforeedit', _AM_MYIFRAME_CONFIG, $frame->getVar('frame_description', 'e'), $frame->getVar('frame_width', 'e'), $frame->getVar('frame_height', 'e'), $frame->getVar('frame_align', 'e'),
+                        	$frame->getVar('frame_frameborder', 'e'), $frame->getVar('frame_marginwidth', 'e'), $frame->getVar('frame_marginheight', 'e'), $frame->getVar('frame_scrolling', 'e'), $frame->getVar('frame_url', 'e'), _AM_MYIFRAME_UPDATE);
+        	} else {
+            	xoops_cp_header();
+            	$adminObject = \Xmf\Module\Admin::getInstance();
+            	$adminObject->displayNavigation(basename(__FILE__));
+            	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+            	echo '<tr><td class="odd">';
+            	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+            	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+            	echo "</td></tr></table>\n";
+            	include_once __DIR__ . '/admin_footer.php';
+            	xoops_cp_footer();
+            	exit();
+        	}
+        	break;
 
-    case 'delete':
-        if (!isset($_POST['ok'])) {
-            xoops_cp_header();
-            $adminObject = \Xmf\Module\Admin::getInstance();
-            $adminObject->displayNavigation(basename(__FILE__));
-            echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
-            xoops_confirm(array(
-                              'op'      => 'delete',
-                              'frameid' => (int)$_GET['frameid'],
-                              'ok'      => 1
-                          ), 'manage.php', _AM_MYIFRAME_RUSUREDEL);
-            include_once __DIR__ . '/admin_footer.php';
-        } else {
-            if (empty($_POST['frameid'])) {
-                redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
-            }
-            $frameid = (int)$_POST['frameid'];
-            $critere = new Criteria('frame_frameid', $frameid, '=');
-            $iframeHandler->deleteAll($critere);
-            redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
-        }
-        break;
+    	case 'delete':
+        	if (!isset($_POST['ok'])) {
+            	xoops_cp_header();
+            	$adminObject = \Xmf\Module\Admin::getInstance();
+            	$adminObject->displayNavigation(basename(__FILE__));
+            	echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
+            	xoops_confirm(array(
+                              	'op'      => 'delete',
+                              	'frameid' => (int)$_GET['frameid'],
+                              	'ok'      => 1
+                          	), 'manage.php', _AM_MYIFRAME_RUSUREDEL);
+            	include_once __DIR__ . '/admin_footer.php';
+        	} else {
+            	if (empty($_POST['frameid'])) {
+                	redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
+            	}
+            	$frameid = (int)$_POST['frameid'];
+            	$critere = new Criteria('frame_frameid', $frameid, '=');
+            	$iframeHandler->deleteAll($critere);
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
+        	}
+        	break;
 
-    case 'verifytoadd':
-        if (isset($_POST['submit']) && $_POST['submit'] !== '') {
-            if ($_POST['url'] === '') {
-                xoops_cp_header();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-                echo '<tr><td class="odd">';
-                echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-                echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-                echo "</td></tr></table>\n";
-                include_once __DIR__ . '/admin_footer.php';
-                xoops_cp_footer();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                exit();
-            }
-            $frame = $iframeHandler->create(true);
-            $frame->setVar('frame_description', $_POST['longdesc']);
-            $frame->setVar('frame_width', $_POST['width']);
-            $frame->setVar('frame_height', $_POST['height']);
-            $frame->setVar('frame_align', $_POST['align']);
-            $frame->setVar('frame_frameborder', $_POST['frameborder']);
-            $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
-            $frame->setVar('frame_marginheight', $_POST['marginheight']);
-            $frame->setVar('frame_scrolling', $_POST['scrolling']);
-            $frame->setVar('frame_url', $_POST['url']);
-            $frame->setVar('frame_created', time());
-            $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
-            $res = $iframeHandler->insert($frame);
-            if (!$res) {
-                redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
-            }
-            redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
-        }
-        break;
+    	case 'verifytoadd':
+        	if (isset($_POST['submit']) && $_POST['submit'] !== '') {
+            	if ($_POST['url'] === '') {
+                	xoops_cp_header();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+                	echo '<tr><td class="odd">';
+                	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+                	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+                	echo "</td></tr></table>\n";
+                	include_once __DIR__ . '/admin_footer.php';
+                	xoops_cp_footer();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	exit();
+            	}
+            	$frame = $iframeHandler->create(true);
+            	$frame->setVar('frame_description', $_POST['longdesc']);
+            	$frame->setVar('frame_width', $_POST['width']);
+            	$frame->setVar('frame_height', $_POST['height']);
+            	$frame->setVar('frame_align', $_POST['align']);
+            	$frame->setVar('frame_frameborder', $_POST['frameborder']);
+            	$frame->setVar('frame_marginwidth', $_POST['marginwidth']);
+            	$frame->setVar('frame_marginheight', $_POST['marginheight']);
+            	$frame->setVar('frame_scrolling', $_POST['scrolling']);
+            	$frame->setVar('frame_url', $_POST['url']);
+            	$frame->setVar('frame_created', time());
+            	$frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
+            	$res = $iframeHandler->insert($frame);
+            	if (!$res) {
+                	redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
+            	}
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
+        	}
+        	break;
 
-    case 'addframe':
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        AddEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
-        break;
+    	case 'addframe':
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	AddEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
+        	break;
 
-    case 'default':
-    default:
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
-        echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-        echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>"
-             . _AM_MYIFRAME_ACTION . "</th></tr>\n";
-        $critere = new Criteria('1', '1', '=');
-        $critere->setSort('frame_description');
-        $frarray = $iframeHandler->getObjects($critere);
-        $class   = 'even';
-        $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
-        if (count($frarray) > 0) {
-            foreach ($frarray as $frame) {
-                $action_edit   = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
-                $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
-                if (xoops_trim($frame->getVar('frame_description') === '')) {
-                    $liendesc = $frame->getVar('frame_url');
-                } else {
-                    $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
-                }
-                echo "<tr class='" . $class . "'><td align='center'>" . $frame->getVar('frame_frameid') . "</td><td align='center'>" . $liendesc . "</td><td align='center'>" . formatTimestamp($frame->getVar('frame_created'))
-                     . "</td><td align='center'>" . $frame->getVar('frame_hits') . "</td><td align='center'>" . $action_edit . '&nbsp;-&nbsp;' . $action_delete . "</td></tr>\n";
-                $class = ($class === 'even') ? 'odd' : 'even';
-            }
-        }
-        echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD
-             . "'></td></tr>";
-        echo '</table>';
-        include_once __DIR__ . '/admin_footer.php';
-        break;
+    	case 'default':
+    	default:
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
+        	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+        	echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>"
+             	. _AM_MYIFRAME_ACTION . "</th></tr>\n";
+        	$critere = new Criteria('1', '1', '=');
+        	$critere->setSort('frame_description');
+        	$frarray = $iframeHandler->getObjects($critere);
+        	$class   = 'even';
+        	$baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
+        	if (count($frarray) > 0) {
+            	foreach ($frarray as $frame) {
+                	$action_edit   = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
+                	$action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
+                	if (xoops_trim($frame->getVar('frame_description') === '')) {
+                    	$liendesc = $frame->getVar('frame_url');
+                	} else {
+                    	$liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
+                	}
+                	echo "<tr class='" . $class . "'><td align='center'>" . $frame->getVar('frame_frameid') . "</td><td align='center'>" . $liendesc . "</td><td align='center'>" . formatTimestamp($frame->getVar('frame_created'))
+                     	. "</td><td align='center'>" . $frame->getVar('frame_hits') . "</td><td align='center'>" . $action_edit . '&nbsp;-&nbsp;' . $action_delete . "</td></tr>\n";
+                	$class = ($class === 'even') ? 'odd' : 'even';
+            	}
+        	}
+        	echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD
+             	. "'></td></tr>";
+        	echo '</table>';
+        	include_once __DIR__ . '/admin_footer.php';
+        	break;
 }
 
 xoops_cp_footer();

Please login to merge, or discard this patch.

		@@ -103,167 +103,167 @@
		block discarded – undo
103	103	}
104	104
105	105	switch ($op) {
106		- case 'verifybeforeedit':
107		- if (isset($_POST['submit']) && $_POST['submit'] !== '') {
108		- if ($_POST['longdesc'] === '') {
109		- xoops_cp_header();
110		- $adminObject = \Xmf\Module\Admin::getInstance();
111		- $adminObject->displayNavigation(basename(__FILE__));
112		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
113		- echo '<tr><td class="odd">';
114		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
115		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
116		- echo '</td></tr></table>';
117		- include_once __DIR__ . '/admin_footer.php';
118		- xoops_cp_footer();
119		- exit();
120		- }
	106	+ case 'verifybeforeedit':
	107	+ if (isset($_POST['submit']) && $_POST['submit'] !== '') {
	108	+ if ($_POST['longdesc'] === '') {
	109	+ xoops_cp_header();
	110	+ $adminObject = \Xmf\Module\Admin::getInstance();
	111	+ $adminObject->displayNavigation(basename(__FILE__));
	112	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	113	+ echo '<tr><td class="odd">';
	114	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	115	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	116	+ echo '</td></tr></table>';
	117	+ include_once __DIR__ . '/admin_footer.php';
	118	+ xoops_cp_footer();
	119	+ exit();
	120	+ }
121	121
122		- $frameid = $_POST['frameid'];
123		- $frame = $iframeHandler->get($frameid);
124		- $frame->unsetNew();
125		- $frame->setVar('frame_description', $_POST['longdesc']);
126		- $frame->setVar('frame_width', $_POST['width']);
127		- $frame->setVar('frame_height', $_POST['height']);
128		- $frame->setVar('frame_align', $_POST['align']);
129		- $frame->setVar('frame_frameborder', $_POST['frameborder']);
130		- $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
131		- $frame->setVar('frame_marginheight', $_POST['marginheight']);
132		- $frame->setVar('frame_scrolling', $_POST['scrolling']);
133		- $frame->setVar('frame_url', $_POST['url']);
134		- $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
135		- $res = $iframeHandler->insert($frame);
136		- if (!$res) {
137		- redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
138		- }
139		- redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
140		- }
141		- break;
	122	+ $frameid = $_POST['frameid'];
	123	+ $frame = $iframeHandler->get($frameid);
	124	+ $frame->unsetNew();
	125	+ $frame->setVar('frame_description', $_POST['longdesc']);
	126	+ $frame->setVar('frame_width', $_POST['width']);
	127	+ $frame->setVar('frame_height', $_POST['height']);
	128	+ $frame->setVar('frame_align', $_POST['align']);
	129	+ $frame->setVar('frame_frameborder', $_POST['frameborder']);
	130	+ $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
	131	+ $frame->setVar('frame_marginheight', $_POST['marginheight']);
	132	+ $frame->setVar('frame_scrolling', $_POST['scrolling']);
	133	+ $frame->setVar('frame_url', $_POST['url']);
	134	+ $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
	135	+ $res = $iframeHandler->insert($frame);
	136	+ if (!$res) {
	137	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
	138	+ }
	139	+ redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
	140	+ }
	141	+ break;
142	142
143		- case 'edit':
144		- xoops_cp_header();
145		- $adminObject = \Xmf\Module\Admin::getInstance();
146		- $adminObject->displayNavigation(basename(__FILE__));
147		- if (isset($_GET['frameid'])) {
148		- $frameid = (int)$_GET['frameid'];
149		- $frame = $iframeHandler->get($frameid);
150		- AddEditForm($frameid, 'verifybeforeedit', _AM_MYIFRAME_CONFIG, $frame->getVar('frame_description', 'e'), $frame->getVar('frame_width', 'e'), $frame->getVar('frame_height', 'e'), $frame->getVar('frame_align', 'e'),
151		- $frame->getVar('frame_frameborder', 'e'), $frame->getVar('frame_marginwidth', 'e'), $frame->getVar('frame_marginheight', 'e'), $frame->getVar('frame_scrolling', 'e'), $frame->getVar('frame_url', 'e'), _AM_MYIFRAME_UPDATE);
152		- } else {
153		- xoops_cp_header();
154		- $adminObject = \Xmf\Module\Admin::getInstance();
155		- $adminObject->displayNavigation(basename(__FILE__));
156		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
157		- echo '<tr><td class="odd">';
158		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
159		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
160		- echo "</td></tr></table>\n";
161		- include_once __DIR__ . '/admin_footer.php';
162		- xoops_cp_footer();
163		- exit();
164		- }
165		- break;
	143	+ case 'edit':
	144	+ xoops_cp_header();
	145	+ $adminObject = \Xmf\Module\Admin::getInstance();
	146	+ $adminObject->displayNavigation(basename(__FILE__));
	147	+ if (isset($_GET['frameid'])) {
	148	+ $frameid = (int)$_GET['frameid'];
	149	+ $frame = $iframeHandler->get($frameid);
	150	+ AddEditForm($frameid, 'verifybeforeedit', _AM_MYIFRAME_CONFIG, $frame->getVar('frame_description', 'e'), $frame->getVar('frame_width', 'e'), $frame->getVar('frame_height', 'e'), $frame->getVar('frame_align', 'e'),
	151	+ $frame->getVar('frame_frameborder', 'e'), $frame->getVar('frame_marginwidth', 'e'), $frame->getVar('frame_marginheight', 'e'), $frame->getVar('frame_scrolling', 'e'), $frame->getVar('frame_url', 'e'), _AM_MYIFRAME_UPDATE);
	152	+ } else {
	153	+ xoops_cp_header();
	154	+ $adminObject = \Xmf\Module\Admin::getInstance();
	155	+ $adminObject->displayNavigation(basename(__FILE__));
	156	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	157	+ echo '<tr><td class="odd">';
	158	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	159	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	160	+ echo "</td></tr></table>\n";
	161	+ include_once __DIR__ . '/admin_footer.php';
	162	+ xoops_cp_footer();
	163	+ exit();
	164	+ }
	165	+ break;
166	166
167		- case 'delete':
168		- if (!isset($_POST['ok'])) {
169		- xoops_cp_header();
170		- $adminObject = \Xmf\Module\Admin::getInstance();
171		- $adminObject->displayNavigation(basename(__FILE__));
172		- echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
173		- xoops_confirm(array(
174		- 'op' => 'delete',
175		- 'frameid' => (int)$_GET['frameid'],
176		- 'ok' => 1
177		- ), 'manage.php', _AM_MYIFRAME_RUSUREDEL);
178		- include_once __DIR__ . '/admin_footer.php';
179		- } else {
180		- if (empty($_POST['frameid'])) {
181		- redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
182		- }
183		- $frameid = (int)$_POST['frameid'];
184		- $critere = new Criteria('frame_frameid', $frameid, '=');
185		- $iframeHandler->deleteAll($critere);
186		- redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
187		- }
188		- break;
	167	+ case 'delete':
	168	+ if (!isset($_POST['ok'])) {
	169	+ xoops_cp_header();
	170	+ $adminObject = \Xmf\Module\Admin::getInstance();
	171	+ $adminObject->displayNavigation(basename(__FILE__));
	172	+ echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
	173	+ xoops_confirm(array(
	174	+ 'op' => 'delete',
	175	+ 'frameid' => (int)$_GET['frameid'],
	176	+ 'ok' => 1
	177	+ ), 'manage.php', _AM_MYIFRAME_RUSUREDEL);
	178	+ include_once __DIR__ . '/admin_footer.php';
	179	+ } else {
	180	+ if (empty($_POST['frameid'])) {
	181	+ redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
	182	+ }
	183	+ $frameid = (int)$_POST['frameid'];
	184	+ $critere = new Criteria('frame_frameid', $frameid, '=');
	185	+ $iframeHandler->deleteAll($critere);
	186	+ redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
	187	+ }
	188	+ break;
189	189
190		- case 'verifytoadd':
191		- if (isset($_POST['submit']) && $_POST['submit'] !== '') {
192		- if ($_POST['url'] === '') {
193		- xoops_cp_header();
194		- $adminObject = \Xmf\Module\Admin::getInstance();
195		- $adminObject->displayNavigation(basename(__FILE__));
196		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
197		- echo '<tr><td class="odd">';
198		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
199		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
200		- echo "</td></tr></table>\n";
201		- include_once __DIR__ . '/admin_footer.php';
202		- xoops_cp_footer();
203		- $adminObject = \Xmf\Module\Admin::getInstance();
204		- $adminObject->displayNavigation(basename(__FILE__));
205		- exit();
206		- }
207		- $frame = $iframeHandler->create(true);
208		- $frame->setVar('frame_description', $_POST['longdesc']);
209		- $frame->setVar('frame_width', $_POST['width']);
210		- $frame->setVar('frame_height', $_POST['height']);
211		- $frame->setVar('frame_align', $_POST['align']);
212		- $frame->setVar('frame_frameborder', $_POST['frameborder']);
213		- $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
214		- $frame->setVar('frame_marginheight', $_POST['marginheight']);
215		- $frame->setVar('frame_scrolling', $_POST['scrolling']);
216		- $frame->setVar('frame_url', $_POST['url']);
217		- $frame->setVar('frame_created', time());
218		- $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
219		- $res = $iframeHandler->insert($frame);
220		- if (!$res) {
221		- redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
222		- }
223		- redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
224		- }
225		- break;
	190	+ case 'verifytoadd':
	191	+ if (isset($_POST['submit']) && $_POST['submit'] !== '') {
	192	+ if ($_POST['url'] === '') {
	193	+ xoops_cp_header();
	194	+ $adminObject = \Xmf\Module\Admin::getInstance();
	195	+ $adminObject->displayNavigation(basename(__FILE__));
	196	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	197	+ echo '<tr><td class="odd">';
	198	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	199	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	200	+ echo "</td></tr></table>\n";
	201	+ include_once __DIR__ . '/admin_footer.php';
	202	+ xoops_cp_footer();
	203	+ $adminObject = \Xmf\Module\Admin::getInstance();
	204	+ $adminObject->displayNavigation(basename(__FILE__));
	205	+ exit();
	206	+ }
	207	+ $frame = $iframeHandler->create(true);
	208	+ $frame->setVar('frame_description', $_POST['longdesc']);
	209	+ $frame->setVar('frame_width', $_POST['width']);
	210	+ $frame->setVar('frame_height', $_POST['height']);
	211	+ $frame->setVar('frame_align', $_POST['align']);
	212	+ $frame->setVar('frame_frameborder', $_POST['frameborder']);
	213	+ $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
	214	+ $frame->setVar('frame_marginheight', $_POST['marginheight']);
	215	+ $frame->setVar('frame_scrolling', $_POST['scrolling']);
	216	+ $frame->setVar('frame_url', $_POST['url']);
	217	+ $frame->setVar('frame_created', time());
	218	+ $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
	219	+ $res = $iframeHandler->insert($frame);
	220	+ if (!$res) {
	221	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
	222	+ }
	223	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
	224	+ }
	225	+ break;
226	226
227		- case 'addframe':
228		- xoops_cp_header();
229		- $adminObject = \Xmf\Module\Admin::getInstance();
230		- $adminObject->displayNavigation(basename(__FILE__));
231		- AddEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
232		- break;
	227	+ case 'addframe':
	228	+ xoops_cp_header();
	229	+ $adminObject = \Xmf\Module\Admin::getInstance();
	230	+ $adminObject->displayNavigation(basename(__FILE__));
	231	+ AddEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
	232	+ break;
233	233
234		- case 'default':
235		- default:
236		- xoops_cp_header();
237		- $adminObject = \Xmf\Module\Admin::getInstance();
238		- $adminObject->displayNavigation(basename(__FILE__));
239		- echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
240		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
241		- echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>"
242		- . _AM_MYIFRAME_ACTION . "</th></tr>\n";
243		- $critere = new Criteria('1', '1', '=');
244		- $critere->setSort('frame_description');
245		- $frarray = $iframeHandler->getObjects($critere);
246		- $class = 'even';
247		- $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
248		- if (count($frarray) > 0) {
249		- foreach ($frarray as $frame) {
250		- $action_edit = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
251		- $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
252		- if (xoops_trim($frame->getVar('frame_description') === '')) {
253		- $liendesc = $frame->getVar('frame_url');
254		- } else {
255		- $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
256		- }
257		- echo "<tr class='" . $class . "'><td align='center'>" . $frame->getVar('frame_frameid') . "</td><td align='center'>" . $liendesc . "</td><td align='center'>" . formatTimestamp($frame->getVar('frame_created'))
258		- . "</td><td align='center'>" . $frame->getVar('frame_hits') . "</td><td align='center'>" . $action_edit . ' - ' . $action_delete . "</td></tr>\n";
259		- $class = ($class === 'even') ? 'odd' : 'even';
260		- }
261		- }
262		- echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD
263		- . "'></td></tr>";
264		- echo '</table>';
265		- include_once __DIR__ . '/admin_footer.php';
266		- break;
	234	+ case 'default':
	235	+ default:
	236	+ xoops_cp_header();
	237	+ $adminObject = \Xmf\Module\Admin::getInstance();
	238	+ $adminObject->displayNavigation(basename(__FILE__));
	239	+ echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
	240	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	241	+ echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>"
	242	+ . _AM_MYIFRAME_ACTION . "</th></tr>\n";
	243	+ $critere = new Criteria('1', '1', '=');
	244	+ $critere->setSort('frame_description');
	245	+ $frarray = $iframeHandler->getObjects($critere);
	246	+ $class = 'even';
	247	+ $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
	248	+ if (count($frarray) > 0) {
	249	+ foreach ($frarray as $frame) {
	250	+ $action_edit = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
	251	+ $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
	252	+ if (xoops_trim($frame->getVar('frame_description') === '')) {
	253	+ $liendesc = $frame->getVar('frame_url');
	254	+ } else {
	255	+ $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
	256	+ }
	257	+ echo "<tr class='" . $class . "'><td align='center'>" . $frame->getVar('frame_frameid') . "</td><td align='center'>" . $liendesc . "</td><td align='center'>" . formatTimestamp($frame->getVar('frame_created'))
	258	+ . "</td><td align='center'>" . $frame->getVar('frame_hits') . "</td><td align='center'>" . $action_edit . ' - ' . $action_delete . "</td></tr>\n";
	259	+ $class = ($class === 'even') ? 'odd' : 'even';
	260	+ }
	261	+ }
	262	+ echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD
	263	+ . "'></td></tr>";
	264	+ echo '</table>';
	265	+ include_once __DIR__ . '/admin_footer.php';
	266	+ break;
267	267	}
268	268
269	269	xoops_cp_footer();

XoopsModules25x / myiframe

Pull Request — master (#6)

Status

Category

Switch Indentation +155 added lines, -155 removed lines patch added patch discarded remove patch