Inspection of "Merge pull request #6 from mambax7/master" - XoopsModules25x/myiframe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c936a...757841 )

by Michael

created 2017-09-08 07:41 UTC

Status

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -51,7 +51,7 @@
 block discarded – undo
     }
 
     /**
-     * @param $id
+     * @param integer $id
      */
     public function load($id)
     {

Please login to merge, or discard this patch.

admin/manage.php 1 patch

Switch Indentation +180 added lines, -180 removed lines patch added patch discarded remove patch

@@ -105,192 +105,192 @@
 block discarded – undo
 }
 
 switch ($op) {
-    case 'verifybeforeedit':
-        if (isset($_POST['submit']) && $_POST['submit'] !== '') {
-            if ($_POST['longdesc'] === '') {
-                xoops_cp_header();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-                echo '<tr><td class="odd">';
-                echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-                echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-                echo '</td></tr></table>';
-                include_once __DIR__ . '/admin_footer.php';
-                xoops_cp_footer();
-                exit();
-            }
+    	case 'verifybeforeedit':
+        	if (isset($_POST['submit']) && $_POST['submit'] !== '') {
+            	if ($_POST['longdesc'] === '') {
+                	xoops_cp_header();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+                	echo '<tr><td class="odd">';
+                	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+                	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+                	echo '</td></tr></table>';
+                	include_once __DIR__ . '/admin_footer.php';
+                	xoops_cp_footer();
+                	exit();
+            	}
 
-            $frameid = $_POST['frameid'];
-            $frame   = $iframeHandler->get($frameid);
-            $frame->unsetNew();
-            $frame->setVar('frame_description', $_POST['longdesc']);
-            $frame->setVar('frame_width', $_POST['width']);
-            $frame->setVar('frame_height', $_POST['height']);
-            $frame->setVar('frame_align', $_POST['align']);
-            $frame->setVar('frame_frameborder', $_POST['frameborder']);
-            $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
-            $frame->setVar('frame_marginheight', $_POST['marginheight']);
-            $frame->setVar('frame_scrolling', $_POST['scrolling']);
-            $frame->setVar('frame_url', $_POST['url']);
-            $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
-            $res = $iframeHandler->insert($frame);
-            if (!$res) {
-                redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
-            }
-            redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
-        }
-        break;
+            	$frameid = $_POST['frameid'];
+            	$frame   = $iframeHandler->get($frameid);
+            	$frame->unsetNew();
+            	$frame->setVar('frame_description', $_POST['longdesc']);
+            	$frame->setVar('frame_width', $_POST['width']);
+            	$frame->setVar('frame_height', $_POST['height']);
+            	$frame->setVar('frame_align', $_POST['align']);
+            	$frame->setVar('frame_frameborder', $_POST['frameborder']);
+            	$frame->setVar('frame_marginwidth', $_POST['marginwidth']);
+            	$frame->setVar('frame_marginheight', $_POST['marginheight']);
+            	$frame->setVar('frame_scrolling', $_POST['scrolling']);
+            	$frame->setVar('frame_url', $_POST['url']);
+            	$frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
+            	$res = $iframeHandler->insert($frame);
+            	if (!$res) {
+                	redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
+            	}
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
+        	}
+        	break;
 
-    case 'edit':
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        if (isset($_GET['frameid'])) {
-            $frameid = (int)$_GET['frameid'];
-            $frame   = $iframeHandler->get($frameid);
-            addEditForm(
-                $frameid,
-                'verifybeforeedit',
-                _AM_MYIFRAME_CONFIG,
-                $frame->getVar('frame_description', 'e'),
-                $frame->getVar('frame_width', 'e'),
-                $frame->getVar('frame_height', 'e'),
-                $frame->getVar('frame_align', 'e'),
-                $frame->getVar('frame_frameborder', 'e'),
-                        $frame->getVar('frame_marginwidth', 'e'),
-                $frame->getVar('frame_marginheight', 'e'),
-                $frame->getVar('frame_scrolling', 'e'),
-                $frame->getVar('frame_url', 'e'),
-                _AM_MYIFRAME_UPDATE
-            );
-        } else {
-            xoops_cp_header();
-            $adminObject = \Xmf\Module\Admin::getInstance();
-            $adminObject->displayNavigation(basename(__FILE__));
-            echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-            echo '<tr><td class="odd">';
-            echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-            echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-            echo "</td></tr></table>\n";
-            include_once __DIR__ . '/admin_footer.php';
-            xoops_cp_footer();
-            exit();
-        }
-        break;
+    	case 'edit':
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	if (isset($_GET['frameid'])) {
+            	$frameid = (int)$_GET['frameid'];
+            	$frame   = $iframeHandler->get($frameid);
+            	addEditForm(
+                	$frameid,
+                	'verifybeforeedit',
+                	_AM_MYIFRAME_CONFIG,
+                	$frame->getVar('frame_description', 'e'),
+                	$frame->getVar('frame_width', 'e'),
+                	$frame->getVar('frame_height', 'e'),
+                	$frame->getVar('frame_align', 'e'),
+                	$frame->getVar('frame_frameborder', 'e'),
+                        	$frame->getVar('frame_marginwidth', 'e'),
+                	$frame->getVar('frame_marginheight', 'e'),
+                	$frame->getVar('frame_scrolling', 'e'),
+                	$frame->getVar('frame_url', 'e'),
+                	_AM_MYIFRAME_UPDATE
+            	);
+        	} else {
+            	xoops_cp_header();
+            	$adminObject = \Xmf\Module\Admin::getInstance();
+            	$adminObject->displayNavigation(basename(__FILE__));
+            	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+            	echo '<tr><td class="odd">';
+            	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+            	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+            	echo "</td></tr></table>\n";
+            	include_once __DIR__ . '/admin_footer.php';
+            	xoops_cp_footer();
+            	exit();
+        	}
+        	break;
 
-    case 'delete':
-        if (!isset($_POST['ok'])) {
-            xoops_cp_header();
-            $adminObject = \Xmf\Module\Admin::getInstance();
-            $adminObject->displayNavigation(basename(__FILE__));
-            echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
-            xoops_confirm([
-                              'op'      => 'delete',
-                              'frameid' => (int)$_GET['frameid'],
-                              'ok'      => 1
-                          ], 'manage.php', _AM_MYIFRAME_RUSUREDEL);
-            include_once __DIR__ . '/admin_footer.php';
-        } else {
-            if (empty($_POST['frameid'])) {
-                redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
-            }
-            $frameid = (int)$_POST['frameid'];
-            $critere = new Criteria('frame_frameid', $frameid, '=');
-            $iframeHandler->deleteAll($critere);
-            redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
-        }
-        break;
+    	case 'delete':
+        	if (!isset($_POST['ok'])) {
+            	xoops_cp_header();
+            	$adminObject = \Xmf\Module\Admin::getInstance();
+            	$adminObject->displayNavigation(basename(__FILE__));
+            	echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
+            	xoops_confirm([
+                              	'op'      => 'delete',
+                              	'frameid' => (int)$_GET['frameid'],
+                              	'ok'      => 1
+                          	], 'manage.php', _AM_MYIFRAME_RUSUREDEL);
+            	include_once __DIR__ . '/admin_footer.php';
+        	} else {
+            	if (empty($_POST['frameid'])) {
+                	redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
+            	}
+            	$frameid = (int)$_POST['frameid'];
+            	$critere = new Criteria('frame_frameid', $frameid, '=');
+            	$iframeHandler->deleteAll($critere);
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
+        	}
+        	break;
 
-    case 'verifytoadd':
-        if (isset($_POST['submit']) && $_POST['submit'] !== '') {
-            if ($_POST['url'] === '') {
-                xoops_cp_header();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-                echo '<tr><td class="odd">';
-                echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
-                echo _AM_MYIFRAME_ERROR_ADD_INDEX;
-                echo "</td></tr></table>\n";
-                include_once __DIR__ . '/admin_footer.php';
-                xoops_cp_footer();
-                $adminObject = \Xmf\Module\Admin::getInstance();
-                $adminObject->displayNavigation(basename(__FILE__));
-                exit();
-            }
-            $frame = $iframeHandler->create(true);
-            $frame->setVar('frame_description', $_POST['longdesc']);
-            $frame->setVar('frame_width', $_POST['width']);
-            $frame->setVar('frame_height', $_POST['height']);
-            $frame->setVar('frame_align', $_POST['align']);
-            $frame->setVar('frame_frameborder', $_POST['frameborder']);
-            $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
-            $frame->setVar('frame_marginheight', $_POST['marginheight']);
-            $frame->setVar('frame_scrolling', $_POST['scrolling']);
-            $frame->setVar('frame_url', $_POST['url']);
-            $frame->setVar('frame_created', time());
-            $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
-            $res = $iframeHandler->insert($frame);
-            if (!$res) {
-                redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
-            }
-            redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
-        }
-        break;
+    	case 'verifytoadd':
+        	if (isset($_POST['submit']) && $_POST['submit'] !== '') {
+            	if ($_POST['url'] === '') {
+                	xoops_cp_header();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+                	echo '<tr><td class="odd">';
+                	echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
+                	echo _AM_MYIFRAME_ERROR_ADD_INDEX;
+                	echo "</td></tr></table>\n";
+                	include_once __DIR__ . '/admin_footer.php';
+                	xoops_cp_footer();
+                	$adminObject = \Xmf\Module\Admin::getInstance();
+                	$adminObject->displayNavigation(basename(__FILE__));
+                	exit();
+            	}
+            	$frame = $iframeHandler->create(true);
+            	$frame->setVar('frame_description', $_POST['longdesc']);
+            	$frame->setVar('frame_width', $_POST['width']);
+            	$frame->setVar('frame_height', $_POST['height']);
+            	$frame->setVar('frame_align', $_POST['align']);
+            	$frame->setVar('frame_frameborder', $_POST['frameborder']);
+            	$frame->setVar('frame_marginwidth', $_POST['marginwidth']);
+            	$frame->setVar('frame_marginheight', $_POST['marginheight']);
+            	$frame->setVar('frame_scrolling', $_POST['scrolling']);
+            	$frame->setVar('frame_url', $_POST['url']);
+            	$frame->setVar('frame_created', time());
+            	$frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
+            	$res = $iframeHandler->insert($frame);
+            	if (!$res) {
+                	redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
+            	}
+            	redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
+        	}
+        	break;
 
-    case 'addframe':
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        addEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
-        break;
+    	case 'addframe':
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	addEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
+        	break;
 
-    case 'default':
-    default:
-        xoops_cp_header();
-        $adminObject = \Xmf\Module\Admin::getInstance();
-        $adminObject->displayNavigation(basename(__FILE__));
-        echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
-        echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
-        echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>" . _AM_MYIFRAME_ACTION . "</th></tr>\n";
-        $critere = new Criteria('1', '1', '=');
-        $critere->setSort('frame_description');
-        $frarray = $iframeHandler->getObjects($critere);
-        $class   = 'even';
-        $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
-        if (count($frarray) > 0) {
-            /** @var Myiframe $frame */
-            foreach ($frarray as $frame) {
-                $action_edit   = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
-                $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
-                if (xoops_trim($frame->getVar('frame_description')) === '') {
-                    $liendesc = $frame->getVar('frame_url');
-                } else {
-                    $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
-                }
-                echo "<tr class='"
-                     . $class
-                     . "'><td align='center'>"
-                     . $frame->getVar('frame_frameid')
-                     . "</td><td align='center'>"
-                     . $liendesc
-                     . "</td><td align='center'>"
-                     . formatTimestamp($frame->getVar('frame_created'))
-                     . "</td><td align='center'>"
-                     . $frame->getVar('frame_hits')
-                     . "</td><td align='center'>"
-                     . $action_edit
-                     . '&nbsp;-&nbsp;'
-                     . $action_delete
-                     . "</td></tr>\n";
-                $class = ($class === 'even') ? 'odd' : 'even';
-            }
-        }
-        echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD . "'></td></tr>";
-        echo '</table>';
-        include_once __DIR__ . '/admin_footer.php';
-        break;
+    	case 'default':
+    	default:
+        	xoops_cp_header();
+        	$adminObject = \Xmf\Module\Admin::getInstance();
+        	$adminObject->displayNavigation(basename(__FILE__));
+        	echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
+        	echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
+        	echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>" . _AM_MYIFRAME_ACTION . "</th></tr>\n";
+        	$critere = new Criteria('1', '1', '=');
+        	$critere->setSort('frame_description');
+        	$frarray = $iframeHandler->getObjects($critere);
+        	$class   = 'even';
+        	$baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
+        	if (count($frarray) > 0) {
+            	/** @var Myiframe $frame */
+            	foreach ($frarray as $frame) {
+                	$action_edit   = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
+                	$action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
+                	if (xoops_trim($frame->getVar('frame_description')) === '') {
+                    	$liendesc = $frame->getVar('frame_url');
+                	} else {
+                    	$liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
+                	}
+                	echo "<tr class='"
+                     	. $class
+                     	. "'><td align='center'>"
+                     	. $frame->getVar('frame_frameid')
+                     	. "</td><td align='center'>"
+                     	. $liendesc
+                     	. "</td><td align='center'>"
+                     	. formatTimestamp($frame->getVar('frame_created'))
+                     	. "</td><td align='center'>"
+                     	. $frame->getVar('frame_hits')
+                     	. "</td><td align='center'>"
+                     	. $action_edit
+                     	. '&nbsp;-&nbsp;'
+                     	. $action_delete
+                     	. "</td></tr>\n";
+                	$class = ($class === 'even') ? 'odd' : 'even';
+            	}
+        	}
+        	echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD . "'></td></tr>";
+        	echo '</table>';
+        	include_once __DIR__ . '/admin_footer.php';
+        	break;
 }
 
 xoops_cp_footer();

Please login to merge, or discard this patch.

		@@ -51,7 +51,7 @@
		block discarded – undo
51	51	}
52	52
53	53	/**
54		- * @param $id
	54	+ * @param integer $id
55	55	*/
56	56	public function load($id)
57	57	{

		@@ -105,192 +105,192 @@
		block discarded – undo
105	105	}
106	106
107	107	switch ($op) {
108		- case 'verifybeforeedit':
109		- if (isset($_POST['submit']) && $_POST['submit'] !== '') {
110		- if ($_POST['longdesc'] === '') {
111		- xoops_cp_header();
112		- $adminObject = \Xmf\Module\Admin::getInstance();
113		- $adminObject->displayNavigation(basename(__FILE__));
114		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
115		- echo '<tr><td class="odd">';
116		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
117		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
118		- echo '</td></tr></table>';
119		- include_once __DIR__ . '/admin_footer.php';
120		- xoops_cp_footer();
121		- exit();
122		- }
	108	+ case 'verifybeforeedit':
	109	+ if (isset($_POST['submit']) && $_POST['submit'] !== '') {
	110	+ if ($_POST['longdesc'] === '') {
	111	+ xoops_cp_header();
	112	+ $adminObject = \Xmf\Module\Admin::getInstance();
	113	+ $adminObject->displayNavigation(basename(__FILE__));
	114	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	115	+ echo '<tr><td class="odd">';
	116	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	117	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	118	+ echo '</td></tr></table>';
	119	+ include_once __DIR__ . '/admin_footer.php';
	120	+ xoops_cp_footer();
	121	+ exit();
	122	+ }
123	123
124		- $frameid = $_POST['frameid'];
125		- $frame = $iframeHandler->get($frameid);
126		- $frame->unsetNew();
127		- $frame->setVar('frame_description', $_POST['longdesc']);
128		- $frame->setVar('frame_width', $_POST['width']);
129		- $frame->setVar('frame_height', $_POST['height']);
130		- $frame->setVar('frame_align', $_POST['align']);
131		- $frame->setVar('frame_frameborder', $_POST['frameborder']);
132		- $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
133		- $frame->setVar('frame_marginheight', $_POST['marginheight']);
134		- $frame->setVar('frame_scrolling', $_POST['scrolling']);
135		- $frame->setVar('frame_url', $_POST['url']);
136		- $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
137		- $res = $iframeHandler->insert($frame);
138		- if (!$res) {
139		- redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
140		- }
141		- redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
142		- }
143		- break;
	124	+ $frameid = $_POST['frameid'];
	125	+ $frame = $iframeHandler->get($frameid);
	126	+ $frame->unsetNew();
	127	+ $frame->setVar('frame_description', $_POST['longdesc']);
	128	+ $frame->setVar('frame_width', $_POST['width']);
	129	+ $frame->setVar('frame_height', $_POST['height']);
	130	+ $frame->setVar('frame_align', $_POST['align']);
	131	+ $frame->setVar('frame_frameborder', $_POST['frameborder']);
	132	+ $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
	133	+ $frame->setVar('frame_marginheight', $_POST['marginheight']);
	134	+ $frame->setVar('frame_scrolling', $_POST['scrolling']);
	135	+ $frame->setVar('frame_url', $_POST['url']);
	136	+ $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
	137	+ $res = $iframeHandler->insert($frame);
	138	+ if (!$res) {
	139	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_MODIFY_DB);
	140	+ }
	141	+ redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
	142	+ }
	143	+ break;
144	144
145		- case 'edit':
146		- xoops_cp_header();
147		- $adminObject = \Xmf\Module\Admin::getInstance();
148		- $adminObject->displayNavigation(basename(__FILE__));
149		- if (isset($_GET['frameid'])) {
150		- $frameid = (int)$_GET['frameid'];
151		- $frame = $iframeHandler->get($frameid);
152		- addEditForm(
153		- $frameid,
154		- 'verifybeforeedit',
155		- _AM_MYIFRAME_CONFIG,
156		- $frame->getVar('frame_description', 'e'),
157		- $frame->getVar('frame_width', 'e'),
158		- $frame->getVar('frame_height', 'e'),
159		- $frame->getVar('frame_align', 'e'),
160		- $frame->getVar('frame_frameborder', 'e'),
161		- $frame->getVar('frame_marginwidth', 'e'),
162		- $frame->getVar('frame_marginheight', 'e'),
163		- $frame->getVar('frame_scrolling', 'e'),
164		- $frame->getVar('frame_url', 'e'),
165		- _AM_MYIFRAME_UPDATE
166		- );
167		- } else {
168		- xoops_cp_header();
169		- $adminObject = \Xmf\Module\Admin::getInstance();
170		- $adminObject->displayNavigation(basename(__FILE__));
171		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
172		- echo '<tr><td class="odd">';
173		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
174		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
175		- echo "</td></tr></table>\n";
176		- include_once __DIR__ . '/admin_footer.php';
177		- xoops_cp_footer();
178		- exit();
179		- }
180		- break;
	145	+ case 'edit':
	146	+ xoops_cp_header();
	147	+ $adminObject = \Xmf\Module\Admin::getInstance();
	148	+ $adminObject->displayNavigation(basename(__FILE__));
	149	+ if (isset($_GET['frameid'])) {
	150	+ $frameid = (int)$_GET['frameid'];
	151	+ $frame = $iframeHandler->get($frameid);
	152	+ addEditForm(
	153	+ $frameid,
	154	+ 'verifybeforeedit',
	155	+ _AM_MYIFRAME_CONFIG,
	156	+ $frame->getVar('frame_description', 'e'),
	157	+ $frame->getVar('frame_width', 'e'),
	158	+ $frame->getVar('frame_height', 'e'),
	159	+ $frame->getVar('frame_align', 'e'),
	160	+ $frame->getVar('frame_frameborder', 'e'),
	161	+ $frame->getVar('frame_marginwidth', 'e'),
	162	+ $frame->getVar('frame_marginheight', 'e'),
	163	+ $frame->getVar('frame_scrolling', 'e'),
	164	+ $frame->getVar('frame_url', 'e'),
	165	+ _AM_MYIFRAME_UPDATE
	166	+ );
	167	+ } else {
	168	+ xoops_cp_header();
	169	+ $adminObject = \Xmf\Module\Admin::getInstance();
	170	+ $adminObject->displayNavigation(basename(__FILE__));
	171	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	172	+ echo '<tr><td class="odd">';
	173	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	174	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	175	+ echo "</td></tr></table>\n";
	176	+ include_once __DIR__ . '/admin_footer.php';
	177	+ xoops_cp_footer();
	178	+ exit();
	179	+ }
	180	+ break;
181	181
182		- case 'delete':
183		- if (!isset($_POST['ok'])) {
184		- xoops_cp_header();
185		- $adminObject = \Xmf\Module\Admin::getInstance();
186		- $adminObject->displayNavigation(basename(__FILE__));
187		- echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
188		- xoops_confirm([
189		- 'op' => 'delete',
190		- 'frameid' => (int)$_GET['frameid'],
191		- 'ok' => 1
192		- ], 'manage.php', _AM_MYIFRAME_RUSUREDEL);
193		- include_once __DIR__ . '/admin_footer.php';
194		- } else {
195		- if (empty($_POST['frameid'])) {
196		- redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
197		- }
198		- $frameid = (int)$_POST['frameid'];
199		- $critere = new Criteria('frame_frameid', $frameid, '=');
200		- $iframeHandler->deleteAll($critere);
201		- redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
202		- }
203		- break;
	182	+ case 'delete':
	183	+ if (!isset($_POST['ok'])) {
	184	+ xoops_cp_header();
	185	+ $adminObject = \Xmf\Module\Admin::getInstance();
	186	+ $adminObject->displayNavigation(basename(__FILE__));
	187	+ echo '<h4>' . _AM_MYIFRAME_CONFIG . '</h4>';
	188	+ xoops_confirm([
	189	+ 'op' => 'delete',
	190	+ 'frameid' => (int)$_GET['frameid'],
	191	+ 'ok' => 1
	192	+ ], 'manage.php', _AM_MYIFRAME_RUSUREDEL);
	193	+ include_once __DIR__ . '/admin_footer.php';
	194	+ } else {
	195	+ if (empty($_POST['frameid'])) {
	196	+ redirect_header('manage.php', 2, _AM_MYIFRAME_ERROR_ADD_INDEX);
	197	+ }
	198	+ $frameid = (int)$_POST['frameid'];
	199	+ $critere = new Criteria('frame_frameid', $frameid, '=');
	200	+ $iframeHandler->deleteAll($critere);
	201	+ redirect_header('manage.php', 1, _AM_MYIFRAME_DBUPDATED);
	202	+ }
	203	+ break;
204	204
205		- case 'verifytoadd':
206		- if (isset($_POST['submit']) && $_POST['submit'] !== '') {
207		- if ($_POST['url'] === '') {
208		- xoops_cp_header();
209		- $adminObject = \Xmf\Module\Admin::getInstance();
210		- $adminObject->displayNavigation(basename(__FILE__));
211		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
212		- echo '<tr><td class="odd">';
213		- echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
214		- echo _AM_MYIFRAME_ERROR_ADD_INDEX;
215		- echo "</td></tr></table>\n";
216		- include_once __DIR__ . '/admin_footer.php';
217		- xoops_cp_footer();
218		- $adminObject = \Xmf\Module\Admin::getInstance();
219		- $adminObject->displayNavigation(basename(__FILE__));
220		- exit();
221		- }
222		- $frame = $iframeHandler->create(true);
223		- $frame->setVar('frame_description', $_POST['longdesc']);
224		- $frame->setVar('frame_width', $_POST['width']);
225		- $frame->setVar('frame_height', $_POST['height']);
226		- $frame->setVar('frame_align', $_POST['align']);
227		- $frame->setVar('frame_frameborder', $_POST['frameborder']);
228		- $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
229		- $frame->setVar('frame_marginheight', $_POST['marginheight']);
230		- $frame->setVar('frame_scrolling', $_POST['scrolling']);
231		- $frame->setVar('frame_url', $_POST['url']);
232		- $frame->setVar('frame_created', time());
233		- $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
234		- $res = $iframeHandler->insert($frame);
235		- if (!$res) {
236		- redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
237		- }
238		- redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
239		- }
240		- break;
	205	+ case 'verifytoadd':
	206	+ if (isset($_POST['submit']) && $_POST['submit'] !== '') {
	207	+ if ($_POST['url'] === '') {
	208	+ xoops_cp_header();
	209	+ $adminObject = \Xmf\Module\Admin::getInstance();
	210	+ $adminObject->displayNavigation(basename(__FILE__));
	211	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	212	+ echo '<tr><td class="odd">';
	213	+ echo "<a href='manage.php'><h4>" . _AM_MYIFRAME_CONFIG . '</h4></a>';
	214	+ echo _AM_MYIFRAME_ERROR_ADD_INDEX;
	215	+ echo "</td></tr></table>\n";
	216	+ include_once __DIR__ . '/admin_footer.php';
	217	+ xoops_cp_footer();
	218	+ $adminObject = \Xmf\Module\Admin::getInstance();
	219	+ $adminObject->displayNavigation(basename(__FILE__));
	220	+ exit();
	221	+ }
	222	+ $frame = $iframeHandler->create(true);
	223	+ $frame->setVar('frame_description', $_POST['longdesc']);
	224	+ $frame->setVar('frame_width', $_POST['width']);
	225	+ $frame->setVar('frame_height', $_POST['height']);
	226	+ $frame->setVar('frame_align', $_POST['align']);
	227	+ $frame->setVar('frame_frameborder', $_POST['frameborder']);
	228	+ $frame->setVar('frame_marginwidth', $_POST['marginwidth']);
	229	+ $frame->setVar('frame_marginheight', $_POST['marginheight']);
	230	+ $frame->setVar('frame_scrolling', $_POST['scrolling']);
	231	+ $frame->setVar('frame_url', $_POST['url']);
	232	+ $frame->setVar('frame_created', time());
	233	+ $frame->setVar('frame_uid', $xoopsUser->getVar('uid'));
	234	+ $res = $iframeHandler->insert($frame);
	235	+ if (!$res) {
	236	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ERROR_ADD_INDEX);
	237	+ }
	238	+ redirect_header('manage.php', 1, _AM_MYIFRAME_ADDED_OK);
	239	+ }
	240	+ break;
241	241
242		- case 'addframe':
243		- xoops_cp_header();
244		- $adminObject = \Xmf\Module\Admin::getInstance();
245		- $adminObject->displayNavigation(basename(__FILE__));
246		- addEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
247		- break;
	242	+ case 'addframe':
	243	+ xoops_cp_header();
	244	+ $adminObject = \Xmf\Module\Admin::getInstance();
	245	+ $adminObject->displayNavigation(basename(__FILE__));
	246	+ addEditForm(0, 'verifytoadd', _AM_MYIFRAME_CONFIG, '', '100%', '', '', '0', '0', '0', 1, '', _AM_MYIFRAME_ADDBUTTON);
	247	+ break;
248	248
249		- case 'default':
250		- default:
251		- xoops_cp_header();
252		- $adminObject = \Xmf\Module\Admin::getInstance();
253		- $adminObject->displayNavigation(basename(__FILE__));
254		- echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
255		- echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
256		- echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>" . _AM_MYIFRAME_ACTION . "</th></tr>\n";
257		- $critere = new Criteria('1', '1', '=');
258		- $critere->setSort('frame_description');
259		- $frarray = $iframeHandler->getObjects($critere);
260		- $class = 'even';
261		- $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
262		- if (count($frarray) > 0) {
263		- /** @var Myiframe $frame */
264		- foreach ($frarray as $frame) {
265		- $action_edit = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
266		- $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
267		- if (xoops_trim($frame->getVar('frame_description')) === '') {
268		- $liendesc = $frame->getVar('frame_url');
269		- } else {
270		- $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
271		- }
272		- echo "<tr class='"
273		- . $class
274		- . "'><td align='center'>"
275		- . $frame->getVar('frame_frameid')
276		- . "</td><td align='center'>"
277		- . $liendesc
278		- . "</td><td align='center'>"
279		- . formatTimestamp($frame->getVar('frame_created'))
280		- . "</td><td align='center'>"
281		- . $frame->getVar('frame_hits')
282		- . "</td><td align='center'>"
283		- . $action_edit
284		- . ' - '
285		- . $action_delete
286		- . "</td></tr>\n";
287		- $class = ($class === 'even') ? 'odd' : 'even';
288		- }
289		- }
290		- echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD . "'></td></tr>";
291		- echo '</table>';
292		- include_once __DIR__ . '/admin_footer.php';
293		- break;
	249	+ case 'default':
	250	+ default:
	251	+ xoops_cp_header();
	252	+ $adminObject = \Xmf\Module\Admin::getInstance();
	253	+ $adminObject->displayNavigation(basename(__FILE__));
	254	+ echo '<h4>' . _AM_MYIFRAME_CONFIG . "</h4><br />\n";
	255	+ echo "<table width='100%' border='0' cellspacing='1' class='outer'>\n";
	256	+ echo "<tr><th align='center'>" . _AM_MYIFRAME_ID . "</th><th align='center'>" . _AM_MYIFRAME_DESC . "</th><th align='center'>" . _AM_MYIFRAME_CREATED . "</th><th align='center'>" . _AM_MYIFRAME_HITS . "</th><th align='center'>" . _AM_MYIFRAME_ACTION . "</th></tr>\n";
	257	+ $critere = new Criteria('1', '1', '=');
	258	+ $critere->setSort('frame_description');
	259	+ $frarray = $iframeHandler->getObjects($critere);
	260	+ $class = 'even';
	261	+ $baseurl = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/admin/manage.php';
	262	+ if (count($frarray) > 0) {
	263	+ /** @var Myiframe $frame */
	264	+ foreach ($frarray as $frame) {
	265	+ $action_edit = "<a href='" . $baseurl . '?op=edit&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/edit.png' alt='" . _AM_MYIFRAME_EDIT . "'></a>";
	266	+ $action_delete = "<a href='" . $baseurl . '?op=delete&frameid=' . $frame->getVar('frame_frameid') . "'><img src='../assets/images/delete.png' alt='" . _AM_MYIFRAME_DELETE . "'></a>";
	267	+ if (xoops_trim($frame->getVar('frame_description')) === '') {
	268	+ $liendesc = $frame->getVar('frame_url');
	269	+ } else {
	270	+ $liendesc = "<a href='" . XOOPS_URL . '/modules/myiframe/index.php?iframeid=' . $frame->getVar('frame_frameid') . "'>" . $frame->getVar('frame_description') . '</a>';
	271	+ }
	272	+ echo "<tr class='"
	273	+ . $class
	274	+ . "'><td align='center'>"
	275	+ . $frame->getVar('frame_frameid')
	276	+ . "</td><td align='center'>"
	277	+ . $liendesc
	278	+ . "</td><td align='center'>"
	279	+ . formatTimestamp($frame->getVar('frame_created'))
	280	+ . "</td><td align='center'>"
	281	+ . $frame->getVar('frame_hits')
	282	+ . "</td><td align='center'>"
	283	+ . $action_edit
	284	+ . ' - '
	285	+ . $action_delete
	286	+ . "</td></tr>\n";
	287	+ $class = ($class === 'even') ? 'odd' : 'even';
	288	+ }
	289	+ }
	290	+ echo "<tr class='" . $class . "'><td colspan='5' align='center'><form name='faddframe' method='post' action='manage.php'><input type='hidden' name='op' value='addframe'><input type='submit' name='submit' value='" . _AM_MYIFRAME_ADD . "'></td></tr>";
	291	+ echo '</table>';
	292	+ include_once __DIR__ . '/admin_footer.php';
	293	+ break;
294	294	}
295	295
296	296	xoops_cp_footer();

XoopsModules25x / myiframe

Push — master ( 8c936a...757841 )

Status

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Switch Indentation +180 added lines, -180 removed lines patch added patch discarded remove patch