XoopsModules\Myiframe\MyiframeBaseHandler

Complexity

Total Complexity

35

Size/Duplication

Total Lines	213
Duplicated Lines	0 %

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	delete()	0	16	4
A	create()	0	8	2
A	get()	0	16	3
B	insert()	0	70	10
A	getCount()	0	13	4
B	getObjects()	0	27	7
A	updatehits()	0	4	1
A	deleteAll()	0	11	4

<?php declare(strict_types=1);

namespace XoopsModules\Myiframe;

/**
 * ****************************************************************************
 * MYIFRAME - MODULE FOR XOOPS
 * Copyright (c) Hervé Thouzard of Instant Zero (https://www.instant-zero.com)
 * ****************************************************************************
 */
require_once XOOPS_ROOT_PATH . '/kernel/object.php';

/**
 * Class MyiframeBaseHandler
 */
class MyiframeBaseHandler extends \XoopsObjectHandler
{
    /**
     * @param bool $isNew
     * @return myiframe
     */
    public function create($isNew = true)
    {
        $object = new MyiframeBase();
        if ($isNew) {
            $object->setNew();
        }

        return $object;

The expression return $object returns the type XoopsModules\Myiframe\MyiframeBase which is incompatible with the documented return type XoopsModules\Myiframe\myiframe.

    }

    /**
     * @param int $id
     * @return myiframe|null
     */
    public function get($id)
    {
        $ret = null;
        $sql = 'SELECT * FROM ' . $this->db->prefix('myiframe') . '  WHERE frame_frameid=' . (int)$id;
        if (!$result = $this->db->query($sql)) {
            return $ret;
        }
        $numrows = $this->db->getRowsNum($result);
        if (1 == $numrows) {
            $object = new MyiframeBase();
            $object->assignVars($this->db->fetchArray($result));

            return $object;

The expression return $object returns the type XoopsModules\Myiframe\MyiframeBase which is incompatible with the documented return type XoopsModules\Myiframe\myiframe|null.

        }

        return $ret;
    }

    /**
     * @param bool $force
     * @return bool
     */
    public function insert(\XoopsObject $object, $force = false)
    {
        if (!$object instanceof MyiframeBase) {
            return false;
        }
        if (!$object->isDirty()) {
            return true;
        }
        if (!$object->cleanVars()) {
            foreach ($object->getErrors() as $oneerror) {
                \trigger_error($oneerror);
            }

            return false;
        }
        foreach ($object->cleanVars as $k => $v) {
            ${$k} = $v;
        }

        if ($object->isNew()) {
            $format = 'INSERT INTO %s (frame_created, frame_uid, frame_description, frame_width, frame_height, frame_align, frame_frameborder, frame_marginwidth, frame_marginheight, frame_scrolling, frame_hits, frame_url) VALUES (%u, %u, %s, %s, %s, %d, %d, %d, %d, %d, %u, %s)';
            $sql    = \sprintf(
                $format,
                $this->db->prefix('myiframe'),
                $frame_created,

The variable $frame_created seems to be never defined.

                $frame_uid,

The variable $frame_uid does not exist. Did you maybe mean $frame_frameid?

                $this->db->quoteString($frame_description),

The variable $frame_description seems to be never defined.

                $this->db->quoteString($frame_width),

The variable $frame_width seems to be never defined.

                $this->db->quoteString($frame_height),

The variable $frame_height seems to be never defined.

                $frame_align,

The variable $frame_align seems to be never defined.

                $frame_frameborder,

The variable $frame_frameborder does not exist. Did you maybe mean $frame_frameid?

                $frame_marginwidth,

The variable $frame_marginwidth seems to be never defined.

                $frame_marginheight,

The variable $frame_marginheight seems to be never defined.

                $frame_scrolling,

The variable $frame_scrolling seems to be never defined.

                $frame_hits,

The variable $frame_hits seems to be never defined.

                $this->db->quoteString($frame_url)

The variable $frame_url seems to be never defined.

            );
            $force  = true;
        } else {
            $format = 'UPDATE %s SET frame_description=%s, frame_width=%s, frame_height=%s, frame_align="%d", frame_frameborder="%d", frame_marginwidth="%d", frame_marginheight="%d", frame_scrolling="%d", frame_hits="%u", frame_url=%s WHERE frame_frameid=%u';
            $sql    = \sprintf(
                $format,
                $this->db->prefix('myiframe'),
                $this->db->quoteString($frame_description),
                $this->db->quoteString($frame_width),
                $this->db->quoteString($frame_height),
                $frame_align,
                $frame_frameborder,
                $frame_marginwidth,
                $frame_marginheight,
                $frame_scrolling,
                $frame_hits,
                $this->db->quoteString($frame_url),
                $frame_frameid

The variable $frame_frameid seems to be never defined.

            );
        }
        if (false !== $force) {
            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }
        if (empty($frame_frameid)) {

The variable $frame_frameid seems to never exist and therefore empty should always be true.

            $frame_frameid = $this->db->getInsertId();
        }
        $object->assignVar('frame_frameid', $frame_frameid);

        return $frame_frameid;
    }

    /**
     * @param bool $force
     * @return bool
     */
    public function delete(\XoopsObject $object, $force = false)
    {
        if (!$object instanceof \MyiframeBase) {

The type MyiframeBase was not found. Maybe you did not declare it correctly or list all dependencies?

            return false;
        }
        $sql = \sprintf('DELETE FROM %s WHERE frame_frameid = "%u"', $this->db->prefix('myiframe'), $object->getVar('frame_frameid'));

It seems like $object->getVar('frame_frameid') can also be of type array and array; however, parameter $values of sprintf() does only seem to accept double|integer|string, maybe add an additional type check?

        if (false !== $force) {
            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * @param \XoopsModules\Myiframe\Criteria $criteria

The type XoopsModules\Myiframe\Criteria was not found. Did you mean Criteria? If so, make sure to prefix the type with \.

     * @param bool                            $id_as_key
     * @return array
     */
    public function &getObjects(\Criteria $criteria = null, $id_as_key = false)
    {
        $ret   = [];
        $limit = $start = 0;
        $sql   = 'SELECT * FROM ' . $this->db->prefix('myiframe');
        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
            if ('' !== $criteria->getSort()) {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $result = $this->db->query($sql, $limit, $start);
        /** @var array $myrow */
        if ($result instanceof \mysqli_result) {

            while (false !== ($myrow = $this->db->fetchArray($result))) {
                if (!$id_as_key) {
                    $ret[] = new MyiframeBase($myrow);
                } else {
                    $ret[$myrow['frame_frameid']] = new MyiframeBase($myrow);
                }
            }
        }

        return $ret;
    }

    /**
     * @param \XoopsModules\Myiframe\CriteriaCompo $criteria

The type XoopsModules\Myiframe\CriteriaCompo was not found. Did you mean CriteriaCompo? If so, make sure to prefix the type with \.

     * @return int
     */
    public function getCount(\CriteriaCompo $criteria = null)
    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('myiframe');
        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        [$count] = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * @param \XoopsModules\Myiframe\CriteriaCompo $criteria
     * @return bool
     */
    public function deleteAll(\CriteriaCompo $criteria = null)
    {
        $sql = 'DELETE FROM ' . $this->db->prefix('myiframe');
        if (($criteria instanceof \CriteriaCompo) || ($criteria instanceof \Criteria)) {
            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {

The assignment to $result is dead and can be removed.

            return false;
        }

        return true;
    }

    /**
     * @param $frame_id
     */
    public function updatehits($frame_id): void
    {
        $sql = \sprintf('UPDATE %s SET frame_hits = frame_hits+1 WHERE frame_frameid="%u"', $this->db->prefix('myiframe'), (int)$frame_id);
        $this->db->queryF($sql);
    }
}