Issues in entries_spot.php (master) - Issues in master - XoopsModules25x/lexikon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (330)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

blocks/entries_spot.php (3 issues)

Labels

Severity

Minor 3

<?php

/**
 * Module: Lexikon
 * credits: hsalazar, Smartfactory, Eric Juden & ackbarr ->Project XHelp
 * Licence: GNU
 */
defined('XOOPS_ROOT_PATH') || exit('Restricted access');

/* This function spotlights a category, with a spotlight definition and links to others */
/**
 * @param $options
 * @return array
 */
function b_lxspot_show($options)
{
    global $xoopsDB, $xoopsUser;
    $myts = MyTextSanitizer:: getInstance();
    xoops_load('XoopsUserUtility');

    $module_name = 'lexikon';

    /** @var \XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $lexikon       = $moduleHandler->getByDirname('lexikon');
    if (!isset($lxConfig)) {

        /** @var \XoopsConfigHandler $configHandler */
        $configHandler = xoops_getHandler('config');
        $lxConfig      = $configHandler->getConfigsByCat(0, $lexikon->getVar('mid'));
    }

    /** @var \XoopsGroupPermHandler $grouppermHandler */
    $grouppermHandler = xoops_getHandler('groupperm');
    $groups           = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
    $module_id        = $lexikon->getVar('mid');

    $block = [];

    // To handle options in the template
    if (1 == $options[2]) {
        $block['showdateask'] = 1;
    } else {
        $block['showdateask'] = 0;
    }
    if (1 == $options[3]) {
        $block['showbylineask'] = 1;
    } else {
        $block['showbylineask'] = 0;
    }
    if (1 == $options[4]) {
        $block['showstatsask'] = 1;
    } else {
        $block['showstatsask'] = 0;
    }
    if ('ver' === $options[5]) {
        $block['verticaltemplate'] = 1;
    } else {
        $block['verticaltemplate'] = 0;
    }
    if (1 == $options[6]) {
        $block['showpicask'] = 1;
    } else {
        $block['showpicask'] = 0;
    }

    // Retrieve the latest terms in the selected category
    $resultA = $xoopsDB->query(
        'SELECT entryID, categoryID, term, definition, uid, datesub, counter, html, smiley, xcodes, breaks, comments
                                 FROM ' . $xoopsDB->prefix('lxentries') . '
                                 WHERE categoryID = ' . $options[0] . " AND submit = '0' AND offline = 0 AND block= 1
                                 ORDER BY datesub DESC", //ORDER BY " . $options[7] . " DESC ",
        1,
        0
    );

    [$entryID, $categoryID, $term, $definition, $authorID, $datesub, $counter, $html, $smiley, $xcodes, $breaks, $comments] = $xoopsDB->fetchRow($resultA);
    $eID = (int)$entryID;
    // If there's no result - which means there's no definition yet...
    if (0 == $eID) {
        $block['display'] = 0;
    } else {
        $block['display'] = 1;
    }

    // Retrieve the category name
    $resultB = $xoopsDB->query('SELECT name, logourl FROM ' . $xoopsDB->prefix('lxcategories') . ' WHERE categoryID = ' . $options[0] . ' ');
    [$name, $logourl] = $xoopsDB->fetchRow($resultB);
    $lexikon = $moduleHandler->getByDirname('lexikon');
    if ($lexikon) {
        if ($grouppermHandler->checkRight('lexikon_view', $options[0], $groups, $module_id)) {
            // get the items
            $block['userID']     = ((int)$authorID);
            $block['authorname'] = \XoopsUserUtility::getUnameFromId((int)$authorID);
            $block['name']       = xoops_substr($name, 0, (int)$options[9]);
            $block['catID']      = (int)$options[0];
            $block['catimage']   = stripslashes($logourl);
            $block['termID']     = (int)$entryID;
            $block['title']      = htmlspecialchars($term, ENT_QUOTES | ENT_HTML5);
            $block['introtext']  = xoops_substr($myts->displayTarea($definition, $html, 1, $xcodes, 1, $breaks), 0, (int)$options[8]);

            $block['moduledir'] = $lexikon->dirname();
            $block['date']      = formatTimestamp($datesub, 'd M Y');
            //$block['date'] = formatTimestamp( $datesub, $lxConfig['dateformat'] );
            $block['hits'] = (int)$counter;
            if ((0 != $lxConfig['com_rule']) || ((0 != $lxConfig['com_rule']) && is_object($xoopsUser))) {
                if (0 != $comments) {
                    $block['comments'] = "<a href='" . XOOPS_URL . '/modules/' . $lexikon->dirname() . '/entry.php?entryID=' . $block['termID'] . "'>" . _COMMENTS . '&nbsp;:&nbsp; ' . $comments . '</a>';
                } else {
                    $block['comments'] = "<a href='" . XOOPS_URL . '/modules/' . $lexikon->dirname() . '/entry.php?entryID=' . $block['termID'] . "'>" . _COMMENTS . '?</a>';
                }
            }

            // get the other terms
            $resultC = $xoopsDB->query('SELECT entryID, term, datesub FROM ' . $xoopsDB->prefix('lxentries') . ' WHERE categoryID = ' . $options[0] . ' AND entryID != ' . $block['termID'] . ' AND submit = 0 AND offline = 0 AND block= 1 ORDER BY ' . $options[7] . ' DESC ', $options[1], 0);

            $i = 0;
            while (false !== ($myrow = $xoopsDB->fetchArray($resultC))) {
                if ($i < $options[1]) {
                    $morelinks         = [];
                    $morelinks['id']   = $myrow['entryID'];
                    $morelinks['head'] = xoops_substr(htmlspecialchars($myrow['term'], ENT_QUOTES | ENT_HTML5), 0, (int)$options[9]);

                    $morelinks['subdate'] = formatTimestamp($datesub, 'd M Y');
                    ++$i;
                    $block['links'][] = $morelinks;
                }
            }
        } else { // if permissions are not granted
            $block['display'] = 0;
        }
    }
    //------------
    return $block;
}

/**
 * @param $options
 * @return string
 */
function b_lxspot_edit($options)
{
    global $xoopsDB;
    $myts      = MyTextSanitizer:: getInstance();

    $resultcat = $xoopsDB->query('SELECT categoryID, name FROM ' . $xoopsDB->prefix('lxcategories') . ' ORDER BY categoryID');
    $form      = "<table border='0'>";
    $form      .= '<tr><td>' . _MB_LEXIKON_SELECTCAT . '</td><td><select name="options[]">';
    while (list($categoryID, $name) = $xoopsDB->fetchRow($resultcat)) {
        $form .= '<option value=' . $categoryID . ' ' . (($options[0] == $categoryID) ? ' selected' : '') . ">$categoryID : $name</option>\n";
    }
    $form .= "</select><br></td></tr>\n";

    $form .= '<tr><td>' . _MB_LEXIKON_TERMSTOSHOW . "</td><td><input type='text' name='options[]' value='" . $options[1] . "' >&nbsp; " . _MB_LEXIKON_TERMS . '.<br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_SHOWDATE . '</td><td>';
    $form .= "<input type='radio' name='options[2]' value='1'" . ((1 == $options[2]) ? ' checked' : '') . ' >' . _YES . '&nbsp;';
    $form .= "<input type='radio' name='options[2]' value='0'" . ((0 == $options[2]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_SHOWBYLINE . '</td><td>';
    $form .= "<input type='radio' name='options[3]' value='1'" . ((1 == $options[3]) ? ' checked' : '') . ' >' . _YES . '&nbsp;';
    $form .= "<input type='radio' name='options[3]' value='0'" . ((0 == $options[3]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_SHOWSTATS . '</td><td>';
    $form .= "<input type='radio' name='options[4]' value='1'" . ((1 == $options[4]) ? ' checked' : '') . ' >' . _YES . '&nbsp;';
    $form .= "<input type='radio' name='options[4]' value='0'" . ((0 == $options[4]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_TEMPLATE . "</td><td><select name='options[]'>";
    $form .= "<option value='ver' " . (('ver' === $options[5]) ? ' selected' : '') . '>' . _MB_LEXIKON_VERTICAL . "</option>\n";
    $form .= "<option value='hor' " . (('hor' === $options[5]) ? ' selected' : '') . '>' . _MB_LEXIKON_HORIZONTAL . "</option>\n";
    $form .= '</select><br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_SHOWPIC . '</td><td>';
    $form .= "<input type='radio' name='options[6]' value='1'" . ((1 == $options[6]) ? ' checked' : '') . ' >' . _YES . '&nbsp;';
    $form .= "<input type='radio' name='options[6]' value='0'" . ((0 == $options[6]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';

    $form .= '<tr><td>' . _MB_LEXIKON_ORDER . "</td><td>&nbsp;<select name='options[7]'>";
    $form .= "<option value='datesub' " . (('datesub' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_DATE . "</option>\n";
    $form .= "<option value='counter' " . (('counter' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_HITS . "</option>\n";
    $form .= "<option value='term' " . (('term' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_NAME . "</option>\n";
    $form .= "</select>\n";

    $form .= "&nbsp;<tr><td style='vertical-align: top;'>" . _MB_LEXIKON_CHARS . "</td><td>&nbsp;<input type='text' name='options[8]' value='" . htmlspecialchars($options[8], ENT_QUOTES | ENT_HTML5) . "' >&nbsp;" . _MB_LEXIKON_LENGTH . '';
    $form .= "&nbsp;<tr><td style='vertical-align: top;'>" . _MB_LEXIKON_CHARSTERM . "</td><td>&nbsp;<input type='text' name='options[9]' value='" . htmlspecialchars($options[9], ENT_QUOTES | ENT_HTML5) . "' >&nbsp;" . _MB_LEXIKON_LENGTH . '';

    $form .= '</td></tr>';
    $form .= '</table>';

    //------------
    return $form;
}


1			<?php
2
3			/**
4			* Module: Lexikon
5			* credits: hsalazar, Smartfactory, Eric Juden & ackbarr ->Project XHelp
6			* Licence: GNU
7			*/
8			defined('XOOPS_ROOT_PATH') \|\| exit('Restricted access');
9
10			/* This function spotlights a category, with a spotlight definition and links to others */
11			/**
12			* @param $options
13			* @return array
14			*/
15			function b_lxspot_show($options)
16			{
17			global $xoopsDB, $xoopsUser;
18			$myts = MyTextSanitizer:: getInstance();
19			xoops_load('XoopsUserUtility');
20
21			$module_name = 'lexikon';
			0 ignored issues – show Unused Code introduced 2021-07-15 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$module_name` is dead and can be removed. Loading history...
22			/** @var \XoopsModuleHandler $moduleHandler */
23			$moduleHandler = xoops_getHandler('module');
24			$lexikon = $moduleHandler->getByDirname('lexikon');
25			if (!isset($lxConfig)) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-07-15 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$lxConfig` seems to never exist and therefore `isset` should always be `false`. Loading history...
26			/** @var \XoopsConfigHandler $configHandler */
27			$configHandler = xoops_getHandler('config');
28			$lxConfig = $configHandler->getConfigsByCat(0, $lexikon->getVar('mid'));
29			}
30
31			/** @var \XoopsGroupPermHandler $grouppermHandler */
32			$grouppermHandler = xoops_getHandler('groupperm');
33			$groups = is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
34			$module_id = $lexikon->getVar('mid');
35
36			$block = [];
37
38			// To handle options in the template
39			if (1 == $options[2]) {
40			$block['showdateask'] = 1;
41			} else {
42			$block['showdateask'] = 0;
43			}
44			if (1 == $options[3]) {
45			$block['showbylineask'] = 1;
46			} else {
47			$block['showbylineask'] = 0;
48			}
49			if (1 == $options[4]) {
50			$block['showstatsask'] = 1;
51			} else {
52			$block['showstatsask'] = 0;
53			}
54			if ('ver' === $options[5]) {
55			$block['verticaltemplate'] = 1;
56			} else {
57			$block['verticaltemplate'] = 0;
58			}
59			if (1 == $options[6]) {
60			$block['showpicask'] = 1;
61			} else {
62			$block['showpicask'] = 0;
63			}
64
65			// Retrieve the latest terms in the selected category
66			$resultA = $xoopsDB->query(
67			'SELECT entryID, categoryID, term, definition, uid, datesub, counter, html, smiley, xcodes, breaks, comments
68			FROM ' . $xoopsDB->prefix('lxentries') . '
69			WHERE categoryID = ' . $options[0] . " AND submit = '0' AND offline = 0 AND block= 1
70			ORDER BY datesub DESC", //ORDER BY " . $options[7] . " DESC ",
71			1,
72			0
73			);
74
75			[$entryID, $categoryID, $term, $definition, $authorID, $datesub, $counter, $html, $smiley, $xcodes, $breaks, $comments] = $xoopsDB->fetchRow($resultA);
76			$eID = (int)$entryID;
77			// If there's no result - which means there's no definition yet...
78			if (0 == $eID) {
79			$block['display'] = 0;
80			} else {
81			$block['display'] = 1;
82			}
83
84			// Retrieve the category name
85			$resultB = $xoopsDB->query('SELECT name, logourl FROM ' . $xoopsDB->prefix('lxcategories') . ' WHERE categoryID = ' . $options[0] . ' ');
86			[$name, $logourl] = $xoopsDB->fetchRow($resultB);
87			$lexikon = $moduleHandler->getByDirname('lexikon');
88			if ($lexikon) {
89			if ($grouppermHandler->checkRight('lexikon_view', $options[0], $groups, $module_id)) {
90			// get the items
91			$block['userID'] = ((int)$authorID);
92			$block['authorname'] = \XoopsUserUtility::getUnameFromId((int)$authorID);
93			$block['name'] = xoops_substr($name, 0, (int)$options[9]);
94			$block['catID'] = (int)$options[0];
95			$block['catimage'] = stripslashes($logourl);
96			$block['termID'] = (int)$entryID;
97			$block['title'] = htmlspecialchars($term, ENT_QUOTES \| ENT_HTML5);
98			$block['introtext'] = xoops_substr($myts->displayTarea($definition, $html, 1, $xcodes, 1, $breaks), 0, (int)$options[8]);
99
100			$block['moduledir'] = $lexikon->dirname();
101			$block['date'] = formatTimestamp($datesub, 'd M Y');
102			//$block['date'] = formatTimestamp( $datesub, $lxConfig['dateformat'] );
103			$block['hits'] = (int)$counter;
104			if ((0 != $lxConfig['com_rule']) \|\| ((0 != $lxConfig['com_rule']) && is_object($xoopsUser))) {
105			if (0 != $comments) {
106			$block['comments'] = "<a href='" . XOOPS_URL . '/modules/' . $lexikon->dirname() . '/entry.php?entryID=' . $block['termID'] . "'>" . _COMMENTS . ' :  ' . $comments . '</a>';
107			} else {
108			$block['comments'] = "<a href='" . XOOPS_URL . '/modules/' . $lexikon->dirname() . '/entry.php?entryID=' . $block['termID'] . "'>" . _COMMENTS . '?</a>';
109			}
110			}
111
112			// get the other terms
113			$resultC = $xoopsDB->query('SELECT entryID, term, datesub FROM ' . $xoopsDB->prefix('lxentries') . ' WHERE categoryID = ' . $options[0] . ' AND entryID != ' . $block['termID'] . ' AND submit = 0 AND offline = 0 AND block= 1 ORDER BY ' . $options[7] . ' DESC ', $options[1], 0);
114
115			$i = 0;
116			while (false !== ($myrow = $xoopsDB->fetchArray($resultC))) {
117			if ($i < $options[1]) {
118			$morelinks = [];
119			$morelinks['id'] = $myrow['entryID'];
120			$morelinks['head'] = xoops_substr(htmlspecialchars($myrow['term'], ENT_QUOTES \| ENT_HTML5), 0, (int)$options[9]);
121
122			$morelinks['subdate'] = formatTimestamp($datesub, 'd M Y');
123			++$i;
124			$block['links'][] = $morelinks;
125			}
126			}
127			} else { // if permissions are not granted
128			$block['display'] = 0;
129			}
130			}
131			//------------
132			return $block;
133			}
134
135			/**
136			* @param $options
137			* @return string
138			*/
139			function b_lxspot_edit($options)
140			{
141			global $xoopsDB;
142			$myts = MyTextSanitizer:: getInstance();
			0 ignored issues – show Unused Code introduced 2021-07-15 17:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$myts` is dead and can be removed. Loading history...
143			$resultcat = $xoopsDB->query('SELECT categoryID, name FROM ' . $xoopsDB->prefix('lxcategories') . ' ORDER BY categoryID');
144			$form = "<table border='0'>";
145			$form .= '<tr><td>' . _MB_LEXIKON_SELECTCAT . '</td><td><select name="options[]">';
146			while (list($categoryID, $name) = $xoopsDB->fetchRow($resultcat)) {
147			$form .= '<option value=' . $categoryID . ' ' . (($options[0] == $categoryID) ? ' selected' : '') . ">$categoryID : $name</option>\n";
148			}
149			$form .= "</select><br></td></tr>\n";
150
151			$form .= '<tr><td>' . _MB_LEXIKON_TERMSTOSHOW . "</td><td><input type='text' name='options[]' value='" . $options[1] . "' >  " . _MB_LEXIKON_TERMS . '.<br></td></tr>';
152
153			$form .= '<tr><td>' . _MB_LEXIKON_SHOWDATE . '</td><td>';
154			$form .= "<input type='radio' name='options[2]' value='1'" . ((1 == $options[2]) ? ' checked' : '') . ' >' . _YES . ' ';
155			$form .= "<input type='radio' name='options[2]' value='0'" . ((0 == $options[2]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';
156
157			$form .= '<tr><td>' . _MB_LEXIKON_SHOWBYLINE . '</td><td>';
158			$form .= "<input type='radio' name='options[3]' value='1'" . ((1 == $options[3]) ? ' checked' : '') . ' >' . _YES . ' ';
159			$form .= "<input type='radio' name='options[3]' value='0'" . ((0 == $options[3]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';
160
161			$form .= '<tr><td>' . _MB_LEXIKON_SHOWSTATS . '</td><td>';
162			$form .= "<input type='radio' name='options[4]' value='1'" . ((1 == $options[4]) ? ' checked' : '') . ' >' . _YES . ' ';
163			$form .= "<input type='radio' name='options[4]' value='0'" . ((0 == $options[4]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';
164
165			$form .= '<tr><td>' . _MB_LEXIKON_TEMPLATE . "</td><td><select name='options[]'>";
166			$form .= "<option value='ver' " . (('ver' === $options[5]) ? ' selected' : '') . '>' . _MB_LEXIKON_VERTICAL . "</option>\n";
167			$form .= "<option value='hor' " . (('hor' === $options[5]) ? ' selected' : '') . '>' . _MB_LEXIKON_HORIZONTAL . "</option>\n";
168			$form .= '</select><br></td></tr>';
169
170			$form .= '<tr><td>' . _MB_LEXIKON_SHOWPIC . '</td><td>';
171			$form .= "<input type='radio' name='options[6]' value='1'" . ((1 == $options[6]) ? ' checked' : '') . ' >' . _YES . ' ';
172			$form .= "<input type='radio' name='options[6]' value='0'" . ((0 == $options[6]) ? ' checked' : '') . ' >' . _NO . '<br></td></tr>';
173
174			$form .= '<tr><td>' . _MB_LEXIKON_ORDER . "</td><td> <select name='options[7]'>";
175			$form .= "<option value='datesub' " . (('datesub' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_DATE . "</option>\n";
176			$form .= "<option value='counter' " . (('counter' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_HITS . "</option>\n";
177			$form .= "<option value='term' " . (('term' === $options[7]) ? ' selected' : '') . '>' . _MB_LEXIKON_NAME . "</option>\n";
178			$form .= "</select>\n";
179
180			$form .= " <tr><td style='vertical-align: top;'>" . _MB_LEXIKON_CHARS . "</td><td> <input type='text' name='options[8]' value='" . htmlspecialchars($options[8], ENT_QUOTES \| ENT_HTML5) . "' > " . _MB_LEXIKON_LENGTH . '';
181			$form .= " <tr><td style='vertical-align: top;'>" . _MB_LEXIKON_CHARSTERM . "</td><td> <input type='text' name='options[9]' value='" . htmlspecialchars($options[9], ENT_QUOTES \| ENT_HTML5) . "' > " . _MB_LEXIKON_LENGTH . '';
182
183			$form .= '</td></tr>';
184			$form .= '</table>';
185
186			//------------
187			return $form;
188			}
189

XoopsModules25x / lexikon

Issues (330)

Security Analysis not enabled

blocks/entries_spot.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like