Issues in content.php - All Issues - Inspection of "Merge pull request #4 from ggoffy/master" - XoopsModules25x/lexikon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cf7347...38da6e )

by Michael

created 2016-11-07 03:39 UTC

content.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * $Id: content.php v 1.0 18 Dec 2011 Yerres Exp $
 * Module: Lexikon
 * Version: v 1.00
 * Release Date: 18 Dec 2011
 * Author: Yerres
 * Licence: GNU
 */

include( "header.php" );
$xoopsOption['template_main'] = 'lx_content.html';
include XOOPS_ROOT_PATH."/header.php";
global $xoTheme, $xoopsUser, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
$myts = MyTextSanitizer::getInstance();
if ( !is_object( $xoopsUser ) && $xoopsModuleConfig['contentsyndication'] == 0 ) {
    redirect_header(XOOPS_URL."/user.php?xoops_redirect=".parse_url($_SERVER['PHP_SELF']), 5, _NOPERM);
    exit();
}

include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";

include "include/syndication.inc.php";
$yform->assign($xoopsTpl);

// Various strings
$xoopsTpl -> assign ( 'introcontentsyn', sprintf(_MD_LEXIKON_INTROCONTENTSYN,  $xoopsConfig['sitename']) );
$xoopsTpl -> assign ( 'modulename', $xoopsModule->dirname());
$xoopsTpl -> assign ( 'lang_modulename', $xoopsModule->name() );
$xoopsTpl -> assign ( 'lang_moduledirname', $xoopsModule->getVar('dirname') );

$xoopsTpl->assign('xoops_pagetitle', _MD_LEXIKON_SYNDICATION . ' - ' . $myts->htmlSpecialChars($xoopsModule->name()));
$xoopsTpl->assign("xoops_module_header", '<link rel="stylesheet" type="text/css" href="style.css" />');

// Meta data
$meta_description = _MD_LEXIKON_SYNDICATION . ' - '.$myts->htmlSpecialChars($xoopsModule->name());
if (isset($xoTheme) && is_object($xoTheme)) {
    $xoTheme->addMeta( 'meta', 'description', $meta_description);
} else {
    $xoopsTpl->assign('xoops_meta_description', $meta_description);
}

include XOOPS_ROOT_PATH."/footer.php";


Push — master ( cf7347...38da6e )

content.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* $Id: content.php v 1.0 18 Dec 2011 Yerres Exp $
4			* Module: Lexikon
5			* Version: v 1.00
6			* Release Date: 18 Dec 2011
7			* Author: Yerres
8			* Licence: GNU
9			*/
10
11			include( "header.php" );
12			$xoopsOption['template_main'] = 'lx_content.html';
13			include XOOPS_ROOT_PATH."/header.php";
14			global $xoTheme, $xoopsUser, $xoopsModuleConfig;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-18 10:48 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
15			$myts = MyTextSanitizer::getInstance();
16			if ( !is_object( $xoopsUser ) && $xoopsModuleConfig['contentsyndication'] == 0 ) {
17			redirect_header(XOOPS_URL."/user.php?xoops_redirect=".parse_url($_SERVER['PHP_SELF']), 5, _NOPERM);
18			exit();
19			}
20
21			include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
22
23			include "include/syndication.inc.php";
24			$yform->assign($xoopsTpl);
25
26			// Various strings
27			$xoopsTpl -> assign ( 'introcontentsyn', sprintf(_MD_LEXIKON_INTROCONTENTSYN, $xoopsConfig['sitename']) );
28			$xoopsTpl -> assign ( 'modulename', $xoopsModule->dirname());
29			$xoopsTpl -> assign ( 'lang_modulename', $xoopsModule->name() );
30			$xoopsTpl -> assign ( 'lang_moduledirname', $xoopsModule->getVar('dirname') );
31
32			$xoopsTpl->assign('xoops_pagetitle', _MD_LEXIKON_SYNDICATION . ' - ' . $myts->htmlSpecialChars($xoopsModule->name()));
33			$xoopsTpl->assign("xoops_module_header", '<link rel="stylesheet" type="text/css" href="style.css" />');
34
35			// Meta data
36			$meta_description = _MD_LEXIKON_SYNDICATION . ' - '.$myts->htmlSpecialChars($xoopsModule->name());
37			if (isset($xoTheme) && is_object($xoTheme)) {
38			$xoTheme->addMeta( 'meta', 'description', $meta_description);
39			} else {
40			$xoopsTpl->assign('xoops_meta_description', $meta_description);
41			}
42
43			include XOOPS_ROOT_PATH."/footer.php";
44

XoopsModules25x / lexikon

Push — master ( cf7347...38da6e )

content.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like