XoopsModules\Lexikon\Utility::getAlphaArray()

Complexity

Conditions	3
Paths	8

Size

Total Lines	60
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	unichr()	0	3	1

<?php

namespace XoopsModules\Lexikon;

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    XOOPS Project (https://xoops.org)
 * @license      GNU GPL 2 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author      XOOPS Development Team, hsalazar
 */

use Xmf\Module\Admin;
use Xmf\Request;

/** @var Helper $helper */
use XoopsModules\Lexikon\Common;

/**
 * Class Utility
 */
class Utility extends Common\SysUtility
{
    //--------------- Custom module methods -----------------------------
    /**
     * static::getLinkedUnameFromId()
     *
     * @param int $userid Userid of author etc
     * @param int $name   :  0 Use Usenamer 1 Use realname
     * @return string
     */
    public static function getLinkedUnameFromId($userid = 0, $name = 0)
    {
        if (!\is_numeric($userid)) {

The condition is_numeric($userid) is always true.

            return $userid;
        }

        $userid = (int)$userid;
        if ($userid > 0) {
            /** @var \XoopsMemberHandler $memberHandler */
            $memberHandler = \xoops_getHandler('member');
            $user          = $memberHandler->getUser($userid);

            if (\is_object($user)) {
                $ts        = \MyTextSanitizer::getInstance();
                $username  = $user->getVar('uname');
                $usernameu = $user->getVar('name');

                if ($name && !empty($usernameu)) {
                    $username = $user->getVar('name');
                }
                if (!empty($usernameu)) {
                    $linkeduser = "$usernameu [<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $userid . "'>" . $ts->htmlSpecialChars($username) . '</a>]';

It seems like $username can also be of type array and array; however, parameter $text of MyTextSanitizer::htmlSpecialChars() does only seem to accept string, maybe add an additional type check?

                } else {
                    $linkeduser = "<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $userid . "'>" . \ucfirst($ts->htmlSpecialChars($username)) . '</a>';
                }

                return $linkeduser;
            }
        }

        return $GLOBALS['xoopsConfig']['anonymous'];
    }

    /**
     * @param $user
     */
    public static function getUserForm($user)
    {
        global $xoopsDB, $xoopsConfig;

        echo "<select name='author'>";
        echo "<option value='-1'>------</option>";
        $result = $xoopsDB->query('SELECT uid, uname FROM ' . $xoopsDB->prefix('users') . ' ORDER BY uname');

        while (list($uid, $uname) = $xoopsDB->fetchRow($result)) {
            if ($uid == $user) {
                $opt_selected = 'selected';
            } else {
                $opt_selected = '';
            }
            echo "<option value='" . $uid . "' $opt_selected>" . $uname . '</option>';
        }
        echo '</select></div>';
    }

    /**
     *
     */
    public static function calculateTotals()
    {
        global $xoopsUser, $xoopsDB, $xoopsModule;
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        $grouppermHandler = \xoops_getHandler('groupperm');

        $result01 = $xoopsDB->query('SELECT categoryID, total FROM ' . $xoopsDB->prefix('lxcategories') . ' ');
        [$totalcategories] = $xoopsDB->getRowsNum($result01);

This list assign is not used and could be removed.

        while (list($categoryID, $total) = $xoopsDB->fetchRow($result01)) {
            if ($grouppermHandler->checkRight('lexikon_view', $categoryID, $groups, $xoopsModule->getVar('mid'))) {

The method checkRight() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsGroupPermHandler or XoopsPersistableObjectHandler.

                $newcount = self::countByCategory($categoryID);
                $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('lxcategories') . " SET total = '$newcount' WHERE categoryID = '$categoryID'");
            }
        }
    }

    /**
     * @param $c
     * @return int
     */
    public static function countByCategory($c)
    {
        global $xoopsUser, $xoopsDB, $xoopsModule;
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;

The assignment to $groups is dead and can be removed.

        $grouppermHandler = \xoops_getHandler('groupperm');

The assignment to $grouppermHandler is dead and can be removed.

        $count            = 0;
        $sql              = $xoopsDB->query('SELECT entryID FROM ' . $xoopsDB->prefix('lxentries') . " WHERE offline = '0' AND categoryID = '$c'");
        while (false !== ($myrow = $xoopsDB->fetchArray($sql))) {

The assignment to $myrow is dead and can be removed.

            ++$count;
        }

        return $count;
    }

    /**
     * @return int
     */
    public static function countCats()
    {
        global $xoopsUser, $xoopsModule;
        $grouppermHandler = \xoops_getHandler('groupperm');
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        $totalcats        = $grouppermHandler->getItemIds('lexikon_view', $groups, $xoopsModule->getVar('mid'));

The method getItemIds() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsGroupPermHandler or XoopsPersistableObjectHandler.

        return \count($totalcats);
    }

    /**
     * @return mixed
     */
    public static function countWords()
    {
        global $xoopsUser, $xoopsDB;
        $grouppermHandler = \xoops_getHandler('groupperm');
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = \xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname('lexikon');
        $module_id     = $module->getVar('mid');
        $allowed_cats  = $grouppermHandler->getItemIds('lexikon_view', $groups, $module_id);
        $catids        = \implode(',', $allowed_cats);
        $catperms      = " AND categoryID IN ($catids) ";

        $pubwords       = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('lxentries') . " WHERE submit = '0' AND offline ='0' AND request = '0' " . $catperms . ' ');
        $publishedwords = $xoopsDB->getRowsNum($pubwords);

        return $publishedwords;
    }

    // To display the list of categories

    /**
     * @return array
     */
    public static function getCategoryArray()
    {
        global $xoopsDB, $xoopsUser, $xoopsModule;

        $helper           = Helper::getInstance();

The assignment to $helper is dead and can be removed.

        $myts             = \MyTextSanitizer::getInstance();

The assignment to $myts is dead and can be removed.

        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        $grouppermHandler = \xoops_getHandler('groupperm');
        $block0           = [];
        $count            = 1;
        $resultcat        = $xoopsDB->query('SELECT categoryID, name, total, logourl FROM ' . $xoopsDB->prefix('lxcategories') . ' ORDER BY weight ASC');
        while (list($catID, $name, $total, $logourl) = $xoopsDB->fetchRow($resultcat)) {
            if ($grouppermHandler->checkRight('lexikon_view', $catID, $groups, $xoopsModule->getVar('mid'))) {
                $catlinks = [];
                ++$count;
                if ($logourl && 'http://' !== $logourl) {
                    $logourl = \htmlspecialchars($logourl, \ENT_QUOTES | \ENT_HTML5);
                } else {
                    $logourl = '';
                }
                $xoopsModule          = \XoopsModule::getByDirname('lexikon');
                $catlinks['id']       = (int)$catID;
                $catlinks['total']    = (int)$total;
                $catlinks['linktext'] = \htmlspecialchars($name, \ENT_QUOTES | \ENT_HTML5);
                $catlinks['image']    = $logourl;
                $catlinks['count']    = $count;

                $block0['categories'][] = $catlinks;
            }
        }

        return $block0;
    }

    /**
     * @return array
     */
    public static function getAlphaArray()
    {
        global $xoopsUser, $xoopsDB, $xoopsModule;
        $grouppermHandler = \xoops_getHandler('groupperm');
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = \xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname('lexikon');
        $module_id     = $module->getVar('mid');
        $allowed_cats  = $grouppermHandler->getItemIds('lexikon_view', $groups, $module_id);
        $catids        = \implode(',', $allowed_cats);
        $catperms      = " AND categoryID IN ($catids) ";
        $alpha         = [];
        /**
         * @param $a
         * @return null|string|string[]
         */
        function unichr($a)
        {
            return mb_convert_encoding(\pack('N', $a), mb_internal_encoding(), 'UCS-4BE');

It seems like mb_internal_encoding() can also be of type true; however, parameter $to_encoding of mb_convert_encoding() does only seem to accept string, maybe add an additional type check?

        }

        for ($a = 48; $a < (48 + 10); ++$a) {
            $letterlinks             = [];
            $initial                 = unichr($a);
            $sql                     = $xoopsDB->query('SELECT entryID FROM ' . $xoopsDB->prefix('lxentries') . " WHERE init = '$initial' AND submit = '0' AND offline ='0' AND request = '0' " . $catperms . '');
            $howmany                 = $xoopsDB->getRowsNum($sql);
            $letterlinks['total']    = $howmany;
            $letterlinks['id']       = unichr($a);
            $letterlinks['linktext'] = unichr($a);

            $alpha['initial'][] = $letterlinks;
        }
        for ($a = 65; $a < (65 + 26); ++$a) {
            $letterlinks             = [];
            $initial                 = unichr($a);
            $sql                     = $xoopsDB->query('SELECT entryID FROM ' . $xoopsDB->prefix('lxentries') . " WHERE init = '$initial' AND submit = '0' AND offline ='0' AND request = '0' " . $catperms . '');
            $howmany                 = $xoopsDB->getRowsNum($sql);
            $letterlinks['total']    = $howmany;
            $letterlinks['id']       = unichr($a);
            $letterlinks['linktext'] = unichr($a);

            $alpha['initial'][] = $letterlinks;
        }
        /*for ($a = 1040; $a < (1040 + 32); ++$a) {
            $letterlinks             = [];
            $initial                 = unichr($a);
            $sql                     = $xoopsDB->query('SELECT entryID FROM '
                                                           . $xoopsDB->prefix('lxentries')
                                                           . " WHERE init = '$initial' AND submit = '0' AND offline ='0' AND request = '0' "
                                                           . $catperms
                                                           . '');
            $howmany                 = $xoopsDB->getRowsNum($sql);
            $letterlinks['total']    = $howmany;
            $letterlinks['id']       = unichr($a);
            $letterlinks['linktext'] = unichr($a);
            $alpha['initial'][] = $letterlinks;
        }*/

        return $alpha;
    }

    /**
     * chr() with unicode support
     * I found this on this site http://en.php.net/chr
     * don't take credit for this.
     * @param $initials
     * @return string
     */
    public static function getUchr($initials)
    {
        if (\is_scalar($initials)) {
            $initials = \func_get_args();
        }
        $str = '';
        foreach ($initials as $init) {
            $str .= \html_entity_decode('&#' . $init . ';', \ENT_NOQUOTES, 'UTF-8');
        }

        return $str;
    }

    /* sample */
    /*
        echo static::getUchr(23383); echo '<br>';
        echo static::getUchr(23383,215,23383); echo '<br>';
        echo static::getUchr(array(23383,215,23383,215,23383)); echo '<br>';
    */

    // Functional links

    /**
     * @param $variable
     * @return string
     */
    public static function getServiceLinks($variable)
    {
        global $xoopsUser, $xoopsDB, $xoopsModule, $xoopsConfig, $entrytype;

        $helper = Helper::getInstance();

        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = \xoops_getHandler('module');
        $moduleInfo    = $moduleHandler->get($xoopsModule->getVar('mid'));

The assignment to $moduleInfo is dead and can be removed.

        $pathIcon16    = Admin::iconUrl('', 16);

        $srvlinks = '';
        if ($xoopsUser) {
            if ($xoopsUser->isAdmin()) {
                $srvlinks .= '<a TITLE="'
                             . _EDIT
                             . '" href="admin/entry.php?op=mod&entryID='
                             . $variable['id']
                             . '" target="_blank"><img src="'
                             . $pathIcon16
                             . '/edit.png"   alt="'
                             . _MD_LEXIKON_EDITTERM
                             . '" style="width:16px; height:16px;"></a>&nbsp;<a TITLE="'
                             . _DELETE
                             . '" href="admin/entry.php?op=del&entryID='
                             . $variable['id']
                             . '" target="_self"><img src="'
                             . $pathIcon16
                             . '/delete.png" alt="'
                             . _MD_LEXIKON_DELTERM
                             . '" style="width:16px; height:16px;"></a>&nbsp;';
            }
        }
        if ('1' != $entrytype) {
            $srvlinks .= '<a TITLE="'
                         . _MD_LEXIKON_PRINTTERM
                         . '" href="print.php?entryID='
                         . $variable['id']
                         . '" target="_blank"><img src="'
                         . $pathIcon16
                         . '/printer.png"  alt="'
                         . _MD_LEXIKON_PRINTTERM
                         . '" style="width:16px; height:16px;"></a>&nbsp;<a TITLE="'
                         . _MD_LEXIKON_SENDTOFRIEND
                         . '" href="mailto:?subject='
                         . \sprintf(_MD_LEXIKON_INTENTRY, $xoopsConfig['sitename'])
                         . '&amp;body='
                         . \sprintf(_MD_LEXIKON_INTENTRYFOUND, $xoopsConfig['sitename'])
                         . ': '
                         . XOOPS_URL
                         . '/modules/'
                         . $xoopsModule->dirname()
                         . '/entry.php?entryID='
                         . $variable['id']
                         . ' " target="_blank"><img src="'
                         . $pathIcon16
                         . '/mail_replay.png" alt="'
                         . _MD_LEXIKON_SENDTOFRIEND
                         . '" style="width:16px; height:16px;"></a>&nbsp;';
            if ((0 != $helper->getConfig('com_rule'))

It seems like you are loosely comparing $helper->getConfig('com_rule') of type mixed|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

                && (!empty($helper->getConfig('com_anonpost'))
                    || \is_object($xoopsUser))) {
                $srvlinks .= '<a TITLE="' . _COMMENTS . '?" href="comment_new.php?com_itemid=' . $variable['id'] . '" target="_parent"><img src="assets/images/comments.gif" alt="' . _COMMENTS . '?" style="width:16px; height:16px;"></a>&nbsp;';
            }
        }

        return $srvlinks;
    }

    // entry footer

    /**
     * @param $variable
     * @return string
     */
    public static function getServiceLinksNew($variable)
    {
        global $xoopsUser, $xoopsDB, $xoopsModule, $xoopsConfig, $myts;

        $helper    = Helper::getInstance();

The assignment to $helper is dead and can be removed.

        $srvlinks2 = '<a TITLE="'
                     . _MD_LEXIKON_PRINTTERM
                     . '" href="print.php?entryID='
                     . $variable['id']
                     . '" target="_blank"><img src="assets/images/print.gif" alt="'
                     . _MD_LEXIKON_PRINTTERM
                     . '" style="vertical-align: middle; width:16px; height:16px; margin: 2px 4px;"> '
                     . _MD_LEXIKON_PRINTTERM2
                     . '</a>&nbsp; <a TITLE="'
                     . _MD_LEXIKON_SENDTOFRIEND
                     . '" href="mailto:?subject='
                     . \sprintf(_MD_LEXIKON_INTENTRY, $xoopsConfig['sitename'])
                     . '&amp;body='
                     . \sprintf(_MD_LEXIKON_INTENTRYFOUND, $xoopsConfig['sitename'])
                     . ': '
                     . $variable['term']
                     . ' '
                     . XOOPS_URL
                     . '/modules/'
                     . $xoopsModule->dirname()
                     . '/entry.php?entryID='
                     . $variable['id']
                     . ' " target="_blank"><img src="assets/images/friend.gif" alt="'
                     . _MD_LEXIKON_SENDTOFRIEND
                     . '" style="vertical-align: middle; width:16px; height:16px; margin: 2px 4px;"> '
                     . _MD_LEXIKON_SENDTOFRIEND2
                     . '</a>&nbsp;';

        return $srvlinks2;
    }

    /**
     * @return XoopsForm

The type XoopsModules\Lexikon\XoopsForm was not found. Did you mean XoopsForm? If so, make sure to prefix the type with \.

     */
    public static function getFormSearch($type = '3', $categoryID = '0', $term = '')
    {
        global $xoopsUser, $xoopsDB, $xoopsModule, $xoopsConfig;

        $helper = Helper::getInstance();

        $grouppermHandler = \xoops_getHandler('groupperm');
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        $action = $_SERVER['REQUEST_URI'];

The assignment to $action is dead and can be removed.

        // Get Theme Form
        \xoops_load('XoopsFormLoader');
        $form = new \XoopsThemeForm(_MD_LEXIKON_LOOKON, 'form', 'search.php', 'post', true);
        $form->setExtra('enctype="multipart/form-data"');
        // Form select search type
        $searchTypeSelect = new \XoopsFormSelect(\_MD_LEXIKON_LOOKON, 'type', $type);
        $searchTypeSelect->addOption('1', _MD_LEXIKON_TERMS);
        $searchTypeSelect->addOption('2', _MD_LEXIKON_DEFINS);
        $searchTypeSelect->addOption('3', _MD_LEXIKON_TERMSDEFS);
        $form->addElement($searchTypeSelect);
        // form select cats
        if (1 == $helper->getConfig('multicats')) {
            $resultcat  = $xoopsDB->query('SELECT categoryID, name FROM ' . $xoopsDB->prefix('lxcategories') . ' ORDER BY categoryID');
            $searchCatSelect = new \XoopsFormSelect(\_MD_LEXIKON_LOOKON, 'categoryID', $categoryID);
            $searchCatSelect->addOption(0, _MD_LEXIKON_ALLOFTHEM);
            while (list($categoryID, $name) = $xoopsDB->fetchRow($resultcat)) {
                if ($grouppermHandler->checkRight('lexikon_view', (int)$categoryID, $groups, $xoopsModule->getVar('mid'))) {
                    $searchCatSelect->addOption($categoryID, $categoryID . ' : ' . $name);
                }
            }
            $form->addElement($searchCatSelect);
        }
        // Form Text term
        $form->addElement(new \XoopsFormText(\_MD_LEXIKON_TERM, 'term', 30, 255, $term), true);
         // To Save
        $form->addElement(new \XoopsFormHidden('op', 'save'));
        $form->addElement(new \XoopsFormButton('', 'submit', \_MD_LEXIKON_SEARCH, 'submit'));

        return $form;

The expression return $form returns the type XoopsThemeForm which is incompatible with the documented return type XoopsModules\Lexikon\XoopsForm.

    }
    
    /**
     * @param $needle
     * @param $haystack
     * @param $hlS
     * @param $hlE
     * @return string
     */
    public static function getHTMLHighlight($needle, $haystack, $hlS, $hlE)
    {
        $parts = \explode('>', $haystack);
        foreach ($parts as $key => $part) {
            $pL = '';
            $pR = '';

            if (false === ($pos = mb_strpos($part, '<'))) {
                $pL = $part;
            } elseif ($pos > 0) {
                $pL = mb_substr($part, 0, $pos);
                $pR = mb_substr($part, $pos, mb_strlen($part));
            }
            if ('' != $pL) {
                $parts[$key] = \preg_replace('|(' . \quotemeta($needle) . ')|iU', $hlS . '\\1' . $hlE, $pL) . $pR;
            }
        }

        return \implode('>', $parts);
    }

    /* *******************************************************************************
     * Most of the following functions are modified functions from Herve's News Module
     * other functions are from  AMS by Novasmart/Mithrandir
     * others from Red Mexico Soft Rmdp
     * others from Xhelp 0.78 thanks to ackbarr and eric_juden
     * *******************************************************************************
     */

    // Create the meta keywords based on content

    /**
     * @param $content
     */
    public static function extractKeywords($content)
    {
        global $xoopsTpl, $xoTheme, $xoopsModule;

        $helper = Helper::getInstance();
        require_once XOOPS_ROOT_PATH . '/modules/lexikon/include/common.inc.php';
        $keywords_count = $helper->getConfig('metakeywordsnum');
        $tmp            = [];
        if (\Xmf\Request::hasVar('xoops_keywords_limit', 'SESSION')) {    // Search the "Minimum keyword length"
            $limit = $_SESSION['xoops_keywords_limit'];
        } else {
            /** @var \XoopsConfigHandler $configHandler */
            $configHandler                    = \xoops_getHandler('config');
            $xoopsConfigSearch                = $configHandler->getConfigsByCat(\XOOPS_CONF_SEARCH);
            $limit                            = $xoopsConfigSearch['keyword_min'];
            $_SESSION['xoops_keywords_limit'] = $limit;
        }
        $myts            = \MyTextSanitizer::getInstance();
        $content         = \str_replace('<br>', ' ', $content);
        $content         = $myts->undoHtmlSpecialChars($content);
        $content         = \strip_tags($content);
        $content         = mb_strtolower($content);
        $search_pattern  = [
            '&nbsp;',
            "\t",
            "\r\n",
            "\r",
            "\n",
            ',',
            '.',
            "'",
            ';',
            ':',
            ')',
            '(',
            '"',
            '?',
            '!',
            '{',
            '}',
            '[',
            ']',
            '<',
            '>',
            '/',
            '+',
            '-',
            '_',
            '\\',
            '*',
        ];
        $replace_pattern = [
            ' ',
            ' ',
            ' ',
            ' ',
            ' ',
            ' ',
            ' ',
            ' ',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
            '',
        ];
        $content         = \str_replace($search_pattern, $replace_pattern, $content);
        $keywords        = \explode(' ', $content);
        switch (\META_KEYWORDS_ORDER) {
            case 1:    // Returns keywords in the same order that they were created in the text
                $keywords = \array_unique($keywords);
                break;
            case 2:    // the keywords order is made according to the reverse keywords frequency (so the less frequent words appear in first in the list)
                $keywords = \array_count_values($keywords);
                \asort($keywords);
                $keywords = \array_keys($keywords);
                break;
            case 3:    // Same as previous, the only difference is that the most frequent words will appear in first in the list
                $keywords = \array_count_values($keywords);
                \arsort($keywords);
                $keywords = \array_keys($keywords);
                break;
        }
        foreach ($keywords as $keyword) {
            if (mb_strlen($keyword) >= $limit && !\is_numeric($keyword)) {
                $tmp[] = $keyword;
            }
        }
        $tmp = \array_slice($tmp, 0, $keywords_count);
        if (\count($tmp) > 0) {
            if (isset($xoTheme) && \is_object($xoTheme)) {
                $xoTheme->addMeta('meta', 'keywords', \implode(',', $tmp));
            } else {    // Compatibility for old Xoops versions
                $xoopsTpl->assign('xoops_meta_keywords', \implode(',', $tmp));
            }
        } else {
            if (!isset($configHandler) || !\is_object($configHandler)) {
                $configHandler = \xoops_getHandler('config');
            }
            $xoopsConfigMetaFooter = $configHandler->getConfigsByCat(\XOOPS_CONF_METAFOOTER);

The method getConfigsByCat() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

            if (isset($xoTheme) && \is_object($xoTheme)) {
                $xoTheme->addMeta('meta', 'keywords', $xoopsConfigMetaFooter['meta_keywords']);
            } else {    // Compatibility for old Xoops versions
                $xoopsTpl->assign('xoops_meta_keywords', $xoopsConfigMetaFooter['meta_keywords']);
            }
        }
    }

    // Create meta description based on content

    /**
     * @param $content
     */
    public static function getMetaDescription($content)
    {
        global $xoopsTpl, $xoTheme;
        $myts    = \MyTextSanitizer::getInstance();
        $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
        if (isset($xoTheme) && \is_object($xoTheme)) {
            $xoTheme->addMeta('meta', 'description', \strip_tags($content));
        } else {  // Compatibility for old Xoops versions
            $xoopsTpl->assign('xoops_meta_description', \strip_tags($content));
        }
    }

    // Create pagetitles

    /**
     * @param string $article
     * @param string $topic
     */
    public static function createPageTitle($article = '', $topic = '')
    {
        global $xoopsModule, $xoopsTpl;
        $myts    = \MyTextSanitizer::getInstance();
        $content = '';
        if (!empty($article)) {
            $content .= \strip_tags($myts->displayTarea($article));
        }
        if (!empty($topic)) {
            if ('' != \xoops_trim($content)) {
                $content .= ' - ' . \strip_tags($myts->displayTarea($topic));
            } else {
                $content .= \strip_tags($myts->displayTarea($topic));
            }
        }
        if (\is_object($xoopsModule) && '' != \xoops_trim($xoopsModule->name())) {
            if ('' != \xoops_trim($content)) {
                $content .= ' - ' . \strip_tags($myts->displayTarea($xoopsModule->name()));
            } else {
                $content .= \strip_tags($myts->displayTarea($xoopsModule->name()));
            }
        }
        if ('' != $content) {
            $xoopsTpl->assign('xoops_pagetitle', $content);
        }
    }

    // clear descriptions

    /**
     * @param $document
     * @return array|string|string[]|null
     */
    public static function convertHtml2text($document)
    {
        // PHP Manual:: function preg_replace $document should contain an HTML document.
        // This will remove HTML tags, javascript sections and white space. It will also
        // convert some common HTML entities to their text equivalent.

        $search = [
            "'<script[^>]*?>.*?</script>'si",  // Strip out javascript
            "'<[\/\!]*?[^<>]*?>'si",          // Strip out HTML tags
            "'([\r\n])[\s]+'",                // Strip out white space
            "'&(quot|#34);'i",                // Replace HTML entities
            "'&(amp|#38);'i",
            "'&(lt|#60);'i",
            "'&(gt|#62);'i",
            "'&(nbsp|#160);'i",
            "'&(iexcl|#161);'i",
            "'&(cent|#162);'i",
            "'&(pound|#163);'i",
            "'&(copy|#169);'i",
        ];

        $replace = [
            '',
            '',
            '\\1',
            '"',
            '&',
            '<',
            '>',
            ' ',
            \chr(161),
            \chr(162),
            \chr(163),
            \chr(169),
        ];

        $text = \preg_replace($search, $replace, $document);

        \preg_replace_callback(
            '/&#(\d+);/',
            static function ($matches) {
                return \chr($matches[1]);
            },
            $document
        );

        return $text;
    }

    //Retrieve moduleoptions equivalent to $Xoopsmoduleconfig

    /**
     * @param         $option
     * @param string  $repmodule
     * @return bool
     */
    public static function getModuleOption($option, $repmodule = 'lexikon')
    {
        global $xoopsModuleConfig, $xoopsModule;
        static $tbloptions = [];
        if (\is_array($tbloptions) && \array_key_exists($option, $tbloptions)) {
            return $tbloptions[$option];
        }

        $retval = false;
        if (isset($xoopsModuleConfig)
            && (\is_object($xoopsModule) && $xoopsModule->getVar('dirname') == $repmodule
                && $xoopsModule->getVar('isactive'))) {
            if (isset($xoopsModuleConfig[$option])) {
                $retval = $xoopsModuleConfig[$option];
            }
        } else {
            /** @var \XoopsModuleHandler $moduleHandler */
            $moduleHandler = \xoops_getHandler('module');
            $module        = $moduleHandler->getByDirname($repmodule);
            $configHandler = \xoops_getHandler('config');
            if ($module) {
                $moduleConfig = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
                if (isset($moduleConfig[$option])) {
                    $retval = $moduleConfig[$option];
                }
            }
        }
        $tbloptions[$option] = $retval;

        return $retval;
    }

    /**
     * Is Xoops 2.3.x ?
     *
     * @return bool need to say it ?
     */
    public static function isX23()
    {
        $x23 = false;
        $xv  = \str_replace('XOOPS ', '', \XOOPS_VERSION);
        if (mb_substr($xv, 2, 1) >= '3') {
            $x23 = true;
        }

        return $x23;
    }

    /**
     * Retreive an editor according to the module's option "form_options"
     * following function is from News modified by trabis
     * @param                                                                                                                                 $caption
     * @param                                                                                                                                 $name
     * @param string                                                                                                                          $value
     * @param string                                                                                                                          $width
     * @param string                                                                                                                          $height
     * @param string                                                                                                                          $supplemental
     * @return bool|\XoopsFormEditor
     */
    public static function getWysiwygForm($caption, $name, $value = '', $width = '100%', $height = '400px', $supplemental = '')
    {
        $editor_option            = mb_strtolower(static::getModuleOption('form_options'));

static::getModuleOption('form_options') of type boolean is incompatible with the type string expected by parameter $string of mb_strtolower().

        $editor                   = false;
        $editor_configs           = [];
        $editor_configs['name']   = $name;
        $editor_configs['value']  = $value;
        $editor_configs['rows']   = 35;
        $editor_configs['cols']   = 60;
        $editor_configs['width']  = '100%';
        $editor_configs['height'] = '350px';
        $editor_configs['editor'] = $editor_option;

        if (static::isX23()) {
            $editor = new \XoopsFormEditor($caption, $name, $editor_configs);

            return $editor;
        }

        // Only for Xoops 2.0.x
        switch ($editor_option) {
            case 'fckeditor':
                if (\is_readable(XOOPS_ROOT_PATH . '/class/fckeditor/formfckeditor.php')) {
                    require_once XOOPS_ROOT_PATH . '/class/fckeditor/formfckeditor.php';
                    $editor = new \XoopsFormFckeditor($caption, $name, $value);

The type XoopsFormFckeditor was not found. Maybe you did not declare it correctly or list all dependencies?

                }
                break;
            case 'htmlarea':
                if (\is_readable(XOOPS_ROOT_PATH . '/class/htmlarea/formhtmlarea.php')) {
                    require_once XOOPS_ROOT_PATH . '/class/htmlarea/formhtmlarea.php';
                    $editor = new \XoopsFormHtmlarea($caption, $name, $value);

The type XoopsFormHtmlarea was not found. Maybe you did not declare it correctly or list all dependencies?

                }
                break;
            case 'dhtmltextarea':
            case 'dhtml':
                $editor = new \XoopsFormDhtmlTextArea($caption, $name, $value, 10, 50, $supplemental);
                break;
            case 'textarea':
                $editor = new \XoopsFormTextArea($caption, $name, $value);
                break;
            case 'tinyeditor':
            case 'tinymce':
                if (\is_readable(XOOPS_ROOT_PATH . '/class/xoopseditor/tinyeditor/formtinyeditortextarea.php')) {
                    require_once XOOPS_ROOT_PATH . '/class/xoopseditor/tinyeditor/formtinyeditortextarea.php';
                    $editor = new \XoopsFormTinyeditorTextArea(

The type XoopsFormTinyeditorTextArea was not found. Maybe you did not declare it correctly or list all dependencies?

                        [
                            'caption' => $caption,
                            'name'    => $name,
                            'value'   => $value,
                            'width'   => '100%',
                            'height'  => '400px',
                        ]
                    );
                }
                break;
            case 'koivi':
                if (\is_readable(XOOPS_ROOT_PATH . '/class/wysiwyg/formwysiwygtextarea.php')) {
                    require_once XOOPS_ROOT_PATH . '/class/wysiwyg/formwysiwygtextarea.php';
                    $editor = new \XoopsFormWysiwygTextArea($caption, $name, $value, $width, $height, '');

The type XoopsFormWysiwygTextArea was not found. Maybe you did not declare it correctly or list all dependencies?

                }
                break;
        }

        return $editor;

The expression return $editor also could return the type XoopsFormDhtmlTextArea which is incompatible with the documented return type XoopsFormEditor|boolean.

    }

    /**
     * @param \Xmf\Module\Helper $helper
     * @param array|null         $options
     * @return \XoopsFormDhtmlTextArea|\XoopsFormEditor
     */
    public static function getEditor($helper = null, $options = null)
    {

        if (null === $options) {
            $options           = [];
            $options['name']   = 'Editor';
            $options['value']  = 'Editor';
            $options['rows']   = 10;
            $options['cols']   = '100%';
            $options['width']  = '100%';
            $options['height'] = '400px';
        }

        if (null === $helper) {
            $helper = Helper::getInstance();
        }

        $isAdmin = $helper->isUserAdmin();

        if (\class_exists('XoopsFormEditor')) {
            if ($isAdmin) {
                $descEditor = new \XoopsFormEditor(\ucfirst($options['name']), $helper->getConfig('editorAdmin'), $options, $nohtml = false, $onfailure = 'textarea');
            } else {
                $descEditor = new \XoopsFormEditor(\ucfirst($options['name']), $helper->getConfig('editorUser'), $options, $nohtml = false, $onfailure = 'textarea');
            }
        } else {
            $descEditor = new \XoopsFormDhtmlTextArea(\ucfirst($options['name']), $options['name'], $options['value'], '100%', '100%');

'100%' of type string is incompatible with the type integer expected by parameter $cols of XoopsFormDhtmlTextArea::__construct().

'100%' of type string is incompatible with the type integer expected by parameter $rows of XoopsFormDhtmlTextArea::__construct().

        }

        //        $form->addElement($descEditor);

        return $descEditor;
    }

    /**
     * linkterms: assign module header
     *
     * tooltips (c) dhtmlgoodies
     */
    public static function getModuleHeader()
    {
        global $xoopsTpl, $xoTheme, $xoopsModule, $lexikon_module_header;

        $helper = Helper::getInstance();

        if (isset($xoTheme) && \is_object($xoTheme)) {
            $xoTheme->addStylesheet('modules/lexikon/assets/css/style.css');
            if (3 == $helper->getConfig('linkterms')) {
                $xoTheme->addStylesheet('modules/lexikon/assets/css/linkterms.css');
                $xoTheme->addScript('/modules/lexikon/assets/js/tooltipscript2.js', ['type' => 'text/javascript']);
            }
            if (4 == $helper->getConfig('linkterms')) {
                $xoTheme->addScript('/modules/lexikon/assets/js/popup.js', ['type' => 'text/javascript']);
            }
            if (5 == $helper->getConfig('linkterms')) {
                $xoTheme->addStylesheet('modules/lexikon/assets/css/linkterms.css');
                $xoTheme->addScript('/modules/lexikon/assets/js/balloontooltip.js', ['type' => 'text/javascript']);
            }
            if (6 == $helper->getConfig('linkterms')) {
                $xoTheme->addStylesheet('modules/lexikon/assets/css/linkterms.css');
                $xoTheme->addScript('/modules/lexikon/assets/js/shadowtooltip.js', ['type' => 'text/javascript']);
            }
        } else {
            $lexikon_url = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname');
            if (3 == $helper->getConfig('linkterms')) {
                $lexikon_module_header = '<link rel="stylesheet" type="text/css" href="assets/css/style.css" >
            <link rel="stylesheet" type="text/css" href="assets/css/linkterms.css" >
            <script src="' . $lexikon_url . '/assets/js/tooltipscript2.js" type="text/javascript"></script>';
            }
            if (4 == $helper->getConfig('linkterms')) {
                $lexikon_module_header = '<link rel="stylesheet" type="text/css" href="assets/css/style.css" >
            <link rel="stylesheet" type="text/css" href="assets/css/linkterms.css" >
            <script src="' . $lexikon_url . '/assets/js/popup.js" type="text/javascript"></script>';
            }
            if (5 == $helper->getConfig('linkterms')) {
                $lexikon_module_header = '<link rel="stylesheet" type="text/css" href="assets/css/style.css" >
            <link rel="stylesheet" type="text/css" href="assets/css/linkterms.css" >
            <script src="' . $lexikon_url . '/assets/js/balloontooltip.js" type="text/javascript"></script>';
            }
            if (6 == $helper->getConfig('linkterms')) {
                $lexikon_module_header = '<link rel="stylesheet" type="text/css" href="assets/css/style.css" >
            <link rel="stylesheet" type="text/css" href="assets/css/linkterms.css" >
            <script src="' . $lexikon_url . '/assets/js/shadowtooltip.js" type="text/javascript"></script>';
            }
        }
    }

    /**
     * Validate userid
     * @param $uids
     * @return bool
     */
    public static function getUserData($uids)
    {
        global $xoopsDB, $xoopsUser, $xoopsUserIsAdmin;

        if ($uids <= 0) {
            return false;
        }
        if ($uids > 0) {
            $memberHandler = \xoops_getHandler('member');
            $user          = $memberHandler->getUser($uids);

The method getUser() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsAvatarHandler or XoopsPersistableObjectHandler.

            if (!\is_object($user)) {
                return false;
            }
        }
        $result = $xoopsDB->query('SELECT * FROM ' . $xoopsDB->prefix('users') . " WHERE uid='$uids'");
        if ($xoopsDB->getRowsNum($result) <= 0) {
            return false;
        }
        $row = $xoopsDB->fetchArray($result);

        return $row;
    }

    // Get all terms published by an author

    /**
     * @param $uid
     */
    public static function getAuthorProfile($uid)
    {
        require_once XOOPS_ROOT_PATH . '/class/pagenav.php';
        global $authortermstotal, $xoopsTpl, $xoopsDB, $xoopsUser;

        $helper = Helper::getInstance();
        $myts   = \MyTextSanitizer::getInstance();

The assignment to $myts is dead and can be removed.

        //permissions
        $grouppermHandler = \xoops_getHandler('groupperm');
        $groups           = \is_object($xoopsUser) ? $xoopsUser->getGroups() : XOOPS_GROUP_ANONYMOUS;
        /** @var \XoopsModuleHandler $moduleHandler */
        $moduleHandler = \xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname('lexikon');
        $module_id     = $module->getVar('mid');
        $allowed_cats  = $grouppermHandler->getItemIds('lexikon_view', $groups, $module_id);
        $catids        = \implode(',', $allowed_cats);
        $catperms      = " AND categoryID IN ($catids) ";

        $start = \Xmf\Request::getInt('start', 0, 'GET');
        $limit = $helper->getConfig('indexperpage');

        $sql = $xoopsDB->query(
            'SELECT *
                              FROM ' . $xoopsDB->prefix('lxentries') . "
                              WHERE uid='" . (int)$uid . "' AND  offline = '0' AND submit = '0' AND request = '0' " . $catperms . "
                              ORDER BY term
                              LIMIT $start,$limit"
        );

        while (false !== ($row = $xoopsDB->fetchArray($sql))) {
            $xoopsTpl->append(
                'entries',
                [
                    'id'      => $row['entryID'],
                    'name'    => $row['term'],
                    'date'    => \date($helper->getConfig('dateformat'), $row['datesub']),

It seems like $helper->getConfig('dateformat') can also be of type null; however, parameter $format of date() does only seem to accept string, maybe add an additional type check?

                    'counter' => $row['counter'],
                ]
            );
        }

        $navstring                = '';
        $navstring                .= 'uid=' . $uid . '&start';
        $pagenav                  = new \XoopsPageNav($authortermstotal, $helper->getConfig('indexperpage'), $start, $navstring);
        $authortermsarr['navbar'] = '<span style="text-align:right;">' . $pagenav->renderNav(6) . '</span>';

$authortermsarr was never initialized. Although not strictly required by PHP, it is generally a good practice to add $authortermsarr = array(); before regardless.

        $xoopsTpl->assign('authortermsarr', $authortermsarr);
    }

    // Returns the author's IDs for authorslist

    /**
     * @param int $limit
     * @param int $start
     * @return array
     */
    public static function getAuthors($limit = 0, $start = 0)

The parameter $limit is not used and could be removed.

The parameter $start is not used and could be removed.

    {
        global $xoopsDB;

        $ret    = [];
        $sql    = 'SELECT DISTINCT(uid) AS uid FROM ' . $xoopsDB->prefix('lxentries') . ' WHERE offline = 0 ';
        $sql    .= ' ORDER BY uid';
        $result = $xoopsDB->query($sql);
        while (false !== ($myrow = $xoopsDB->fetchArray($result))) {
            $ret[] = $myrow['uid'];
        }

        return $ret;
    }

    // link to userprofile

    /**
     * @param $userid
     * @return string
     */
    public static function getLinkedProfileFromId($userid)

The parameter $userid is not used and could be removed.

    {
        global $uid, $xoopsModule;
        $userid = (int)$uid;
        if ($userid > 0) {
            $memberHandler = \xoops_getHandler('member');
            $user          = $memberHandler->getUser($userid);
            if (\is_object($user)) {
                $linkeduser = '<A TITLE="' . _MD_LEXIKON_AUTHORPROFILETEXT . '" HREF="' . XOOPS_URL . '/modules/' . $xoopsModule->dirname() . '/profile.php?uid=' . $uid . '">' . $user->getVar('uname') . '</a>';
                //$linkeduser = \XoopsUserUtility::getUnameFromId ( $uid );
                //$linkeduser .= '<div style=\'position:relative; right: 4px; top: 2px;\'><A TITLE="'._MD_LEXIKON_AUTHORPROFILETEXT.'" HREF="'.XOOPS_URL.'/modules/'.$xoopsModule->dirname().'/profile.php?uid='.$uid.'">'._MD_LEXIKON_AUTHORPROFILETEXT.'</a></div>';
                return $linkeduser;
            }
        }

        return $GLOBALS['xoopsConfig']['anonymous'];
    }

    // functionset to assign terms with accentuated or umlaut initials to the adequate initial

    /**
     * @param $string
     * @return array|string|string[]
     */
    public static function removeAccents($string)
    {
        $chars['in']  = \chr(128)

$chars was never initialized. Although not strictly required by PHP, it is generally a good practice to add $chars = array(); before regardless.

                        . \chr(131)
                        . \chr(138)
                        . \chr(142)
                        . \chr(154)
                        . \chr(158)
                        . \chr(159)
                        . \chr(162)
                        . \chr(165)
                        . \chr(181)
                        . \chr(192)
                        . \chr(193)
                        . \chr(194)
                        . \chr(195)
                        . \chr(196)
                        . \chr(197)
                        . \chr(199)
                        . \chr(200)
                        . \chr(201)
                        . \chr(202)
                        . \chr(203)
                        . \chr(204)
                        . \chr(205)
                        . \chr(206)
                        . \chr(207)
                        . \chr(209)
                        . \chr(210)
                        . \chr(211)
                        . \chr(212)
                        . \chr(213)
                        . \chr(214)
                        . \chr(216)
                        . \chr(217)
                        . \chr(218)
                        . \chr(219)
                        . \chr(220)
                        . \chr(221)
                        . \chr(224)
                        . \chr(225)
                        . \chr(226)
                        . \chr(227)
                        . \chr(228)
                        . \chr(229)
                        . \chr(231)
                        . \chr(232)
                        . \chr(233)
                        . \chr(234)
                        . \chr(235)
                        . \chr(236)
                        . \chr(237)
                        . \chr(238)
                        . \chr(239)
                        . \chr(241)
                        . \chr(242)
                        . \chr(243)
                        . \chr(244)
                        . \chr(245)
                        . \chr(246)
                        . \chr(248)
                        . \chr(249)
                        . \chr(250)
                        . \chr(251)
                        . \chr(252)
                        . \chr(253)
                        . \chr(255);
        $chars['out'] = 'EfSZszYcYuAAAAAACEEEEIIIINOOOOOOUUUUYaaaaaaceeeeiiiinoooooouuuuyy';
        if (static::isUtf8($string)) {
            $invalid_latin_chars = [
                \chr(197) . \chr(146)             => 'OE',
                \chr(197) . \chr(147)             => 'oe',
                \chr(197) . \chr(160)             => 'S',
                \chr(197) . \chr(189)             => 'Z',
                \chr(197) . \chr(161)             => 's',
                \chr(197) . \chr(190)             => 'z',
                \chr(226) . \chr(130) . \chr(172) => 'E',
            ];
            $string              = utf8_decode(strtr($string, $invalid_latin_chars));
        }
        $string              = strtr($string, $chars['in'], $chars['out']);
        $double_chars['in']  = [

$double_chars was never initialized. Although not strictly required by PHP, it is generally a good practice to add $double_chars = array(); before regardless.

            \chr(140),
            \chr(156),
            \chr(198),
            \chr(208),
            \chr(222),
            \chr(223),
            \chr(230),
            \chr(240),
            \chr(254),
        ];
        $double_chars['out'] = ['OE', 'oe', 'AE', 'DH', 'TH', 'ss', 'ae', 'dh', 'th'];
        $string              = \str_replace($double_chars['in'], $double_chars['out'], $string);

        return $string;
    }

    /**
     * @param $Str
     * @return bool
     */
    public static function isUtf8($Str)
    { # by bmorel at ssi dot fr
        for ($i = 0, $iMax = mb_strlen($Str); $i < $iMax; ++$i) {
            if (\ord($Str[$i]) < 0x80) {
                continue;
            }

            if (0xC0 == (\ord($Str[$i]) & 0xE0)) {
                $n = 1;
            } # 0bbbbbbb
            # 110bbbbb
            elseif (0xE0 == (\ord($Str[$i]) & 0xF0)) {
                $n = 2;
            } # 1110bbbb
            elseif (0xF0 == (\ord($Str[$i]) & 0xF8)) {
                $n = 3;
            } # 11110bbb
            elseif (0xF8 == (\ord($Str[$i]) & 0xFC)) {
                $n = 4;
            } # 111110bb
            elseif (0xFC == (\ord($Str[$i]) & 0xFE)) {
                $n = 5;
            } # 1111110b
            else {
                return false;
            } # Does not match any model
            for ($j = 0; $j < $n; ++$j) { # n bytes matching 10bbbbbb follow ?
                if ((++$i == mb_strlen($Str)) || (0x80 != (\ord($Str[$i]) & 0xC0))) {
                    return false;
                }
            }
        }

        return true;
    }

    /**
     * @param $field
     * @return string
     */
    public static function sanitizeFieldName($field)
    {
        $field = static::removeAccents($field);
        $field = mb_strtolower($field);
        $field = \preg_replace('/&.+?;/', '', $field); // kill entities
        $field = \preg_replace('/[^a-z0-9 _-]/', '', $field);
        $field = \preg_replace('/\s+/', ' ', $field);
        $field = \str_replace(' ', '-', $field);
        $field = \preg_replace('|-+|', '-', $field);
        $field = \trim($field, '-');

        return $field;
    }

    // Verify that a term does not exist for submissions and requests (both user frontend and admin backend)

    /**
     * @param $term
     * @param $table
     * @return mixed
     */
    public static function isTermPresent($term, $table)
    {
        global $xoopsDB;
        $sql    = \sprintf('SELECT COUNT(*) FROM `%s` WHERE term = %s', $table, $xoopsDB->quoteString(\addslashes($term)));
        $result = $xoopsDB->query($sql);
        [$count] = $xoopsDB->fetchRow($result);

        return $count;
    }

    // Static method to get author data block authors - from AMS

    /**
     * @param int    $limit
     * @param string $sort
     * @param string $name
     * @param string $compute_method
     * @return array|bool
     */
    public static function getBlockAuthors($limit = 5, $sort = 'count', $name = 'uname', $compute_method = 'average')
    {
        $limit = (int)$limit;
        if ('uname' !== $name) {
            $name = 'name';
        } //making sure that there is not invalid information in field value
        $ret = [];
        $db  = \XoopsDatabaseFactory::getDatabaseConnection();
        if ('count' === $sort) {
            $sql = 'SELECT u.' . $name . ' AS name, u.uid , count( n.entryID ) AS count
              FROM ' . $db->prefix('users') . ' u, ' . $db->prefix('lxentries') . ' n
              WHERE u.uid = n.uid
              AND n.datesub > 0 AND n.datesub <= ' . \time() . ' AND n.offline = 0 AND n.submit = 0
              GROUP BY u.uid ORDER BY count DESC';
        } elseif ('read' === $sort) {
            if ('average' === $compute_method) {
                $compute = 'sum( n.counter ) / count( n.entryID )';
            } else {
                $compute = 'sum( n.counter )';
            }
            $sql = 'SELECT u.' . $name . " AS name, u.uid , $compute AS count
              FROM " . $db->prefix('users') . ' u, ' . $db->prefix('lxentries') . ' n
              WHERE u.uid = n.uid
              AND n.datesub > 0 AND n.datesub <= ' . \time() . ' AND n.offline = 0 AND n.submit = 0
              GROUP BY u.uid ORDER BY count DESC';
        }
        if (!$result = $db->query($sql, $limit)) {

The variable $sql does not seem to be defined for all execution paths leading up to this point.

            return false;
        }

        while (false !== ($row = $db->fetchArray($result))) {
            if ('name' === $name && '' == $row['name']) {
                $row['name'] = \XoopsUser::getUnameFromId($row['uid']);
            }
            $row['count'] = \round($row['count'], 0);
            $ret[]        = $row;
        }

        return $ret;
    }

    /**
     * close all unclosed xhtml tags *Test*
     *
     * @param string $html
     * @return string
     * @author Milian Wolff <mail -at- milianw.de>
     */
    public static function closeTags2($html)
    {
        // put all opened tags into an array
        \preg_match_all('#<([a-z]+)( .*)?(?!/)>#iU', $html, $result);
        $openedtags = $result[1];

        // put all closed tags into an array
        \preg_match_all('#</([a-z]+)>#iU', $html, $result);
        $closedtags = $result[1];
        $len_opened = \count($openedtags);
        // all tags are closed
        if (\count($closedtags) == $len_opened) {
            return $html;
        }

        $openedtags = \array_reverse($openedtags);
        // close tags
        for ($i = 0; $i < $len_opened; ++$i) {
            if (!\in_array($openedtags[$i], $closedtags)) {
                $html .= '</' . $openedtags[$i] . '>';
            } else {
                unset($closedtags[\array_search($openedtags[$i], $closedtags, true)]);
            }
        }

        return $html;
    }

    /**
     * @param $string
     * @return string
     * @author   Monte Ohrt <monte at ohrt dot com>, modified by Amos Robinson
     *           <amos dot robinson at gmail dot com>
     */
    public static function closeTags($string)
    {
        // match opened tags
        if (\preg_match_all('/<([a-z\:\-]+)[^\/]>/', $string, $start_tags)) {
            $start_tags = $start_tags[1];
            // match closed tags
            if (\preg_match_all('/<\/([a-z]+)>/', $string, $end_tags)) {
                $complete_tags = [];
                $end_tags      = $end_tags[1];

                foreach ($start_tags as $key => $val) {
                    $posb = \array_search($val, $end_tags, true);
                    if (\is_int($posb)) {
                        unset($end_tags[$posb]);
                    } else {
                        $complete_tags[] = $val;
                    }
                }
            } else {
                $complete_tags = $start_tags;
            }

            $complete_tags = \array_reverse($complete_tags);
            for ($i = 0, $iMax = \count($complete_tags); $i < $iMax; ++$i) {
                $string .= '</' . $complete_tags[$i] . '>';
            }
        }

        return $string;
    }

    /**
     * Smarty plugin
     * @param mixed $string
     * @param mixed $length
     * @param mixed $etc
     * @param mixed $break_words
     * @package    Smarty
     * @subpackage plugins
     */

    /**
     * Smarty truncate_tagsafe modifier plugin
     *
     * Type:     modifier<br>
     * Name:     truncate_tagsafe<br>
     * Purpose:  Truncate a string to a certain length if necessary,
     *           optionally splitting in the middle of a word, and
     *           appending the $etc string or inserting $etc into the middle.
     *           Makes sure no tags are left half-open or half-closed (e.g. "Banana in a <a...")
     * @param               $string
     * @param int           $length
     * @param string        $etc
     * @param bool          $break_words
     * @return string
     * @author   Monte Ohrt <monte at ohrt dot com>, modified by Amos Robinson
     *           <amos dot robinson at gmail dot com>
     *           used in Block entries_scrolling.php
     */
    public static function truncateTagSafe($string, $length = 80, $etc = '...', $break_words = false)
    {
        if (0 == $length) {
            return '';
        }
        if (mb_strlen($string) > $length) {
            $length -= mb_strlen($etc);
            if (!$break_words) {
                $string = \preg_replace('/\s+?(\S+)?$/', '', mb_substr($string, 0, $length + 1));
                $string = \preg_replace('/<[^>]*$/', '', $string);
                $string = static::closeTags($string);
            }

            return $string . $etc;
        }

        return $string;
    }

    /**
     * @return array
     */
    public static function getSummary()
    {
        global $xoopsDB;

        $summary = [];

        $result01 = $xoopsDB->query(
            'SELECT COUNT(*)
                                   FROM ' . $xoopsDB->prefix('lxcategories') . ' '
        );
        [$totalcategories] = $xoopsDB->fetchRow($result01);

        $result02 = $xoopsDB->query(
            'SELECT COUNT(*)
                                   FROM ' . $xoopsDB->prefix('lxentries') . '
                                   WHERE submit = 0'
        );
        [$totalpublished] = $xoopsDB->fetchRow($result02);

        $result03 = $xoopsDB->query(
            'SELECT COUNT(*)
                                   FROM ' . $xoopsDB->prefix('lxentries') . "
                                   WHERE submit = '1' AND request = '0' "
        );
        [$totalsubmitted] = $xoopsDB->fetchRow($result03);

        $result04 = $xoopsDB->query(
            'SELECT COUNT(*)
                                   FROM ' . $xoopsDB->prefix('lxentries') . "
                                   WHERE submit = '1' AND request = '1' "
        );
        [$totalrequested] = $xoopsDB->fetchRow($result04);

        // Recuperer les valeurs dans la base de donnees

        $summary['publishedEntries']    = $totalpublished ?: '0';
        $summary['availableCategories'] = $totalcategories ?: '0';
        $summary['submittedEntries']    = $totalsubmitted ?: '0';
        $summary['requestedEntries']    = $totalrequested ?: '0';

        //print_r($summary);
        return $summary;
    }

    // end function

    /**
     * @param $text
     * @param $form_sort
     * @return string
     */
    public static function selectSorting($text, $form_sort)
    {
        global $start, $order, $file_cat, $sort, $xoopsModule;

        $select_view   = '';

The assignment to $select_view is dead and can be removed.

        $moduleDirName = \basename(\dirname(__DIR__));

        $helper = Helper::getInstance();

        $pathModIcon16 = XOOPS_URL . '/modules/' . $moduleDirName . '/' . $helper->getModule()->getInfo('modicons16');

Are you sure $helper->getModule()->getInfo('modicons16') of type array|string can be used in concatenation?

        $select_view = '<form name="form_switch" id="form_switch" action="' . Request::getString('REQUEST_URI', '', 'SERVER') . '" method="post"><span style="font-weight: bold;">' . $text . '</span>';
        //$sorts =  $sort ==  'asc' ? 'desc' : 'asc';
        if ($form_sort == $sort) {
            $sel1 = 'asc' === $order ? 'selasc.png' : 'asc.png';
            $sel2 = 'desc' === $order ? 'seldesc.png' : 'desc.png';
        } else {
            $sel1 = 'asc.png';
            $sel2 = 'desc.png';
        }
        $select_view .= '  <a href="' . Request::getString('SCRIPT_NAME', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=asc" ><img src="' . $pathModIcon16 . '/' . $sel1 . '" title="ASC" alt="ASC"></a>';
        $select_view .= '<a href="' . Request::getString('SCRIPT_NAME', '', 'SERVER') . '?start=' . $start . '&sort=' . $form_sort . '&order=desc" ><img src="' . $pathModIcon16 . '/' . $sel2 . '" title="DESC" alt="DESC"></a>';
        $select_view .= '</form>';

        return $select_view;
    }

    /***************Blocks***************/

    /**
     * @param array $cats
     * @return string
     */
    public static function block_addCatSelect($cats)
    {
        $cat_sql = '';
        if (\is_array($cats)) {

The condition is_array($cats) is always true.

            $cat_sql = '(' . \current($cats);
            \array_shift($cats);
            foreach ($cats as $cat) {
                $cat_sql .= ',' . $cat;
            }
            $cat_sql .= ')';
        }

        return $cat_sql;
    }

    /**
     * @param $content
     */
    public static function meta_keywords($content)
    {
        global $xoopsTpl, $xoTheme;
        $myts    = \MyTextSanitizer::getInstance();
        $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
        if (null !== $xoTheme && \is_object($xoTheme)) {
            $xoTheme->addMeta('meta', 'keywords', \strip_tags($content));
        } else {    // Compatibility for old Xoops versions
            $xoopsTpl->assign('xoops_meta_keywords', \strip_tags($content));
        }
    }

    /**
     * @param $content
     */
    public static function meta_description($content)
    {
        global $xoopsTpl, $xoTheme;
        $myts    = \MyTextSanitizer::getInstance();
        $content = $myts->undoHtmlSpecialChars($myts->displayTarea($content));
        if (null !== $xoTheme && \is_object($xoTheme)) {
            $xoTheme->addMeta('meta', 'description', \strip_tags($content));
        } else {    // Compatibility for old Xoops versions
            $xoopsTpl->assign('xoops_meta_description', \strip_tags($content));
        }
    }

    /**
     * @param $tableName
     * @param $columnName
     *
     * @return array
     */
    public static function enumerate($tableName, $columnName)
    {
        $table = $GLOBALS['xoopsDB']->prefix($tableName);

        //    $result = $GLOBALS['xoopsDB']->query("SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS
        //        WHERE TABLE_NAME = '" . $table . "' AND COLUMN_NAME = '" . $columnName . "'")
        //    || exit ($GLOBALS['xoopsDB']->error());

        $sql    = 'SELECT COLUMN_TYPE FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = "' . $table . '" AND COLUMN_NAME = "' . $columnName . '"';
        $result = $GLOBALS['xoopsDB']->query($sql);
        if (!$result) {
            exit($GLOBALS['xoopsDB']->error());

Using exit here is not recommended.

        }

        $row      = $GLOBALS['xoopsDB']->fetchBoth($result);
        $enumList = \explode(',', \str_replace("'", '', mb_substr($row['COLUMN_TYPE'], 5, -6)));

        return $enumList;
    }

    /**
     * @param array|string $tableName
     * @param string       $id_field
     * @param int          $id
     *
     * @return false|void
     */
    public static function cloneRecord($tableName, $id_field, $id)
    {
        $new_id = false;
        $table  = $GLOBALS['xoopsDB']->prefix($tableName);
        // copy content of the record you wish to clone
        $tempTable = $GLOBALS['xoopsDB']->fetchArray($GLOBALS['xoopsDB']->query("SELECT * FROM $table WHERE $id_field='$id' "), \MYSQLI_ASSOC) or exit('Could not select record');

Using exit here is not recommended.

        // set the auto-incremented id's value to blank.
        unset($tempTable[$id_field]);
        // insert cloned copy of the original  record
        $result = $GLOBALS['xoopsDB']->queryF("INSERT INTO $table (" . \implode(', ', \array_keys($tempTable)) . ") VALUES ('" . \implode("', '", \array_values($tempTable)) . "')") or exit($GLOBALS['xoopsDB']->error());

Using exit here is not recommended.

        if ($result) {
            // Return the new id
            $new_id = $GLOBALS['xoopsDB']->getInsertId();
        }

        return $new_id;
    }

    /**
     * truncateHtml can truncate a string up to a number of characters while preserving whole words and HTML tags
     * www.gsdesign.ro/blog/cut-html-string-without-breaking-the-tags
     * www.cakephp.org
     *
     * @param string $text         String to truncate.
     * @param int    $length       Length of returned string, including ellipsis.
     * @param string $ending       Ending to be appended to the trimmed string.
     * @param bool   $exact        If false, $text will not be cut mid-word
     * @param bool   $considerHtml If true, HTML tags would be handled correctly
     *
     * @return string Trimmed string.
     */
    public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
    {
        if ($considerHtml) {
            // if the plain text is shorter than the maximum length, return the whole text
            if (mb_strlen(\preg_replace('/<.*?' . '>/', '', $text)) <= $length) {
                return $text;
            }
            // splits all html-tags to scanable lines
            \preg_match_all('/(<.+?' . '>)?([^<>]*)/s', $text, $lines, \PREG_SET_ORDER);
            $total_length = mb_strlen($ending);
            $open_tags    = [];
            $truncate     = '';
            foreach ($lines as $line_matchings) {
                // if there is any html-tag in this line, handle it and add it (uncounted) to the output
                if (!empty($line_matchings[1])) {
                    // if it's an "empty element" with or without xhtml-conform closing slash
                    if (\preg_match('/^<(\s*.+?\/\s*|\s*(img|br|input|hr|area|base|basefont|col|frame|isindex|link|meta|param)(\s.+?)?)>$/is', $line_matchings[1])) {
                        // do nothing
                        // if tag is a closing tag
                    } elseif (\preg_match('/^<\s*\/(\S+?)\s*>$/s', $line_matchings[1], $tag_matchings)) {
                        // delete tag from $open_tags list
                        $pos = \array_search($tag_matchings[1], $open_tags, true);
                        if (false !== $pos) {
                            unset($open_tags[$pos]);
                        }
                        // if tag is an opening tag
                    } elseif (\preg_match('/^<\s*([^\s>!]+).*?' . '>$/s', $line_matchings[1], $tag_matchings)) {
                        // add tag to the beginning of $open_tags list
                        \array_unshift($open_tags, mb_strtolower($tag_matchings[1]));
                    }
                    // add html-tag to $truncate'd text
                    $truncate .= $line_matchings[1];
                }
                // calculate the length of the plain text part of the line; handle entities as one character
                $content_length = mb_strlen(\preg_replace('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|[0-9a-f]{1,6};/i', ' ', $line_matchings[2]));
                if ($total_length + $content_length > $length) {
                    // the number of characters which are left
                    $left            = $length - $total_length;
                    $entities_length = 0;
                    // search for html entities
                    if (\preg_match_all('/&[0-9a-z]{2,8};|&#[0-9]{1,7};|[0-9a-f]{1,6};/i', $line_matchings[2], $entities, \PREG_OFFSET_CAPTURE)) {
                        // calculate the real length of all entities in the legal range
                        foreach ($entities[0] as $entity) {
                            if ($left >= $entity[1] + 1 - $entities_length) {
                                $left--;
                                $entities_length += mb_strlen($entity[0]);
                            } else {
                                // no more characters left
                                break;
                            }
                        }
                    }
                    $truncate .= mb_substr($line_matchings[2], 0, $left + $entities_length);
                    // maximum lenght is reached, so get off the loop
                    break;
                }
                $truncate     .= $line_matchings[2];
                $total_length += $content_length;

                // if the maximum length is reached, get off the loop
                if ($total_length >= $length) {
                    break;
                }
            }
        } else {
            if (mb_strlen($text) <= $length) {
                return $text;
            }
            $truncate = mb_substr($text, 0, $length - mb_strlen($ending));
        }
        // if the words shouldn't be cut in the middle...
        if (!$exact) {
            // ...search the last occurance of a space...
            $spacepos = mb_strrpos($truncate, ' ');
            if (isset($spacepos)) {
                // ...and cut the text in this position
                $truncate = mb_substr($truncate, 0, $spacepos);
            }
        }
        // add the defined ending to the text
        $truncate .= $ending;
        if ($considerHtml) {
            // close all unclosed html-tags
            foreach ($open_tags as $tag) {

The variable $open_tags does not seem to be defined for all execution paths leading up to this point.

                $truncate .= '</' . $tag . '>';
            }
        }

        return $truncate;
    }
}