blocksadmin.inc.php ➔ myblocksadmin_update_blockinstance()

Complexity

Conditions	7
Paths	18

Size

Total Lines	66
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function myblocksadmin_update_blockinstance(

myblocksadmin_update_blockinstance uses the super-global variable $GLOBALS which is generally not recommended.

    $id,
    $bside,
    $bweight,
    $bvisible,
    $btitle,
    $bcontent,

The parameter $bcontent is not used and could be removed.

    $bctype,

The parameter $bctype is not used and could be removed.

    $bcachetime,
    $bmodule,
    $options = array(),
    $bid = null
) {
    global $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    $instanceHandler = xoops_getHandler('blockinstance');
    $blockHandler    = xoops_getHandler('block');
    if ($id > 0) {
        // update
        $instance =& $instanceHandler->get($id);
        if ($bside >= 0) {
            $instance->setVar('side', $bside);
        }
        if (!empty($options)) {
            $instance->setVar('options', $options);
        }
    } else {
        // insert
        $instance = $instanceHandler->create();
        $instance->setVar('bid', $bid);
        $instance->setVar('side', $bside);
        $block = $blockHandler->get($bid);
        $instance->setVar('options', $block->getVar('options'));
        if (empty($btitle)) {
            $btitle = $block->getVar('name');
        }
    }
    $instance->setVar('weight', $bweight);
    $instance->setVar('visible', $bvisible);
    $instance->setVar('title', $btitle);
    // if( isset( $bcontent ) ) $instance->setVar('content', $bcontent);

66% of this comment could be valid code. Did you maybe forget this after debugging?

    // if( isset( $bctype ) ) $instance->setVar('c_type', $bctype);

66% of this comment could be valid code. Did you maybe forget this after debugging?

    $instance->setVar('bcachetime', $bcachetime);

    if ($instanceHandler->insert($instance)) {
        $GLOBALS['xoopsDB']->query('DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('block_module_link') . ' WHERE block_id=' . $instance->getVar('instanceid'));
        foreach ($bmodule as $mid) {
            $page   = explode('-', $mid);
            $mid    = $page[0];
            $pageid = $page[1];
            $GLOBALS['xoopsDB']->query('INSERT INTO '
                                       . $GLOBALS['xoopsDB']->prefix('block_module_link')
                                       . ' VALUES ('
                                       . $instance->getVar('instanceid')
                                       . ', '
                                       . (int)$mid
                                       . ', '
                                       . (int)$pageid
                                       . ')');
        }

        return _MD_AM_DBUPDATED;
    }

    return 'Failed update of block instance. ID:' . $id;
}