myblocksadmin2.php ➔ list_groups2() - Code Metrics - Inspection of "sync" - XoopsModules25x/lexikon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1777d...d193e2 )

by Michael

created 2017-02-06 16:45 UTC

myblocksadmin2.php ➔ list_groups2() B

↳ Parent: Project

Complexity

Conditions	4
Paths	8

Size

Total Lines	25
Code Lines	17

Duplication

Lines	4
Ratio	16 %

Importance

Changes

Metric	Value
cc	4
eloc	17
nc	8
nop	0
dl	4
loc	25
rs	8.5806
c	0
b	0
f	0

<?php

// ------------------------------------------------------------------------- //
//                     myblocksadmin_for_2.2.php                             //
//                - XOOPS block admin for each modules -                     //
//                          GIJOE <http://www.peak.ne.jp/>                   //
// ------------------------------------------------------------------------- //

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

include_once __DIR__ . '/../../../include/cp_header.php';

include_once __DIR__ . '/mygrouppermform.php';
include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php';
include_once __DIR__ . '/../include/gtickets.php';

$xoops_system_path = XOOPS_ROOT_PATH . '/modules/system';

// language files
$language = $xoopsConfig['language'];
if (!file_exists("$xoops_system_path/language/$language/admin/blocksadmin.php")) {
    $language = 'english';
}

// to prevent from notice that constants already defined
$error_reporting_level = error_reporting(0);
include_once "$xoops_system_path/constants.php";
include_once "$xoops_system_path/language/$language/admin.php";
include_once "$xoops_system_path/language/$language/admin/blocksadmin.php";
error_reporting($error_reporting_level);

$group_defs = file("$xoops_system_path/language/$language/admin/groups.php");
foreach ($group_defs as $def) {

    if (false !== strpos($def, '_AM_ACCESSRIGHTS') || false !== strpos($def, '_AM_ACTIVERIGHTS')) {
        eval($def);
    }
}

// check $xoopsModule
if (!is_object($xoopsModule)) {
    redirect_header(XOOPS_URL . '/user.php', 1, _NOPERM);
}

// set target_module if specified by $_GET['dirname']
/** @var XoopsModuleHandler $moduleHandler */
$moduleHandler = xoops_getHandler('module');
if (!empty($_GET['dirname'])) {
    $target_module = $moduleHandler->getByDirname($_GET['dirname']);
}/* else if ( ! empty( $_GET['mid'] ) ) {

    $target_module = $moduleHandler->get( (int)( $_GET['mid'] ) );
}*/

if (!empty($target_module) && is_object($target_module)) {

    // specified by dirname
    $target_mid     = $target_module->getVar('mid');
    $target_mname   = $target_module->getVar('name') . '&nbsp;' . sprintf('(%2.2f)', $target_module->getVar('version') / 100.0);
    $query4redirect = '?dirname=' . urlencode(strip_tags($_GET['dirname']));
} elseif (isset($_GET['mid']) && $_GET['mid'] == 0 || $xoopsModule->getVar('dirname') === 'blocksadmin') {
    $target_mid     = 0;
    $target_mname   = '';
    $query4redirect = '?mid=0';
} else {
    $target_mid     = $xoopsModule->getVar('mid');
    $target_mname   = $xoopsModule->getVar('name');
    $query4redirect = '';
}

// check access right (needs system_admin of BLOCK)
$syspermHandler = xoops_getHandler('groupperm');
if (!$syspermHandler->checkRight('system_admin', XOOPS_SYSTEM_BLOCK, $xoopsUser->getGroups())) {

    redirect_header(XOOPS_URL . '/user.php', 1, _NOPERM);
}

// get blocks owned by the module (Imported from xoopsblock.php then modified)
$db        = XoopsDatabaseFactory::getDatabaseConnection();
$sql       = 'SELECT bid,name,show_func,func_file,template FROM ' . $db->prefix('newblocks') . " WHERE mid='$target_mid'";
$result    = $db->query($sql);
$block_arr = array();
while (list($bid, $bname, $show_func, $func_file, $template) = $db->fetchRow($result)) {
    $block_arr[$bid] = array(
        'name'      => $bname,
        'show_func' => $show_func,
        'func_file' => $func_file,
        'template'  => $template
    );
}

// for 2.2
function list_blockinstances()
{
    global $query4redirect, $block_arr, $xoopsGTicket;
function myFunction($a, $b) {
    // Do something
}

    $myts = MyTextSanitizer::getInstance();

    // cachetime options
    $cachetimes = array(
        '0'       => _NOCACHE,
        '30'      => sprintf(_SECONDS, 30),
        '60'      => _MINUTE,
        '300'     => sprintf(_MINUTES, 5),
        '1800'    => sprintf(_MINUTES, 30),
        '3600'    => _HOUR,
        '18000'   => sprintf(_HOURS, 5),
        '86400'   => _DAY,
        '259200'  => sprintf(_DAYS, 3),
        '604800'  => _WEEK,
        '2592000' => _MONTH
    );

    // displaying TH
    echo "
    <form action='admin.php' name='blockadmin' method='post'>
        <table width='95%' class='outer' cellpadding='4' cellspacing='1'>
        <tr valign='middle'>
            <th>" . _AM_TITLE . "</th>
            <th align='center' nowrap='nowrap'>" . _AM_SIDE . "</th>
            <th align='center'>" . _AM_WEIGHT . "</th>
            <th align='center'>" . _AM_VISIBLEIN . "</th>
            <th align='center'>" . _AM_BCACHETIME . "</th>
            <th align='right'>" . _AM_ACTION . "</th>
        </tr>\n";

    // get block instances
    $crit     = new Criteria('bid', '(' . implode(',', array_keys($block_arr)) . ')', 'IN');
    $criteria = new CriteriaCompo($crit);
    $criteria->setSort('visible DESC, side ASC, weight');
    $instanceHandler = xoops_getHandler('blockinstance');
    $instances       =& $instanceHandler->getObjects($criteria, true, true);

    //Get modules and pages for visible in
    $module_list[_AM_SYSTEMLEVEL]['0-2'] = _AM_ADMINBLOCK;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    $module_list[_AM_SYSTEMLEVEL]['0-1'] = _AM_TOPPAGE;
    $module_list[_AM_SYSTEMLEVEL]['0-0'] = _AM_ALLPAGES;
    $criteria                            = new CriteriaCompo(new Criteria('hasmain', 1));
    $criteria->add(new Criteria('isactive', 1));
    /** @var XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $module_main   = $moduleHandler->getObjects($criteria, true, true);
    if (count($module_main) > 0) {
        foreach (array_keys($module_main) as $mid) {
            $module_list[$module_main[$mid]->getVar('name')][$mid . '-0'] = _AM_ALLMODULEPAGES;
            $pages                                                        = $module_main[$mid]->getInfo('pages');
            if ($pages === false) {
                $pages = $module_main[$mid]->getInfo('sub');
            }
            if (is_array($pages) && $pages != array()) {
                foreach ($pages as $id => $pageinfo) {
                    $module_list[$module_main[$mid]->getVar('name')][$mid . '-' . $id] = $pageinfo['name'];
                }
            }
        }
    }

    // blocks displaying loop
    $class         = 'even';
    $block_configs = get_block_configs();
    foreach (array_keys($instances) as $i) {
        $sseln = $ssel0 = $ssel1 = $ssel2 = $ssel3 = $ssel4 = '';
        $scoln = $scol0 = $scol1 = $scol2 = $scol3 = $scol4 = '#FFFFFF';

        $weight     = $instances[$i]->getVar('weight');
        $title      = $instances[$i]->getVar('title');
        $bcachetime = $instances[$i]->getVar('bcachetime');
        $bid        = $instances[$i]->getVar('bid');
        $name       = $myts->makeTboxData4Edit($block_arr[$bid]['name']);

        $visiblein = $instances[$i]->getVisibleIn();

        // visible and side
        if ($instances[$i]->getVar('visible') != 1) {
            $sseln = ' checked';
            $scoln = '#FF0000';
        } else {
            switch ($instances[$i]->getVar('side')) {
                default:
                case XOOPS_SIDEBLOCK_LEFT:
                    $ssel0 = ' checked';
                    $scol0 = '#00FF00';
                    break;
                case XOOPS_SIDEBLOCK_RIGHT:
                    $ssel1 = ' checked';
                    $scol1 = '#00FF00';
                    break;
                case XOOPS_CENTERBLOCK_LEFT:
                    $ssel2 = ' checked';
                    $scol2 = '#00FF00';
                    break;
                case XOOPS_CENTERBLOCK_RIGHT:
                    $ssel4 = ' checked';
                    $scol4 = '#00FF00';
                    break;
                case XOOPS_CENTERBLOCK_CENTER:
                    $ssel3 = ' checked';
                    $scol3 = '#00FF00';
                    break;
            }
        }

        // bcachetime
        $cachetime_options = '';
        foreach ($cachetimes as $cachetime => $cachetime_name) {

            if ($bcachetime == $cachetime) {
                $cachetime_options .= "<option value='$cachetime' selected>$cachetime_name</option>\n";
            } else {
                $cachetime_options .= "<option value='$cachetime'>$cachetime_name</option>\n";
            }
        }

        $module_options = '';
        foreach ($module_list as $mname => $module) {
            $module_options .= "<optgroup label='$mname'>\n";
            foreach ($module as $mkey => $mval) {
                if (in_array($mkey, $visiblein)) {
                    $module_options .= "<option value='$mkey' selected>$mval</option>\n";
                } else {
                    $module_options .= "<option label='$mval' value='$mkey'>$mval</option>\n";
                }
            }
            $module_options .= "</optgroup>\n";
        }

        // delete link if it is cloned block
        $delete_link = "<br><a href='" . XOOPS_URL . "/modules/system/admin.php?fct=blocksadmin&amp;op=delete&amp;id=$i&amp;selmod=$mid'>" . _DELETE . '</a>';
foreach ($a as $b) {
}

// $b is defined here only if $a has elements, for example if $a is array()
// then $b would not be defined here. To avoid that, we recommend to set a
// default value for $b.


// Better
$b = 0; // or whatever default makes sense in your context
foreach ($a as $b) {
}

// $b is now guaranteed to be defined here.

        // displaying part
        echo "
        <tr valign='middle'>
            <td class='$class'>
                $name
                <br>
                <input type='text' name='title[$i]' value='$title' size='20' />
            </td>
            <td class='$class' align='center' nowrap='nowrap' width='125px'>
                <div style='float:left;background-color:$scol0;'>
                    <input type='radio' name='side[$i]' value='" . XOOPS_SIDEBLOCK_LEFT . "' style='background-color:$scol0;' $ssel0 />
                </div>
                <div style='float:left;'>-</div>
                <div style='float:left;background-color:$scol2;'>
                    <input type='radio' name='side[$i]' value='" . XOOPS_CENTERBLOCK_LEFT . "' style='background-color:$scol2;' $ssel2 />
                </div>
                <div style='float:left;background-color:$scol3;'>
                    <input type='radio' name='side[$i]' value='" . XOOPS_CENTERBLOCK_CENTER . "' style='background-color:$scol3;' $ssel3 />
                </div>
                <div style='float:left;background-color:$scol4;'>
                    <input type='radio' name='side[$i]' value='" . XOOPS_CENTERBLOCK_RIGHT . "' style='background-color:$scol4;' $ssel4 />
                </div>
                <div style='float:left;'>-</div>
                <div style='float:left;background-color:$scol1;'>
                    <input type='radio' name='side[$i]' value='" . XOOPS_SIDEBLOCK_RIGHT . "' style='background-color:$scol1;' $ssel1 />
                </div>
                <br>
                <br>
                <div style='float:left;width:40px;'>&nbsp;</div>
                <div style='float:left;background-color:$scoln;'>
                    <input type='radio' name='side[$i]' value='-1' style='background-color:$scoln;' $sseln />
                </div>
                <div style='float:left;'>" . _NONE . "</div>
            </td>
            <td class='$class' align='center'>
                <input type='text' name=weight[$i] value='$weight' size='3' maxlength='5' style='text-align:right;' />
            </td>
            <td class='$class' align='center'>
                <select name='bmodule[$i][]' size='5' multiple='multiple'>
                    $module_options
                </select>
            </td>
            <td class='$class' align='center'>
                <select name='bcachetime[$i]' size='1'>
                    $cachetime_options
                </select>
            </td>
            <td class='$class' align='right'>
                <a href='" . XOOPS_URL . "/modules/system/admin.php?fct=blocksadmin&amp;op=edit&amp;id=$i'>" . _EDIT . "</a>{$delete_link}
                <input type='hidden' name='id[$i]' value='$i' />
            </td>
        </tr>\n";

        $class = ($class === 'even') ? 'odd' : 'even';
    }

    // list block classes for add (not instances)
    foreach ($block_arr as $bid => $block) {
        $description4show = '';
        foreach ($block_configs as $bconf) {

            if ($block['show_func'] == $bconf['show_func'] && $block['func_file'] == $bconf['file']
                && (empty($bconf['template']) || $block['template'] == $bconf['template'])
            ) {
                if (!empty($bconf['description'])) {
                    $description4show = $myts->htmlSpecialChars($bconf['description']);
                }
            }
        }

        echo "
        <tr>
            <td class='$class' align='left'>
                " . $myts->makeTboxData4Edit($block['name']) . "
            </td>
            <td class='$class' align='left' colspan='4'>
                $description4show
            </td>
            <td class='$class' align='center'>
                <input type='submit' name='addblock[$bid]' value='" . _ADD . "' />
            </td>
        </tr>
        \n";
        $class = ($class === 'even') ? 'odd' : 'even';
    }

    echo "
        <tr>
            <td class='foot' align='center' colspan='6'>
                <input type='hidden' name='query4redirect' value='$query4redirect' />
                <input type='hidden' name='fct' value='blocksadmin' />
                <input type='hidden' name='op' value='order2' />
                " . $xoopsGTicket->getTicketHtml(__LINE__, 1800, 'myblocksadmin') . "
                <input type='submit' name='submit' value='" . _SUBMIT . "' />
            </td>
        </tr>
        </table>
    </form>\n";
}

// for 2.2
function list_groups2()
{
    global $target_mid, $target_mname, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $result = $xoopsDB->query('SELECT i.instanceid,i.title FROM '
                              . $xoopsDB->prefix('block_instance')
                              . ' i LEFT JOIN '
                              . $xoopsDB->prefix('newblocks')
                              . " b ON i.bid=b.bid WHERE b.mid='$target_mid'");

    $item_list = array();
    while (list($iid, $title) = $xoopsDB->fetchRow($result)) {
        $item_list[$iid] = $title;
    }

    $form = new MyXoopsGroupPermForm(_MD_AM_ADGS, 1, 'block_read', '');
    if ($target_mid > 1) {

        $form->addAppendix('module_admin', $target_mid, $target_mname . ' ' . _AM_ACTIVERIGHTS);
        $form->addAppendix('module_read', $target_mid, $target_mname . ' ' . _AM_ACCESSRIGHTS);
    }
    foreach ($item_list as $item_id => $item_name) {
        $form->addItem($item_id, $item_name);
    }
    echo $form->render();
}

if (!empty($_POST['submit'])) {

    if (!$xoopsGTicket->check(true, 'myblocksadmin')) {
        redirect_header(XOOPS_URL . '/', 3, $xoopsGTicket->getErrors());
    }

    include __DIR__ . '/mygroupperm.php';
    redirect_header(XOOPS_URL . '/modules/' . $xoopsModule->dirname() . "/admin/myblocksadmin.php$query4redirect", 1, _MD_AM_DBUPDATED);
}

xoops_cp_header();
//if( file_exists( './mymenu.php' ) ) include( './mymenu.php' ) ;

include_once XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->dirname() . '/admin/functions.php';
//lx_adminMenu(3, _AM_LEXIKON_BLOCKS);


//echo "<h3 style='text-align:left;'>$target_mname</h3>\n" ;

if (!empty($block_arr)) {
    echo "<h4 style='text-align:left;'>" . _AM_BADMIN . "</h4>\n";
    list_blockinstances();
}

list_groups2();
xoops_cp_footer();


Push — master ( c1777d...d193e2 )

myblocksadmin2.php ➔ list_groups2() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-06-01 03:48 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 88 and the first side effect is on line 8. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		// ------------------------------------------------------------------------- //
3		// myblocksadmin_for_2.2.php //
4		// - XOOPS block admin for each modules - //
5		// GIJOE <http://www.peak.ne.jp/> //
6		// ------------------------------------------------------------------------- //
7
8		defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
9
10		include_once __DIR__ . '/../../../include/cp_header.php';
11
12		include_once __DIR__ . '/mygrouppermform.php';
13		include_once XOOPS_ROOT_PATH . '/class/xoopsblock.php';
14		include_once __DIR__ . '/../include/gtickets.php';
15
16		$xoops_system_path = XOOPS_ROOT_PATH . '/modules/system';
17
18		// language files
19		$language = $xoopsConfig['language'];
20		if (!file_exists("$xoops_system_path/language/$language/admin/blocksadmin.php")) {
21		$language = 'english';
22		}
23
24		// to prevent from notice that constants already defined
25		$error_reporting_level = error_reporting(0);
26		include_once "$xoops_system_path/constants.php";
27		include_once "$xoops_system_path/language/$language/admin.php";
28		include_once "$xoops_system_path/language/$language/admin/blocksadmin.php";
29		error_reporting($error_reporting_level);
30
31		$group_defs = file("$xoops_system_path/language/$language/admin/groups.php");
32	View Code Duplication	foreach ($group_defs as $def) {
		0 ignored issues – show Duplication introduced 2017-02-06 16:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		if (false !== strpos($def, '_AM_ACCESSRIGHTS') \|\| false !== strpos($def, '_AM_ACTIVERIGHTS')) {
34		eval($def);
35		}
36		}
37
38		// check $xoopsModule

XoopsModules25x / lexikon

Push — master ( c1777d...d193e2 )

myblocksadmin2.php ➔ list_groups2() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like