XoopsModules25x /
lexikon
| Conditions | 28 |
| Paths | 2881 |
| Total Lines | 199 |
| Code Lines | 132 |
| Lines | 12 |
| Ratio | 6.03 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 78 | function list_blocks() { |
||
| 79 | global $query4redirect , $block_arr , $xoopsGTicket ; |
||
| 80 | |||
| 81 | // cachetime options |
||
| 82 | $cachetimes = array('0' => _NOCACHE, '30' => sprintf(_SECONDS, 30), '60' => _MINUTE, '300' => sprintf(_MINUTES, 5), '1800' => sprintf(_MINUTES, 30), '3600' => _HOUR, '18000' => sprintf(_HOURS, 5), '86400' => _DAY, '259200' => sprintf(_DAYS, 3), '604800' => _WEEK, '2592000' => _MONTH); |
||
| 83 | |||
| 84 | // displaying TH |
||
| 85 | lx_collapsableBar('default', 'defaultIcon'); |
||
| 86 | echo "<img onclick=\"toggle('default'); toggleIcon('defaultIcon');\" id='defaultIcon' src='" . XOOPS_URL . "/modules/lexikon/images/close12.gif' alt='' /></a> "._AM_BADMIN."<br /><br />"; |
||
| 87 | echo "<div id='default' style='float:left; width:100%;'>"; |
||
| 88 | echo " |
||
| 89 | <form action='admin.php' name='blockadmin' method='post'> |
||
| 90 | <table width='95%' class='outer' cellpadding='4' cellspacing='1'> |
||
| 91 | <tr valign='middle'> |
||
| 92 | <th>"._AM_TITLE."</th> |
||
| 93 | <th align='center' nowrap='nowrap'>"._AM_SIDE."<div style='font-size:smaller'>"._LEFT."-"._CENTER."-"._RIGHT."</div></th> |
||
| 94 | <th align='center'>"._AM_WEIGHT."</th> |
||
| 95 | <th align='center'>"._AM_VISIBLEIN."</th> |
||
| 96 | <th align='center'>"._AM_BCACHETIME."</th> |
||
| 97 | <th align='right'>"._AM_ACTION."</th> |
||
| 98 | </tr>\n" ; |
||
| 99 | |||
| 100 | // blocks displaying loop |
||
| 101 | $class = 'even' ; |
||
| 102 | $block_configs = get_block_configs() ; |
||
| 103 | foreach( array_keys( $block_arr ) as $i ) { |
||
| 104 | $sseln = $ssel0 = $ssel1 = $ssel2 = $ssel3 = $ssel4 = $ssel5 = $ssel6 = $ssel7 = ""; |
||
| 105 | $scoln = $scol0 = $scol1 = $scol2 = $scol3 = $scol4 = $ssel5 = $ssel6 = $ssel7 = ""; |
||
| 106 | |||
| 107 | $weight = $block_arr[$i]->getVar("weight") ; |
||
| 108 | $title = $block_arr[$i]->getVar("title") ; |
||
| 109 | $name = $block_arr[$i]->getVar("name") ; |
||
| 110 | $bcachetime = $block_arr[$i]->getVar("bcachetime") ; |
||
| 111 | $bid = $block_arr[$i]->getVar("bid") ; |
||
| 112 | |||
| 113 | // visible and side |
||
| 114 | if ( $block_arr[$i]->getVar("visible") != 1 ) { |
||
| 115 | $sseln = " checked='checked'"; |
||
| 116 | $scoln = "#FF9966"; |
||
| 117 | } else switch( $block_arr[$i]->getVar("side") ) { |
||
| 118 | default : |
||
| 119 | case XOOPS_SIDEBLOCK_LEFT : |
||
| 120 | $ssel0 = " checked='checked'"; |
||
| 121 | $scol0 = "#00FF00"; |
||
| 122 | break ; |
||
| 123 | case XOOPS_SIDEBLOCK_RIGHT : |
||
| 124 | $ssel1 = " checked='checked'"; |
||
| 125 | $scol1 = "#00FF00"; |
||
| 126 | break ; |
||
| 127 | case XOOPS_CENTERBLOCK_LEFT : |
||
| 128 | $ssel2 = " checked='checked'"; |
||
| 129 | $scol2 = "#00FF00"; |
||
| 130 | break ; |
||
| 131 | case XOOPS_CENTERBLOCK_RIGHT : |
||
| 132 | $ssel4 = " checked='checked'"; |
||
| 133 | $scol4 = "#00FF00"; |
||
| 134 | break ; |
||
| 135 | case XOOPS_CENTERBLOCK_CENTER : |
||
| 136 | $ssel3 = " checked='checked'"; |
||
| 137 | $scol3 = "#00FF00"; |
||
| 138 | break ; |
||
| 139 | case XOOPS_CENTERBLOCK_BOTTOMLEFT : |
||
| 140 | $ssel5 = " checked='checked'"; |
||
| 141 | $scol5 = "#00FF00"; |
||
| 142 | break ; |
||
| 143 | case XOOPS_CENTERBLOCK_BOTTOMRIGHT : |
||
| 144 | $ssel6 = " checked='checked'"; |
||
| 145 | $scol6 = "#00FF00"; |
||
| 146 | break ; |
||
| 147 | case XOOPS_CENTERBLOCK_BOTTOM : |
||
| 148 | $ssel7 = " checked='checked'"; |
||
| 149 | $scol7 = "#00FF00"; |
||
| 150 | break ; |
||
| 151 | } |
||
| 152 | |||
| 153 | // bcachetime |
||
| 154 | $cachetime_options = '' ; |
||
| 155 | View Code Duplication | foreach( $cachetimes as $cachetime => $cachetime_name ) { |
|
| 156 | if( $bcachetime == $cachetime ) { |
||
| 157 | $cachetime_options .= "<option value='$cachetime' selected='selected'>$cachetime_name</option>\n" ; |
||
| 158 | } else { |
||
| 159 | $cachetime_options .= "<option value='$cachetime'>$cachetime_name</option>\n" ; |
||
| 160 | } |
||
| 161 | } |
||
| 162 | |||
| 163 | // target modules |
||
| 164 | $db =& XoopsDatabaseFactory::getDatabaseConnection(); |
||
| 165 | $result = $db->query( "SELECT module_id FROM ".$db->prefix('block_module_link')." WHERE block_id='$bid'" ) ; |
||
| 166 | $selected_mids = array(); |
||
| 167 | while ( list( $selected_mid ) = $db->fetchRow( $result ) ) { |
||
| 168 | $selected_mids[] = intval( $selected_mid ) ; |
||
| 169 | } |
||
| 170 | $module_handler =& xoops_gethandler('module'); |
||
| 171 | $criteria = new CriteriaCompo(new Criteria('hasmain', 1)); |
||
| 172 | $criteria->add(new Criteria('isactive', 1)); |
||
| 173 | $module_list =& $module_handler->getList($criteria); |
||
| 174 | $module_list[-1] = _AM_TOPPAGE; |
||
| 175 | $module_list[0] = _AM_ALLPAGES; |
||
| 176 | ksort($module_list); |
||
| 177 | $module_options = '' ; |
||
| 178 | foreach( $module_list as $mid => $mname ) { |
||
| 179 | if( in_array( $mid , $selected_mids ) ) { |
||
| 180 | $module_options .= "<option value='$mid' selected='selected'>$mname</option>\n" ; |
||
| 181 | } else { |
||
| 182 | $module_options .= "<option value='$mid'>$mname</option>\n" ; |
||
| 183 | } |
||
| 184 | } |
||
| 185 | |||
| 186 | // delete link if it is cloned block |
||
| 187 | if( $block_arr[$i]->getVar("block_type") == 'D' || $block_arr[$i]->getVar("block_type") == 'C' ) { |
||
| 188 | $delete_link = "<br /><a href='admin.php?fct=blocksadmin&op=delete&bid=$bid'>"._DELETE."</a>" ; |
||
| 189 | } else { |
||
| 190 | $delete_link = '' ; |
||
| 191 | } |
||
| 192 | |||
| 193 | // clone link if it is marked as cloneable block |
||
| 194 | // $modversion['blocks'][n]['can_clone'] |
||
| 195 | if( $block_arr[$i]->getVar("block_type") == 'D' || $block_arr[$i]->getVar("block_type") == 'C' ) { |
||
| 196 | $can_clone = true ; |
||
| 197 | } else { |
||
| 198 | $can_clone = false ; |
||
| 199 | View Code Duplication | foreach( $block_configs as $bconf ) { |
|
| 200 | if( $block_arr[$i]->getVar("show_func") == $bconf['show_func'] && $block_arr[$i]->getVar("func_file") == $bconf['file'] && ( empty( $bconf['template'] ) || $block_arr[$i]->getVar("template") == $bconf['template'] ) ) { |
||
| 201 | if( ! empty( $bconf['can_clone'] ) ) $can_clone = true ; |
||
| 202 | } |
||
| 203 | } |
||
| 204 | } |
||
| 205 | if( $can_clone ) { |
||
| 206 | $clone_link = "<br /><a href='admin.php?fct=blocksadmin&op=clone&bid=$bid'>"._CLONE."</a>" ; |
||
| 207 | } else { |
||
| 208 | $clone_link = '' ; |
||
| 209 | } |
||
| 210 | |||
| 211 | // displaying part |
||
| 212 | echo " |
||
| 213 | <tr valign='middle'> |
||
| 214 | <td class='$class'> |
||
| 215 | $name |
||
| 216 | <br /> |
||
| 217 | <input type='text' name='title[$bid]' value='$title' size='20' /> |
||
| 218 | </td> |
||
| 219 | <td class='$class' align='center' nowrap='nowrap' width='125px'> |
||
| 220 | <div align='center' > |
||
| 221 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_LEFT."'$ssel2 /> |
||
| 222 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_CENTER."'$ssel3 /> |
||
| 223 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_RIGHT."'$ssel4 /> |
||
| 224 | </div> |
||
| 225 | <div> |
||
| 226 | <span style='float:right'><input type='radio' name='side[$bid]' value='".XOOPS_SIDEBLOCK_RIGHT."'$ssel1 /></span> |
||
| 227 | <div align='left'><input type='radio' name='side[$bid]' value='".XOOPS_SIDEBLOCK_LEFT."'$ssel0 /></div> |
||
| 228 | </div> |
||
| 229 | <div align='center'> |
||
| 230 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_BOTTOMLEFT."'$ssel5 /> |
||
| 231 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_BOTTOM."'$ssel7 /> |
||
| 232 | <input type='radio' name='side[$bid]' value='".XOOPS_CENTERBLOCK_BOTTOMRIGHT."'$ssel6 /> |
||
| 233 | </div> |
||
| 234 | <br /> |
||
| 235 | <div style='float:left;width:30%;'> </div> |
||
| 236 | <div style='float:left;background-color:$scoln;'> |
||
| 237 | <input type='radio' name='side[$bid]' value='-1' $sseln /> |
||
| 238 | </div> |
||
| 239 | <div style='float:left;'>"._NONE."</div> |
||
| 240 | </td> |
||
| 241 | <td class='$class' align='center'> |
||
| 242 | <input type='text' name=weight[$bid] value='$weight' size='3' maxlength='5' style='text-align:right;' /> |
||
| 243 | </td> |
||
| 244 | <td class='$class' align='center'> |
||
| 245 | <select name='bmodule[$bid][]' size='5' multiple='multiple'> |
||
| 246 | $module_options |
||
| 247 | </select> |
||
| 248 | </td> |
||
| 249 | <td class='$class' align='center'> |
||
| 250 | <select name='bcachetime[$bid]' size='1'> |
||
| 251 | $cachetime_options |
||
| 252 | </select> |
||
| 253 | </td> |
||
| 254 | <td class='$class' align='right'> |
||
| 255 | <a href='admin.php?fct=blocksadmin&op=edit&bid=$bid'>"._EDIT."</a>{$delete_link}{$clone_link} |
||
| 256 | <input type='hidden' name='bid[$bid]' value='$bid' /> |
||
| 257 | </td> |
||
| 258 | </tr>\n" ; |
||
| 259 | |||
| 260 | $class = ( $class == 'even' ) ? 'odd' : 'even' ; |
||
| 261 | } |
||
| 262 | |||
| 263 | echo " |
||
| 264 | <tr> |
||
| 265 | <td class='foot' align='center' colspan='6'> |
||
| 266 | <input type='hidden' name='query4redirect' value='$query4redirect' /> |
||
| 267 | <input type='hidden' name='fct' value='blocksadmin' /> |
||
| 268 | <input type='hidden' name='op' value='order' /> |
||
| 269 | ".$xoopsGTicket->getTicketHtml( __LINE__ , 1800 , 'myblocksadmin' )." |
||
| 270 | <input type='submit' name='submit' value='"._SUBMIT."' /> |
||
| 271 | </td> |
||
| 272 | </tr> |
||
| 273 | </table> |
||
| 274 | </form>\n" ; |
||
| 275 | echo "</div>"; |
||
| 276 | } |
||
| 277 | |||
| 332 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.