admin/category.php ➔ categorySave()

Complexity

Conditions	19
Paths	6144

Size

Total Lines	83
Code Lines	65

Duplication

Lines	9
Ratio	10.84 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function categorySave ($categoryID = '') {

categorySave uses the super-global variable $_POST which is generally not recommended.

categorySave uses the super-global variable $_GET which is generally not recommended.

categorySave uses the super-global variable $_FILES which is generally not recommended.

    include_once XOOPS_ROOT_PATH."/class/xoopsformloader.php";
    include_once XOOPS_ROOT_PATH."/class/uploader.php";
    Global $xoopsUser, $xoopsConfig, $xoopsModuleConfig, $xoopsModule, $xoopsDB, $myts, $categoryID;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

    //print_r ($_POST);

67% of this comment could be valid code. Did you maybe forget this after debugging?

    $categoryID = isset( $_POST['categoryID'] ) ? intval( $_POST['categoryID'] ) : intval( $_GET['categoryID'] );
    $weight = isset($_POST['weight'] ) ? intval($_POST['weight']) : intval($_GET['weight']);
    $name = isset($_POST['name'] ) ? htmlSpecialChars($_POST['name']) : htmlSpecialChars($_GET['name']);

$name is not used, you could remove the assignment.

    $description = isset($_POST['description'] ) ? htmlSpecialChars($_POST['description']) : htmlSpecialChars($_GET['description']);
    //$description = $myts->xoopsCodeDecode($description, $allowimage = 0);

56% of this comment could be valid code. Did you maybe forget this after debugging?

    $description = $myts -> xoopsCodeDecode($myts->censorString($description), $allowimage = 1);
    $name = $myts->addSlashes($_POST['name']);
    $logourl = $myts->addSlashes($_POST["logourl"]);

$logourl is not used, you could remove the assignment.

    $groups = isset($_POST['groups']) ? $_POST['groups'] : array();
    // image upload
    $logourl = "";
    $maxfilesize = 30000;
    $maxfilewidth = 128;
    $maxfileheight = 128;
      if (!empty($_FILES['userfile']['name'])) {
        $allowed_mimetypes = array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png');
        $uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH ."/modules/".$xoopsModule->getVar('dirname')."/images/uploads/", $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
        if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
          if (!$uploader->upload()) {
             echo $uploader->getErrors();
          } else {
             echo '<h4>'._AM_LEXIKON_FILESUCCESS.'</h4>';
             $logourl = $uploader->getSavedFileName();
          }
        } else {
          echo $uploader->getErrors();
        }
     }
    $logourl = empty($logourl)?(empty($_POST['logourl'])?"":$_POST['logourl']):$logourl;
    
    // Run the query and update the data
    if ( !$_POST['categoryID'] ) {
        if ( $xoopsDB -> query( "INSERT INTO " . $xoopsDB -> prefix( "lxcategories" ) . " (categoryID, name, description, weight, logourl)
								 VALUES ('', '$name', '$description', '$weight', '$logourl')" ) ) {
            $newid = $xoopsDB->getInsertId();
            // Increment author's posts count (only if it's a new definition)
            if (is_object($xoopsUser) && empty($categoryID)) {

This code seems to be duplicated across your project.

                $member_handler = &xoops_gethandler('member');
                $submitter =& $member_handler -> getUser($uid);

The variable $uid does not exist. Did you forget to declare it?

                if (is_object($submitter) ) {
                    $submitter -> setVar('posts',$submitter -> getVar('posts') + 1);
                    $res=$member_handler -> insertUser($submitter, true);

$res is not used, you could remove the assignment.

                    unset($submitter);
                }
            }
            //notification
            if(!empty($xoopsModuleConfig['notification_enabled']) ){
                if ($newid == 0) {
                    $newid = $xoopsDB -> getInsertId();
                }
                global $xoopsModule;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

                $notification_handler =& xoops_gethandler('notification');
                $tags = array();
                $tags['ITEM_NAME'] = $name;
                $tags['ITEM_URL'] = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/category.php?categoryID=' . $newid;
                $notification_handler->triggerEvent( 'global', 0, 'new_category', $tags);
            }
            lx_save_Permissions($groups, $categoryID, "lexikon_view");
            redirect_header( "category.php", 1, _AM_LEXIKON_CATCREATED );
            exit();

The function categorySave() contains an exit expression.

        } else {
            redirect_header( "index.php", 1, _AM_LEXIKON_NOTUPDATED );
            exit();

The function categorySave() contains an exit expression.

        }
    } else {
        if ( $xoopsDB -> queryF( "
								UPDATE " . $xoopsDB -> prefix( "lxcategories" ) . "
								SET name = '$name', description = '$description', weight = '$weight' , logourl = '$logourl'
								WHERE categoryID = '$categoryID'" ) ) {
            lx_save_Permissions($groups, $categoryID, "lexikon_view");
            redirect_header( "category.php", 1, _AM_LEXIKON_CATMODIFIED );
            exit();

The function categorySave() contains an exit expression.

        } else {
            redirect_header( "index.php", 1, _AM_LEXIKON_NOTUPDATED );
            exit();

The function categorySave() contains an exit expression.

        }
    }
}