Issues in Resizer.php (master) - Issues in master - XoopsModules25x/groupmanager - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/Common/Resizer.php (2 issues)

Labels

Severity

Minor 2

<?php

namespace XoopsModules\Groupmanager\Common;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Image resizer class for xoops
 *
 * @copyright      2000-2020 XOOPS Project (https://xoops.org)
 * @license        GPL 2.0 or later
 * @package        XOOPS common
 * @since          1.0
 * @min_xoops      2.5.9
 * @author         Goffy - Wedega - Email:<[email protected]> - Website:<https://wedega.com>
 */
class Resizer
{
    public $sourceFile    = '';
    public $endFile       = '';
    public $maxWidth      = 0;
    public $maxHeight     = 0;
    public $imageMimetype = '';
    public $jpgQuality    = 90;
    public $mergeType     = 0;
    public $mergePos      = 0;
    public $degrees       = 0;
    public $error         = '';

    /**
     * resize image if size exceed given width/height
     * @return string|bool
     */
    public function resizeImage()
    {
        // check file extension
        switch ($this->imageMimetype) {
            case 'image/png':
                $img = \imagecreatefrompng($this->sourceFile);
                break;
            case 'image/jpeg':
                $img = \imagecreatefromjpeg($this->sourceFile);
                if (!$img) {
                    $img = \imagecreatefromstring(file_get_contents($this->sourceFile));
                }
                break;
            case 'image/gif':
                $img = \imagecreatefromgif($this->sourceFile);
                break;
            default:
                return 'Unsupported format';
        }

        $width  = \imagesx($img);
        $height = \imagesy($img);

        if ($width > $this->maxWidth || $height > $this->maxHeight) {
            // recalc image size based on this->maxWidth/this->maxHeight
            if ($width > $height) {
                if ($width < $this->maxWidth) {
                    $new_width = $width;
                } else {
                    $new_width  = $this->maxWidth;
                    $divisor    = $width / $new_width;
                    $new_height = \floor($height / $divisor);
                }
            } elseif ($height < $this->maxHeight) {
                $new_height = $height;
            } else {
                $new_height = $this->maxHeight;
                $divisor    = $height / $new_height;
                $new_width  = \floor($width / $divisor);
            }

            // Create a new temporary image.
            $tmpimg = \imagecreatetruecolor($new_width, $new_height);

            imagealphablending($tmpimg, false);
            imagesavealpha($tmpimg, true);

            // Copy and resize old image into new image.
            \imagecopyresampled($tmpimg, $img, 0, 0, 0, 0, $new_width, $new_height, $width, $height);

            \unlink($this->endFile);
            //compressing the file
            switch ($this->imageMimetype) {
                case 'image/png':
                    \imagepng($tmpimg, $this->endFile, 0);
                    break;
                case 'image/jpeg':
                    \imagejpeg($tmpimg, $this->endFile, 100);
                    break;
                case 'image/gif':
                    \imagegif($tmpimg, $this->endFile);
                    break;
            }

            // release the memory
            \imagedestroy($tmpimg);
        } else {
            return 'copy';
        }
        \imagedestroy($img);

        return true;
    }

    /**
     * @return bool|string
     */
    public function resizeAndCrop()
    {
        // check file extension
        switch ($this->imageMimetype) {
            case 'image/png':
                $original = \imagecreatefrompng($this->sourceFile);
                break;
            case 'image/jpeg':
                $original = \imagecreatefromjpeg($this->sourceFile);
                break;
            case 'image/gif':
                $original = \imagecreatefromgif($this->sourceFile);
                break;
            default:
                return 'Unsupported format';
        }

        if (!$original) {
            return false;
        }
        // GET ORIGINAL IMAGE DIMENSIONS
        [$original_w, $original_h] = \getimagesize($this->sourceFile);

        // RESIZE IMAGE AND PRESERVE PROPORTIONS
        $max_width_resize  = $this->maxWidth;
        $max_height_resize = $this->maxHeight;
        if ($original_w > $original_h) {
            $max_height_ratio = $this->maxHeight / $original_h;
            $max_width_resize = (int)\round($original_w * $max_height_ratio);
        } else {
            $max_width_ratio   = $this->maxWidth / $original_w;
            $max_height_resize = (int)\round($original_h * $max_width_ratio);
        }
        if ($max_width_resize < $this->maxWidth) {
            $max_height_ratio  = $this->maxWidth / $max_width_resize;
            $max_height_resize = (int)\round($this->maxHeight * $max_height_ratio);
            $max_width_resize  = $this->maxWidth;
        }

        // CREATE THE PROPORTIONAL IMAGE RESOURCE
        $thumb = \imagecreatetruecolor($max_width_resize, $max_height_resize);
        if (!\imagecopyresampled($thumb, $original, 0, 0, 0, 0, $max_width_resize, $max_height_resize, $original_w, $original_h)) {
            return false;
        }
        // CREATE THE CENTERED CROPPED IMAGE TO THE SPECIFIED DIMENSIONS
        $final = \imagecreatetruecolor($this->maxWidth, $this->maxHeight);

        $max_width_offset  = 0;
        $max_height_offset = 0;
        if ($this->maxWidth < $max_width_resize) {
            $max_width_offset = (int)\round(($max_width_resize - $this->maxWidth) / 2);
        } else {
            $max_height_offset = (int)\round(($max_height_resize - $this->maxHeight) / 2);
        }

        if (!\imagecopy($final, $thumb, 0, 0, $max_width_offset, $max_height_offset, $max_width_resize, $max_height_resize)) {
            return false;
        }
        // STORE THE FINAL IMAGE - WILL OVERWRITE $this->endFile
        if (!\imagejpeg($final, $this->endFile, $this->jpgQuality)) {
            return false;
        }

        return true;
    }

    /**
     *
     */
    public function mergeImage()
    {
        $dest = \imagecreatefromjpeg($this->endFile);
        $src  = \imagecreatefromjpeg($this->sourceFile);
        if (4 == $this->mergeType) {
            $imgWidth  = (int)\round($this->maxWidth / 2 - 1);
            $imgHeight = (int)\round($this->maxHeight / 2 - 1);
            $posCol2   = (int)\round($this->maxWidth / 2 + 1);
            $posRow2   = (int)\round($this->maxHeight / 2 + 1);
            switch ($this->mergePos) {
                case 1:
                    \imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
                    break;
                case 2:
                    \imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top right
                    break;
                case 3:
                    \imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
                    break;
                case 4:
                    \imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
                    break;
            }
        }
        if (6 == $this->mergeType) {
            $imgWidth  = (int)\round($this->maxWidth / 3 - 1);
            $imgHeight = (int)\round($this->maxHeight / 2 - 1);
            $posCol2   = (int)\round($this->maxWidth / 3 + 1);
            $posCol3   = $posCol2 + (int)\round($this->maxWidth / 3 + 1);
            $posRow2   = (int)\round($this->maxHeight / 2 + 1);

            switch ($this->mergePos) {
                case 1:
                    \imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
                    break;
                case 2:
                    \imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top center
                    break;
                case 3:
                    \imagecopy($dest, $src, $posCol3, 0, 0, 0, $imgWidth, $imgHeight); //top right
                    break;
                case 4:
                    \imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
                    break;
                case 5:
                    \imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom center
                    break;
                case 6:
                    \imagecopy($dest, $src, $posCol3, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
                    break;
            }
        }
        \imagejpeg($dest, $this->endFile);

        \imagedestroy($src);
        \imagedestroy($dest);
    }

    /**
     * @return bool|string
     */
    public function rotateImage()
    {
        // check file extension
        switch ($this->imageMimetype) {
            case 'image/png':
                $original = \imagecreatefrompng($this->sourceFile);
                break;
            case 'image/jpeg':
                $original = \imagecreatefromjpeg($this->sourceFile);
                break;
            case 'image/gif':
                $original = \imagecreatefromgif($this->sourceFile);
                break;
            default:
                return 'Unsupported format';
        }

        if (!$original) {
            return false;
        }
        // Rotate
        $tmpimg = \imagerotate($original, $this->degrees, 0);

        \unlink($this->endFile);
        //compressing the file
        switch ($this->imageMimetype) {
            case 'image/png':
                if (!\imagepng($tmpimg, $this->endFile, 0)) {
                    return false;
                }
                break;
            case 'image/jpeg':
                if (!\imagejpeg($tmpimg, $this->endFile, $this->jpgQuality)) {
                    return false;
                }
                break;
            case 'image/gif':
                if (!\imagegif($tmpimg, $this->endFile)) {
                    return false;
                }
                break;
        }

        // release the memory
        \imagedestroy($tmpimg);

        return true;
    }
}


1			<?php
2
3			namespace XoopsModules\Groupmanager\Common;
4
5			/*
6			You may not change or alter any portion of this comment or credits
7			of supporting developers from this source code or any supporting source code
8			which is considered copyrighted (c) material of the original comment or credit authors.
9
10			This program is distributed in the hope that it will be useful,
11			but WITHOUT ANY WARRANTY; without even the implied warranty of
12			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
13			*/
14
15			/**
16			* Image resizer class for xoops
17			*
18			* @copyright 2000-2020 XOOPS Project (https://xoops.org)
19			* @license GPL 2.0 or later
20			* @package XOOPS common
21			* @since 1.0
22			* @min_xoops 2.5.9
23			* @author Goffy - Wedega - Email:<[email protected]> - Website:<https://wedega.com>
24			*/
25			class Resizer
26			{
27			public $sourceFile = '';
28			public $endFile = '';
29			public $maxWidth = 0;
30			public $maxHeight = 0;
31			public $imageMimetype = '';
32			public $jpgQuality = 90;
33			public $mergeType = 0;
34			public $mergePos = 0;
35			public $degrees = 0;
36			public $error = '';
37
38			/**
39			* resize image if size exceed given width/height
40			* @return string\|bool
41			*/
42			public function resizeImage()
43			{
44			// check file extension
45			switch ($this->imageMimetype) {
46			case 'image/png':
47			$img = \imagecreatefrompng($this->sourceFile);
48			break;
49			case 'image/jpeg':
50			$img = \imagecreatefromjpeg($this->sourceFile);
51			if (!$img) {
52			$img = \imagecreatefromstring(file_get_contents($this->sourceFile));
53			}
54			break;
55			case 'image/gif':
56			$img = \imagecreatefromgif($this->sourceFile);
57			break;
58			default:
59			return 'Unsupported format';
60			}
61
62			$width = \imagesx($img);
63			$height = \imagesy($img);
64
65			if ($width > $this->maxWidth \|\| $height > $this->maxHeight) {
66			// recalc image size based on this->maxWidth/this->maxHeight
67			if ($width > $height) {
68			if ($width < $this->maxWidth) {
69			$new_width = $width;
70			} else {
71			$new_width = $this->maxWidth;
72			$divisor = $width / $new_width;
73			$new_height = \floor($height / $divisor);
74			}
75			} elseif ($height < $this->maxHeight) {
76			$new_height = $height;
77			} else {
78			$new_height = $this->maxHeight;
79			$divisor = $height / $new_height;
80			$new_width = \floor($width / $divisor);
81			}
82
83			// Create a new temporary image.
84			$tmpimg = \imagecreatetruecolor($new_width, $new_height);
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-01-26 06:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$new_height` does not seem to be defined for all execution paths leading up to this point. Loading history... Comprehensibility Best Practice introduced 2020-01-26 06:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$new_width` does not seem to be defined for all execution paths leading up to this point. Loading history...
85			imagealphablending($tmpimg, false);
86			imagesavealpha($tmpimg, true);
87
88			// Copy and resize old image into new image.
89			\imagecopyresampled($tmpimg, $img, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
90
91			\unlink($this->endFile);
92			//compressing the file
93			switch ($this->imageMimetype) {
94			case 'image/png':
95			\imagepng($tmpimg, $this->endFile, 0);
96			break;
97			case 'image/jpeg':
98			\imagejpeg($tmpimg, $this->endFile, 100);
99			break;
100			case 'image/gif':
101			\imagegif($tmpimg, $this->endFile);
102			break;
103			}
104
105			// release the memory
106			\imagedestroy($tmpimg);
107			} else {
108			return 'copy';
109			}
110			\imagedestroy($img);
111
112			return true;
113			}
114
115			/**
116			* @return bool\|string
117			*/
118			public function resizeAndCrop()
119			{
120			// check file extension
121			switch ($this->imageMimetype) {
122			case 'image/png':
123			$original = \imagecreatefrompng($this->sourceFile);
124			break;
125			case 'image/jpeg':
126			$original = \imagecreatefromjpeg($this->sourceFile);
127			break;
128			case 'image/gif':
129			$original = \imagecreatefromgif($this->sourceFile);
130			break;
131			default:
132			return 'Unsupported format';
133			}
134
135			if (!$original) {
136			return false;
137			}
138			// GET ORIGINAL IMAGE DIMENSIONS
139			[$original_w, $original_h] = \getimagesize($this->sourceFile);
140
141			// RESIZE IMAGE AND PRESERVE PROPORTIONS
142			$max_width_resize = $this->maxWidth;
143			$max_height_resize = $this->maxHeight;
144			if ($original_w > $original_h) {
145			$max_height_ratio = $this->maxHeight / $original_h;
146			$max_width_resize = (int)\round($original_w * $max_height_ratio);
147			} else {
148			$max_width_ratio = $this->maxWidth / $original_w;
149			$max_height_resize = (int)\round($original_h * $max_width_ratio);
150			}
151			if ($max_width_resize < $this->maxWidth) {
152			$max_height_ratio = $this->maxWidth / $max_width_resize;
153			$max_height_resize = (int)\round($this->maxHeight * $max_height_ratio);
154			$max_width_resize = $this->maxWidth;
155			}
156
157			// CREATE THE PROPORTIONAL IMAGE RESOURCE
158			$thumb = \imagecreatetruecolor($max_width_resize, $max_height_resize);
159			if (!\imagecopyresampled($thumb, $original, 0, 0, 0, 0, $max_width_resize, $max_height_resize, $original_w, $original_h)) {
160			return false;
161			}
162			// CREATE THE CENTERED CROPPED IMAGE TO THE SPECIFIED DIMENSIONS
163			$final = \imagecreatetruecolor($this->maxWidth, $this->maxHeight);
164
165			$max_width_offset = 0;
166			$max_height_offset = 0;
167			if ($this->maxWidth < $max_width_resize) {
168			$max_width_offset = (int)\round(($max_width_resize - $this->maxWidth) / 2);
169			} else {
170			$max_height_offset = (int)\round(($max_height_resize - $this->maxHeight) / 2);
171			}
172
173			if (!\imagecopy($final, $thumb, 0, 0, $max_width_offset, $max_height_offset, $max_width_resize, $max_height_resize)) {
174			return false;
175			}
176			// STORE THE FINAL IMAGE - WILL OVERWRITE $this->endFile
177			if (!\imagejpeg($final, $this->endFile, $this->jpgQuality)) {
178			return false;
179			}
180
181			return true;
182			}
183
184			/**
185			*
186			*/
187			public function mergeImage()
188			{
189			$dest = \imagecreatefromjpeg($this->endFile);
190			$src = \imagecreatefromjpeg($this->sourceFile);
191			if (4 == $this->mergeType) {
192			$imgWidth = (int)\round($this->maxWidth / 2 - 1);
193			$imgHeight = (int)\round($this->maxHeight / 2 - 1);
194			$posCol2 = (int)\round($this->maxWidth / 2 + 1);
195			$posRow2 = (int)\round($this->maxHeight / 2 + 1);
196			switch ($this->mergePos) {
197			case 1:
198			\imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
199			break;
200			case 2:
201			\imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top right
202			break;
203			case 3:
204			\imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
205			break;
206			case 4:
207			\imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
208			break;
209			}
210			}
211			if (6 == $this->mergeType) {
212			$imgWidth = (int)\round($this->maxWidth / 3 - 1);
213			$imgHeight = (int)\round($this->maxHeight / 2 - 1);
214			$posCol2 = (int)\round($this->maxWidth / 3 + 1);
215			$posCol3 = $posCol2 + (int)\round($this->maxWidth / 3 + 1);
216			$posRow2 = (int)\round($this->maxHeight / 2 + 1);
217
218			switch ($this->mergePos) {
219			case 1:
220			\imagecopy($dest, $src, 0, 0, 0, 0, $imgWidth, $imgHeight); //top left
221			break;
222			case 2:
223			\imagecopy($dest, $src, $posCol2, 0, 0, 0, $imgWidth, $imgHeight); //top center
224			break;
225			case 3:
226			\imagecopy($dest, $src, $posCol3, 0, 0, 0, $imgWidth, $imgHeight); //top right
227			break;
228			case 4:
229			\imagecopy($dest, $src, 0, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom left
230			break;
231			case 5:
232			\imagecopy($dest, $src, $posCol2, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom center
233			break;
234			case 6:
235			\imagecopy($dest, $src, $posCol3, $posRow2, 0, 0, $imgWidth, $imgHeight); //bottom right
236			break;
237			}
238			}
239			\imagejpeg($dest, $this->endFile);
240
241			\imagedestroy($src);
242			\imagedestroy($dest);
243			}
244
245			/**
246			* @return bool\|string
247			*/
248			public function rotateImage()
249			{
250			// check file extension
251			switch ($this->imageMimetype) {
252			case 'image/png':
253			$original = \imagecreatefrompng($this->sourceFile);
254			break;
255			case 'image/jpeg':
256			$original = \imagecreatefromjpeg($this->sourceFile);
257			break;
258			case 'image/gif':
259			$original = \imagecreatefromgif($this->sourceFile);
260			break;
261			default:
262			return 'Unsupported format';
263			}
264
265			if (!$original) {
266			return false;
267			}
268			// Rotate
269			$tmpimg = \imagerotate($original, $this->degrees, 0);
270
271			\unlink($this->endFile);
272			//compressing the file
273			switch ($this->imageMimetype) {
274			case 'image/png':
275			if (!\imagepng($tmpimg, $this->endFile, 0)) {
276			return false;
277			}
278			break;
279			case 'image/jpeg':
280			if (!\imagejpeg($tmpimg, $this->endFile, $this->jpgQuality)) {
281			return false;
282			}
283			break;
284			case 'image/gif':
285			if (!\imagegif($tmpimg, $this->endFile)) {
286			return false;
287			}
288			break;
289			}
290
291			// release the memory
292			\imagedestroy($tmpimg);
293
294			return true;
295			}
296			}
297

XoopsModules25x / groupmanager

Issues (36)

Security Analysis not enabled

class/Common/Resizer.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like