Issues in success.php (master) - Issues in master - XoopsModules25x/efqdirectory - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1149)

success.php (5 issues)

Labels

Security 5

Severity

Major 5

<?php
/*
* success.php
*
* PHP Toolkit for PayPal v0.51
* http://www.paypal.com/pdn
*
* Copyright (c) 2004 PayPal Inc
*
* Released under Common Public License 1.0
* http://opensource.org/licenses/cpl.php
*
*/
?>

<html>
<head><title>::Thank You::</title>
    <link rel="stylesheet" type="text/css" href="styles.css">
</head>

<body bgcolor="ffffff">
<br>
<br>
<table width="500" border="0" align="center" cellpadding="1" cellspacing="0">
    <tr>
        <td align="left" valign="top" bgcolor="#333333">
            <table width="100%" border="0" cellspacing="0" cellpadding="0">
                <tr>
                    <td align="center" bgcolor="#EEEEEE"><p>&nbsp;</p>
                        <p>Thank you! Your order has been successfully processed.</p>
                        <p>&nbsp;</p></td>
                </tr>
            </table>
        </td>
    </tr>
</table>
<br>
<table width="500" border="0" align="center" cellpadding="1" cellspacing="0">
    <tr>
        <td align="left" valign="top" bgcolor="#333333">
            <table width="100%" border="0" cellspacing="0" cellpadding="0">
                <tr align="left" valign="top">
                    <td width="20%" bgcolor="#EEEEEE">
                        <table width="100%" border="0" cellspacing="0" cellpadding="3">
                            <tr align="left" valign="top">
                                <td bgcolor="#EEEEEE">Order Number:</td>
                                <td bgcolor="#EEEEEE">
                                    <?= $_POST['txn_id'] ?>
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
                                </td>
                            </tr>
                            <tr align="left" valign="top">
                                <td bgcolor="#EEEEEE">Date:</td>
                                <td bgcolor="#EEEEEE">
                                    <?= $_POST['payment_date'] ?>
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
                                </td>
                            </tr>
                            <tr align="left" valign="top">
                                <td width="20%" bgcolor="#EEEEEE"> First Name:</td>
                                <td width="80%" bgcolor="#EEEEEE">
                                    <?= $_POST['first_name'] ?>
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
                                </td>
                            </tr>
                            <tr align="left" valign="top">
                                <td bgcolor="#EEEEEE">Last Name:</td>
                                <td bgcolor="#EEEEEE">
                                    <?= $_POST['last_name'] ?>
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
                                </td>
                            </tr>
                            <tr align="left" valign="top">
                                <td bgcolor="#EEEEEE">Email:</td>
                                <td bgcolor="#EEEEEE">
                                    <?= $_POST['payer_email'] ?>
// for HTML
$sanitized = htmlentities($tainted, ENT_QUOTES);

// for URLs
$sanitized = urlencode($tainted);
                                </td>
                            </tr>
                        </table>
                    </td>
                </tr>
            </table>
        </td>
    </tr>
</table>
<br>
</body>
</html>


Issues (1149)

success.php (5 issues)

Labels

Severity

Introduced By

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1			<?php
2			/*
3			* success.php
4			*
5			* PHP Toolkit for PayPal v0.51
6			* http://www.paypal.com/pdn
7			*
8			* Copyright (c) 2004 PayPal Inc
9			*
10			* Released under Common Public License 1.0
11			* http://opensource.org/licenses/cpl.php
12			*
13			*/
14			?>
15
16			<html>
17			<head><title>::Thank You::</title>
18			<link rel="stylesheet" type="text/css" href="styles.css">
19			</head>
20
21			<body bgcolor="ffffff">
22			<br>
23			<br>
24			<table width="500" border="0" align="center" cellpadding="1" cellspacing="0">
25			<tr>
26			<td align="left" valign="top" bgcolor="#333333">
27			<table width="100%" border="0" cellspacing="0" cellpadding="0">
28			<tr>
29			<td align="center" bgcolor="#EEEEEE"><p> </p>
30			<p>Thank you! Your order has been successfully processed.</p>
31			<p> </p></td>
32			</tr>
33			</table>
34			</td>
35			</tr>
36			</table>
37			<br>
38			<table width="500" border="0" align="center" cellpadding="1" cellspacing="0">
39			<tr>
40			<td align="left" valign="top" bgcolor="#333333">
41			<table width="100%" border="0" cellspacing="0" cellpadding="0">
42			<tr align="left" valign="top">
43			<td width="20%" bgcolor="#EEEEEE">
44			<table width="100%" border="0" cellspacing="0" cellpadding="3">
45			<tr align="left" valign="top">
46			<td bgcolor="#EEEEEE">Order Number:</td>
47			<td bgcolor="#EEEEEE">
48			<?= $_POST['txn_id'] ?>
			0 ignored issues – show Security introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_POST['txn_id']` can contain request data and is used in output context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_POST` in success.php on line 48 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
49			</td>
50			</tr>
51			<tr align="left" valign="top">
52			<td bgcolor="#EEEEEE">Date:</td>
53			<td bgcolor="#EEEEEE">
54			<?= $_POST['payment_date'] ?>
			0 ignored issues – show Security introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_POST['payment_date']` can contain request data and is used in output context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_POST` in success.php on line 54 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
55			</td>
56			</tr>
57			<tr align="left" valign="top">
58			<td width="20%" bgcolor="#EEEEEE"> First Name:</td>
59			<td width="80%" bgcolor="#EEEEEE">
60			<?= $_POST['first_name'] ?>
			0 ignored issues – show Security introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_POST['first_name']` can contain request data and is used in output context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_POST` in success.php on line 60 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
61			</td>
62			</tr>
63			<tr align="left" valign="top">
64			<td bgcolor="#EEEEEE">Last Name:</td>
65			<td bgcolor="#EEEEEE">
66			<?= $_POST['last_name'] ?>
			0 ignored issues – show Security introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_POST['last_name']` can contain request data and is used in output context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_POST` in success.php on line 66 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
67			</td>
68			</tr>
69			<tr align="left" valign="top">
70			<td bgcolor="#EEEEEE">Email:</td>
71			<td bgcolor="#EEEEEE">
72			<?= $_POST['payer_email'] ?>
			0 ignored issues – show Security introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$_POST['payer_email']` can contain request data and is used in output context(s) leading to a potential security vulnerability. 1 path for user data to reach this point Read from `$_POST` in success.php on line 72 Preventing Cross-Site-Scripting Attacks Cross-Site-Scripting allows an attacker to inject malicious code into your website - in particular Javascript code, and have that code executed with the privileges of a visiting user. This can be used to obtain data, or perform actions on behalf of that visiting user. In order to prevent this, make sure to escape all user-provided data: // for HTML $sanitized = htmlentities($tainted, ENT_QUOTES); // for URLs $sanitized = urlencode($tainted); General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
73			</td>
74			</tr>
75			</table>
76			</td>
77			</tr>
78			</table>
79			</td>
80			</tr>
81			</table>
82			<br>
83			</body>
84			</html>
85

XoopsModules25x / efqdirectory

Issues (1149)

success.php (5 issues)

Labels

Severity

Introduced By

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

1 path for user data to reach this point

Preventing Cross-Site-Scripting Attacks

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like