XoopsModules25x / efqdirectory

class/class.listing.php

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      efqdirectory
 * @since
 * @author       Martijn Hertog (aka wtravel)
 * @author       XOOPS Development Team,
 */

/**
 * Class efqListing
 * Manages operations for listings
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqListing extends XoopsObject

The type XoopsObject was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public $_editrights = false;
    public $_currentuser;
    public $_value      = array();
    public $_postdata   = array();
    public $_datatypes  = array();

    /**
     * Constructor
     */
    public function __construct()
    {
        // class constructor;
        $this->setCurrentUser();

        $this->initVar('itemid', XOBJ_DTYPE_INT, 0, true);

The constant XOBJ_DTYPE_INT was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('logourl', XOBJ_DTYPE_TXTBOX, null, false, 255);

The constant XOBJ_DTYPE_TXTBOX was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('uid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('status', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('created', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('title', XOBJ_DTYPE_TXTBOX, null, false, 255);
        $this->initVar('hits', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('rating', XOBJ_DTYPE_OTHER, 0.0, true);

The constant XOBJ_DTYPE_OTHER was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('votes', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('typeid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('dirid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('description', XOBJ_DTYPE_TXTAREA, null, false);

The constant XOBJ_DTYPE_TXTAREA was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * Function setListingVars sets listing variables
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param   array $listing Array with listing details
     */
    public function setListingVars($listing = array())
    {
        if (is_array($listing)) {
            $this->setVar('itemid', $listing['itemid']);
            $this->setVar('logourl', $listing['logourl']);
            $this->setVar('uid', $listing['uid']);
            $this->setVar('status', $listing['status']);
            $this->setVar('created', $listing['created']);
            $this->setVar('title', $listing['title']);
            $this->setVar('hits', $listing['hits']);
            $this->setVar('rating', $listing['rating']);
            $this->setVar('votes', $listing['votes']);
            $this->setVar('typeid', $listing['typeid']);
            $this->setVar('dirid', $listing['dirid']);
            $this->setVar('description', $listing['description']);
        }
    }

    public function setDataTypes($arr = array())
    {
        $this->_datatypes = $arr;
    }

    public function getDataTypes()
    {
        return $this->_datatypes;
    }

    public function setCurrentUser()
    {
        global $xoopsUser;
        $this->_currentuser = !empty($xoopsUser) ? $xoopsUser->getVar('uid') : 0;
    }

    public function setEditRights($value = false)
    {
        $this->_editrights = $value;
    }

    public function addPostDataArray($arr)
    {
        $this->_postdata[] = $arr;
    }

    public function updateListing()
    {
        global $xoopsDB;
        // Save array _postdata into database as update;
    }

    public function insertListing()
    {
        global $xoopsDB;
        // Save array postdata into database as new record;
    }
}

/**
 * Class efqListingHandler
 * Manages database operations for listings
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqListingHandler extends XoopsObjectHandler

The type XoopsObjectHandler was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public function __construct()
    {
        //Instantiate class
        $this->db = XoopsDatabaseFactory::getDatabaseConnection();

The type XoopsDatabaseFactory was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    /**
     * Function updateStatus updates status for listing
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param   int      $itemid    - Default: 0 - Listing to be updated
     * @param int|string $newstatus - Default: '1' - New status for listing
     * @return bool true if update is succesful, false if unsuccesful
     */
    public function updateStatus($itemid = 0, $newstatus = '1')
    {
        $sql = 'UPDATE ' . $this->db->prefix($module->getVar('dirname', 'n') . '_items') . ' SET status = ' . $newstatus . ' WHERE itemid = ' . (int)$itemid . '';

The variable $module seems to be never defined.

        if ($this->db->query($sql)) {
            return true;
        }

        return false;
    }

    /**
     * Function incrementHits increments hits for listing with 1
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param   int $itemid - Default: 0 - Listing to be updated
     *
     * @return bool true if update is succesful, false if unsuccesful
     */
    public function incrementHits($itemid = 0)
    {
        $sql = sprintf('UPDATE %s SET hits = hits+1 WHERE itemid = %u AND STATUS = 2', $this->db->prefix($module->getVar('dirname', 'n') . '_items'), (int)$itemid);

The variable $module seems to be never defined.

        if ($this->db->queryF($sql)) {
            return true;
        }

        return false;
    }

    /**
     * Function getLinkedCatsArray gets categories linked to a listing.
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param int|string $itemid - Default: '0' - Listing ID
     * @param int|string $dirid  - Default: '0' - Directory ID
     * @return array $arr Array with category ID's
     */
    public function getLinkedCatsArray($itemid = '0', $dirid = '0')
    {
        $sql     = 'SELECT c.cid, x.active FROM '
                   . $this->db->prefix($module->getVar('dirname', 'n') . '_cat')

The variable $module seems to be never defined.

                   . ' c, '
                   . $this->db->prefix($module->getVar('dirname', 'n') . '_item_x_cat')
                   . ' x WHERE c.cid=x.cid AND x.itemid='
                   . (int)$itemid
                   . " AND c.dirid='"
                   . (int)$dirid
                   . '\' AND c.active=\'1\'';
        $result  = $this->db->query($sql);
        $numrows = $this->db->getRowsNum($result);
        $arr     = array();
        if ($numrows > 0) {
            while (list($cid, $active) = $this->db->fetchRow($result)) {
                $arr[] = $cid;
            }
        }

        return $arr;
    }

    /**
     * Function getListing gets listing from DB as an array.
     *
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param   int $itemid - Default: '0' - Listing ID
     *
     * @return array $arr Array with listing fields and values
     */
    public function getListing($itemid)
    {
        $sql    = 'SELECT i.*, t.description FROM ' . $this->db->prefix($module->getVar('dirname', 'n') . '_items') . ' i LEFT JOIN ' . $this->db->prefix($module->getVar('dirname', 'n') . '_item_text') . ' t ON (i.itemid=t.itemid) WHERE i.itemid=' . (int)$itemid;

The variable $module seems to be never defined.

        $result = $this->db->query($sql);
        $arr    = array();
        if (!$result) {
            return $arr;
        } else {
            $numrows = $this->db->getRowsNum($result);
            if ($numrows == 0) {
                return $arr;
            } else {
                $arr = $this->db->fetchArray($result);
            }
        }

        return $arr;
    }

    public function getDataTypes($itemid)
    {
        global $datafieldmanager;
        $sql     = 'SELECT DISTINCT t.dtypeid, t.title, t.section, t.icon, f.typeid, f.fieldtype, f.ext, t.options, t.custom, d.itemid, d.value, d.customtitle ';
        $sql     .= 'FROM '
                    . $this->db->prefix($module->getVar('dirname', 'n') . '_item_x_cat')

The variable $module seems to be never defined.

                    . ' ic, '
                    . $this->db->prefix($module->getVar('dirname', 'n') . '_dtypes_x_cat')
                    . ' xc, '
                    . $this->db->prefix($module->getVar('dirname', 'n') . '_fieldtypes')
                    . ' f, '
                    . $this->db->prefix($module->getVar('dirname', 'n') . '_dtypes')
                    . ' t ';
        $sql     .= 'LEFT JOIN ' . $this->db->prefix($module->getVar('dirname', 'n') . '_data') . ' d ON (t.dtypeid=d.dtypeid AND d.itemid=' . (int)$itemid . ') ';
        $sql     .= "WHERE ic.cid=xc.cid AND ic.active='1' AND xc.dtypeid=t.dtypeid AND t.fieldtypeid=f.typeid AND t.activeyn='1' AND ic.itemid=" . (int)$itemid . ' ORDER BY t.seq ASC';
        $result  = $this->db->query($sql);
        $numrows = $this->db->getRowsNum($result);

The assignment to $numrows is dead and can be removed.

        //$arr = $this->db->fetchArray($result);

62% of this comment could be valid code. Did you maybe forget this after debugging?

        $arr = array();
        while (list($dtypeid, $title, $section, $icon, $ftypeid, $fieldtype, $ext, $options, $custom, $itemid, $value, $customtitle) = $this->db->fetchRow($result)) {

This code seems to be duplicated across your project.

            $fieldvalue = $datafieldmanager->getFieldValue($fieldtype, $options, $value);
            if ($icon != '') {
                $iconurl = "<img src=\"uploads/$icon\">";
            } else {
                $iconurl = '';
            }
            if ($custom != '0' && $customtitle != '') {
                $title = $customtitle;
            }
            $arr[] = array(
                'dtypeid'     => $dtypeid,
                'title'       => $title,
                'section'     => $section,
                'icon'        => $iconurl,
                'ftypeid'     => $ftypeid,
                'fieldtype'   => $fieldtype,
                'ext'         => $ext,
                'options'     => $options,
                'custom'      => $custom,
                'itemid'      => $itemid,
                'value'       => $fieldvalue,
                'customtitle' => $customtitle
            );
        }

        return $arr;
    }
}