XoopsModules25x / efqdirectory

blocks/efqdir_menu.php

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      efqdirectory
 * @since
 * @author       Martijn Hertog (aka wtravel)
 * @author       XOOPS Development Team,
 */

/******************************************************************************
 * Function: b_efqdiralpha1_menu_show
 * Input   : $options[0] = date for the most recent links
 *                    hits for the most popular links
 *           $block['content'] = The optional above content
 *           $options[1]   = How many reviews are displayes
 * Output  : Returns the desired most recent or most popular links
 *****************************************************************************
 * @param $options
 * @return array
 */

function b_efqdiralpha1_menu_show($options)

The parameter $options is not used and could be removed.

{
    global $xoopsDB, $xoopsModule, $eh;
    if (isset($xoopsModule)) {

        //$moddir = $xoopsModule->getvar("dirname");

64% of this comment could be valid code. Did you maybe forget this after debugging?

        $moduleDirName       = basename(dirname(__DIR__));
        $moduleHandler = xoops_getHandler('module');

The function xoops_getHandler was not found. Maybe you did not declare it correctly or list all dependencies?

        $module        = $moduleHandler->getByDirname($moduleDirName);
        $moddir        = $module->getvar('dirname');
    } else {
        $info   = __DIR__;
        $split  = preg_split("#[\]#", $info);
        $count  = count($split) - 2;
        $moddir = $split[$count];
    }
    $block                 = array();
    $block['lang_dirmenu'] = _MB_EFQDIR_MENU;
    $block['moddir']       = $moddir;
    $myts                  = MyTextSanitizer::getInstance();

The type MyTextSanitizer was not found. Maybe you did not declare it correctly or list all dependencies?

    $result                = $xoopsDB->query('SELECT dirid, name, descr FROM ' . $xoopsDB->prefix($module->getVar('dirname', 'n') . '_dir') . " WHERE open='1' ORDER BY name") or $eh->show('0013');

The variable $module does not seem to be defined for all execution paths leading up to this point.

    echo 'test';
    print_r($result);
    while ($myrow = $xoopsDB->fetchArray($result)) {

This code seems to be duplicated across your project.

        $directory              = array();
        $name                   = $myts->htmlSpecialChars($myrow['name']);
        $directory['dirid']     = $myrow['dirid'];
        $directory['name']      = $name;
        $directory['descr']     = $myrow['descr'];
        $block['directories'][] = $directory;
    }
    $sublink = array();

The assignment to $sublink is dead and can be removed.

    return $block;
}

/**
 * @param $options
 * @return string
 */
function b_efqdiralpha1_menu_edit($options)

This function seems to be duplicated in your project.

{
    $form = '' . _MB_EFQDIR_DISP . ' ';
    $form .= "<input type='hidden' name='options[]' value='";
    if ($options[0] === 'date') {
        $form .= "date'";
    } else {
        $form .= "hits'";
    }
    $form .= '>';
    $form .= "<input type='text' name='options[]' value='" . $options[1] . '\'>&nbsp;' . _MB_EFQDIR_LISTINGS . '';
    $form .= '&nbsp;<br>' . _MB_EFQDIR_CHARS . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . '\'>&nbsp;' . _MB_EFQDIR_LENGTH . '';

    return $form;
}