Issues in menu.php (master) - Issues in master - XoopsModules25x/efqdirectory - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1149)

admin/menu.php (7 issues)

Labels

Severity

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package
 * @since
 * @author       XOOPS Development Team,
 */

// Part of the efqDirectory module provided by: wtravel      //
//  e-mail: [email protected]            //
// Purpose: Create a business directory for xoops.          //
// Based upon the mylinks and the mxDirectory modules       //

$moduleDirName = basename(dirname(__DIR__));

if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
filter:
    dependency_paths: ["lib/*"]
} else {
    $moduleHelper = Xmf\Module\Helper::getHelper('system');
}
$adminObject = \Xmf\Module\Admin::getInstance();
filter:
    dependency_paths: ["lib/*"]

$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
//$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');


$moduleHelper->loadLanguage('modinfo');

$adminmenu[] = [
    'title' => _AM_MODULEADMIN_HOME,

    'link'  => 'admin/index.php',
    'icon'  => $pathIcon32 . '/home.png',
];
$adminmenu[] = [
    'title' => _MI_EFQDIR_ADMENU3,
    'link'  => 'admin/directories.php',
    'icon'  => $pathIcon32 . '/category.png',
];
$adminmenu[] = [
    'title' => _MI_EFQDIR_ADMENU4,
    'link'  => 'admin/fieldtypes.php',
    'icon'  => $pathIcon32 . '/manage.png'
];
$adminmenu[] = [
    'title' => _MI_EFQDIR_ADMENU5,
    'link'  => 'admin/main.php?op=listNewListings',
    'icon'  => 'images/prefs.png',
];
$adminmenu[] = [
    'title' => _MI_EFQDIR_ADMENU7,
    'link'  => 'admin/subscriptions.php',
    'icon'  => $pathIcon32 . '/manage.png'
];
$adminmenu[] = [
    'title' => _MI_EFQDIR_ADMENU8,
    'link'  => 'admin/main.php?op=duplicateDataTypes',
    'icon'  => $pathIcon32 . '/manage.png',
];
$adminmenu[] = [
    'title' => _AM_MODULEADMIN_ABOUT,

    'link'  => 'admin/about.php',
    'icon'  => $pathIcon32 . '/about.png',
];
//$adminmenu[5]['title'] = _MI_EFQDIR_ADMENU6;

//$adminmenu[5]['link'] = "admin/addresstypes.php";


1			<?php
2			/*
3			* You may not change or alter any portion of this comment or credits
4			* of supporting developers from this source code or any supporting source code
5			* which is considered copyrighted (c) material of the original comment or credit authors.
6			*
7			* This program is distributed in the hope that it will be useful,
8			* but WITHOUT ANY WARRANTY; without even the implied warranty of
9			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* @copyright {@link https://xoops.org/ XOOPS Project}
14			* @license {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
15			* @package
16			* @since
17			* @author XOOPS Development Team,
18			*/
19
20			// Part of the efqDirectory module provided by: wtravel //
21			// e-mail: [email protected] //
22			// Purpose: Create a business directory for xoops. //
23			// Based upon the mylinks and the mxDirectory modules //
24
25			$moduleDirName = basename(dirname(__DIR__));
26
27			if (false !== ($moduleHelper = Xmf\Module\Helper::getHelper($moduleDirName))) {
			0 ignored issues – show Bug introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Xmf\Module\Helper` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history... Unused Code introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
28			} else {
29			$moduleHelper = Xmf\Module\Helper::getHelper('system');
30			}
31			$adminObject = \Xmf\Module\Admin::getInstance();
			0 ignored issues – show Bug introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Xmf\Module\Admin` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
32
33			$pathIcon32 = \Xmf\Module\Admin::menuIconPath('');
34			//$pathModIcon32 = $moduleHelper->getModule()->getInfo('modicons32');
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35
36			$moduleHelper->loadLanguage('modinfo');
37
38			$adminmenu[] = [
39			'title' => _AM_MODULEADMIN_HOME,
			0 ignored issues – show Bug introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `_AM_MODULEADMIN_HOME` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
40			'link' => 'admin/index.php',
41			'icon' => $pathIcon32 . '/home.png',
42			];
43			$adminmenu[] = [
44			'title' => _MI_EFQDIR_ADMENU3,
45			'link' => 'admin/directories.php',
46			'icon' => $pathIcon32 . '/category.png',
47			];
48			$adminmenu[] = [
49			'title' => _MI_EFQDIR_ADMENU4,
50			'link' => 'admin/fieldtypes.php',
51			'icon' => $pathIcon32 . '/manage.png'
52			];
53			$adminmenu[] = [
54			'title' => _MI_EFQDIR_ADMENU5,
55			'link' => 'admin/main.php?op=listNewListings',
56			'icon' => 'images/prefs.png',
57			];
58			$adminmenu[] = [
59			'title' => _MI_EFQDIR_ADMENU7,
60			'link' => 'admin/subscriptions.php',
61			'icon' => $pathIcon32 . '/manage.png'
62			];
63			$adminmenu[] = [
64			'title' => _MI_EFQDIR_ADMENU8,
65			'link' => 'admin/main.php?op=duplicateDataTypes',
66			'icon' => $pathIcon32 . '/manage.png',
67			];
68			$adminmenu[] = [
69			'title' => _AM_MODULEADMIN_ABOUT,
			0 ignored issues – show Bug introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `_AM_MODULEADMIN_ABOUT` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
70			'link' => 'admin/about.php',
71			'icon' => $pathIcon32 . '/about.png',
72			];
73			//$adminmenu[5]['title'] = _MI_EFQDIR_ADMENU6;
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `68%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
74			//$adminmenu[5]['link'] = "admin/addresstypes.php";
75

XoopsModules25x / efqdirectory

Issues (1149)

admin/menu.php (7 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like