XoopsModules25x / efqdirectory

admin/categories.php

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      efqdirectory
 * @since
 * @author       Martijn Hertog (aka wtravel)
 * @author       XOOPS Development Team,
 */

require_once __DIR__ . '/admin_header.php';
//include __DIR__ . '/../../../include/cp_header.php';

50% of this comment could be valid code. Did you maybe forget this after debugging?

include __DIR__ . '/../include/functions.php';
require_once XOOPS_ROOT_PATH . '/class/xoopstree.php';

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

require_once XOOPS_ROOT_PATH . '/include/xoopscodes.php';
require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
require_once __DIR__ . '/../class/class.formimage.php';
require_once XOOPS_ROOT_PATH . '/class/module.errorhandler.php';
require_once __DIR__ . '/../class/class.efqtree.php';
$efqtree = new EfqTree($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), 'cid', 'pid');
$myts    = MyTextSanitizer::getInstance();

The type MyTextSanitizer was not found. Maybe you did not declare it correctly or list all dependencies?

$eh      = new ErrorHandler;

The type ErrorHandler was not found. Maybe you did not declare it correctly or list all dependencies?

$mytree  = new XoopsTree($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), 'cid', 'pid');

The type XoopsTree was not found. Maybe you did not declare it correctly or list all dependencies?

$mytree2 = new XoopsTree($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_fieldtypes'), 'typeid', 0);
$efqtree = new EfqTree($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), 'cid', 'pid');

$moddir = $xoopsModule->getVar('dirname');
if (isset($_GET['dirid'])) {
    $get_dirid = (int)$_GET['dirid'];
} else {
    $get_dirid = 0;
}
if (isset($_GET['dtypeid'])) {
    $get_dtypeid = (int)$_GET['dtypeid'];
}
if (isset($_GET['catid'])) {
    $get_catid = (int)$_GET['catid'];
}

function catConfig($dirid = '0')
{
    global $xoopsDB, $xoopsModule, $xoopsUser, $mytree, $efqtree;
    if ($dirid == '0') {
        redirect_header('directories.php', 2, _MD_NOVALIDDIR);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

        exit();
    }
    xoops_cp_header();

The function xoops_cp_header was not found. Maybe you did not declare it correctly or list all dependencies?

    //adminmenu(-1, _MD_MANAGE_CATS);

56% of this comment could be valid code. Did you maybe forget this after debugging?

    $dirname = getDirNameFromId($dirid);
    echo '<h4>' . _MD_CATCONF . '&nbsp;-&nbsp;' . $dirname . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1' class='outer'>";
    //Get all main categories for this directory.
    $cats = getCatOverview();
    echo $cats;
    echo '</table>';
    echo '<br>';
    echo '<h4>' . _MD_CREATE_NEWCAT . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1'><tr><td>";
    $form = new XoopsThemeForm(_MD_NEWCATFORM, 'submitform', 'categories.php');

The type XoopsThemeForm was not found. Maybe you did not declare it correctly or list all dependencies?

    $form->setExtra('enctype="multipart/form-data"');
    $form->addElement(new XoopsFormText(_MD_CATTITLE, 'title', 50, 100, ''), true);

The type XoopsFormText was not found. Maybe you did not declare it correctly or list all dependencies?

    $form_active = new XoopsFormCheckBox(_MD_ACTIVEYN, 'active', '');

The type XoopsFormCheckBox was not found. Maybe you did not declare it correctly or list all dependencies?

    $form_active->addOption(1, _MD_YESNO);
    $form->addElement($form_active);
    $form_importdtypes = new XoopsFormCheckBox(_MD_IMPORT_DTYPES_YN, 'importdtypes', '');
    $form_importdtypes->addOption(1, _MD_YESNO);
    $form->addElement($form_importdtypes);
    $form_allowlist = new XoopsFormCheckBox(_MD_ALLOWLISTYN, 'allowlist', '');
    $form_allowlist->addOption(1, _MD_YESNO);
    $form->addElement($form_allowlist);
    $form_showpopular = new XoopsFormCheckBox(_MD_SHOWPOPULARYN, 'showpopular', '');
    $form_showpopular->addOption(1, _MD_YESNO);
    $form->addElement($form_showpopular);
    $form->addElement(new XoopsFormDhtmlTextArea(_MD_DESCRIPTION, 'descr', '', 5, 50));

The type XoopsFormDhtmlTextArea was not found. Maybe you did not declare it correctly or list all dependencies?

    //Add parent category select box.
    ob_start();
    $efqtree->setDir($dirid);
    $pcat_selbox = $efqtree->makeMySelBox('title', 'title', '', 1, 'pid');

The assignment to $pcat_selbox is dead and can be removed.

    $selbox      = ob_get_contents();
    ob_end_clean();
    $pcat_tray = new XoopsFormElementTray(_MD_PARENTCAT, '<br>');

The type XoopsFormElementTray was not found. Maybe you did not declare it correctly or list all dependencies?

    $pcat_tray->addElement(new XoopsFormLabel('', $selbox));

The type XoopsFormLabel was not found. Maybe you did not declare it correctly or list all dependencies?

    $form->addElement($pcat_tray);
    $form->addElement(new XoopsFormFile(_MD_SELECT_PIC, 'img', 30000));

The type XoopsFormFile was not found. Maybe you did not declare it correctly or list all dependencies?

    $form_txtactive = new XoopsFormCheckBox(_MD_CATTEXT_ACTIVE_YN, 'open', 0);
    $form_txtactive->addOption(1, _MD_YESNO);
    $form->addElement($form_txtactive);
    $form->addElement(new XoopsFormButton('', 'submit', _MD_SUBMIT, 'submit'));

The type XoopsFormButton was not found. Maybe you did not declare it correctly or list all dependencies?

    $form->addElement(new XoopsFormHidden('op', 'newcat'));

The type XoopsFormHidden was not found. Maybe you did not declare it correctly or list all dependencies?

    $form->addElement(new XoopsFormHidden('dirid', $dirid));
    $form->addElement(new XoopsFormHidden('uid', $xoopsUser->getVar('uid')));
    $form->display();
    echo '</td></tr></table>';
    xoops_cp_footer();

The function xoops_cp_footer was not found. Maybe you did not declare it correctly or list all dependencies?

}

function editCat($catid = '0')
{
    global $xoopsDB, $efqtree, $mytree, $mytree2, $xoopsUser, $get_catid, $eh, $myts;
    xoops_cp_header();

The function xoops_cp_header was not found. Maybe you did not declare it correctly or list all dependencies?

    $diridfromcatid = getDirId($get_catid);
    //adminmenu(-1, _MD_EDITCAT);

56% of this comment could be valid code. Did you maybe forget this after debugging?

    echo '<h4>' . _MD_EDITCAT . '</h4>';
    $pathstring = "<a href='categories.php?dirid=$diridfromcatid'>" . _MD_MAIN . '</a>&nbsp;:&nbsp;';
    $pathstring .= $efqtree->getNicePathFromId($get_catid, 'title', 'categories.php?op=edit');
    echo $pathstring . '<br><br>';

    $catchildren   = $mytree->getFirstChild($get_catid);
    $count_subcats = count($catchildren);
    if ($count_subcats != 0) {
        $subcategories = '';
        echo '<strong>' . _MD_SUBCATEGORIES . '</strong>:<br>';
        for ($i = 0; $i < $count_subcats; ++$i) {
            $subcategories .= "<a href='categories.php?op=edit&catid=" . $catchildren[$i]['cid'] . '\'>' . $catchildren[$i]['title'] . '</a>';
            if ($i + 1 != $count_subcats) {
                $subcategories .= ', ';
            }
        }
        echo $subcategories . '<br><br>';
    }

    echo "<table width='100%' border='0' cellspacing='1'><tr><td>";
    $result  = $xoopsDB->query('SELECT c.cid, c.dirid, c.title, c.active, c.pid, c.img, c.allowlist, c.showpopular, c.height, c.width, t.text FROM '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat')

The variable $xoopsModule seems to be never defined.

                               . ' c LEFT JOIN '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n')
                                                  . '_cat_txt')
                               . " t  ON (c.cid=t.cid) WHERE c.cid='"
                               . $catid
                               . '\'');
    $numrows = $xoopsDB->getRowsNum($result);
    if ($numrows > 0) {
        while (list($cid, $dirid, $title, $active, $pid, $img, $allowlist, $showpopular, $imgheight, $imgwidth, $descr) = $xoopsDB->fetchRow($result)) {
            $title     = $myts->htmlSpecialChars($title);
            $parentcat = $pid;
            if ($img != '') {
                $picture = "../uploads/$img";
            } else {
                $picture = '../uploads/dummy.png';
            }
            $form = new XoopsThemeForm(_MD_EDITCATFORM, 'editform', 'categories.php');
            $form->setExtra('enctype="multipart/form-data"');
            $form->addElement(new XoopsFormText(_MD_CATTITLE, 'title', 50, 100, "$title"), true);
            $form_active = new XoopsFormCheckBox(_MD_ACTIVEYN, 'active', $active);
            $form_active->addOption(1, _MD_YESNO);
            $form->addElement($form_active);
            $form_allowlist = new XoopsFormCheckBox(_MD_ALLOWLISTYN, 'allowlist', $allowlist);
            $form_allowlist->addOption(1, _MD_YESNO);
            $form->addElement($form_allowlist);
            $form_showpopular = new XoopsFormCheckBox(_MD_SHOWPOPULARYN, 'showpopular', $showpopular);
            $form_showpopular->addOption(1, _MD_YESNO);
            $form->addElement($form_showpopular);
            //Add parent category select box.
            ob_start();
            $pcat_selbox = $mytree->makeMySelBox('title', 'title', $pid, 1, 'pid');

The assignment to $pcat_selbox is dead and can be removed.

            $selbox      = ob_get_contents();
            ob_end_clean();
            $pcat_tray = new XoopsFormElementTray(_MD_PARENTCAT, '<br>');
            $pcat_tray->addElement(new XoopsFormLabel('', $selbox));
            $form->addElement($pcat_tray);

            $form->addElement(new XoopsFormDhtmlTextArea(_MD_DESCRIPTION, 'descr', "$descr", 5, 50));
            $form->addElement(new XoopsFormFile(_MD_SELECT_PIC, 'img', 30000));
            $form->addElement(new XoopsFormImage(_MD_CURRENT_PIC, 'current_image', null, "$picture", $imgheight, $imgwidth));
            $form->addElement(new XoopsFormButton('', 'submit', _MD_UPDATE, 'submit'));
            $form->addElement(new XoopsFormHidden('op', 'update'));
            $form->addElement(new XoopsFormHidden('catid', $cid));
            $form->addElement(new XoopsFormHidden('uid', $xoopsUser->getVar('uid')));
            $form->display();
        }
    }
    echo '</td></tr></table>';
    $dellink = "<align=\"right\"><a href=\"categories.php?op=deleteCatConfirm&catid=$get_catid\"><img src=\"" . XOOPS_URL . '/images/drop.png">' . _MD_DELETE_CAT . '</a></align>';

The constant XOOPS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

    echo $dellink;
    echo '<h4>' . _MD_EDITDTYPES . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1'><tr><td>";
    echo '<form name="editdtypes" id="editdtypes" action="categories.php" method="post">';
    echo '<table width="100%" class="outer" cellspacing="1">';
    $result  = $xoopsDB->query('SELECT d.dtypeid, x.cid, d.title, d.section, d.seq, d.icon, f.title, f.typeid, d.defaultyn, d.activeyn, d.options, d.custom FROM '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
                               . ' d, '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n')
                                                  . '_fieldtypes')
                               . ' f, '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat')
                               . " x WHERE d.fieldtypeid=f.typeid AND d.dtypeid=x.dtypeid AND x.cid='"
                               . $catid
                               . '\' ORDER BY d.section ASC, d.seq ASC')
               || $eh->show('0013');
    $numrows = $xoopsDB->getRowsNum($result);
    echo '<tr><th>' . _MD_DTYPE_ICON . '</th><th>' . _MD_DTYPE_TITLE . '</th><th>' . _MD_FTYPE_NAME . '</th><th>' . _MD_OPTIONS . '</th><th>' . _MD_CUSTOM . '</th><th>' . _MD_ACTIVE . '</th><th>' . _MD_DEFAULT . '</th><th>' . _MD_DTYPE_SEQ . '</th><th>' . _MD_SECTION . '</th></tr>';
    if ($numrows > 0) {
        $dtypes = '';
        $count  = 1;
        while (list($dtypeid, $cid, $dtypetitle, $section, $dseq, $picture, $ftypename, $ftypeid, $defaultyn, $activeyn, $options, $dcustom) = $xoopsDB->fetchRow($result)) {
            if ($defaultyn == '1') {

This code seems to be duplicated across your project.

                $default = _MD_YES;

The assignment to $default is dead and can be removed.

                $checked = ' checked';
            } else {
                $default = _MD_NO;
                $checked = '';
            }
            if ($activeyn == '1') {

This code seems to be duplicated across your project.

                $default       = _MD_YES;
                $activechecked = ' checked';
            } else {
                $default       = _MD_NO;
                $activechecked = '';
            }
            if ($picture != '') {
                $iconurl = "../uploads/$picture";
            } else {
                $iconurl = '';
            }
            if ($dcustom == '1') {
                $custom = _MD_YES;
            } else {
                $custom = _MD_NO;
            }
            //Get the existing fields for this category.
            ob_start();
            $mytree2->makeMySelBox('title', 'title', $ftypeid, 1, 'fieldtype' . $dtypeid . '');
            $ftypebox = ob_get_contents();

The assignment to $ftypebox is dead and can be removed.

            ob_end_clean();

            if ($count != 1) {
                $dtypes .= '|' . $dtypeid;
            } else {
                $dtypes = $dtypeid;
            }
            ++$count;
            echo "<tr><td class=\"even\"><img src=\"$iconurl\"></td><td class=\"even\"><a href=\"categories.php?op=editdtype&dtypeid=$dtypeid&amp;catid=$get_catid\">$dtypetitle</a></td><td class=\"even\">"
                 . $ftypename
                 . "</td><td class=\"even\">$options</td><td class=\"even\">$custom</td><td class=\"even\"><input type=\"checkbox\" name=\"activeyn"
                 . $dtypeid
                 . "\"$activechecked></input></td><td class=\"even\"><input type=\"checkbox\" name=\"defaultyn"
                 . $dtypeid
                 . "\"$checked></input></td><td class=\"even\"><input type=\"text\" size=\"5\" maxsize=\"10\" name=\"seq"
                 . $dtypeid
                 . '" value="'
                 . $dseq
                 . '"></input></td><td class="even"><input type="text" size="5" maxsize="10" name="section'
                 . $dtypeid
                 . '" value="'
                 . $section
                 . '"></input></td></tr>';
        }
        echo '<tr><td class="even">&nbsp;</td><td class="even" colspan="8"><input type="hidden" name="op" value="editdtypes"><input type="hidden" name="catid" value="'
             . $get_catid
             . '"><input type="hidden" name="dtypes" value="'
             . $dtypes
             . '"><input type="submit" class="formButton" name="submit"  id="submit" value="'
             . _MD_UPDATE
             . '" ></td></tr>';
    } else {
        echo '<tr><td colspan="7">' . _MD_NORECORDS . '&nbsp;';
        if ($parentcat != '0') {

The variable $parentcat does not seem to be defined for all execution paths leading up to this point.

            echo '<input type="hidden" name="op" value="importdtypes"><input type="hidden" name="catid" value="'
                 . $get_catid
                 . '"><input type="hidden" name="pid" value="'
                 . $parentcat
                 . '"><input type="submit" class="formButton" name="submit"  id="submit" value="'
                 . _MD_IMPORT_DTYPES_FROM_PARENTCAT
                 . '" >';
        }
        echo '</td></tr>';
    }
    echo '</table></form></td></tr></table>';
    echo '<h4>' . _MD_ADDDTYPE . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1'><tr><td>";

    $form = new XoopsThemeForm(_MD_ADD_DTYPE_FORM, 'newdatatypeform', 'categories.php');
    $form->setExtra('enctype="multipart/form-data"');
    $form->addElement(new XoopsFormText(_MD_DTYPE_TITLE, 'title', 50, 100, ''), true);
    $form->addElement(new XoopsFormFile(_MD_SELECT_ICON, 'image', 30000));
    $fieldtype_tray = new XoopsFormElementTray(_MD_FTYPE_NAME, '', 'typeid');
    ob_start();
    $mytree2->makeMySelBox('title', 'title', 0, 1);
    $selbox = ob_get_contents();
    ob_end_clean();
    $options_tray     = new XoopsFormElementTray(_MD_OPTIONS, '');
    $options_text     = new XoopsFormLabel('', '<br>' . _MD_OPTIONS_EXPL);
    $options_textarea = new XoopsFormTextArea('', 'options', '', 6, 50);

The type XoopsFormTextArea was not found. Maybe you did not declare it correctly or list all dependencies?

    $options_tray->addElement($options_textarea);
    $options_tray->addElement($options_text);
    $fieldtype_tray->addElement(new XoopsFormLabel('', $selbox . ' <a href="fieldtypes.php">' . _MD_EDIT . ''));
    $form->addElement($fieldtype_tray, true);
    $form->addElement($options_tray);
    $form_active = new XoopsFormCheckBox(_MD_DTYPE_ACTIVEYN, 'activeyn', 0);
    $form_active->addOption(1, _MD_YESNO);
    $form->addElement($form_active);
    $form_default = new XoopsFormCheckBox(_MD_DTYPE_DEFAULTYN, 'defaultyn', 0);
    $form_default->addOption(1, _MD_YESNO);
    $form->addElement($form_default);
    $form->addElement(new XoopsFormText(_MD_DTYPE_SEQ, 'seq', 5, 10, 0), true);
    $form->addElement(new XoopsFormText(_MD_SECTION, 'section', 5, 10, 0), true);
    //$form_custom = new XoopsFormCheckBox(_MD_DTYPE_CUSTOM, "custom", "");

53% of this comment could be valid code. Did you maybe forget this after debugging?

    //$form_custom->addOption(1, _MD_YESNO);

70% of this comment could be valid code. Did you maybe forget this after debugging?

    //$form->addElement($form_custom);

86% of this comment could be valid code. Did you maybe forget this after debugging?

    $form->addElement(new XoopsFormButton('', 'submit', _MD_SUBMIT, 'submit'));
    $form->addElement(new XoopsFormHidden('op', 'newdatatype'));
    $form->addElement(new XoopsFormHidden('catid', $get_catid));
    $form->addElement(new XoopsFormHidden('uid', $xoopsUser->getVar('uid')));
    $form->display();
    echo '</td></tr></table>';
    echo '<br>';
    echo '<h4>' . _MD_CREATE_NEWSUBCAT . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1'><tr><td>";
    $form = new XoopsThemeForm(_MD_NEWCATFORM, 'submitform', 'categories.php');
    $form->setExtra('enctype="multipart/form-data"');
    $form->addElement(new XoopsFormText(_MD_CATTITLE, 'title', 50, 100, "$title"), true);

The variable $title does not seem to be defined for all execution paths leading up to this point.

    $form_active = new XoopsFormCheckBox(_MD_ACTIVEYN, 'active', '');
    $form_active->addOption(1, _MD_YESNO);
    $form->addElement($form_active);
    $form_importdtypes = new XoopsFormCheckBox(_MD_IMPORT_DTYPES_YN, 'importdtypes', 1);
    $form_importdtypes->addOption(1, _MD_YESNO);
    $form->addElement($form_importdtypes);
    $form_allowlist = new XoopsFormCheckBox(_MD_ALLOWLISTYN, 'allowlist', '');
    $form_allowlist->addOption(1, _MD_YESNO);
    $form->addElement($form_allowlist);
    $form_showpopular = new XoopsFormCheckBox(_MD_SHOWPOPULARYN, 'showpopular', '');
    $form_showpopular->addOption(1, _MD_YESNO);
    $form->addElement($form_showpopular);
    $form->addElement(new XoopsFormDhtmlTextArea(_MD_DESCRIPTION, 'descr', '', 5, 50));
    ob_start();
    $pcat_selbox = $mytree->makeMySelBox('title', 'title', "$get_catid", 0, 'pid');
    $selbox      = ob_get_contents();
    ob_end_clean();
    $pcat_tray = new XoopsFormElementTray(_MD_PARENTCAT, '<br>');
    $pcat_tray->addElement(new XoopsFormLabel('', $selbox));
    $form->addElement($pcat_tray);
    $form->addElement(new XoopsFormFile(_MD_SELECT_PIC, 'img', 30000));
    $form_txtactive = new XoopsFormCheckBox(_MD_CATTEXT_ACTIVE_YN, 'open', 0);
    $form_txtactive->addOption(1, _MD_YESNO);
    $form->addElement($form_txtactive);
    $form->addElement(new XoopsFormButton('', 'submit', _MD_SUBMIT, 'submit'));
    $form->addElement(new XoopsFormHidden('op', 'newcat'));
    $form->addElement(new XoopsFormHidden('dirid', $diridfromcatid));
    $form->addElement(new XoopsFormHidden('uid', $xoopsUser->getVar('uid')));
    $form->display();
    echo '</td></tr></table>';
    xoops_cp_footer();

The function xoops_cp_footer was not found. Maybe you did not declare it correctly or list all dependencies?

}

function editDatatype($dtypeid = '0')
{
    global $xoopsDB, $mytree, $mytree2, $xoopsUser, $get_catid, $eh;
    xoops_cp_header();

The function xoops_cp_header was not found. Maybe you did not declare it correctly or list all dependencies?

    //adminmenu(-1, _MD_EDITCAT);

56% of this comment could be valid code. Did you maybe forget this after debugging?

    echo '<h4>' . _MD_EDITDTYPE . '</h4>';
    echo "<table width='100%' border='0' cellspacing='1' class='outer'><tr><td>";

    $result  = $xoopsDB->query('SELECT d.dtypeid, d.title, d.section, d.seq, d.icon, f.title, f.typeid, d.defaultyn, d.activeyn, d.options, d.custom FROM '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')

The variable $xoopsModule seems to be never defined.

                               . ' d, '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n')
                                                  . '_fieldtypes')
                               . " f WHERE d.fieldtypeid=f.typeid AND d.dtypeid='"
                               . $dtypeid
                               . '\' ORDER BY d.seq ASC')
               || $eh->show('0013');
    $numrows = $xoopsDB->getRowsNum($result);
    if ($numrows > 0) {
        while (list($dtypeid, $dtypetitle, $section, $dseq, $picture, $ftypename, $ftypeid, $defaultyn, $activeyn, $options, $dcustom) = $xoopsDB->fetchRow($result)) {
            if ($defaultyn == '1') {

This code seems to be duplicated across your project.

                $default = _MD_YES;

The assignment to $default is dead and can be removed.

                $checked = ' checked';
            } else {
                $default = _MD_NO;
                $checked = '';
            }
            if ($activeyn == '1') {

This code seems to be duplicated across your project.

                $default       = _MD_YES;
                $activechecked = ' checked';
            } else {
                $default       = _MD_NO;
                $activechecked = '';
            }
            if ($picture != '') {
                $iconurl = "../uploads/$picture";
            } else {
                $iconurl = '';
            }
            if ($dcustom == '1') {
                $custom = '1';
            } else {
                $custom = '0';
            }
            ob_start();
            $mytree2->makeMySelBox('title', 'title', $ftypeid, 1, 'fieldtype' . $dtypeid . '');
            $ftypebox = ob_get_contents();

The assignment to $ftypebox is dead and can be removed.

            ob_end_clean();

            $form = new XoopsThemeForm(_MD_EDIT_DTYPE_FORM, 'editdatatypeform', 'categories.php');
            $form->setExtra('enctype="multipart/form-data"');
            //$form_custom = new XoopsFormCheckBox(_MD_DTYPE_CUSTOM, "custom", $custom);

53% of this comment could be valid code. Did you maybe forget this after debugging?

            //$form_custom->addOption(1, _MD_YESNO);

70% of this comment could be valid code. Did you maybe forget this after debugging?

            //$form->addElement($form_custom);

86% of this comment could be valid code. Did you maybe forget this after debugging?

            $form->addElement(new XoopsFormText(_MD_DTYPE_TITLE, 'title', 50, 100, $dtypetitle), true);
            $form->addElement(new XoopsFormFile(_MD_SELECT_ICON, 'image', 30000));
            $form->addElement(new XoopsFormImage(_MD_CURRENT_ICON, 'current_image', null, $iconurl, '', ''));
            $fieldtype_tray = new XoopsFormElementTray(_MD_FTYPE_NAME, '', 'typeid');
            ob_start();
            $mytree2->makeMySelBox('title', 'title', $ftypeid, 1);
            $selbox = ob_get_contents();
            ob_end_clean();
            $options_tray     = new XoopsFormElementTray(_MD_OPTIONS, '');
            $options_text     = new XoopsFormLabel('', '<br>' . _MD_OPTIONS_EXPL);
            $options_textarea = new XoopsFormTextArea('', 'options', $options, 6, 5);
            $options_tray->addElement($options_textarea);
            $options_tray->addElement($options_text);
            $fieldtype_tray->addElement(new XoopsFormLabel('', $selbox . ' <a href="fieldtypes.php">' . _MD_EDIT . ''));
            $form->addElement($fieldtype_tray, true);
            $form->addElement($options_tray);
            $form_active = new XoopsFormCheckBox(_MD_DTYPE_ACTIVEYN, 'activeyn', $activeyn);
            $form_active->addOption(1, _MD_YESNO);
            $form->addElement($form_active);
            $form_default = new XoopsFormCheckBox(_MD_DTYPE_DEFAULTYN, 'defaultyn', $defaultyn);
            $form_default->addOption(1, _MD_YESNO);
            $form->addElement($form_default);
            $form->addElement(new XoopsFormText(_MD_DTYPE_SEQ, 'seq', 5, 10, $dseq), true);
            $form->addElement(new XoopsFormText(_MD_SECTION, 'section', 5, 10, $section), true);
            $form->addElement(new XoopsFormButton('', 'submit', _MD_SUBMIT, 'submit'));
            $form->addElement(new XoopsFormHidden('op', 'savedtype'));
            $form->addElement(new XoopsFormHidden('catid', $get_catid));
            $form->addElement(new XoopsFormHidden('dtypeid', $dtypeid));
            $form->addElement(new XoopsFormHidden('uid', $xoopsUser->getVar('uid')));
            $form->display();
        }
    } else {
        echo '<table><tr><td colspan="7">' . _MD_NORECORDS . '&nbsp;';
        //  if ($parentcat != '0') {

54% of this comment could be valid code. Did you maybe forget this after debugging?

        //   echo "<input type=\"hidden\" name=\"op\" value=\"importdtypes\"><input type=\"hidden\" name=\"catid\" value=\"".$get_catid."\"><input type=\"hidden\" name=\"pid\" value=\"".$parentcat."\"><input type=\"submit\" class=\"formButton\" name=\"submit\"  id=\"submit\" value=\""._MD_IMPORT_DTYPES_FROM_PARENTCAT."\" >";

56% of this comment could be valid code. Did you maybe forget this after debugging?

        //  }
        echo '</td></tr></table>';
    }
    echo '</td></tr></table>';
    xoops_cp_footer();

The function xoops_cp_footer was not found. Maybe you did not declare it correctly or list all dependencies?

}

function saveDatatype()
{
    global $xoopsDB, $_POST, $myts, $eh, $moddir, $xoopsUser;
    $count     = 1;

The assignment to $count is dead and can be removed.

    $return    = '';

The assignment to $return is dead and can be removed.

    $p_dtypeid = $_POST['dtypeid'];
    $p_catid   = $_POST['catid'];
    if (isset($_POST['title'])) {
        if (isset($_POST['custom'])) {
            $p_custom = $_POST['custom'];
        } else {
            $p_custom = '0';
        }
        $p_title     = $myts->makeTboxData4Save($_POST['title']);
        $p_fieldtype = $_POST['typeid'];

The assignment to $p_fieldtype is dead and can be removed.

        $p_section   = $myts->makeTboxData4Save($_POST['section']);
        if (isset($_POST['defaultyn'])) {
            $p_default = $_POST['defaultyn'];
        } else {
            $p_default = '0';
        }
        if (isset($_POST['activeyn'])) {
            $p_active = $_POST['activeyn'];
        } else {
            $p_active = '0';
        }
        if (isset($_POST['options'])) {

This code seems to be duplicated across your project.

            $p_options = $myts->makeTareaData4Save($_POST['options']);
        } else {
            $p_options = '';
        }
        $p_fieldtype = $_POST['typeid'];
        $p_seq       = $myts->makeTboxData4Save($_POST['seq']);

        require_once XOOPS_ROOT_PATH . '/class/class.uploader.php';

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

        $uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads", array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/jpg'), 30000, 50, 50);
        $uploader->setPrefix('icon');
        $err    = array();
        $ucount = count($_POST['xoops_upload_file']);
        if ($ucount != 0) {
            for ($i = 0; $i < $ucount; ++$i) {
                if ($_POST['xoops_upload_file'][$i] != '') {
                    $medianame = $_POST['xoops_upload_file'][$i];

The assignment to $medianame is dead and can be removed.

                    if ($uploader->fetchMedia($_POST['xoops_upload_file'][$i])) {
                        if (!$uploader->upload()) {
                            $err[] = $uploader->getErrors();
                        } else {
                            $savedfilename = $uploader->getSavedFileName();
                            $ticket        = uniqid(mt_rand(), 1);

The assignment to $ticket is dead and can be removed.

                            //Rename the uploaded file to the same name in a different location that does not have 777 rights or 755.
                            rename('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '', '' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/uploads/' . $savedfilename . '');
                            //Delete the uploaded file from the initial upload folder if it is still present in that folder.
                            if (file_exists('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '')) {
                                unlink('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '');
                            }
                            $sql = 'UPDATE '
                                   . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')

The variable $xoopsModule seems to be never defined.

                                   . " SET title = '$p_title', section = '$p_section', fieldtypeid = '$p_fieldtype', defaultyn = '$p_default', activeyn='$p_active', seq='$p_seq', options='$p_options', custom='$p_custom', icon='$savedfilename' WHERE dtypeid = $p_dtypeid";
                            $xoopsDB->query($sql) or $eh->show('0013');
                        }
                    } else {

This code seems to be duplicated across your project.

                        $sql = 'UPDATE '
                               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
                               . " SET title = '$p_title', section = '$p_section', fieldtypeid = '$p_fieldtype', defaultyn = '$p_default', activeyn='$p_active', seq='$p_seq', options='$p_options', custom='$p_custom' WHERE dtypeid = $p_dtypeid";
                        $xoopsDB->query($sql) or $eh->show('0013');
                    }
                } else {

This code seems to be duplicated across your project.

                    $sql = 'UPDATE '
                           . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
                           . " SET title = '$p_title', section = '$p_section', fieldtypeid = '$p_fieldtype', defaultyn = '$p_default', activeyn='$p_active', seq='$p_seq', options='$p_options', custom='$p_custom' WHERE dtypeid = $p_dtypeid";
                    $xoopsDB->query($sql) or $eh->show('0013');
                }
            }
        } else {

This code seems to be duplicated across your project.

            $sql = 'UPDATE '
                   . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
                   . " SET title = '$p_title', section = '$p_section', fieldtypeid = '$p_fieldtype', defaultyn = '$p_default', activeyn='$p_active', seq='$p_seq', options='$p_options', custom='$p_custom' WHERE dtypeid = $p_dtypeid";
            $xoopsDB->query($sql) or $eh->show('0013');
        }
    }
    redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_DTYPE_UPDATED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

    exit();
}

function addDatatype()
{
    global $xoopsDB, $_POST, $myts, $eh, $xoopsUser, $moddir;
    if (isset($_POST['catid'])) {
        $p_catid = $_POST['catid'];
    } else {
        exit();
    }
    $p_title = $myts->makeTboxData4Save($_POST['title']);
    if (isset($_POST['defaultyn'])) {
        $p_default = $_POST['defaultyn'];
    } else {
        $p_default = '0';
    }
    if (isset($_POST['activeyn'])) {
        $p_active = $_POST['activeyn'];
    } else {
        $p_active = '0';
    }
    if (isset($_POST['custom'])) {
        $p_custom = $_POST['custom'];
    } else {
        $p_custom = '0';
    }
    if (isset($_POST['options'])) {

This code seems to be duplicated across your project.

        $p_options = $myts->makeTareaData4Save($_POST['options']);
    } else {
        $p_options = '';
    }
    $p_fieldtype = (int)$_POST['typeid'];
    if ($p_fieldtype == '') {
        redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_NOFIELDTYPE_SELECTED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

        exit();
    }
    $p_section = $myts->makeTboxData4Save($_POST['section']);
    $uid       = $xoopsUser->getVar('uid');

    require_once XOOPS_ROOT_PATH . '/class/class.uploader.php';

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

    //$uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH.'/modules/'.$moddir.'/init_uploads', array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/jpg'), 30000, 50, 50);

62% of this comment could be valid code. Did you maybe forget this after debugging?

    $uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads", array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/jpg'), 30000, 50, 50);
    $uploader->setPrefix('icon');
    $err           = array();
    $ucount        = count($_POST['xoops_upload_file']);
    $savedfilename = '';
    for ($i = 0; $i < $ucount; ++$i) {
        if ($_POST['xoops_upload_file'][$i] != '') {
            $medianame = $_POST['xoops_upload_file'][$i];

The assignment to $medianame is dead and can be removed.

            if ($uploader->fetchMedia($_POST['xoops_upload_file'][$i])) {
                if (!$uploader->upload()) {

This code seems to be duplicated across your project.

                    $err[] = $uploader->getErrors();
                } else {
                    $savedfilename = $uploader->getSavedFileName();
                    $ticket        = uniqid(mt_rand(), 1);

The assignment to $ticket is dead and can be removed.

                    //Rename the uploaded file to the same name in a different location that does not have 777 rights or 755.
                    rename('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '', '' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/uploads/' . $savedfilename . '');
                    //Delete the uploaded file from the initial upload folder if it is still present in that folder.
                    if (file_exists('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '')) {
                        unlink('' . XOOPS_ROOT_PATH . '/modules/' . $moddir . '/init_uploads/' . $savedfilename . '');
                    }
                }
            }
        }
    }
    $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes') . '_dtypeid_seq');

The variable $xoopsModule seems to be never defined.

    $sql   = sprintf("INSERT INTO %s (dtypeid, title, section, fieldtypeid, uid, defaultyn, created, seq, activeyn, OPTIONS, custom, icon) VALUES (%u, '%s', %u, %u, %u, %u, '%s', '%s', %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes'), $newid, $p_title,
                     $p_section, $p_fieldtype, $uid, $p_default, time(), 0, $p_active, $p_options, $p_custom, $savedfilename);
    $xoopsDB->query($sql) or $eh->show('0013');
    $dtypeid = $xoopsDB->getInsertId();
    $newid   = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat') . '_xid_seq');
    $sql     = sprintf('INSERT INTO %s (xid, cid, dtypeid) VALUES (%u, %u, %u)', $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat'), $newid, $p_catid, $dtypeid);
    $xoopsDB->query($sql) or $eh->show('0013');
    redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);
    exit();
}

function editDatatypes()
{
    global $xoopsDB, $_POST, $myts, $eh, $moddir, $xoopsUser;
    $count      = 1;

The assignment to $count is dead and can be removed.

    $return     = '';

The assignment to $return is dead and can be removed.

    $dtypes     = $_POST['dtypes'];
    $p_catid    = $_POST['catid'];
    $dtypes_arr = explode('[|]', $dtypes);
    foreach ($dtypes_arr as $dtype) {
        $p_section = $myts->makeTboxData4Save($_POST['section' . $dtype . '']);
        if (isset($_POST['defaultyn' . $dtype . ''])) {
            $p_defaultyn = '1';
        } else {
            $p_defaultyn = '0';
        }
        $p_seq = $myts->makeTboxData4Save($_POST['seq' . $dtype . '']);
        if (isset($_POST['activeyn' . $dtype . ''])) {
            $p_activeyn = '1';
        } else {
            $p_activeyn = '0';
        }
        $sql = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes') . " SET section = '$p_section', defaultyn = '$p_defaultyn', activeyn='$p_activeyn', seq='$p_seq' WHERE dtypeid = $dtype";

The variable $xoopsModule seems to be never defined.

        $xoopsDB->query($sql) or $eh->show('0013');
    }
    redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

    exit();
}

function importDatatypes()
{
    global $xoopsDB, $_POST, $myts, $eh, $moddir, $xoopsUser;
    if (isset($_POST['pid'])) {
        $p_pid = $_POST['pid'];
    } else {
        exit();
    }
    if (isset($_POST['catid'])) {
        $p_catid = $_POST['catid'];
    } else {
        exit();
    }
    if ($p_pid != 0) {

This code seems to be duplicated across your project.

        $sql = 'INSERT INTO '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat')

The variable $xoopsModule seems to be never defined.

               . ' (cid, dtypeid) SELECT '
               . $p_catid
               . ', d.dtypeid FROM '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
               . ' d, '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n')
                                  . '_dtypes_x_cat')
               . ' x  WHERE d.dtypeid=x.dtypeid AND x.cid = '
               . $p_pid
               . " AND d.defaultyn = '1'";
    }
    $xoopsDB->query($sql) or $eh->show('0013');

The variable $sql does not seem to be defined for all execution paths leading up to this point.

    redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

    exit();
}

function updateCat()
{
    global $xoopsDB, $_POST, $myts, $eh, $moddir;
    if (isset($_POST['catid'])) {
        $p_catid = $_POST['catid'];
    } else {
        exit();
    }
    $descr_exists = checkDescription($p_catid);

    if (isset($_POST['pid'])) {
        $p_pid = $_POST['pid'];
    } else {
        $p_pid = '0';
    }
    $p_title = $myts->makeTboxData4Save($_POST['title']);
    if (isset($_POST['active'])) {
        $p_active = $_POST['active'];
    } else {
        $p_active = 0;
    }
    if (isset($_POST['allowlist'])) {
        $p_allowlist = $_POST['allowlist'];
    } else {
        $p_allowlist = 0;
    }
    if (isset($_POST['showpopular'])) {
        $p_showpopular = $_POST['showpopular'];
    } else {
        $p_showpopular = 0;
    }
    if (isset($_POST['descr'])) {

This code seems to be duplicated across your project.

        $p_descr = $myts->makeTareaData4Save($_POST['descr']);
    } else {
        $p_descr = false;
    }
    if ($_POST['xoops_upload_file'][0] != '') {
        require_once XOOPS_ROOT_PATH . "/modules/$moddir/class/class.uploader.php";

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

        $uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads", array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/jpg'), 30000, 250, 250);
        if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
            $filename = $uploader->getMediaName();

The assignment to $filename is dead and can be removed.

        } else {

This code seems to be duplicated across your project.

            $sql = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . " SET title = '$p_title', active='$p_active', pid='$p_pid', allowlist='$p_allowlist', showpopular='$p_showpopular' WHERE cid = $p_catid";

The variable $xoopsModule seems to be never defined.

            $xoopsDB->query($sql) or $eh->show('0013');

            if ($p_descr) {
                if ($descr_exists === true) {
                    $sql2 = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . " SET text='$p_descr' WHERE cid = $p_catid";
                } else {
                    $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . '_txtid_seq');
                    $sql2  = sprintf("INSERT INTO %s (txtid, cid, TEXT, active, created) VALUES (%u, %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $newid, $p_catid, $p_descr, '1', time());
                }
                $xoopsDB->query($sql2) or $eh->show('0013');
            }
            redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

            exit();
        }
        $uploader->setPrefix('efqdir');
        if ($uploader->upload()) {
            $savedfilename = $uploader->getSavedFileName();
            $width         = $uploader->getWidth();
            $height        = $uploader->getHeight();
            $imagelocation = $uploader->uploadDir;

The assignment to $imagelocation is dead and can be removed.

            echo $uploader->getErrors();

            $sql = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . " SET img = '$savedfilename', width = '$width', height = '$height' WHERE cid = $p_catid";
            $xoopsDB->query($sql) or $eh->show('0013');
            rename('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '', '' . XOOPS_ROOT_PATH . "/modules/$moddir/uploads/" . $savedfilename . '');
            //Delete the uploaded file from the initial upload folder if it is still present in that folder.
            if (file_exists('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '')) {

This code seems to be duplicated across your project.

                unlink('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '');
            }
            redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);
            exit();
        } else {

This code seems to be duplicated across your project.

            echo $uploader->getErrors();
            $sql = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . " SET title = '$p_title', active='$p_active', pid='$p_pid', allowlist='$p_allowlist', showpopular='$p_showpopular' WHERE cid = $p_catid";
            $xoopsDB->query($sql) or $eh->show('0013');
            if ($p_descr) {
                if ($descr_exists === true) {
                    $sql2 = 'UPDATE ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . " SET text='$p_descr' WHERE cid = $p_catid";
                } else {
                    $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . '_txtid_seq');
                    $sql2  = sprintf("INSERT INTO %s (txtid, cid, TEXT, active, created) VALUES (%u, %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $newid, $p_catid, $p_descr, '1', time());
                }
                $xoopsDB->query($sql2) or $eh->show('0013');
            }
            redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_UPDATED);
            exit();
        }
    }
    redirect_header("categories.php?op=edit&catid=$p_catid", 2, _MD_CAT_NOT_UPDATED);

The constant _MD_CAT_NOT_UPDATED was not found. Maybe you did not declare it correctly or list all dependencies?

    exit();
}

function newCat()
{
    global $xoopsDB, $_POST, $myts, $eh, $moddir;
    if (isset($_POST['dirid'])) {
        $p_dirid = $_POST['dirid'];
    } else {
        exit();
    }
    if (isset($_POST['pid'])) {
        $p_pid = $_POST['pid'];
    } else {
        $p_pid = '0';
    }
    $p_title = $myts->makeTboxData4Save($_POST['title']);
    if (isset($_POST['active'])) {
        $p_active = $_POST['active'];
    } else {
        $p_active = 0;
    }
    if (isset($_POST['importdtypes'])) {
        if ($p_pid != 0) {
            $p_import = $_POST['importdtypes'];
        } else {
            $p_import = 0;
        }
    } else {
        $p_import = 0;
    }
    if (isset($_POST['txtactive'])) {
        $p_txtactive = $_POST['txtactive'];
    } else {
        $p_txtactive = 0;
    }
    if (isset($_POST['allowlist'])) {
        $p_allowlist = $_POST['allowlist'];
    } else {
        $p_allowlist = 0;
    }
    if (isset($_POST['showpopular'])) {
        $p_showpopular = $_POST['showpopular'];
    } else {
        $p_showpopular = 0;
    }
    if (isset($_POST['descr'])) {

This code seems to be duplicated across your project.

        $p_descr = $myts->makeTareaData4Save($_POST['descr']);
    } else {
        $p_descr = '';
    }

    if ($_POST['xoops_upload_file'][0] != '') {
        require_once XOOPS_ROOT_PATH . "/modules/$moddir/class/class.uploader.php";

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

        $uploader = new XoopsMediaUploader(XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads", array('image/gif', 'image/jpeg', 'image/pjpeg', 'image/x-png', 'image/png', 'image/jpg'), 30000, 250, 250);
        if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
            $filename = $uploader->getMediaName();

The assignment to $filename is dead and can be removed.

        } else {
            $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . '_cid_seq');

The variable $xoopsModule seems to be never defined.

            $sql   = sprintf("INSERT INTO %s (cid, dirid, title, active, pid, allowlist, showpopular) VALUES (%u, %u, '%s', %u, %u, %u, %u)", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), $newid, $p_dirid, $p_title, $p_active, $p_pid, $p_allowlist, $p_showpopular);
            $xoopsDB->query($sql) or $eh->show('0013');
            if ($newid == 0) {
                $cid = $xoopsDB->getInsertId();
            }
            if ($p_descr != '') {
                $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . '_txtid_seq');
                $sql2  = sprintf("INSERT INTO %s (txtid, cid, TEXT, active, created) VALUES (%u, %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $newid, $cid, $p_descr, $p_txtactive, time());

The variable $cid does not seem to be defined for all execution paths leading up to this point.

                $xoopsDB->query($sql2) or $eh->show('0013');
            }
            if ($p_import == '1') {
                importDtypes($p_pid, $cid);
            }
            redirect_header("categories.php?op=edit&catid=$cid", 2, _MD_CAT_SAVED);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

            exit();
        }
        $uploader->setPrefix('efqdir');
        if ($uploader->upload()) {
            $savedfilename = $uploader->getSavedFileName();
            //echo $savedfilename;
            $width         = $uploader->getWidth();
            $height        = $uploader->getHeight();
            $imagelocation = $uploader->uploadDir;

The assignment to $imagelocation is dead and can be removed.

            echo $uploader->getErrors();
            $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . '_cid_seq');
            $sql   = sprintf("INSERT INTO %s (cid, dirid, title, active, pid, img, allowlist, showpopular, width, height) VALUES (%u, %u, '%s', %u, %u, '%s', %u, %u, %u, %u)", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), $newid, $p_dirid, $p_title, $p_active, $p_pid,
                             $savedfilename, $p_allowlist, $p_showpopular, $width, $height);
            $xoopsDB->query($sql) or $eh->show('0013');
            if ($newid == 0) {
                $cid = $xoopsDB->getInsertId();
            }
            if ($p_descr != '') {
                $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . '_txtid_seq');
                $sql2  = sprintf("INSERT INTO %s (txtid, cid, TEXT, active, created) VALUES (%u, %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $newid, $cid, $p_descr, $p_txtactive, time());
                $xoopsDB->query($sql2) or $eh->show('0013');
            }
            if ($p_import == '1') {
                importDtypes($p_pid, $cid);
            }
            rename('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '', '' . XOOPS_ROOT_PATH . "/modules/$moddir/uploads/" . $savedfilename . '');
            //Delete the uploaded file from the initial upload folder if it is still present in that folder.
            if (file_exists('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '')) {

This code seems to be duplicated across your project.

                unlink('' . XOOPS_ROOT_PATH . "/modules/$moddir/init_uploads/" . $savedfilename . '');
            }
            redirect_header("categories.php?op=edit&catid=$cid", 2, _MD_CAT_SAVED);
            exit();
        } else {
            echo $uploader->getErrors();
            $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . '_cid_seq');
            $sql   = sprintf("INSERT INTO %s (cid, dirid, title, active, pid, img, allowlist, showpopular, width, height) VALUES (%u, %u, '%s', %u, %u, %u, %u, %u, %u, %u)", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), $newid, $p_dirid, $p_title, $p_active, $p_pid, '',
                             $p_allowlist, $p_showpopular, '', '');
            $xoopsDB->query($sql) or $eh->show('0013');
            if ($newid == 0) {
                $cid = $xoopsDB->getInsertId();
            }
            if ($p_descr != '') {
                $newid = $xoopsDB->genId($xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt') . '_txtid_seq');
                $sql2  = sprintf("INSERT INTO %s (txtid, cid, TEXT, active, created) VALUES (%u, %u, '%s', %u, '%s')", $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $newid, $cid, $p_descr, $p_txtactive, time());
                $xoopsDB->query($sql2) or $eh->show('0013');
            }
            if ($p_import == '1') {
                importDtypes($p_pid, $cid);
            }
            redirect_header("categories.php?op=edit&catid=$cid", 2, _MD_CAT_SAVED);
            exit();
        }
    }

    redirect_header("categories.php?op=edit&catid=$cid", 2, _MD_CAT_SAVED);

The variable $cid seems to be never defined.

    exit();
}

function deleteCatConfirm()

This function seems to be duplicated in your project.

{
    global $xoopsDB, $_POST, $eh, $xoopsModule, $get_catid;
    xoops_cp_header();

The function xoops_cp_header was not found. Maybe you did not declare it correctly or list all dependencies?

    $form        = new XoopsThemeForm(_MD_CONFIRM_DELETECAT_FORM, 'confirmform', 'categories.php');
    $submit_tray = new XoopsFormElementTray(_MD_DELETE_CAT_YN, '', 'cid');
    $submit_tray->addElement(new XoopsFormButton('', 'submit', _MD_DELETE, 'submit'));
    $submit_tray->addElement(new XoopsFormLabel('', '<input type="button" class="formButton" value="' . _MD_CANCEL . "\" onclick=\"location='categories.php?op=edit&amp;catid=$get_catid'\""));
    $form->addElement($submit_tray, true);
    //'$form->addElement($form_submit);
    $form->addElement(new XoopsFormHidden('op', 'deleteCat'));
    $form->addElement(new XoopsFormHidden('catid', $get_catid));
    $form->display();
    xoops_cp_footer();

The function xoops_cp_footer was not found. Maybe you did not declare it correctly or list all dependencies?

}

function deleteCat()
{
    global $xoopsDB, $_POST, $eh, $xoopsModule;
    if (isset($_POST['catid'])) {
        $p_catid = (int)$_POST['catid'];
    } else {
        redirect_header('directories.php', 2, _MD_INVALID_DIR);

The function redirect_header was not found. Maybe you did not declare it correctly or list all dependencies?

        exit();
    }
    $dirid = getDirId($p_catid);
    $sql   = sprintf('DELETE FROM %s WHERE cid = %u', $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_item_x_cat'), $p_catid);
    $xoopsDB->queryF($sql) or $eh->show('0013');
    $sql = sprintf('DELETE FROM %s WHERE cid = %u', $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat'), $p_catid);
    $xoopsDB->queryF($sql) or $eh->show('0013');
    $sql = sprintf('DELETE FROM %s WHERE cid = %u', $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat_txt'), $p_catid);
    $xoopsDB->queryF($sql) or $eh->show('0013');
    $sql = sprintf('DELETE FROM %s WHERE cid = %u', $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat'), $p_catid);
    $xoopsDB->queryF($sql) or $eh->show('0013');
    redirect_header('categories.php?dirid=' . $dirid, 2, _MD_CAT_DELETED);

The constant _MD_CAT_DELETED was not found. Maybe you did not declare it correctly or list all dependencies?

    exit();
}

if (!isset($_POST['op'])) {

This code seems to be duplicated across your project.

    $op = isset($_GET['op']) ? $_GET['op'] : 'main';
} else {
    $op = $_POST['op'];
}
switch ($op) {
    case 'newdatatype':
        addDatatype();
        break;
    case 'editdtypes':
        editDatatypes();
        break;
    case 'editdtype':
        editDatatype($get_dtypeid);
        break;
    case 'savedtype':
        saveDatatype();
        break;
    case 'importdtypes':
        importDatatypes();
        break;
    case 'edit':
        editCat($get_catid);
        break;
    case 'update':
        updateCat();
        break;
    case 'newcat':
        newCat();
        break;
    case 'deleteCat':
        deleteCat();
        break;
    case 'deleteCatConfirm':
        deleteCatConfirm();
        break;
    default:
        catConfig($get_dirid);
        break;
}

function getCatOverview()
{
    global $xoopsDB, $myts, $eh, $mytree, $get_dirid, $moddir;
    $mainresult = $xoopsDB->query('SELECT cid, title, active, pid FROM ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . " WHERE dirid='" . $get_dirid . '\' AND pid=\'0\'');

The variable $xoopsModule seems to be never defined.

    $numrows    = $xoopsDB->getRowsNum($mainresult);
    $output     = '';
    if ($numrows > 0) {
        $output = '<th>' . _MD_CATTITLE . '</th><th>' . _MD_ACTIVE . '</th><th>' . _MD_ACTION . "</th>\n";
        $brench = 0;

The assignment to $brench is dead and can be removed.

        $tab    = '';
        while (list($cid, $title, $active, $pid) = $xoopsDB->fetchRow($mainresult)) {
            //For each cid, get all 'first children' using getFirstChildId() function
            if ($active != '0') {

This code seems to be duplicated across your project.

                $activeyn = '' . _MD_YES . '';
            } else {
                $activeyn = '' . _MD_NO . '';
            }
            $output .= '<tr><td>'
                       . $tab
                       . ''
                       . $title
                       . '</td><td>'
                       . $activeyn
                       . '</td><td><a href="'
                       . XOOPS_URL

The constant XOOPS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

                       . "/modules/$moddir/admin/categories.php?op=edit&catid=$cid\"><img src=\""
                       . XOOPS_URL
                       . '/modules/'
                       . $moddir
                       . '/assets/images/accessories-text-editor.png" title="'
                       . _MD_MANAGE_CAT
                       . '" alt="'
                       . _MD_MANAGE_CAT
                       . "\"></a></td></tr>\n";
            $output .= getChildrenCategories($cid);
        }
    } else {
        $output = '<p><span style="background-color: #E6E6E6; padding: 5px; border: 1px solid #000000;">' . _MD_NORESULTS_PLEASE_CREATE_CATEGORY . '</span></p>';
    }

    return $output;
}

function getChildrenCategories($childid = '0', $level = '0')
{
    global $xoopsDB, $myts, $eh, $mytree, $get_dirid, $moddir;
    $tab    = '&nbsp;';
    $level  = $level;
    $output = '';
    $plus   = '<img src="' . XOOPS_URL . '/images/arrow.gif">';

The constant XOOPS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

    for ($i = 0; $i < $level; ++$i) {
        $tab .= '&nbsp;&nbsp;&nbsp;&nbsp;';
    }
    $sql         = 'SELECT cid, title, active, pid FROM ' . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_cat') . " WHERE dirid='" . $get_dirid . '\' AND pid=\'' . $childid . '\'';

The variable $xoopsModule seems to be never defined.

    $childresult = $xoopsDB->query($sql);
    $numrows     = $xoopsDB->getRowsNum($childresult);
    if ($numrows > 0) {
        while (list($cid, $title, $active, $pid) = $xoopsDB->fetchRow($childresult)) {
            if ($active != '0') {

This code seems to be duplicated across your project.

                $activeyn = '' . _MD_YES . '';
            } else {
                $activeyn = '' . _MD_NO . '';
            }
            $output   .= '<tr><td>'
                         . $tab
                         . $plus
                         . $title
                         . '&nbsp;</td><td>'
                         . $activeyn
                         . '</td><td><a href="'
                         . XOOPS_URL
                         . "/modules/$moddir/admin/categories.php?op=edit&catid=$cid\"><img src=\""
                         . XOOPS_URL
                         . '/modules/'
                         . $moddir
                         . '/assets/images/accessories-text-editor.png" title="'
                         . _MD_MANAGE_CAT
                         . '" alt="'
                         . _MD_MANAGE_CAT
                         . "\"></a></td></tr>\n";
            $newlevel = $level + 1;
            $output   .= getChildrenCategories($cid, $newlevel);
        }
    }

    return $output;
}

function importDtypes($pid = '0', $catid = '0')
{
    global $xoopsDB, $_POST, $eh;
    if ($pid != 0) {

This code seems to be duplicated across your project.

        $sql = 'INSERT INTO '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes_x_cat')

The variable $xoopsModule seems to be never defined.

               . ' (cid, dtypeid) SELECT '
               . $catid
               . ', d.dtypeid FROM '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n') . '_dtypes')
               . ' d, '
               . $xoopsDB->prefix($xoopsModule->getVar('dirname', 'n')
                                  . '_dtypes_x_cat')
               . ' x  WHERE d.dtypeid=x.dtypeid AND x.cid = '
               . $pid
               . " AND d.defaultyn = '1'";
    }
    $xoopsDB->query($sql) or $eh->show('0013');

The variable $sql does not seem to be defined for all execution paths leading up to this point.

}