XoopsFormImage::__construct() - Code Metrics - Inspection of "Updates" - XoopsModules25x/efqdirectory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Michael

created 2017-07-23 13:16 UTC

XoopsFormImage::__construct() A

↳ Parent: XoopsFormImage

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	8
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0

How to fix Many Parameters

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      efqdirectory
 * @since
 * @author       Martijn Hertog (aka wtravel)
 * @author       XOOPS Development Team,
 */
class XoopsFormImage extends XoopsFormElement
filter:
    dependency_paths: ["lib/*"]
{
    /**
     * Options
     * @var array
     * @access private
     */
    public $_options  = array();
    public $_multiple = false;
    public $_size;

    public $_height;
    public $_width;
    public $_src;
    public $_value = array();

    /**
     * Constructor
     *
     * @param string     $caption  Caption
     * @param string     $name     "name" attribute
     * @param mixed      $value    Pre-selected value (or array of them).
     * @param string     $src
     * @param string     $height
     * @param string     $width
     * @param bool       $multiple Allow multiple selections?
     * @param int|string $size     Size of the selection box
     */
    public function __construct($caption, $name, $value = null, $src = '', $height = '50', $width = '50', $multiple = false, $size = '1')
    {
        $this->setCaption($caption);
        $this->setName($name);
        $this->_multiple = $multiple;
        $this->_size     = (int)$size;
        if (isset($value)) {
            $this->setValue($value);
        }
        $this->_height = $height;
        $this->_width  = $width;
        $this->_src    = $src;
    }

    /**
     * @return string
     */
    public function getWidth()
    {
        return $this->_width;
    }

    /**
     * @return string
     */
    public function getHeight()
    {
        return $this->_height;
    }

    /**
     * @return string
     */
    public function getSrc()
    {
        return $this->_src;
    }

    /*
    * Are multiple selections allowed?
    *
    * @return bool
    */
    /**
     * @return bool
     */
    public function isMultiple()
    {
        return $this->_multiple;
    }

    /**
     * Get the size
     *
     * @return int
     */
    public function getSize()
    {
        return $this->_size;
    }

    /**
     * Get an array of pre-selected values
     *
     * @return array
     */
    public function getValue()
    {
        return $this->_value;
    }

    /**
     * Set pre-selected values
     *
     * @param $value mixed
     */
    public function setValue($value)

    {
        if (is_array($value)) {
            foreach ($value as $v) {
                $this->_value[] = $v;
            }
        } else {
            $this->_value[] = $value;
        }
    }

    /**
     * Add an option
     *
     * @param string $value "value" attribute
     * @param string $name  "name" attribute
     */
    public function addOption($value, $name = '')

    {
        if ($name !== '') {
            $this->_options[$value] = $name;
        } else {
            $this->_options[$value] = $value;
        }
    }

    /**
     * Add multiple options
     *
     * @param array $options Associative array of value->name pairs
     */
    public function addOptionArray($options)
    {
        if (is_array($options)) {
            foreach ($options as $k => $v) {
                $this->addOption($k, $v);
            }
        }
    }

    /**
     * Get all options
     *
     * @return array   Associative array of value->name pairs
     */
    public function getOptions()
    {
        return $this->_options;
    }

    /**
     * Prepare HTML for output
     *
     * @return string  HTML
     */
    public function render()
    {
        if ($this->getSrc() !== '') {
            $ret = "<img src='" . $this->getSrc() . '\' width=\'' . $this->getWidth() . '\'  height=\'' . $this->getHeight() . '\'';
            $ret .= '>';
        } else {
            $ret = _MD_NOIMAGE;
        }

        return $ret;
    }
}


1		<?php
2		/*
3		* You may not change or alter any portion of this comment or credits
4		* of supporting developers from this source code or any supporting source code
5		* which is considered copyrighted (c) material of the original comment or credit authors.
6		*
7		* This program is distributed in the hope that it will be useful,
8		* but WITHOUT ANY WARRANTY; without even the implied warranty of
9		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* @copyright {@link https://xoops.org/ XOOPS Project}
14		* @license {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
15		* @package efqdirectory
16		* @since
17		* @author Martijn Hertog (aka wtravel)
18		* @author XOOPS Development Team,
19		*/
20		class XoopsFormImage extends XoopsFormElement
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The type `XoopsFormElement` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21		{
22		/**
23		* Options
24		* @var array
25		* @access private
26		*/
27		public $_options = array();
28		public $_multiple = false;
29		public $_size;
30
31		public $_height;
32		public $_width;
33		public $_src;
34		public $_value = array();
35
36		/**
37		* Constructor
38		*
39		* @param string $caption Caption
40		* @param string $name "name" attribute
41		* @param mixed $value Pre-selected value (or array of them).
42		* @param string $src
43		* @param string $height
44		* @param string $width
45		* @param bool $multiple Allow multiple selections?
46		* @param int\|string $size Size of the selection box
47		*/
48		public function __construct($caption, $name, $value = null, $src = '', $height = '50', $width = '50', $multiple = false, $size = '1')
49		{
50		$this->setCaption($caption);
51		$this->setName($name);
52		$this->_multiple = $multiple;
53		$this->_size = (int)$size;
54		if (isset($value)) {
55		$this->setValue($value);
56		}
57		$this->_height = $height;
58		$this->_width = $width;
59		$this->_src = $src;
60		}
61
62		/**
63		* @return string
64		*/
65		public function getWidth()
66		{
67		return $this->_width;
68		}
69
70		/**
71		* @return string
72		*/
73		public function getHeight()
74		{
75		return $this->_height;
76		}
77
78		/**
79		* @return string
80		*/
81		public function getSrc()
82		{
83		return $this->_src;
84		}
85
86		/*
87		* Are multiple selections allowed?
88		*
89		* @return bool
90		*/
91		/**
92		* @return bool
93		*/
94		public function isMultiple()
95		{
96		return $this->_multiple;
97		}
98
99		/**
100		* Get the size
101		*
102		* @return int
103		*/
104		public function getSize()
105		{
106		return $this->_size;
107		}
108
109		/**
110		* Get an array of pre-selected values
111		*
112		* @return array
113		*/
114		public function getValue()
115		{
116		return $this->_value;
117		}
118
119		/**
120		* Set pre-selected values
121		*
122		* @param $value mixed
123		*/
124	View Code Duplication	public function setValue($value)
		0 ignored issues – show Duplication introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
125		{
126		if (is_array($value)) {
127		foreach ($value as $v) {
128		$this->_value[] = $v;
129		}
130		} else {
131		$this->_value[] = $value;
132		}
133		}
134
135		/**
136		* Add an option
137		*
138		* @param string $value "value" attribute
139		* @param string $name "name" attribute
140		*/
141	View Code Duplication	public function addOption($value, $name = '')
		0 ignored issues – show Duplication introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142		{
143		if ($name !== '') {
144		$this->_options[$value] = $name;
145		} else {
146		$this->_options[$value] = $value;
147		}
148		}
149
150		/**
151		* Add multiple options
152		*
153		* @param array $options Associative array of value->name pairs
154		*/
155		public function addOptionArray($options)
156		{
157		if (is_array($options)) {
158		foreach ($options as $k => $v) {
159		$this->addOption($k, $v);
160		}
161		}
162		}
163
164		/**
165		* Get all options
166		*
167		* @return array Associative array of value->name pairs
168		*/
169		public function getOptions()
170		{
171		return $this->_options;
172		}
173
174		/**
175		* Prepare HTML for output
176		*
177		* @return string HTML
178		*/
179		public function render()
180		{
181		if ($this->getSrc() !== '') {
182		$ret = "<img src='" . $this->getSrc() . '\' width=\'' . $this->getWidth() . '\' height=\'' . $this->getHeight() . '\'';
183		$ret .= '>';
184		} else {
185		$ret = _MD_NOIMAGE;
186		}
187
188		return $ret;
189		}
190		}
191

XoopsModules25x / efqdirectory

Pull Request — master (#1)

XoopsFormImage::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like