efqSubscriptionOfferHandler::__construct() - Code Metrics - Inspection of "Merge pull request #1 from mambax7/master" - XoopsModules25x/efqdirectory - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 2ecc51...c1b656 )

by Michael

created 2017-07-23 13:16 UTC

efqSubscriptionOfferHandler::__construct() A

↳ Parent: efqSubscriptionOfferHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php
/*
// ID: class.offer.php 30-apr-2007 13:39:01 efqconsultancy
//  ------------------------------------------------------------------------ //
//                				EFQ Directory			                     //
//                    Copyright (c) 2006 EFQ Consultancy                     //
//                       <http://www.efqdirectory.com/>                      //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
//	Part of the efqDirectory module provided by: wtravel					 //
// 	e-mail: [email protected]											 //
//	Purpose: Create a business directory for xoops.		 	 				 //
//	Based upon the mylinks and the mxDirectory modules						 //
// ------------------------------------------------------------------------- //
*/

/**
 * Class efqSubscriptionOffer
 * Manages operations for subscription offers
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <[email protected]>
 * @copyright EFQ Consultancy (c) 2008
 * @version   1.1.0
 */
class efqSubscriptionOffer extends XoopsObject
filter:
    dependency_paths: ["lib/*"]
{

    /**
     * efqSubscriptionOffer::efqSubscriptionOffer()
     *
     * @param bool $offer
     * @internal param bool $itemtype
     */
    public function __construct($offer = false)
    {
        global $moddir;
        $this->db = XoopsDatabaseFactory::getDatabaseConnection();
filter:
    dependency_paths: ["lib/*"]
        $this->initVar('offerid', XOBJ_DTYPE_INT, 0, false);

        $this->initVar('dirid', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('typeid', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('title', XOBJ_DTYPE_TXTBOX, null, true, 255);

        $this->initVar('duration', XOBJ_DTYPE_INT, 0, true, 5);
        $this->initVar('count', XOBJ_DTYPE_INT, 0, true, 5);
        $this->initVar('price', XOBJ_DTYPE_CURRENCY, 0.00, true);

        $this->initVar('activeyn', XOBJ_DTYPE_INT, 0, true, 2);
        $this->initVar('currency', XOBJ_DTYPE_TXTBOX, null, false, 10);
        $this->initVar('descr', XOBJ_DTYPE_OTHER, 0);

        $this->initVar('typename', XOBJ_DTYPE_TXTBOX, null, false, 50);
        $this->initVar('level', XOBJ_DTYPE_INT, null, false, 10);
    }
}

/**
 * Class efqFieldTypeHandler
 * Manages database operations for field types
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <[email protected]>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqSubscriptionOfferHandler extends xoopsObjectHandler
filter:
    dependency_paths: ["lib/*"]
{
//    public $db; //Database reference

    public $objOffer; // reference to object

    /**
     * efqSubscriptionOfferHandler::efqItemTypeHandler()
     *
     * @param bool $offer
     */
    public function __construct($offer = false)
    {
        $this->db       = XoopsDatabaseFactory::getDatabaseConnection();
        $this->objOffer = $offer;
    }

    /**
     * Function insertOffer inserts Subscripion offer into DB
     * @author    EFQ Consultancy <[email protected]>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param   efqSubscriptionOffer $obj object
     *
     * @param bool     $forceQuery
     * @return bool true if insertion is succesful, false if unsuccesful
     */
    public function insertOffer($obj, $forceQuery = false)

    {
        $tablename    = 'efqdiralpha1_subscr_offers';
        $keyName      = 'offerid';
        $excludedVars = array('level', 'typename');
        if ($obj instanceof efqSubscriptionOffer) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 1;
        $strFields = '';
        $strValues = '';
        foreach ($cleanvars as $k => $v) {
            if (!in_array($k, $excludedVars)) {
                $strFields .= $k;
                $strValues .= "'" . $v . "'";
                if ($i < $countVars) {
                    $strFields .= ', ';
                    $strValues .= ', ';
                }
                $i++;
            }
        }
        $sql = sprintf('INSERT INTO %s (%s) VALUES (%s)', $this->db->prefix($tablename), $strFields, $strValues);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        }

        return false;
    }

    /**
     * Function updateOffer updates subscription offer
     * @author    EFQ Consultancy <[email protected]>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param      $obj
     * @param bool $forceQuery
     * @return bool true if update is succesful, false if unsuccesful
     * @internal  param object $objOffer object of type listing
     */
    public function updateOffer($obj, $forceQuery = false)

    {
        $tablename    = 'efqdiralpha1_subscr_offers';
        $keyName      = 'offerid';
        $excludedVars = array('level', 'typename');
        if ($obj instanceof efqSubscriptionOffer) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
            $keyValue  = $obj->getVar($keyName);
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 1;
        $strSet    = '';
        $strValues = '';

        foreach ($cleanvars as $k => $v) {
            if (!in_array($k, $excludedVars)) {
                if ($i < $countVars and $i > 1) {
                    $strSet .= ', ';
                }
                $strSet .= $k . '=' . "'" . $v . "'";
            }
            $i++;
        }
        $sql = sprintf('UPDATE %s SET %s WHERE %s = %u', $this->db->prefix($tablename), $strSet, $keyName, $keyValue);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                return true;
            }
        }

        return false;
    }

    /**
     * efqSubscriptionOfferHandler::setOffer()
     *
     * Sets the object created by class efqSubscriptionOffer with data from query
     *
     * @param int $gpc_offerid
     * @return bool true or false
     */
    public function setOffer($gpc_offerid = 0)
    {
        $sql     = 'SELECT o.offerid, o.title, o.typeid, o.duration, o.count, '
                   . 'o.price, o.activeyn, o.currency, o.descr, o.dirid, t.typename, t.level FROM '
                   . $this->db->prefix('efqdiralpha1_itemtypes')
                   . ' t, '
                   . $this->db->prefix('efqdiralpha1_subscr_offers')
                   . ' o	WHERE o.typeid=t.typeid AND o.offerid='
                   . (int)$gpc_offerid
                   . '';
        $result  = $this->db->query($sql);
        $numrows = $this->db->getRowsNum($result);
        if ($numrows > 0) {

            while (list($offerid, $offertitle, $typeid, $duration, $count, $price, $activeyn, $currency, $descr, $dirid, $typename, $level) = $this->db->fetchRow($result)) {
                if (!$this->objOffer) {
                    $this->objOffer = new efqSubscriptionOffer();
                }
                $this->objOffer->setVar('offerid', $offerid);
                $this->objOffer->setVar('title', $offertitle);
                $this->objOffer->setVar('typeid', $typeid);
                $this->objOffer->setVar('duration', $duration);
                $this->objOffer->setVar('count', $count);
                $this->objOffer->setVar('price', $price);
                $this->objOffer->setVar('activeyn', $activeyn);
                $this->objOffer->setVar('currency', $currency);
                $this->objOffer->setVar('descr', $descr);
                $this->objOffer->setVar('dirid', $dirid);
                $this->objOffer->setVar('typename', $typename);
                $this->objOffer->setVar('level', $level);
            }
        } else {
            return false;
        }

        return true;
    }

    /**
     * @return bool
     */
    public function getOffer()
    {
        return $this->objOffer;
    }
}


1		<?php
2		/*
3		// ID: class.offer.php 30-apr-2007 13:39:01 efqconsultancy
4		// ------------------------------------------------------------------------ //
5		// EFQ Directory //
6		// Copyright (c) 2006 EFQ Consultancy //
7		// <http://www.efqdirectory.com/> //
8		// ------------------------------------------------------------------------ //
9		// This program is free software; you can redistribute it and/or modify //
10		// it under the terms of the GNU General Public License as published by //
11		// the Free Software Foundation; either version 2 of the License, or //
12		// (at your option) any later version. //
13		// //
14		// You may not change or alter any portion of this comment or credits //
15		// of supporting developers from this source code or any supporting //
16		// source code which is considered copyrighted (c) material of the //
17		// original comment or credit authors. //
18		// //
19		// This program is distributed in the hope that it will be useful, //
20		// but WITHOUT ANY WARRANTY; without even the implied warranty of //
21		// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
22		// GNU General Public License for more details. //
23		// //
24		// You should have received a copy of the GNU General Public License //
25		// along with this program; if not, write to the Free Software //
26		// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
27		// ------------------------------------------------------------------------ //
28		// Part of the efqDirectory module provided by: wtravel //
29		// e-mail: [email protected] //
30		// Purpose: Create a business directory for xoops. //
31		// Based upon the mylinks and the mxDirectory modules //
32		// ------------------------------------------------------------------------- //
33		*/
34
35		/**
36		* Class efqSubscriptionOffer
37		* Manages operations for subscription offers
38		*
39		* @package efqDirectory
40		* @author EFQ Consultancy <[email protected]>
41		* @copyright EFQ Consultancy (c) 2008
42		* @version 1.1.0
43		*/
44	View Code Duplication	class efqSubscriptionOffer extends XoopsObject
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The type `XoopsObject` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history... Duplication introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46
47		/**
48		* efqSubscriptionOffer::efqSubscriptionOffer()
49		*
50		* @param bool $offer
51		* @internal param bool $itemtype
52		*/
53		public function __construct($offer = false)
54		{
55		global $moddir;
56		$this->db = XoopsDatabaseFactory::getDatabaseConnection();
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The type `XoopsDatabaseFactory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
57		$this->initVar('offerid', XOBJ_DTYPE_INT, 0, false);
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The constant `XOBJ_DTYPE_INT` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
58		$this->initVar('dirid', XOBJ_DTYPE_INT, 0, false);
59		$this->initVar('typeid', XOBJ_DTYPE_INT, 0, false);
60		$this->initVar('title', XOBJ_DTYPE_TXTBOX, null, true, 255);
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The constant `XOBJ_DTYPE_TXTBOX` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
61		$this->initVar('duration', XOBJ_DTYPE_INT, 0, true, 5);
62		$this->initVar('count', XOBJ_DTYPE_INT, 0, true, 5);
63		$this->initVar('price', XOBJ_DTYPE_CURRENCY, 0.00, true);
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The constant `XOBJ_DTYPE_CURRENCY` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
64		$this->initVar('activeyn', XOBJ_DTYPE_INT, 0, true, 2);
65		$this->initVar('currency', XOBJ_DTYPE_TXTBOX, null, false, 10);
66		$this->initVar('descr', XOBJ_DTYPE_OTHER, 0);
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The constant `XOBJ_DTYPE_OTHER` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
67		$this->initVar('typename', XOBJ_DTYPE_TXTBOX, null, false, 50);
68		$this->initVar('level', XOBJ_DTYPE_INT, null, false, 10);
69		}
70		}
71
72		/**
73		* Class efqFieldTypeHandler
74		* Manages database operations for field types
75		*
76		* @package efqDirectory
77		* @author EFQ Consultancy <[email protected]>
78		* @copyright EFQ Consultancy (c) 2007
79		* @version 1.1.0
80		*/
81		class efqSubscriptionOfferHandler extends xoopsObjectHandler
		0 ignored issues – show Bug introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The type `xoopsObjectHandler` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
82		{
83		// public $db; //Database reference
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
84		public $objOffer; // reference to object
85
86		/**
87		* efqSubscriptionOfferHandler::efqItemTypeHandler()
88		*
89		* @param bool $offer
90		*/
91		public function __construct($offer = false)
92		{
93		$this->db = XoopsDatabaseFactory::getDatabaseConnection();
94		$this->objOffer = $offer;
95		}
96
97		/**
98		* Function insertOffer inserts Subscripion offer into DB
99		* @author EFQ Consultancy <[email protected]>
100		* @copyright EFQ Consultancy (c) 2008
101		* @version 1.0.0
102		*
103		* @param efqSubscriptionOffer $obj object
104		*
105		* @param bool $forceQuery
106		* @return bool true if insertion is succesful, false if unsuccesful
107		*/
108	View Code Duplication	public function insertOffer($obj, $forceQuery = false)
		0 ignored issues – show Duplication introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
109		{
110		$tablename = 'efqdiralpha1_subscr_offers';
111		$keyName = 'offerid';
112		$excludedVars = array('level', 'typename');
113		if ($obj instanceof efqSubscriptionOffer) {
114		// Variable part of this function ends. From this line you can copy
115		// this function for similar object handling functions.
116		$obj->cleanVars();
117		$cleanvars = $obj->cleanVars;
118		} else {
119		return false;
120		}
121		$countVars = count($cleanvars);
122		$i = 1;
123		$strFields = '';
124		$strValues = '';
125		foreach ($cleanvars as $k => $v) {
126		if (!in_array($k, $excludedVars)) {
127		$strFields .= $k;
128		$strValues .= "'" . $v . "'";
129		if ($i < $countVars) {
130		$strFields .= ', ';
131		$strValues .= ', ';
132		}
133		$i++;
134		}
135		}
136		$sql = sprintf('INSERT INTO %s (%s) VALUES (%s)', $this->db->prefix($tablename), $strFields, $strValues);
137		if ($forceQuery) {
138		if ($this->db->queryF($sql)) {
139		$itemid = $this->db->getInsertId();
140		$obj->setVar($keyName, $itemid);
141
142		return true;
143		}
144		} else {
145		if ($this->db->query($sql)) {
146		$itemid = $this->db->getInsertId();
147		$obj->setVar($keyName, $itemid);
148
149		return true;
150		}
151		}
152
153		return false;
154		}
155
156		/**
157		* Function updateOffer updates subscription offer
158		* @author EFQ Consultancy <[email protected]>
159		* @copyright EFQ Consultancy (c) 2008
160		* @version 1.0.0
161		*
162		* @param $obj
163		* @param bool $forceQuery
164		* @return bool true if update is succesful, false if unsuccesful
165		* @internal param object $objOffer object of type listing
166		*/
167	View Code Duplication	public function updateOffer($obj, $forceQuery = false)
		0 ignored issues – show Duplication introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
168		{
169		$tablename = 'efqdiralpha1_subscr_offers';
170		$keyName = 'offerid';
171		$excludedVars = array('level', 'typename');
172		if ($obj instanceof efqSubscriptionOffer) {
173		// Variable part of this function ends. From this line you can copy
174		// this function for similar object handling functions.
175		$obj->cleanVars();
176		$cleanvars = $obj->cleanVars;
177		$keyValue = $obj->getVar($keyName);
178		} else {
179		return false;
180		}
181		$countVars = count($cleanvars);
182		$i = 1;
183		$strSet = '';
184		$strValues = '';
		0 ignored issues – show Unused Code introduced 2017-07-23 13:05 UTC by Report Bug Copy Issue Report The assignment to `$strValues` is dead and can be removed. Loading history...
185		foreach ($cleanvars as $k => $v) {
186		if (!in_array($k, $excludedVars)) {
187		if ($i < $countVars and $i > 1) {
188		$strSet .= ', ';
189		}
190		$strSet .= $k . '=' . "'" . $v . "'";
191		}
192		$i++;
193		}
194		$sql = sprintf('UPDATE %s SET %s WHERE %s = %u', $this->db->prefix($tablename), $strSet, $keyName, $keyValue);
195		if ($forceQuery) {
196		if ($this->db->queryF($sql)) {
197		return true;
198		}
199		} else {
200		if ($this->db->query($sql)) {
201		return true;
202		}
203		}
204
205		return false;
206		}
207
208		/**
209		* efqSubscriptionOfferHandler::setOffer()
210		*
211		* Sets the object created by class efqSubscriptionOffer with data from query
212		*
213		* @param int $gpc_offerid
214		* @return bool true or false
215		*/
216		public function setOffer($gpc_offerid = 0)
217		{
218		$sql = 'SELECT o.offerid, o.title, o.typeid, o.duration, o.count, '
219		. 'o.price, o.activeyn, o.currency, o.descr, o.dirid, t.typename, t.level FROM '
220		. $this->db->prefix('efqdiralpha1_itemtypes')
221		. ' t, '
222		. $this->db->prefix('efqdiralpha1_subscr_offers')
223		. ' o WHERE o.typeid=t.typeid AND o.offerid='
224		. (int)$gpc_offerid
225		. '';
226		$result = $this->db->query($sql);
227		$numrows = $this->db->getRowsNum($result);
228	View Code Duplication	if ($numrows > 0) {
		0 ignored issues – show Duplication introduced 2017-07-23 13:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
229		while (list($offerid, $offertitle, $typeid, $duration, $count, $price, $activeyn, $currency, $descr, $dirid, $typename, $level) = $this->db->fetchRow($result)) {
230		if (!$this->objOffer) {
231		$this->objOffer = new efqSubscriptionOffer();
232		}
233		$this->objOffer->setVar('offerid', $offerid);
234		$this->objOffer->setVar('title', $offertitle);
235		$this->objOffer->setVar('typeid', $typeid);
236		$this->objOffer->setVar('duration', $duration);
237		$this->objOffer->setVar('count', $count);
238		$this->objOffer->setVar('price', $price);
239		$this->objOffer->setVar('activeyn', $activeyn);
240		$this->objOffer->setVar('currency', $currency);
241		$this->objOffer->setVar('descr', $descr);
242		$this->objOffer->setVar('dirid', $dirid);
243		$this->objOffer->setVar('typename', $typename);
244		$this->objOffer->setVar('level', $level);
245		}
246		} else {
247		return false;
248		}
249
250		return true;
251		}
252
253		/**
254		* @return bool
255		*/
256		public function getOffer()
257		{
258		return $this->objOffer;
259		}
260		}
261

XoopsModules25x / efqdirectory

Push — master ( 2ecc51...c1b656 )

efqSubscriptionOfferHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like