efqDataFieldManager::getFieldValue()

Complexity

Conditions	38
Paths	1555

Size

Total Lines	144
Code Lines	121

Duplication

Lines	39
Ratio	27.08 %

Importance

Changes

0

<?php
    public function getFieldValue($fieldtype = '', $options = '', $value = 0)
    {
        global $form, $myts, $moddir;
        switch ($fieldtype) {
            case 'textbox':
                return $myts->htmlSpecialChars($value);
                break;

break is not strictly necessary here and could be removed.

            case 'yesno':
                if ($value == '1') {
                    return _YES;

The constant _YES was not found. Maybe you did not declare it correctly or list all dependencies?

                } else {
                    return _NO;

The constant _NO was not found. Maybe you did not declare it correctly or list all dependencies?

                }
                break;
            case 'radio':
                return $myts->htmlSpecialChars($value);
                break;
            case 'select':
                return $myts->htmlSpecialChars($value);
            case 'dhtml':
                return $myts->displayTarea($value);
            case 'rating':

This code seems to be duplicated across your project.

                $xoops_url = XOOPS_URL;

The constant XOOPS_URL was not found. Maybe you did not declare it correctly or list all dependencies?

                switch ($value) {
                    case 1:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_1.gif";
                        break;
                    case 2:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_2.gif";
                        break;
                    case 3:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_3.gif";
                        break;
                    case 4:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_4.gif";
                        break;
                    case 5:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_5.gif";
                        break;
                    case 6:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_6.gif";
                        break;
                    case 7:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_7.gif";
                        break;
                    case 8:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_8.gif";
                        break;
                    case 9:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_9.gif";
                        break;
                    case 10:
                        $src = "$xoops_url/modules/$moddir/assets/images/rating_10.gif";
                        break;
                    default:
                        $src = '';
                }
                $rating = "<img src=\"$src\">";

                return $rating;
            case 'address':
                $fieldtitles   = array(
                    'address'  => _MD_DF_ADDRESS,
                    'address2' => _MD_DF_ADDRESS2,
                    'zip'      => _MD_DF_ZIP,
                    'postcode' => _MD_DF_POSTCODE,
                    'lat'      => _MD_DF_LAT,
                    'lon'      => _MD_DF_LON,
                    'phone'    => _MD_DF_PHONE,
                    'fax'      => _MD_DF_FAX,
                    'mobile'   => _MD_DF_MOBILE,
                    'city'     => _MD_DF_CITY,
                    'country'  => _MD_DF_COUNTRY
                );
                $addressfields = getAddressFields('0');
                $addressvalues = getAddressValues($value);
                $address       = '';

                foreach ($addressfields['addressfields'] as $field => $fieldvalue) {
                    $storedvalue = $addressvalues["$field"];
                    if ($fieldvalue == '1' && $storedvalue != '') {
                        $title = $fieldtitles["$field"];

The assignment to $title is dead and can be removed.

                        switch ($field) {
                            case 'address':
                                $street = $myts->htmlSpecialChars($storedvalue);
                                break;
                            case 'city':
                                $city = $myts->htmlSpecialChars($storedvalue);
                                break;
                            case 'zip':
                                $zip = $myts->htmlSpecialChars($storedvalue);
                                break;
                            case 'state':
                                $state = $myts->htmlSpecialChars($storedvalue);
                                break;
                            case 'country':
                                $country = $myts->htmlSpecialChars($storedvalue);
                                break;
                            default:
                                break;
                        }
                        $address .= $myts->htmlSpecialChars($storedvalue) . '<br>';
                    }
                }
                if (!isset($street)) {
                    $street = '';
                }
                if (!isset($city)) {
                    $city = '';
                }
                if (!isset($zip)) {
                    $zip = '';
                }
                if (!isset($state)) {
                    $state = '';
                }
                if (!isset($country)) {
                    $country = '';
                }
                if ($country == 'United States') {
                    $countrycode = 'us';
                } elseif ($country == 'Canada') {
                    $countrycode = 'ca';
                }
                if (isset($countrycode) && isset($city) && isset($street)) {
                    $address .= '<form name=mapForm2 action="http://us.rd.yahoo.com/maps/home/submit_a/*-http://maps.yahoo.com/maps" target="_new" method=get>
                    <input type="hidden" name="addr" value="' . $street . '">
                    <input type="hidden" name="csz" value="' . $city . ', ' . $state . ' ' . $zip . '">
                    <input type="hidden" name="country" value="' . $countrycode . '">
                    <input type=hidden name=srchtype value=a>
                    <input type=submit name="getmap" value="Yahoo Map">
                    </form>';
                }

                return $address;
            case 'url':
                $link = explode('|', $value);

                return '<a href="' . $myts->htmlSpecialChars($link[0]) . '" title="' . $myts->htmlSpecialChars($link[1]) . '">' . $myts->htmlSpecialChars($link[0]) . '</a>';
                break;
            default:
                return $myts->htmlSpecialChars($value);
                break;
        }