efqListingData

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	21.05 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setInserted()	0	3	1
A	__construct()	0	11	1
A	setListingData()	12	12	3
A	setUpdated()	0	3	1

<?php
// $Id: listing.php,v 1.1.0 2007/11/03 17:46:00 wtravel
//  ------------------------------------------------------------------------ //
//                				EFQ Directory			                     //
//                    Copyright (c) 2006 EFQ Consultancy                     //
//                       <http://www.efqdirectory.com/>                      //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
//	Part of the efqDirectory module provided by: wtravel					 //
// 	e-mail: info@efqdirectory.com											 //
//	Purpose: Create a business directory for xoops.		 	 				 //
//	Based upon the mylinks and the mxDirectory modules						 //
// ------------------------------------------------------------------------- //

/**
 * Class efqListing
 * Manages operations for listings
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqListingData extends XoopsObject

The type XoopsObject was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public $_updated  = false;
    public $_inserted = false;

    /**
     * Constructor
     */
    public function __construct()
    {
        // class constructor;
        //$this->setCurrentUser();

84% of this comment could be valid code. Did you maybe forget this after debugging?

        $this->initVar('dataid', XOBJ_DTYPE_INT, 0, true);

The constant XOBJ_DTYPE_INT was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('itemid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('dtypeid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('itemid', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('value', XOBJ_DTYPE_TXTAREA, null, false);

The constant XOBJ_DTYPE_TXTAREA was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('created', XOBJ_DTYPE_INT, 0, true);
        $this->initVar('customtitle', XOBJ_DTYPE_TXTBOX, null, false, 255);

The constant XOBJ_DTYPE_TXTBOX was not found. Maybe you did not declare it correctly or list all dependencies?

    }

    //Set variable $_updated to true of false (default)

36% of this comment could be valid code. Did you maybe forget this after debugging?

    /**
     * @param bool $set
     */
    public function setUpdated($set = false)
    {
        $this->_updated = $set;
    }

    //Set variable $_inserted to true of false (default)

36% of this comment could be valid code. Did you maybe forget this after debugging?

    /**
     * @param bool $set
     */
    public function setInserted($set = false)
    {
        $this->_inserted = $set;
    }

    /**
     * @param $arr
     * @return bool
     */
    public function setListingData($arr)

This method seems to be duplicated in your project.

    {
        if (is_array($arr)) {
            $vars = $this->getVars();
            foreach ($vars as $k => $v) {
                $this->setVar($k, $arr[$k]);
            }
        } else {
            return false;
        }

        return true;
    }
}

/**
 * Class efqListingHandler
 * Manages database operations for listings
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqListingDataHandler extends XoopsObjectHandler

The type XoopsObjectHandler was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public $errorhandler;

    /**
     * efqListingDataHandler constructor.
     */
    public function __construct()
    {
        //Instantiate class
        global $eh;
        $this->db           = XoopsDatabaseFactory::getDatabaseConnection();

The type XoopsDatabaseFactory was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->errorhandler = $eh;
    }

    /**
     * @param int $itemid
     * @return array
     */
    public function getData($itemid = 0)
    {
        $arr = array();
        $sql = 'SELECT DISTINCT t.dtypeid, t.title, t.section, f.typeid, f.fieldtype, f.ext, t.options, d.dataid, d.itemid, d.value, d.created, t.custom ';
        $sql .= 'FROM ' . $this->db->prefix('efqdiralpha1_item_x_cat') . ' ic, ' . $this->db->prefix('efqdiralpha1_dtypes_x_cat') . ' xc, ' . $this->db->prefix('efqdiralpha1_fieldtypes') . ' f, ' . $this->db->prefix('efqdiralpha1_dtypes') . ' t ';
        $sql .= 'LEFT JOIN ' . $this->db->prefix('efqdiralpha1_data') . ' d ON (t.dtypeid=d.dtypeid AND d.itemid=' . $itemid . ') ';
        $sql .= "WHERE ic.cid=xc.cid AND ic.active='1' AND xc.dtypeid=t.dtypeid AND t.fieldtypeid=f.typeid AND t.activeyn='1' AND ic.itemid=" . $itemid . '';
        $data_result = $this->db->query($sql) or $eh->show('0013');

The variable $eh seems to be never defined.

        while (list($dtypeid, $title, $section, $ftypeid, $fieldtype, $ext, $options, $dataid, $itemid, $value, $created, $custom) = $this->db->fetchRow($data_result)) {
            $arr[] = array(
                'dtypeid'     => $dtypeid,
                'title'       => $title,
                'section'     => $section,
                'ftypeid'     => $ftypeid,
                'fieldtype'   => $fieldtype,
                'ext'         => $ext,
                'options'     => $options,
                'dataid'      => $dataid,
                'itemid'      => $itemid,
                'value'       => $value,
                'created'     => $created,
                'customtitle' => $custom
            );
        }

        return $arr;
    }

    /**
     * Function updateListingData updates listing data
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param   object $obj object of type listing
     *
     * @param bool     $forceQuery
     * @return bool true if update is successful, false if unsuccessful
     */
    public function updateListingData($obj, $forceQuery = false)

This method seems to be duplicated in your project.

    {
        $tablename = 'efqdiralpha1_data';
        $keyName   = 'dataid';
        if ($obj instanceof efqListingData) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
            $keyValue  = $obj->getVar($keyName);
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 1;
        $strSet    = '';
        $strValues = '';

The assignment to $strValues is dead and can be removed.

        foreach ($cleanvars as $k => $v) {
            $strSet .= $k . '=' . "'" . $v . "'";
            if ($i < $countVars) {
                $strSet .= ', ';
            }
            $i++;
        }
        $sql = sprintf('UPDATE %s SET %s WHERE %s = %u', $this->db->prefix($tablename), $strSet, $keyName, $keyValue);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Function insertListingData inserts listing data into DB
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param      $obj
     * @param bool $forceQuery
     * @return bool true if insertion is succesful, false if unsuccesful
     * @internal  param object $objListing object of type listing
     */
    public function insertListingData($obj, $forceQuery = false)

This method seems to be duplicated in your project.

    {
        $tablename = 'efqdiralpha1_data';
        $keyName   = 'dataid';
        if ($obj instanceof efqListingData) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 1;
        $strFields = '';
        $strValues = '';
        foreach ($cleanvars as $k => $v) {
            $strFields .= $k;
            $strValues .= "'" . $v . "'";
            if ($i < $countVars) {
                $strFields .= ', ';
                $strValues .= ', ';
            }
            $i++;
        }
        $sql = sprintf('INSERT INTO %s (%s) VALUES (%s)', $this->db->prefix($tablename), $strFields, $strValues);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        }

        return false;
    }
}