efqItemTypeHandler

Complexity

Total Complexity

28

Size/Duplication

Total Lines	207
Duplicated Lines	39.13 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
C	insert()	43	46	8
A	__construct()	0	3	1
A	getByDir()	0	13	3
A	delete()	0	12	2
A	getObjItemType()	0	3	1
A	set()	0	20	4
D	update()	38	39	9

<?php
/*
// ID: class.itemtypes.php 30-apr-2007 13:39:01 efqconsultancy
//  ------------------------------------------------------------------------ //
//                				EFQ Directory			                     //
//                    Copyright (c) 2006 EFQ Consultancy                     //
//                       <http://www.efqdirectory.com/>                      //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
//	Part of the efqDirectory module provided by: wtravel					 //
// 	e-mail: info@efqdirectory.com											 //
//	Purpose: Create a business directory for xoops.		 	 				 //
//	Based upon the mylinks and the mxDirectory modules						 //
// ------------------------------------------------------------------------- //
*/

/**
 * Class efqItemType
 * Manages operations for item types
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqItemType extends XoopsObject

The type XoopsObject was not found. Maybe you did not declare it correctly or list all dependencies?

{

    /**
     * efqItemType::efqItemType()
     *
     * @param bool $obj
     * @internal param bool $itemtype
     */
    public function __construct($obj = false)
    {
        global $moddir;
        $this->db = XoopsDatabaseFactory::getDatabaseConnection();

The type XoopsDatabaseFactory was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('typeid', XOBJ_DTYPE_INT, 0, false);

The constant XOBJ_DTYPE_INT was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('typename', XOBJ_DTYPE_TXTBOX, null, false, 50);

The constant XOBJ_DTYPE_TXTBOX was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->initVar('level', XOBJ_DTYPE_INT, 0, true, 4);
        $this->initVar('dirid', XOBJ_DTYPE_INT, 0, true, 5);
    }
}

/**
 * Class efqFieldTypeHandler
 * Manages database operations for field types
 *
 * @package   efqDirectory
 * @author    EFQ Consultancy <info@efqconsultancy.com>
 * @copyright EFQ Consultancy (c) 2007
 * @version   1.1.0
 */
class efqItemTypeHandler extends xoopsObject

The type xoopsObject was not found. Maybe you did not declare it correctly or list all dependencies?

{
    public $db; //Database reference
    public $objItemType;

    /**
     * efqItemTypeHandler::efqItemTypeHandler()
     *
     */
    public function __construct()
    {
        $this->db = XoopsDatabaseFactory::getDatabaseConnection();
    }

    /**
     * Function insert inserts new record into DB
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param   efqItemType $obj object
     *
     * @param bool     $forceQuery
     * @return bool true if insertion is succesful, false if unsuccesful
     */
    public function insert($obj, $forceQuery = false)

This method seems to be duplicated in your project.

    {
        $tablename    = 'efqdiralpha1_itemtypes';
        $keyName      = 'typeid';
        $excludedVars = array();
        if ($obj instanceof efqItemType) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 1;
        $strFields = '';
        $strValues = '';
        foreach ($cleanvars as $k => $v) {
            if (!in_array($k, $excludedVars)) {
                $strFields .= $k;
                $strValues .= "'" . $v . "'";
                if ($i < $countVars) {
                    $strFields .= ', ';
                    $strValues .= ', ';
                }
                $i++;
            }
        }
        $sql = sprintf('INSERT INTO %s (%s) VALUES (%s)', $this->db->prefix($tablename), $strFields, $strValues);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                $itemid = $this->db->getInsertId();
                $obj->setVar($keyName, $itemid);

                return true;
            }
        }

        return false;
    }

    /**
     * Function update updates record in DB
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2008
     * @version   1.0.0
     *
     * @param      $obj
     * @param bool $forceQuery
     * @return bool true if update is succesful, false if unsuccesful
     * @internal  param object $objOffer object of type listing
     */
    public function update($obj, $forceQuery = false)

This method seems to be duplicated in your project.

    {
        $tablename    = 'efqdiralpha1_itemtypes';
        $keyName      = 'typeid';
        $excludedVars = array();
        if ($obj instanceof efqItemType) {
            // Variable part of this function ends. From this line you can copy
            // this function for similar object handling functions.
            $obj->cleanVars();
            $cleanvars = $obj->cleanVars;
            $keyValue  = $obj->getVar($keyName);
        } else {
            return false;
        }
        $countVars = count($cleanvars);
        $i         = 0;
        $strSet    = '';
        $strValues = '';

The assignment to $strValues is dead and can be removed.

        foreach ($cleanvars as $k => $v) {
            if (!in_array($k, $excludedVars)) {
                if ($i < $countVars and $i > 0) {
                    $strSet .= ', ';
                }
                $strSet .= $k . '=' . "'" . $v . "'";
            }
            $i++;
        }
        $sql = sprintf('UPDATE %s SET %s WHERE %s = %u', $this->db->prefix($tablename), $strSet, $keyName, $keyValue);
        if ($forceQuery) {
            if ($this->db->queryF($sql)) {
                return true;
            }
        } else {
            if ($this->db->query($sql)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Function set()
     *
     * Sets the object with data from query
     *
     * @param int $typeid
     * @return bool true or false
     */
    public function set($typeid = 0)
    {
        $sql     = 'SELECT typeid,typename,level,dirid FROM ' . $this->db->prefix('efqdiralpha1_itemtypes') . ' WHERE typeid=' . (int)$typeid . '';
        $result  = $this->db->query($sql);
        $numrows = $this->db->getRowsNum($result);
        if ($numrows > 0) {
            while (list($typeid, $typename, $level, $dirid) = $this->db->fetchRow($result)) {
                if (!$this->objItemType) {
                    $this->objItemType = new efqSubscriptionOffer();
                }
                $this->objItemType->setVar('typeid', $typeid);
                $this->objItemType->setVar('typename', $typename);
                $this->objItemType->setVar('level', $level);
                $this->objItemType->setVar('dirid', $dirid);
            }
        } else {
            return false;
        }

        return true;
    }

    /**
     * @return mixed
     */
    public function getObjItemType()
    {
        return $this->objItemType;
    }

    /**
     * efqItemTypeHandler::getByDir()
     *
     * @param integer $dirid
     * @return array|bool
     */
    public function getByDir($dirid = 0)
    {
        $arr = array();
        $sql = 'SELECT typeid,typename,level FROM ' . $this->db->prefix('efqdiralpha1_itemtypes') . ' WHERE dirid=' . (int)$dirid . '';
        if (!$result = $this->db->query($sql)) {
            return false;
        }
        $numrows = $this->db->getRowsNum($result);

The assignment to $numrows is dead and can be removed.

        while (list($typeid, $typename, $level) = $this->db->fetchRow($result)) {
            $arr[$typeid] = array('typeid' => $typeid, 'typename' => $typename, 'level' => $level);
        }

        return $arr;
    }

    /**
     * Function delete: Delete record
     *
     * @author    EFQ Consultancy <info@efqconsultancy.com>
     * @copyright EFQ Consultancy (c) 2007
     * @version   1.0.0
     *
     * @param $obj
     * @return array|bool
     * @internal  param int $orderid - Default: '0' - Order ID
     */
    public function delete($obj)
    {
        $tablename = 'efqdiralpha1_itemtypes';
        $keyName   = 'typeid';
        $id        = $obj->getVar($keyName);
        if ($id != 0) {
            $sql = 'DELETE FROM ' . $this->db->prefix($tablename) . ' WHERE ' . $keyName . '=' . (int)$id . '';
            $this->db->queryF($sql);

            return true;
        } else {
            return false;
        }
    }
}