backpack_cron()

Complexity

Conditions	3
Paths	4

Size

Total Lines	23
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function backpack_cron($parameter = null)
{
    global $xoopsDB;
    $dirname = basename(__DIR__);
    require XOOPS_ROOT_PATH . '/modules/' . $dirname . '/include/zip.lib.php';
    require XOOPS_ROOT_PATH . '/modules/' . $dirname . '/include/defines.lib.php';
    require XOOPS_ROOT_PATH . '/modules/' . $dirname . '/include/read_dump.lib.php';
    require XOOPS_ROOT_PATH . '/modules/' . $dirname . '/admin/backup.ini.php';
    require XOOPS_ROOT_PATH . '/modules/' . $dirname . '/class/class.backpack.php';

    $alltables  = $backup_structure = $backup_data = 1;

The assignment to $alltables is dead and can be removed.

    $result     = $xoopsDB->queryF('SHOW TABLES FROM ' . $db_selected);

The variable $db_selected seems to be never defined.

    $num_tables = $xoopsDB->getRowsNum($result);
    for ($i = 0; $i < $num_tables; ++$i) {
        $tablename_array[$i] = mysqli_tablename($result, $i);
    }
    $filename   = 'xdb' . date('YmdHis', time());
    $cfgZipType = 'gzip';
    $bp         = new backpack($dirname, $parameter);

The call to backpack::__construct() has too many arguments starting with $dirname.

    if ($bp->err_msg) {
        echo "<span style=\"color: red; \">" . $bp->err_msg . '</span>';
    }
    $bp->backup_data($tablename_array, $backup_structure, $backup_data, $filename, $cfgZipType);

The variable $tablename_array does not seem to be defined for all execution paths leading up to this point.

}