backpack::restore_data()

Complexity

Conditions	17
Paths	277

Size

Total Lines	78
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

<?php
    public function restore_data($filename, $restore_structure, $restore_data, $db_selected, $replace_url = '')
    {
        global $xoopsDB;
        if (!is_file($filename)) {
            exit();

Using exit here is not recommended.

        }
        $handle = fopen($filename, 'r');

        $prefix = '';
        mysqli_set_charset('utf8');

'utf8' of type string is incompatible with the type mysqli expected by parameter $link of mysqli_set_charset().

The call to mysqli_set_charset() has too few arguments starting with charset.

        while (!feof($handle)) {

It seems like $handle can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

            $buffer = '';
            while (!feof($handle)) {
                //$cbuff = ereg_replace("\n|\r|\t","",fgets($handle));
                $cbuff = preg_replace('/\n|\r|\t/', '', fgets($handle));

It seems like $handle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

                // print (ereg('--',$cbuff)?"true<br>":"false<br>");
                //if (!ereg('^--',$cbuff)) $buffer .= $cbuff;
                if (!preg_match('/^--/', $cbuff)) {
                    $buffer .= $cbuff;
                }
                if (false !== preg_match('/;/', $cbuff)) {
                    break;
                }
            }
            if (preg_match('/^CREATE TABLE|^INSERT INTO|^DELETE/i', $buffer)) {
                if (!$prefix) {
                    $match  = explode(' ', $buffer);
                    $prefix = explode('_', $match[2]);
                    $prefix = preg_replace('/^`/', '', $prefix[0]);
                }
                $buffer = preg_replace('/' . $prefix . '_/', XOOPS_DB_PREFIX . '_', $buffer);
                if ($replace_url) {
                    $pattern = 'http://' . $replace_url;
                    $buffer  = preg_replace('/' . preg_quote($pattern, '/') . '/', XOOPS_URL, $buffer);
                }
            }
            // 20100218
            $buffer = preg_replace("/on update CURRENT_TIMESTAMP default \'CURRENT_TIMESTAMP\'/i", '', $buffer);
            if ($buffer) {
                // if this line is a create table query then check if the table already exists

                //if (eregi("^CREATE TABLE",$buffer) ) {
                if (preg_match('/^CREATE TABLE/i', $buffer)) {
                    if ($restore_structure) {
                        $tablename = explode(' ', $buffer);
                        $tablename = preg_replace('/`/', '', $tablename[2]);
//                        $result    = mysqli_list_tables($db_selected);
                        $sql = "SHOW TABLES FROM $db_selected";
                        $result = $xoopsDB->query($sql);
                        for ($i = 0; $i < $GLOBALS['xoopsDB']->getRowsNum($result); ++$i) {
                            if (mysqli_tablename($result, $i) == $tablename) {
                                //$rand = substr(md5(time()), 0, 8);
                                //$random_tablename = sprintf("%s_bak_%s", $tablename, $rand);
                                //mysqli_query("DROP TABLE IF EXISTS $tablename");
                                $xoopsDB->queryF('DROP TABLE IF EXISTS ' . $tablename);
                                //mysqli_query("RENAME TABLE $tablename TO $random_tablename");
                                //echo "Backed up $tablename to $random_tablename.<br>\n";
                            }
                        }
                        //$result = mysqli_query($buffer);
                        $xoopsDB->queryF($buffer);
                        if (!$result) {
                            echo $GLOBALS['xoopsDB']->error() . "<br>\n";
                        } else {
                            echo "Table '$tablename' successfully recreated.<br>\n";
                        }
                    }
                    //echo "[".$buffer."]";die;
                } elseif ($restore_data) {
                    //$result = mysqli_query($buffer);
                    $xoopsDB->queryF($buffer);
                    if (!$result) {

The variable $result does not seem to be defined for all execution paths leading up to this point.

                        echo $GLOBALS['xoopsDB']->error() . "<br>\n";
                    }
                }
            }
        }
        fclose($handle);

It seems like $handle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    }