Issues in navegacao.php (master) - Issues in master - XoopsModules25x/assessment - Measure and Improve Code Quality continuously with Scrutinizer

Issues (379)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/navegacao.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

// $Id: navegacao.php,v 1.6 2007/03/24 17:50:52 marcellobrandao Exp $
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                    Copyright (c) 2000 XOOPS.org                           //
//                       <http://www.xoops.org/>                             //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
include_once XOOPS_ROOT_PATH . '/class/pagenav.php';

/**
 * Class NavegadorProva
 */
class NavegadorProva extends XoopsPageNav
namespace YourVendor;

class YourClass { }
{
    /**
     * Create navigation with images
     *
     * @param int     $cod_perguntas

     * @param         $cod_perguntas_respondidas
     * @param integer $offset
     *
     * @return string

     */
    public function renderImageNav($cod_perguntas = null, $cod_perguntas_respondidas = null, $offset = 1)
    {
        global $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
        $vazio     = array();
        $largura   = 50 * $offset;
        $perguntas = @array_merge($perguntas, $vazio);
function someFunction() {
    $x = 5;
    echo $x;
}
        if ($this->total < $this->perpage) {
            return null;
        }
        $total_pages = ceil($this->total / $this->perpage);

        if ($total_pages > 1) {
            $ret = '<table align="center" style="width:' . $largura . 'px;"><tr>';

            $prev = $this->current - $this->perpage;
            if ($prev >= 0) {
                $ret .= '<td align="right"><a href="' . $this->url . $prev . $this->extra . '">
                <img src="assets/images/anterior.gif" border="0" alt="' . _MA_ASSESSMENT_ANTERIOR . '" title="' . _MA_ASSESSMENT_ANTERIOR . '"></a></td> ';
            }
            $ret  .= '<td align="center"><table><tr>';
            $next = $this->current + $this->perpage;

            $counter      = 1;
            $current_page = (int)floor(($this->current + $this->perpage) / $this->perpage);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            while ($counter <= $total_pages) {
                $cod_pergunta_atual = $cod_perguntas[$counter - 1];

                if (in_array($cod_pergunta_atual, $cod_perguntas_respondidas)) {
                    $ret .= '<td  valign="center" style="height=20px; text-align:center; background:url(assets/images/feita.jpg); background-repeat:no-repeat;background-position:center;">
                    <a rel="sad" href="'
                            . $this->url
                            . (($counter - 1) * $this->perpage)
                            . $this->extra
                            . '">'
                            . $counter
                            . '</a></td>';
                } else {
                    $ret .= '<td  valign="center" style="height=20px; text-align:center; background:url(assets/images/naofeita.jpg); background-repeat:no-repeat;background-position:center;">
                    <a href="'
                            . $this->url
                            . (($counter - 1) * $this->perpage)
                            . $this->extra
                            . '">'
                            . $counter 
                            . '</a></td>';
                }

                if ((($counter % $offset) == 0) & $counter != $total_pages - 1) {
                    $ret .= '</tr><tr>';
                }
                ++$counter;
            }
            $ret .= '</tr></table></td>';
            if ($this->total > $next) {
                $ret .= '<td valign="middle"><a href="' . $this->url . $next . $this->extra . '"><img src="assets/images/proximo.gif" border="0" alt="' . _MA_ASSESSMENT_PROXIMO . '" title="' . _MA_ASSESSMENT_PROXIMO . '"></a></td>';
            }

            $ret .= '</tr></table>';
        }

        return $ret;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
}


Issues (379)

Security Analysis not enabled

class/navegacao.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 32 and the first side effect is on line 27. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			// $Id: navegacao.php,v 1.6 2007/03/24 17:50:52 marcellobrandao Exp $
3			// ------------------------------------------------------------------------ //
4			// XOOPS - PHP Content Management System //
5			// Copyright (c) 2000 XOOPS.org //
6			// <http://www.xoops.org/> //
7			// ------------------------------------------------------------------------ //
8			// This program is free software; you can redistribute it and/or modify //
9			// it under the terms of the GNU General Public License as published by //
10			// the Free Software Foundation; either version 2 of the License, or //
11			// (at your option) any later version. //
12			// //
13			// You may not change or alter any portion of this comment or credits //
14			// of supporting developers from this source code or any supporting //
15			// source code which is considered copyrighted (c) material of the //
16			// original comment or credit authors. //
17			// //
18			// This program is distributed in the hope that it will be useful, //
19			// but WITHOUT ANY WARRANTY; without even the implied warranty of //
20			// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the //
21			// GNU General Public License for more details. //
22			// //
23			// You should have received a copy of the GNU General Public License //
24			// along with this program; if not, write to the Free Software //
25			// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA //
26			// ------------------------------------------------------------------------ //
27			include_once XOOPS_ROOT_PATH . '/class/pagenav.php';
28
29			/**
30			* Class NavegadorProva
31			*/
32			class NavegadorProva extends XoopsPageNav
			0 ignored issues – show Coding Style Compatibility introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
33			{
34			/**
35			* Create navigation with images
36			*
37			* @param int $cod_perguntas
			0 ignored issues – show Documentation introduced 2017-02-08 14:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$cod_perguntas` not be `integer\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
38			* @param $cod_perguntas_respondidas
39			* @param integer $offset
40			*
41			* @return string
			0 ignored issues – show Documentation introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `null\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
42			*/
43			public function renderImageNav($cod_perguntas = null, $cod_perguntas_respondidas = null, $offset = 1)
44			{
45			global $xoopsModule;
			0 ignored issues – show Compatibility Best Practice introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
46			$vazio = array();
47			$largura = 50 * $offset;
48			$perguntas = @array_merge($perguntas, $vazio);
			0 ignored issues – show Bug introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$perguntas` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history... Unused Code introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$perguntas` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
49			if ($this->total < $this->perpage) {
50			return null;
51			}
52			$total_pages = ceil($this->total / $this->perpage);
53
54			if ($total_pages > 1) {
55			$ret = '<table align="center" style="width:' . $largura . 'px;"><tr>';
56
57			$prev = $this->current - $this->perpage;
58			if ($prev >= 0) {
59			$ret .= '<td align="right"><a href="' . $this->url . $prev . $this->extra . '">
60			<img src="assets/images/anterior.gif" border="0" alt="' . _MA_ASSESSMENT_ANTERIOR . '" title="' . _MA_ASSESSMENT_ANTERIOR . '"></a></td> ';
61			}
62			$ret .= '<td align="center"><table><tr>';
63			$next = $this->current + $this->perpage;
64
65			$counter = 1;
66			$current_page = (int)floor(($this->current + $this->perpage) / $this->perpage);
			0 ignored issues – show Unused Code introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$current_page` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
67			while ($counter <= $total_pages) {
68			$cod_pergunta_atual = $cod_perguntas[$counter - 1];
69
70			if (in_array($cod_pergunta_atual, $cod_perguntas_respondidas)) {
71			$ret .= '<td valign="center" style="height=20px; text-align:center; background:url(assets/images/feita.jpg); background-repeat:no-repeat;background-position:center;">
72			<a rel="sad" href="'
73			. $this->url
74			. (($counter - 1) * $this->perpage)
75			. $this->extra
76			. '">'
77			. $counter
78			. '</a></td>';
79			} else {
80			$ret .= '<td valign="center" style="height=20px; text-align:center; background:url(assets/images/naofeita.jpg); background-repeat:no-repeat;background-position:center;">
81			<a href="'
82			. $this->url
83			. (($counter - 1) * $this->perpage)
84			. $this->extra
85			. '">'
86			. $counter
87			. '</a></td>';
88			}
89
90			if ((($counter % $offset) == 0) & $counter != $total_pages - 1) {
91			$ret .= '</tr><tr>';
92			}
93			++$counter;
94			}
95			$ret .= '</tr></table></td>';
96			if ($this->total > $next) {
97			$ret .= '<td valign="middle"><a href="' . $this->url . $next . $this->extra . '"><img src="assets/images/proximo.gif" border="0" alt="' . _MA_ASSESSMENT_PROXIMO . '" title="' . _MA_ASSESSMENT_PROXIMO . '"></a></td>';
98			}
99
100			$ret .= '</tr></table>';
101			}
102
103			return $ret;
			0 ignored issues – show Bug introduced 2016-06-28 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$ret` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
104			}
105			}
106

XoopsModules25x / assessment

Issues (379)

Security Analysis not enabled

class/navegacao.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like