assessment_perguntas

Complexity

Total Complexity

14

Size/Duplication

Total Lines	85
Duplicated Lines	56.47 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	9	20	3
A	load()	9	9	2
D	getAllassessment_perguntass()	30	30	9

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 41 and the first side effect is on line 32.

// $Id: assessment_perguntas.php,v 1.10 2007/03/24 14:41:41 marcellobrandao Exp $
//  ------------------------------------------------------------------------ //
//                XOOPS - PHP Content Management System                      //
//                    Copyright (c) 2000 XOOPS.org                           //
//                       <http://www.xoops.org/>                             //
//  ------------------------------------------------------------------------ //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
// assessment_perguntas.php,v 1
//  ---------------------------------------------------------------- //
// Author: Marcello Brandao                                            //
// ----------------------------------------------------------------- //

include_once XOOPS_ROOT_PATH . '/kernel/object.php';
include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
//include_once("../class/assessment_respostas.php");

/**
 * assessment_perguntas class.
 * $this class is responsible for providing data access mechanisms to the data source
 * of XOOPS user class objects.
 */
class assessment_perguntas extends XoopsObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $db;

    // constructor

    /**
     * @param null $id
     * @return assessment_perguntas

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct($id = null)
    {
        $this->db = XoopsDatabaseFactory::getDatabaseConnection();
        $this->initVar('cod_pergunta', XOBJ_DTYPE_INT, null, false, 10);
        $this->initVar('cod_prova', XOBJ_DTYPE_INT, null, false, 10);
        $this->initVar('titulo', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('data_criacao', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('data_update', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('uid_elaborador', XOBJ_DTYPE_TXTBOX, null, false);
        $this->initVar('ordem', XOBJ_DTYPE_INT, null, false, 10);
        if (!empty($id)) {

This code seems to be duplicated across your project.

            if (is_array($id)) {
                $this->assignVars($id);
            } else {
                $this->load((int)$id);
            }
        } else {
            $this->setNew();
        }
    }

    /**
     * @param $id
     */
    public function load($id)

This method seems to be duplicated in your project.

    {
        $sql   = 'SELECT * FROM ' . $this->db->prefix('assessment_perguntas') . ' WHERE cod_pergunta=' . $id;
        $myrow = $this->db->fetchArray($this->db->query($sql));
        $this->assignVars($myrow);
        if (!$myrow) {
            $this->setNew();
        }
    }

    /**
     * @param array  $criteria
     * @param bool   $asobject
     * @param string $sort
     * @param string $order
     * @param int    $limit
     * @param int    $start
     *
     * @return array
     */
    public function getAllassessment_perguntass($criteria = array(), $asobject = false, $sort = 'cod_pergunta', $order = 'ASC', $limit = 0, $start = 0)

This method seems to be duplicated in your project.

    {
        $db          = XoopsDatabaseFactory::getDatabaseConnection();
        $ret         = array();
        $where_query = '';
        if (is_array($criteria) && count($criteria) > 0) {
            $where_query = ' WHERE';
            foreach ($criteria as $c) {
                $where_query .= " $c AND";
            }
            $where_query = substr($where_query, 0, -4);
        } elseif (!is_array($criteria) && $criteria) {
            $where_query = ' WHERE ' . $criteria;
        }
        if (!$asobject) {
            $sql    = 'SELECT cod_pergunta FROM ' . $db->prefix('assessment_perguntas') . "$where_query ORDER BY $sort $order";
            $result = $db->query($sql, $limit, $start);
            while ($myrow = $db->fetchArray($result)) {
                $ret[] = $myrow['assessment_perguntas_id'];
            }
        } else {
            $sql    = 'SELECT * FROM ' . $db->prefix('assessment_perguntas') . "$where_query ORDER BY $sort $order";
            $result = $db->query($sql, $limit, $start);
            while ($myrow = $db->fetchArray($result)) {
                $ret[] = new assessment_perguntas($myrow);
            }
        }

        return $ret;
    }
}

// -------------------------------------------------------------------------
// ------------------assessment_perguntas user handler class -------------------
// -------------------------------------------------------------------------

/**
 * assessment_perguntashandler class.
 * This class provides simple mecanisme for assessment_perguntas object
 */
class Xoopsassessment_perguntasHandler extends XoopsPersistableObjectHandler

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * create a new assessment_perguntas
     *
     * @param bool $isNew flag the new objects as "new"?
     *
     * @return object assessment_perguntas
     */
    public function &create($isNew = true)
    {
        $assessment_perguntas = new assessment_perguntas();
        if ($isNew) {
            $assessment_perguntas->setNew();
        } //hack consertando
        else {
            $assessment_perguntas->unsetNew();
        }

        //fim do hack para consertar
        return $assessment_perguntas;
    }

    /**
     * retrieve a assessment_perguntas
     *
     * @param  mixed $id     ID
     * @param  array $fields fields to fetch

Should the type for parameter $fields not be array|null?

     * @return XoopsObject {@link XoopsObject}

Should the return type not be false|assessment_perguntas?

     */
    public function get($id = null, $fields = null)

This method seems to be duplicated in your project.

    {
        $sql = 'SELECT * FROM ' . $this->db->prefix('assessment_perguntas') . ' WHERE cod_pergunta=' . $id;
        if (!$result = $this->db->query($sql)) {
            return false;
        }

        $numrows = $this->db->getRowsNum($result);
        if ($numrows == 1) {
            $assessment_perguntas = new assessment_perguntas();
            $assessment_perguntas->assignVars($this->db->fetchArray($result));

            return $assessment_perguntas;
        }

        return false;
    }

    /**
     * insert a new assessment_perguntas in the database
     *
     * @param XoopsObject $assessment_perguntas reference to the {@link assessment_perguntas} object
     * @param bool        $force
     *
     * @return bool FALSE if failed, TRUE if already present and unchanged or successful
     */
    public function insert(XoopsObject $assessment_perguntas, $force = false)

This method seems to be duplicated in your project.

    {
        global $xoopsConfig;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        if (get_class($assessment_perguntas) != 'assessment_perguntas') {
            return false;
        }
        if (!$assessment_perguntas->isDirty()) {
            return true;
        }
        if (!$assessment_perguntas->cleanVars()) {
            return false;
        }
        foreach ($assessment_perguntas->cleanVars as $k => $v) {
            ${$k} = $v;
        }
        $now = 'date_add(now(), interval ' . $xoopsConfig['server_TZ'] . ' hour)';
        if ($assessment_perguntas->isNew()) {
            // ajout/modification d'un assessment_perguntas
            $assessment_perguntas = new assessment_perguntas();
            $format               = 'INSERT INTO %s (cod_pergunta, cod_prova, titulo, data_criacao, data_update, uid_elaborador,ordem)';
            $format               .= 'VALUES (%u, %u, %s, %s, %s, %s, %u)';
            $sql                  = sprintf($format, $this->db->prefix('assessment_perguntas'), $cod_pergunta, $cod_prova, $this->db->quoteString($titulo), $now, $now, $this->db->quoteString($uid_elaborador), $ordem);

The variable $cod_pergunta seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

The variable $cod_prova does not exist. Did you forget to declare it?

The variable $titulo does not exist. Did you forget to declare it?

The variable $uid_elaborador does not exist. Did you forget to declare it?

The variable $ordem does not exist. Did you forget to declare it?

            $force                = true;
        } else {
            $format = 'UPDATE %s SET ';
            $format .= 'cod_pergunta=%u, cod_prova=%u, titulo=%s, data_criacao=%s, data_update=%s, uid_elaborador=%s, ordem=%u';
            $format .= ' WHERE cod_pergunta = %u';
            $sql    = sprintf($format, $this->db->prefix('assessment_perguntas'), $cod_pergunta, $cod_prova, $this->db->quoteString($titulo), $now, $now, $this->db->quoteString($uid_elaborador), $ordem, $cod_pergunta);

The variable $cod_pergunta seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

        }
        if (false != $force) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }
        if (empty($cod_pergunta)) {

The variable $cod_pergunta seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

            $cod_pergunta = $this->db->getInsertId();
        }
        $assessment_perguntas->assignVar('cod_pergunta', $cod_pergunta);

        return true;
    }

    /**
     * delete a assessment_perguntas from the database
     *
     * @param XoopsObject $assessment_perguntas reference to the assessment_perguntas to delete
     * @param bool        $force
     *
     * @return bool FALSE if failed.
     */
    public function delete(XoopsObject $assessment_perguntas, $force = false)

This method seems to be duplicated in your project.

    {
        if (get_class($assessment_perguntas) != 'assessment_perguntas') {
            return false;
        }
        $sql = sprintf('DELETE FROM %s WHERE cod_pergunta = %u', $this->db->prefix('assessment_perguntas'), $assessment_perguntas->getVar('cod_pergunta'));
        if (false != $force) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison !== instead.

            $result = $this->db->queryF($sql);
        } else {
            $result = $this->db->query($sql);
        }
        if (!$result) {
            return false;
        }

        return true;
    }

    /**
     * retrieve assessment_perguntass from the database
     *
     * @param CriteriaElement $criteria  {@link CriteriaElement} conditions to be met

Should the type for parameter $criteria not be null|CriteriaElement?

     * @param bool            $id_as_key use the UID as key for the array?
     *
     * @param bool            $as_object
     * @return array array of <a href='psi_element://assessment_perguntas'>assessment_perguntas</a> objects
     *                                   objects
     */
    public function &getObjects(CriteriaElement $criteria = null, $id_as_key = false, $as_object = true)

This method seems to be duplicated in your project.

    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = 'SELECT * FROM ' . $this->db->prefix('assessment_perguntas');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $result = $this->db->query($sql, $limit, $start);
        if (!$result) {
            return $ret;
        }
        while ($myrow = $this->db->fetchArray($result)) {
            $assessment_perguntas = new assessment_perguntas();
            $assessment_perguntas->assignVars($myrow);
            if (!$id_as_key) {
                $ret[] = $assessment_perguntas;
            } else {
                $ret[$myrow['cod_pergunta']] = $assessment_perguntas;
            }
            unset($assessment_perguntas);
        }

        return $ret;
    }

    /**
     * retrieve assessment_perguntass from the database
     *
     * @param object $criteria  {@link CriteriaElement} conditions to be met

Should the type for parameter $criteria not be object|null?

     * @param bool   $id_as_key use the UID as key for the array?
     *
     * @return array array of {@link assessment_perguntas} objects
     */
    public function &getCodObjects($criteria = null, $id_as_key = false)
    {
        $ret   = array();
        $limit = $start = 0;
        $sql   = 'SELECT cod_pergunta FROM ' . $this->db->prefix('assessment_perguntas');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
            if ($criteria->getSort() != '') {
                $sql .= ' ORDER BY ' . $criteria->getSort() . ' ' . $criteria->getOrder();
            }
            $limit = $criteria->getLimit();
            $start = $criteria->getStart();
        }
        $result = $this->db->query($sql, $limit, $start);
        while ($myrow = $this->db->fetchArray($result)) {
            $ret[] = $myrow['cod_pergunta'];
        }

        return $ret;
    }

    /**
     * count assessment_perguntass matching a condition
     *
     * @param CriteriaElement $criteria {@link CriteriaElement} to match

Should the type for parameter $criteria not be null|CriteriaElement?

     *
     * @return int count of assessment_perguntass
     */
    public function getCount(CriteriaElement $criteria = null)

This method seems to be duplicated in your project.

    {
        $sql = 'SELECT COUNT(*) FROM ' . $this->db->prefix('assessment_perguntas');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
        }
        $result = $this->db->query($sql);
        if (!$result) {
            return 0;
        }
        list($count) = $this->db->fetchRow($result);

        return $count;
    }

    /**
     * delete assessment_perguntass matching a set of conditions
     *
     * @param CriteriaElement $criteria {@link CriteriaElement}

Should the type for parameter $criteria not be null|CriteriaElement?

     *
     * @param bool            $force
     * @param bool            $asObject
     * @return bool FALSE if deletion failed
     */
    public function deleteAll(CriteriaElement $criteria = null, $force = true, $asObject = false)

This method seems to be duplicated in your project.

    {
        $sql = 'DELETE FROM ' . $this->db->prefix('assessment_perguntas');
        if (isset($criteria) && is_subclass_of($criteria, 'criteriaelement')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

            $sql .= ' ' . $criteria->renderWhere();
        }
        if (!$result = $this->db->query($sql)) {
            return false;
        }

        return true;
    }

    /**
     * cria form de inser��o e edi��o de pergunta
     *
     * @param string $action caminho para arquivo que ...
     * @param null   $prova
     * @return bool FALSE if failed
     * @internal param object $assessment_prova <a href='psi_element://assessment_pprova'>assessment_pprova</a>
     *
     */
    public function renderFormCadastrar($action, $prova = null)
    {
        $form              = new XoopsThemeForm(_AM_ASSESSMENT_CADASTRAR . ' ' . _AM_ASSESSMENT_PERGUNTA, 'form_pergunta', $action, 'post', true);
        $campo_titulo      = new XoopsFormTextArea(_AM_ASSESSMENT_TITULO, 'campo_titulo', '', 2, 50);
        $campo_ordem       = new XoopsFormText(_AM_ASSESSMENT_ORDEM, 'campo_ordem', 3, 3, '0');
        $cod_prova         = $prova->getVar('cod_prova');

The method getVar cannot be called on $prova (of type null).

        $titulo_prova      = $prova->getVar('titulo');

The method getVar cannot be called on $prova (of type null).

        $campo_prova_label = new XoopsFormLabel(_AM_ASSESSMENT_PROVA, $titulo_prova);
        $campo_prova_valor = new XoopsFormHidden('campo_cod_prova', $cod_prova);
        $campo_resposta1   = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . ' 1 <br />(correta)', 'campo_resposta1', '', 2, 50);
        $campo_resposta1->setExtra('style="background-color:#ECFFEC"');
        $campo_resposta2 = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . ' 2 - (errada)', 'campo_resposta2', '', 2, 50);
        $campo_resposta2->setExtra('style="background-color:#FFF0F0"');
        $campo_resposta3 = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . ' 3 - (errada)', 'campo_resposta3', '', 2, 50);
        $campo_resposta3->setExtra('style="background-color:#FFF0F0"');
        $campo_resposta4 = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . ' 4 - (errada)', 'campo_resposta4', '', 2, 50);
        $campo_resposta4->setExtra('style="background-color:#FFF0F0"');
        $campo_resposta5 = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . ' 5 - (errada)', 'campo_resposta5', '', 2, 50);
        $campo_resposta5->setExtra('style="background-color:#FFF0F0"');
        $botao_enviar = new XoopsFormButton(_AM_ASSESSMENT_CADASTRAR, 'botao_submit', _SUBMIT, 'submit');
        $form->addElement($campo_prova_label);
        $form->addElement($campo_prova_valor);
        $form->addElement($campo_ordem, true);
        $form->addElement($campo_titulo, true);
        $form->addElement($campo_resposta1, true);
        $form->addElement($campo_resposta2, true);
        $form->addElement($campo_resposta3, true);
        $form->addElement($campo_resposta4, true);
        $form->addElement($campo_resposta5, true);
        $form->addElement($botao_enviar);
        $form->display();

        return true;
    }

    /**
     * @param       $action
     * @param       $pergunta
     * @param array $respostas
     *
     * @return bool
     */
    public function renderFormEditar($action, $pergunta, $respostas = array())
    {
        $cod_prova    = $pergunta->getVar('cod_prova');

$cod_prova is not used, you could remove the assignment.

        $titulo       = $pergunta->getVar('titulo');
        $cod_pergunta = $pergunta->getVar('cod_pergunta');
        $ordem        = $pergunta->getVar('ordem');

        $form = new XoopsThemeForm(_AM_ASSESSMENT_EDITAR . ' ' . _AM_ASSESSMENT_PERGUNTA, 'form_pergunta', $action, 'post', true);

        $campo_ordem = new XoopsFormText(_AM_ASSESSMENT_ORDEM, 'campo_ordem', 3, 3, $ordem);
        $form->addElement($campo_ordem, true);
        $campo_titulo = new XoopsFormTextArea(_AM_ASSESSMENT_PERGUNTA, 'campo_titulo', $titulo, 2, 50);
        $form->addElement($campo_titulo, true);
        $botao_enviar       = new XoopsFormButton('', 'botao_submit', _AM_ASSESSMENT_SALVARALTERACOES, 'submit');
        $campo_cod_pergunta = new XoopsFormHidden('campo_cod_pergunta', $cod_pergunta);

        $i = 1;
        foreach ($respostas as $resposta) {
            $titulo_resposta            = $resposta->getVar('titulo');
            $cod_resposta               = $resposta->getVar('cod_resposta');
            $nome_campo_titulo_resposta = 'campo_resposta' . $i;
            if ($resposta->getVar('iscerta') == 1) {
                $resposta_correta = new XoopsFormTextArea(_AM_ASSESSMENT_RESPCORRETA . $i, $nome_campo_titulo_resposta, $titulo_resposta, 2, 50);
                $resposta_correta->setExtra('style="background-color:#ECFFEC"');
                $cod_resposta_correta = new XoopsFormHidden('campo_cod_resp1', $cod_resposta);
                $form->addElement($cod_resposta_correta, true);
                $form->addElement($resposta_correta, true);
            } else {
                $vetor_respostas_erradas[$i] = new XoopsFormTextArea(_AM_ASSESSMENT_RESPOSTA . $i, $nome_campo_titulo_resposta, $titulo_resposta, 2, 50);

$vetor_respostas_erradas was never initialized. Although not strictly required by PHP, it is generally a good practice to add $vetor_respostas_erradas = array(); before regardless.

                $vetor_respostas_erradas[$i]->setExtra('style="background-color:#FFF0F0"');

The variable $vetor_respostas_erradas does not seem to be defined for all execution paths leading up to this point.

                $vetor_cod_respostas_erradas[$i] = new XoopsFormHidden('campo_cod_resp' . $i, $cod_resposta);

$vetor_cod_respostas_erradas was never initialized. Although not strictly required by PHP, it is generally a good practice to add $vetor_cod_respostas_erradas = array(); before regardless.

                $form->addElement($vetor_respostas_erradas[$i], true);
                $form->addElement($vetor_cod_respostas_erradas[$i], true);

The variable $vetor_cod_respostas_erradas does not seem to be defined for all execution paths leading up to this point.

            }
            ++$i;
        }

        $form->addElement($campo_prova_valor, true);

The variable $campo_prova_valor does not exist. Did you forget to declare it?

        $form->addElement($campo_cod_pergunta, true);

        $form->addElement($botao_enviar);
        $form->display();

        return true;
    }

    /**
     * @param       $action
     * @param       $pergunta
     * @param array $respostas
     * @param int   $param_cod_resposta
     *
     * @return XoopsThemeForm
     */
    public function renderFormResponder($action, $pergunta, $respostas = array(), $param_cod_resposta = 0)

renderFormResponder uses the super-global variable $_GET which is generally not recommended.

    {
        global $_GET;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        $start        = $_GET['start'];
        $cod_prova    = $pergunta->getVar('cod_prova');

$cod_prova is not used, you could remove the assignment.

        $titulo       = $pergunta->getVar('titulo');
        $cod_pergunta = $pergunta->getVar('cod_pergunta');
        $form         = new XoopsThemeForm("$titulo", 'form_resposta', $action, 'post', true);

        $botao_enviar       = new XoopsFormButton('', 'botao_submit', _SUBMIT, 'submit');
        $campo_cod_pergunta = new XoopsFormHidden('cod_pergunta', $cod_pergunta);
        $campo_start        = new XoopsFormHidden('start', $start);
        $campo_respostas    = new XoopsFormRadio(_MA_ASSESSMENT_RESPOSTA, 'cod_resposta', '','<br/>');
        shuffle($respostas);

        $campo_respostas->setValue($param_cod_resposta);
        foreach ($respostas as $resposta) {
            $titulo_resposta = $resposta->getVar('titulo');
            $cod_resposta    = $resposta->getVar('cod_resposta');
            $campo_respostas->addOption($cod_resposta, $titulo_resposta . '<br />');
        }
        //$form->addElement($campo_prova_valor,true);

89% of this comment could be valid code. Did you maybe forget this after debugging?

        $form->addElement($campo_cod_pergunta);
        $form->addElement($campo_respostas, true);
        $form->addElement($campo_start);

        $form->addElement($botao_enviar);

        //$form->display();

84% of this comment could be valid code. Did you maybe forget this after debugging?

        return $form;
    }

    /**
     * @param $db
     *
     * @return mixed
     */
    public function pegarultimocodigo(&$db)
    {
        return $db->getInsertId();
    }

    /**
     * Copia as perguntas e salva elas ligadas � prova clone
     *
     * @param object $criteria {@link CriteriaElement} to match
     *
     * @param        $cod_prova
     * @return int count of assessment_perguntass

Should the return type not be integer|null?

     */
    public function clonarPerguntas($criteria, $cod_prova)
    {
        global $xoopsDB;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        $fabrica_de_respostas = new Xoopsassessment_respostasHandler($xoopsDB);
        $perguntas            = $this->getObjects($criteria);
        foreach ($perguntas as $pergunta) {
            $cod_pergunta = $pergunta->getVar('cod_pergunta');
            $pergunta->setVar('cod_prova', $cod_prova);
            $pergunta->setVar('cod_pergunta', 0);
            $pergunta->setNew();
            $this->insert($pergunta);
            $cod_pergunta_clone = $xoopsDB->getInsertId();

            $criteria_pergunta = new Criteria('cod_pergunta', $cod_pergunta);
            $respostas         = $fabrica_de_respostas->getObjects($criteria_pergunta);

            foreach ($respostas as $resposta) {
                $resposta->setVar('cod_pergunta', $cod_pergunta_clone);
                $resposta->setVar('cod_resposta', 0);
                $resposta->setNew();
                $fabrica_de_respostas->insert($resposta);
            }
        }
    }
}