Issues in thumb.php (master) - Issues in master - XoopsModules25x/apcal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1210)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/thumb.php (4 issues)

Labels

Unused Code 4

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Class thumb
 */
class Thumb
{
    /**
     * @param $filename
     * @param $maxWidth
     * @param $maxHeight
     * @return array
     */
    public static function make($filename, $maxWidth, $maxHeight)
    {
        $imgPath = XOOPS_UPLOAD_PATH . '/apcal/' . $filename;

        $imgInfo = getimagesize($imgPath);
        $oWidth  = $imgInfo[0];
        $oHeight = $imgInfo[1];
        $ratio   = $oHeight / $oWidth;
        $nWidth  = $maxWidth;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $nHeight = $maxHeight;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($ratio > 1) {
            $nHeight = $maxHeight;
            $nWidth  = $nHeight / $ratio;
        } else {
            $nWidth  = $maxWidth;
            $nHeight = $nWidth * $ratio;
        }

        return array('width' => $nWidth, 'height' => $nHeight);
    }

    /**
     * @param $filename
     * @param $maxWidth
     * @param $maxHeight
     */
    public static function save($filename, $maxWidth, $maxHeight)
    {
        $thumbPath = XOOPS_UPLOAD_PATH . '/apcal/thumbs/' . $filename;
        $imgPath   = XOOPS_UPLOAD_PATH . '/apcal/' . $filename;
        $nSize     = self::make($filename, $maxWidth, $maxHeight);
        $imgInfo   = getimagesize($imgPath);
        $oWidth    = $imgInfo[0];
        $oHeight   = $imgInfo[1];
        $fileType  = $imgInfo[2];

        switch ($fileType) {
            case IMAGETYPE_JPEG:
            default:
                $img = imagecreatefromjpeg($imgPath);
                if (!$img) {
                    $img = imagecreatefromstring(file_get_contents($imgPath));
                }
                break;
            case IMAGETYPE_GIF:
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                $img = imagecreatefromgif($imgPath);
                break;
            case IMAGETYPE_PNG:
                $img = imagecreatefrompng($imgPath);
                break;
        }

        $nImg    = imagecreatetruecolor($nSize['width'], $nSize['height']);
        $bgColor = imagecolorallocate($nImg, 0xFF, 0xFF, 0xFF);
        imagefill($nImg, 0, 0, $bgColor);
        imagecopyresampled($nImg, $img, 0, 0, 0, 0, $nSize['width'], $nSize['height'], $oWidth, $oHeight);

        switch ($fileType) {
            case IMAGETYPE_JPEG:
            default:
                imagejpeg($nImg, $thumbPath, 75);
                break;
            case IMAGETYPE_GIF:
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                imagegif($nImg, $thumbPath);
                break;
            case IMAGETYPE_PNG:
                imagepng($nImg, $thumbPath);
                break;
        }
    }

    /**
     * @param $filename
     * @return bool
     */
    public static function exists($filename)
    {
        return file_exists(XOOPS_UPLOAD_PATH . '/apcal/thumbs/' . $filename);
    }
}


1			<?php
2
3			/**
4			* Class thumb
5			*/
6			class Thumb
7			{
8			/**
9			* @param $filename
10			* @param $maxWidth
11			* @param $maxHeight
12			* @return array
13			*/
14			public static function make($filename, $maxWidth, $maxHeight)
15			{
16			$imgPath = XOOPS_UPLOAD_PATH . '/apcal/' . $filename;
17
18			$imgInfo = getimagesize($imgPath);
19			$oWidth = $imgInfo[0];
20			$oHeight = $imgInfo[1];
21			$ratio = $oHeight / $oWidth;
22			$nWidth = $maxWidth;
			0 ignored issues – show Unused Code introduced 2017-03-23 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$nWidth` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23			$nHeight = $maxHeight;
			0 ignored issues – show Unused Code introduced 2017-03-23 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$nHeight` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
24
25			if ($ratio > 1) {
26			$nHeight = $maxHeight;
27			$nWidth = $nHeight / $ratio;
28			} else {
29			$nWidth = $maxWidth;
30			$nHeight = $nWidth * $ratio;
31			}
32
33			return array('width' => $nWidth, 'height' => $nHeight);
34			}
35
36			/**
37			* @param $filename
38			* @param $maxWidth
39			* @param $maxHeight
40			*/
41			public static function save($filename, $maxWidth, $maxHeight)
42			{
43			$thumbPath = XOOPS_UPLOAD_PATH . '/apcal/thumbs/' . $filename;
44			$imgPath = XOOPS_UPLOAD_PATH . '/apcal/' . $filename;
45			$nSize = self::make($filename, $maxWidth, $maxHeight);
46			$imgInfo = getimagesize($imgPath);
47			$oWidth = $imgInfo[0];
48			$oHeight = $imgInfo[1];
49			$fileType = $imgInfo[2];
50
51			switch ($fileType) {
52			case IMAGETYPE_JPEG:
53			default:
54			$img = imagecreatefromjpeg($imgPath);
55			if (!$img) {
56			$img = imagecreatefromstring(file_get_contents($imgPath));
57			}
58			break;
59			case IMAGETYPE_GIF:
			0 ignored issues – show Unused Code introduced 2017-03-23 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case IMAGETYPE_GIF: ...f($imgPath); break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
60			$img = imagecreatefromgif($imgPath);
61			break;
62			case IMAGETYPE_PNG:
63			$img = imagecreatefrompng($imgPath);
64			break;
65			}
66
67			$nImg = imagecreatetruecolor($nSize['width'], $nSize['height']);
68			$bgColor = imagecolorallocate($nImg, 0xFF, 0xFF, 0xFF);
69			imagefill($nImg, 0, 0, $bgColor);
70			imagecopyresampled($nImg, $img, 0, 0, 0, 0, $nSize['width'], $nSize['height'], $oWidth, $oHeight);
71
72			switch ($fileType) {
73			case IMAGETYPE_JPEG:
74			default:
75			imagejpeg($nImg, $thumbPath, 75);
76			break;
77			case IMAGETYPE_GIF:
			0 ignored issues – show Unused Code introduced 2017-03-23 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case IMAGETYPE_GIF: ...$thumbPath); break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
78			imagegif($nImg, $thumbPath);
79			break;
80			case IMAGETYPE_PNG:
81			imagepng($nImg, $thumbPath);
82			break;
83			}
84			}
85
86			/**
87			* @param $filename
88			* @return bool
89			*/
90			public static function exists($filename)
91			{
92			return file_exists(XOOPS_UPLOAD_PATH . '/apcal/thumbs/' . $filename);
93			}
94			}
95

XoopsModules25x / apcal

Issues (1210)

Security Analysis not enabled

class/thumb.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like