Issues in adminMenu.php (master) - Issues in master - XoopsModules25x/apcal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1210)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/adminMenu.php (1 issue)

Labels

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Class for tab navigation
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
  * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @author      John Neill (AKA Catzwolf)
 * @author      Andricq Nicolas (AKA MusS)
 */

defined('XOOPS_ROOT_PATH') || die();

/**
 * Class APCalAdminMenuHandler
 */
class APCalAdminMenuHandler
{
    /**
     *
     * @var string
     */
    public $_menutop  = array();
    public $_menutabs = array();
    public $_obj;
    public $_header;
    public $_subheader;

    /**
     * Constructor
     */
    public function __construct()
    {
        global $xoopsModule;
        $this->_obj = $xoopsModule;
    }

    /**
     * @param $addon
     */
    public function getAddon($addon)
    {
        $this->_obj = $addon;
    }

    /**
     * @param        $value
     * @param string $name
     */
    public function addMenuTop($value, $name = '')
    {
        if ($name !== '') {
            $this->_menutop[$value] = $name;
        } else {
            $this->_menutop[$value] = $value;
        }
    }

    /**
     * @param      $options
     * @param bool $multi
     */
    public function addMenuTopArray($options, $multi = true)
    {
        if (is_array($options)) {
            if ($multi === true) {
                foreach ($options as $k => $v) {
                    $this->addOptionTop($k, $v);
                }
            } else {
                foreach ($options as $k) {
                    $this->addOptiontop($k, $k);
                }
            }
        }
    }

    /**
     * @param        $value
     * @param string $name
     */
    public function addMenuTabs($value, $name = '')
    {
        if ($name !== '') {
            $this->_menutabs[$value] = $name;
        } else {
            $this->_menutabs[$value] = $value;
        }
    }

    /**
     * @param      $options
     * @param bool $multi
     */
    public function addMenuTabsArray($options, $multi = true)
    {
        if (is_array($options)) {
            if ($multi === true) {
                foreach ($options as $k => $v) {
                    $this->addMenuTabsTop($k, $v);
                }
            } else {
                foreach ($options as $k) {
                    $this->addMenuTabsTop($k, $k);
                }
            }
        }
    }

    /**
     * @param $value
     */
    public function addHeader($value)
    {
        $this->_header = $value;
    }

    /**
     * @param $value
     */
    public function addSubHeader($value)
    {
        $this->_subheader = $value;
    }

    /**
     * @param  string $basename
     * @return string
     */
    public function breadcrumb_nav($basename = 'Home')
    {
        global $bc_site, $bc_label;
        $site       = $bc_site;
        $return_str = "<a href=\"/\">$basename</a>";
        $str        = substr(dirname(xoops_getenv('PHP_SELF')), 1);

        $arr = explode('/', $str);
        $num = count($arr);

        if ($num > 1) {
            foreach ($arr as $val) {
                $return_str .= ' &gt; <a href="' . $site . $val . '/">' . $bc_label[$val] . '</a>';
                $site       .= $val . '/';
            }
        } elseif ($num == 1) {
            $arr        = $str;
            $return_str .= ' &gt; <a href="' . $bc_site . $arr . '/">' . $bc_label[$arr] . '</a>';
        }

        return $return_str;
    }

    /**
     * @param  int  $currentoption
     * @param  bool $display
     * @return string
     */
    public function render($currentoption = 1, $display = true)
    {
        global $modversion;
        $_dirname = $this->_obj->getVar('dirname');
        $i        = 0;

        /**
         * Selects current menu tab
         */
        foreach ($this->_menutabs as $k => $menus) {
            $menuItems[] = $menus;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $breadcrumb                = $menuItems[$currentoption];
        $menuItems[$currentoption] = 'current';
        //Not the best method of adding CSS but the only method available at the moment since xoops is shitty with the backend
        $menu = '<style type="text/css" media="screen">@import "' . XOOPS_URL . '/modules/' . $this->_obj->getVar('dirname') . '/css/menu.css";</style>';
        $menu .= "<div id='buttontop_mod'>";
        $menu .= "<table style='width: 100%; padding: 0;' cellspacing='0'>\n<tr>";
        $menu .= "<td style='font-size: 10px; text-align: left; color: #2F5376; padding: 0 6px; line-height: 18px;'>";
        foreach ($this->_menutop as $k => $v) {
            $menu .= " <a href=\"$k\">$v</a> |";
        }
        $menu = substr($menu, 0, -1);

        $menu .= '</td>';
        $menu .= "<td style='text-align: right;'><strong>" . $this->_obj->getVar('name') . '</strong> : ' . $breadcrumb . '</td>';
        $menu .= "</tr>\n</table>\n";
        $menu .= "</div>\n";
        $menu .= "<div id='buttonbar_mod'><ul>";
        foreach ($this->_menutabs as $k => $v) {
            $menu .= "<li id='" . $menuItems[$i] . "'><a href='" . XOOPS_URL . '/modules/' . $this->_obj->getVar('dirname') . '/' . $k . "'><span>$v</span></a></li>\n";
            ++$i;
        }
        $menu .= "</ul>\n</div>\n";
        if ($this->_header) {
            $menu .= "<h4 class='admin_header'>";
            if (isset($modversion['name'])) {
                if ($modversion['image'] && $this->_obj->getVar('mid') == 1) {
                    $system_image = XOOPS_URL . '/modules/system/images/system/' . $modversion['image'];
                } else {
                    $system_image = XOOPS_URL . '/modules/' . $_dirname . '/assets/images/' . $modversion['image'];
                }
                $menu .= "<img src='$system_image' align='middle' height='32' width='32' alt='' />";
                $menu .= ' ' . $modversion['name'] . "</h4>\n";
            } else {
                $menu .= ' ' . $this->_header . "</h4>\n";
            }
        }
        if ($this->_subheader) {
            $menu .= "<div class='admin_subheader'>" . $this->_subheader . "</div>\n";
        }
        $menu .= '<div class="clear">&nbsp;</div>';
        unset($this->_obj);
        if ($display === true) {
            echo $menu;
        } else {
            return $menu;
        }
    }
}


1		<?php
2		/**
3		* Class for tab navigation
4		*
5		* You may not change or alter any portion of this comment or credits
6		* of supporting developers from this source code or any supporting source code
7		* which is considered copyrighted (c) material of the original comment or credit authors.
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11		*
12		* @copyright {@link http://xoops.org/ XOOPS Project}
13		* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
14		* @author John Neill (AKA Catzwolf)
15		* @author Andricq Nicolas (AKA MusS)
16		*/
17
18		defined('XOOPS_ROOT_PATH') \|\| die();
19
20		/**
21		* Class APCalAdminMenuHandler
22		*/
23		class APCalAdminMenuHandler
24		{
25		/**
26		*
27		* @var string
28		*/
29		public $_menutop = array();
30		public $_menutabs = array();
31		public $_obj;
32		public $_header;
33		public $_subheader;
34
35		/**
36		* Constructor
37		*/
38		public function __construct()
39		{
40		global $xoopsModule;
41		$this->_obj = $xoopsModule;
42		}
43
44		/**
45		* @param $addon
46		*/
47		public function getAddon($addon)
48		{
49		$this->_obj = $addon;
50		}
51
52		/**
53		* @param $value
54		* @param string $name
55		*/
56		public function addMenuTop($value, $name = '')
57		{
58		if ($name !== '') {
59		$this->_menutop[$value] = $name;
60		} else {
61		$this->_menutop[$value] = $value;
62		}
63		}
64
65		/**
66		* @param $options
67		* @param bool $multi
68		*/
69	View Code Duplication	public function addMenuTopArray($options, $multi = true)
70		{
71		if (is_array($options)) {
72		if ($multi === true) {
73		foreach ($options as $k => $v) {
74		$this->addOptionTop($k, $v);
75		}
76		} else {
77		foreach ($options as $k) {
78		$this->addOptiontop($k, $k);
79		}
80		}
81		}
82		}
83
84		/**
85		* @param $value
86		* @param string $name
87		*/
88		public function addMenuTabs($value, $name = '')
89		{
90		if ($name !== '') {
91		$this->_menutabs[$value] = $name;
92		} else {
93		$this->_menutabs[$value] = $value;
94		}
95		}
96
97		/**
98		* @param $options
99		* @param bool $multi
100		*/
101	View Code Duplication	public function addMenuTabsArray($options, $multi = true)
102		{
103		if (is_array($options)) {
104		if ($multi === true) {
105		foreach ($options as $k => $v) {
106		$this->addMenuTabsTop($k, $v);
107		}
108		} else {
109		foreach ($options as $k) {
110		$this->addMenuTabsTop($k, $k);
111		}
112		}
113		}
114		}
115
116		/**
117		* @param $value
118		*/
119		public function addHeader($value)
120		{
121		$this->_header = $value;
122		}
123
124		/**
125		* @param $value
126		*/
127		public function addSubHeader($value)
128		{
129		$this->_subheader = $value;
130		}
131
132		/**
133		* @param string $basename
134		* @return string
135		*/
136		public function breadcrumb_nav($basename = 'Home')
137		{
138		global $bc_site, $bc_label;
139		$site = $bc_site;
140		$return_str = "<a href=\"/\">$basename</a>";
141		$str = substr(dirname(xoops_getenv('PHP_SELF')), 1);
142
143		$arr = explode('/', $str);
144		$num = count($arr);
145
146		if ($num > 1) {
147		foreach ($arr as $val) {
148		$return_str .= ' > <a href="' . $site . $val . '/">' . $bc_label[$val] . '</a>';
149		$site .= $val . '/';
150		}
151		} elseif ($num == 1) {
152		$arr = $str;
153		$return_str .= ' > <a href="' . $bc_site . $arr . '/">' . $bc_label[$arr] . '</a>';
154		}
155
156		return $return_str;
157		}
158
159		/**
160		* @param int $currentoption
161		* @param bool $display
162		* @return string
163		*/
164		public function render($currentoption = 1, $display = true)
165		{
166		global $modversion;
167		$_dirname = $this->_obj->getVar('dirname');
168		$i = 0;
169
170		/**
171		* Selects current menu tab
172		*/
173		foreach ($this->_menutabs as $k => $menus) {
174		$menuItems[] = $menus;
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-23 08:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$menuItems` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$menuItems = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
175		}
176		$breadcrumb = $menuItems[$currentoption];
177		$menuItems[$currentoption] = 'current';
178		//Not the best method of adding CSS but the only method available at the moment since xoops is shitty with the backend
179		$menu = '<style type="text/css" media="screen">@import "' . XOOPS_URL . '/modules/' . $this->_obj->getVar('dirname') . '/css/menu.css";</style>';
180		$menu .= "<div id='buttontop_mod'>";
181		$menu .= "<table style='width: 100%; padding: 0;' cellspacing='0'>\n<tr>";
182		$menu .= "<td style='font-size: 10px; text-align: left; color: #2F5376; padding: 0 6px; line-height: 18px;'>";
183		foreach ($this->_menutop as $k => $v) {
184		$menu .= " <a href=\"$k\">$v</a> \|";
185		}
186		$menu = substr($menu, 0, -1);
187
188		$menu .= '</td>';
189		$menu .= "<td style='text-align: right;'><strong>" . $this->_obj->getVar('name') . '</strong> : ' . $breadcrumb . '</td>';
190		$menu .= "</tr>\n</table>\n";
191		$menu .= "</div>\n";
192		$menu .= "<div id='buttonbar_mod'><ul>";
193		foreach ($this->_menutabs as $k => $v) {
194		$menu .= "<li id='" . $menuItems[$i] . "'><a href='" . XOOPS_URL . '/modules/' . $this->_obj->getVar('dirname') . '/' . $k . "'><span>$v</span></a></li>\n";
195		++$i;
196		}
197		$menu .= "</ul>\n</div>\n";
198		if ($this->_header) {
199		$menu .= "<h4 class='admin_header'>";
200		if (isset($modversion['name'])) {
201		if ($modversion['image'] && $this->_obj->getVar('mid') == 1) {
202		$system_image = XOOPS_URL . '/modules/system/images/system/' . $modversion['image'];
203		} else {
204		$system_image = XOOPS_URL . '/modules/' . $_dirname . '/assets/images/' . $modversion['image'];
205		}
206		$menu .= "<img src='$system_image' align='middle' height='32' width='32' alt='' />";
207		$menu .= ' ' . $modversion['name'] . "</h4>\n";
208		} else {
209		$menu .= ' ' . $this->_header . "</h4>\n";
210		}
211		}
212		if ($this->_subheader) {
213		$menu .= "<div class='admin_subheader'>" . $this->_subheader . "</div>\n";
214		}
215		$menu .= '<div class="clear"> </div>';
216		unset($this->_obj);
217		if ($display === true) {
218		echo $menu;
219		} else {
220		return $menu;
221		}
222		}
223		}
224

XoopsModules25x / apcal

Issues (1210)

Security Analysis not enabled

class/adminMenu.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like