XoopsModules25x / apcal

class/APCal.php

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright   {@link http://xoops.org/ XOOPS Project}
 * @license     {@link http://www.fsf.org/copyleft/gpl.html GNU public license}
 * @package
 * @since
 * @author       XOOPS Development Team,
 * @author       GIJ=CHECKMATE (PEAK Corp. http://www.peak.ne.jp/)
 * @author       Antiques Promotion (http://www.antiquespromotion.ca)
 */

if (!class_exists('APCal')) {
    define('APCAL_EVENT_TABLE', 'apcal_event');
    define('APCAL_CAT_TABLE', 'apcal_cat');
//    require_once __DIR__ . '/../../../include/cp_header.php';
    require_once XOOPS_ROOT_PATH . '/modules/apcal/include/ro_contacthandler.php'; // added by goffy convert name(s) in field contact in a links to member account
    require_once XOOPS_ROOT_PATH . '/modules/apcal/class/thumb.php';

    /**
     * Class APCal
     */
    class APCal
    {
        // SKELTON (they will be defined in language files)
        public $holidays           = array();
        public $date_short_names   = array();
        public $date_long_names    = array();
        public $week_numbers       = array();
        public $week_short_names   = array();
        public $week_middle_names  = array();
        public $week_long_names    = array();
        public $month_short_names  = array();
        public $month_middle_names = array();
        public $month_long_names   = array();
        public $byday2langday_w    = array();
        public $byday2langday_m    = array();

        // LOCALES
        public $locale        = '';            // locale for APCal original
        public $locale4system = '';    // locale for UNIX systems (deprecated)

        // COLORS/STYLES  public
        public $holiday_color     = '#CC0000';
        public $holiday_bgcolor   = '#FFEEEE';
        public $sunday_color      = '#CC0000';
        public $sunday_bgcolor    = '#FFEEEE';
        public $saturday_color    = '#0000FF';
        public $saturday_bgcolor  = '#EEF7FF';
        public $weekday_color     = '#000099';
        public $weekday_bgcolor   = '#FFFFFF';
        public $targetday_bgcolor = '#CCFF99';
        public $calhead_color     = '#009900';
        public $calhead_bgcolor   = '#CCFFCC';
        public $frame_css         = '#000000';
        public $allcats_color     = '#5555AA';
        public $event_color       = '#000000';
        public $event_bgcolor     = '#EEEEEE';

        // GOOGLE MAPS
        public $gmlat    = 0;
        public $gmlng    = 0;
        public $gmzoom   = 12;
        public $gmheight = 350;
        public $gmPoints = array();

        // PICTURES
        public $picWidth   = 150;
        public $picHeight  = 150;
        public $nbPictures = 5;

        public $showPicMonthly = 1;
        public $showPicWeekly  = 1;
        public $showPicDaily   = 1;
        public $showPicList    = 1;

        public $widerDays = array('Saturday', 'Sunday');

        public $useurlrewrite     = 0;
        public $enablecalmap      = 1;
        public $enableeventmap    = 1;
        public $enablesharing     = 1;
        public $eventNavEnabled   = 1;
        public $displayCatTitle   = 1;
        public $enablesocial      = false;
        public $enabletellafriend = false;
        public $enableprint       = false;

        public $default_view = 'Monthly';

        // TIMEZONES
        public $server_TZ       = 9;            // Server's  Timezone Offset (hour)
        public $user_TZ         = 9;                // User's Timezone Offset (hour)
        public $use_server_TZ   = false;    // if 'caldate' is generated in Server's time
        public $displayTimezone = 1;

        // AUTHORITIES
        public $insertable = true;        // can insert a new event
        public $editable   = true;            // can update an event he posted
        public $superedit  = false;            // can update all event
        public $deletable  = true;            // can delete an event he posted
        public $user_id    = -1;                // User's ID
        public $isadmin    = false;            // Is admin or not

        // ANOTHER public properties
        public $conn;                    // MySQL�Ȥ���³�ϥ�ɥ� (ͽ������򤹤�����å�)
        public $table                = 'apcal_event';        // table name for events
        public $cat_table            = 'apcal_cat';        // table name for categories
        public $pic_table            = 'apcal_pictures';        // table name for pictures
        public $plugin_table         = 'apcal_plugin';    // table name for plugins
        public $base_url             = '';
        public $base_path            = '';
        public $images_url           = '/include/apcal/images';    // ���Υե������ spacer.gif, arrow*.gif ����֤��Ƥ���
        public $images_path          = 'include/apcal/images';
        public $jscalendar           = 'jscalendar'; // DHTML Date/Time Selector
        public $jscalendar_lang_file = 'calendar-jp.js'; // language file of the jscalh
        public $can_output_ics       = true;    // ics�ե�������Ϥ���Ĥ��뤫�ɤ���
        public $ics_new_cal          = true;
        public $connection           = 'http';        // http �� https ��
        public $max_rrule_extract    = 100;    // rrule ��Ÿ���ξ�¿�(COUNT)
        public $week_start           = 0;            // ��������� 0������ 1������
        public $week_numbering       = 0;        // ���ο����� 0�ʤ��� 1�ʤ�ǯ���̻�
        public $day_start            = 0;            // ���դζ���������ñ�̡�
        public $use24                = true;                // 24�������ʤ�true��12�������ʤ�false
        public $now_cid              = 0;                // ���ƥ������
        public $categories           = array();        // ����������ǽ�ʥ��ƥ��ꥪ�֥�������Ϣ������
        public $canbemain_cats       = array();
        public $groups               = array();            // PRIVATE���������ǽ�ʥ��롼�פ�Ϣ������
        public $nameoruname          = 'name';        // ��ƼԤ�ɽ���ʥ?����̾���ϥ�ɥ�̾����
        public $proxysettings        = '';        // Proxy setting
        public $last_summary         = '';        // ���������̾�򻲾Ȥ��뤿��Υץ�ѥƥ�
        public $plugins_path_monthly = 'plugins/monthly';
        public $plugins_path_weekly  = 'plugins/weekly';
        public $plugins_path_daily   = 'plugins/daily';

        // private members
        public $year;
        public $month;
        public $date;
        public $day;            // 0:Sunday ... 6:Saturday
        public $daytype;        // 0:weekdays 1:saturday 2:sunday 3:holiday
        public $caldate;        // everytime 'Y-n-j' formatted
        public $unixtime;
        public $long_event_legends = array();
        public $language           = 'japanese';

        // ����դ������ѥ���
        public $original_id;    // $_GET['event_id']�����ľ��˻��Ȳ�ǽ

        // added by goffy: vars for online registration
        public $table_ro_members = '_apcal_ro_members'; // table for eventmembers
        public $table_ro_events  = '_apcal_ro_events';  // table for events, where online registration is possible (max registration, email notify in case off add/remove eventmembers
        public $table_ro_notify  = '_apcal_ro_notify';  // table for persons, which should be informed about registrations by email
        public $redirecturl      = '';                  // variable für redirect
        public $registered       = 0;                   // var whether user is already regristrated for this event or not
        public $regonline        = 0;                   // var, whether online registration is activated or not
        public $roimage          = 0;                   // var for image to mark events with online registration
        public $eventmembers     = '';                  // first var for show additional info
        public $eventmembersall  = '';                  // second var for show additional info
        public $enableregistration = 1;
        var $enablecontact = 0;                         // use contacthandler
        var $ro_showtip = 0;                            // show tip for online registration
        var $ro_mail_sender = "webmaster@apcal.tld";    // e-mail of sender for notify registered person
        var $ro_mail_sendername = "Calendar of APCal";  // name of sender for notify registered person
        var $ro_mail_signature = "Your Team of APCal";  // signature for notify registered person
        var $ro_showlist = 0;                           // show list of registered persons
        // var $ro_superedit = 0;                          // user can edit/delete registration of other persons
        // var $ro_image_available = "";                   // path to image showing availability of the event
        // var $ro_use_waiting_list = "";                  // a waiting list will be used for an event
        // var $ro_need_confirm = "";                      // each online registration must be confirm by event owner
        var $ro_extrainfo1 = '';                 // define extrainfo1
        var $ro_extrainfo2 = '';                 // define extrainfo2
        var $ro_extrainfo3 = '';                 // define extrainfo3
        var $ro_extrainfo4 = '';                 // define extrainfo4
        var $ro_extrainfo5 = '';                 // define extrainfo5
        var $ro_extrainfo1_obl = 0;              // define whether extrainfo1 is obligatory or on voluntary base
        var $ro_extrainfo2_obl = 0;              // define whether extrainfo1 is obligatory or on voluntary base
        var $ro_extrainfo3_obl = 0;              // define whether extrainfo1 is obligatory or on voluntary base
        var $ro_extrainfo4_obl = 0;              // define whether extrainfo1 is obligatory or on voluntary base
        var $ro_extrainfo5_obl = 0;              // define whether extrainfo1 is obligatory or on voluntary base
        // end goffy

        /*******************************************************************/
        /*        CONSTRUCTOR etc.                                         */
        /*******************************************************************/

        // Constructor
        /**
         * APCal constructor.
         * @param string $target_date
         * @param string $language
         * @param bool   $reload
         */
        public function __construct($target_date = '', $language = 'japanese', $reload = false)
        {
            // ���դΥ��å�
            if ($target_date) {
                $this->set_date($target_date);
            } elseif (isset($_GET['caldate'])) {
                $this->set_date($_GET['caldate']);
            } elseif (isset($_POST['apcal_jumpcaldate']) && isset($_POST['apcal_year'])) {
                if (empty($_POST['apcal_month'])) {
                    // ǯ�Τߤ�POST���줿���
                    $month = 1;
                    $date  = 1;
                } elseif (empty($_POST['apcal_date'])) {
                    // ǯ���POST���줿���
                    $month = (int)$_POST['apcal_month'];
                    $date  = 1;
                } else {
                    // ǯ�����POST���줿���
                    $month = (int)$_POST['apcal_month'];
                    $date  = (int)$_POST['apcal_date'];
                }
                $year = (int)$_POST['apcal_year'];
                $this->set_date("$year-$month-$date");
                $caldate_posted = true;
            } else {
                $this->set_date(date('Y-n-j'));
                $this->use_server_TZ = true;
            }

            // SSL��̵ͭ��$_SERVER['HTTPS'] �ˤ�Ƚ��
            if (defined('XOOPS_URL')) {
                $this->connection = substr(XOOPS_URL, 0, 8) === 'https://' ? 'https' : 'http';
            } elseif (!empty($_SERVER['HTTPS'])) {
                $this->connection = 'https';
            } else {
                $this->connection = 'http';
            }

            // ���ƥ��꡼����μ���
            $this->now_cid = !empty($_GET['cid']) ? (int)$_GET['cid'] : 0;

            // POST�ǥХ�Х�����դ��������줿��硢���꤬����Х�?�ɤ�Ԥ�
            if (!empty($caldate_posted) && $reload && !headers_sent()) {
                $reload_str       = "Location: $this->connection://{$_SERVER['HTTP_HOST']}{$_SERVER['PHP_SELF']}?caldate=$this->caldate&{$_SERVER['QUERY_STRING']}";
                $needed_post_vars = array('op', 'order', 'cid', 'num', 'txt');
                foreach ($needed_post_vars as $post) {
                    if (isset($_POST[$post])) {
                        $reload_str .= "&$post=" . urlencode($_POST[$post]);
                    }
                }
                $reload_str4header = strtr($reload_str, "\r\n\0", '   ');
                header($reload_str4header);
                exit;
            }

            // APCal.php �ե������¸�ߤ���ǥ��쥯�ȥ�ΰ�ľ��١����Ȥ���
            $this->base_path = dirname(__DIR__);

            // ����ե�������ɤ߹���
            if (file_exists("$this->base_path/language/$language/apcal_vars.phtml")) {
                include "$this->base_path/language/$language/apcal_vars.phtml";
                require_once "$this->base_path/language/$language/apcal_constants.php";
                $this->language             = $language;
                $this->jscalendar_lang_file = _APCAL_JS_CALENDAR;
            } elseif (file_exists("$this->base_path/language/english/apcal_vars.phtml")) {
                include "$this->base_path/language/english/apcal_vars.phtml";
                require_once "$this->base_path/language/english/apcal_constants.php";
                $this->language             = 'english';
                $this->jscalendar_lang_file = 'calendar-en.js';
            }

            // �?����ե�������ɹ�
            if (!empty($this->locale)) {
                $this->read_locale();
            }
        }

        /**
         * @param  string $get_target
         * @param  string $smode
         * @param  int    $cid
         * @param  string $caldate
         * @return string
         */
        public function make_cal_link($get_target = '', $smode = 'Monthly', $cid = 0, $caldate = '')
        {
            global $xoopsModule;

            if ($cid < 0) {
                $cid = $this->now_cid;
            }
            if ($caldate === '') {
                $caldate = $this->caldate;
            }
            if ($smode === '') {
                $smode = $this->default_view;
            }

            $isAllCat      = $cid == 0;
            $isDefaultView = $smode == $this->default_view;
            $isToday       = date('Y-n-j') == $caldate;

            if ($this->conn) {
                $cat = $GLOBALS['xoopsDB']->query("SELECT cat_shorttitle FROM $this->cat_table WHERE cid=$cid LIMIT 0,1");
            } else {
                $cat = false;
            }

            if ($cat && $GLOBALS['xoopsDB']->getRowsNum($cat)) {
                $cat = $GLOBALS['xoopsDB']->fetchObject($cat);
                $cat = urlencode(urlencode($cat->cat_shorttitle));
            } else {
                $cat = isset($xoopsModule)
                       && !empty($xoopsModule) ? urlencode(urlencode($xoopsModule->getVar('name'))) : 0;
            }

            if ($this->useurlrewrite) {
                if (!$isAllCat && !$isDefaultView && !$isToday) {
                    $link = XOOPS_URL . "/modules/apcal/$cat-$smode-$caldate";
                } elseif (!$isAllCat && !$isDefaultView && $isToday) {

This code seems to be duplicated across your project.

                    $link = XOOPS_URL . "/modules/apcal/$cat-$smode";
                } elseif (!$isAllCat && $isDefaultView && !$isToday) {
                    $link = XOOPS_URL . "/modules/apcal/$cat-$caldate";
                } elseif (!$isAllCat && $isDefaultView && $isToday) {
                    $link = XOOPS_URL . "/modules/apcal/$cat";
                } elseif ($isAllCat && !$isDefaultView && !$isToday) {

This code seems to be duplicated across your project.

                    $link = XOOPS_URL . "/modules/apcal/$smode-$caldate";
                } elseif ($isAllCat && !$isDefaultView && $isToday) {
                    $link = XOOPS_URL . "/modules/apcal/$smode";
                } elseif ($isAllCat && $isDefaultView && !$isToday) {
                    $link = XOOPS_URL . "/modules/apcal/$caldate";
                } else {
                    $link = XOOPS_URL . '/modules/apcal/';
                }

                return $link;
            } else {
                return ($get_target === '' ? XOOPS_URL . '/modules/apcal/' : $get_target) . "?cid=$cid&smode=$smode&caldate=$caldate";
            }
        }

        /**
         * @param         $event_id
         * @param  string $get_target
         * @param  string $caldate
         * @return string
         */
        public function make_event_link($event_id, $get_target = '', $caldate = '')
        {
            if ($caldate === '') {
                $caldate = $this->caldate;
            }

            $event = $GLOBALS['xoopsDB']->query("SELECT shortsummary, start FROM $this->table WHERE id=$event_id LIMIT 0,1");

            if ($event && $GLOBALS['xoopsDB']->getRowsNum($event)) {
                $event = $GLOBALS['xoopsDB']->fetchObject($event);
                $date  = date('j-n-Y', $event->start);
                $event = urlencode(urlencode($event->shortsummary));
            } else {
                $event = $event_id;
                $date  = $caldate !== '' ? date('j-n-Y', strtotime($caldate)) : date('j-n-Y');
            }

            if ($this->useurlrewrite) {
                return XOOPS_URL . "/modules/apcal/$event-$date";
            } else {
                return ($get_target === '' ? XOOPS_URL . '/modules/apcal/' : $get_target) . "?event_id=$event_id&action=View&caldate=$caldate";
            }
        }

        /**
         * @param $str
         * @return mixed
         */
        public function urlencode($str)
        {
            $str = urlencode($str);

            return str_replace(array('%26', '3D'), array('&', '='), $str);
        }

        /**
         * @param $str
         * @return mixed
         */
        public function makeShort($str)
        {
            $replacements = array(
                'Ä' => 'Ae',
                'Ü' => 'Ue',
                'Ö' => 'Oe',
                'ä' => 'ae',
                'ö' => 'oe',
                'ü' => 'ue',
                'ß' => 'sz',
                'Å ' => 'S',
                'Å¡' => 's',
                'Ž' => 'Z',
                'ž' => 'z',
                'À' => 'A',
                '�' => 'A',
                'Â' => 'A',
                'Ã' => 'A',
                'Ä' => 'A',
                'Ã…' => 'A',
                'Æ' => 'A',
                'Ç' => 'C',
                'È' => 'E',
                'É' => 'E',
                'Ê' => 'E',
                'Ë' => 'E',
                'Ì' => 'I',
                '�' => 'I',
                'ÃŽ' => 'I',
                '�' => 'I',
                'Ñ' => 'N',
                'Ã’' => 'O',
                'Ó' => 'O',
                'Ô' => 'O',
                'Õ' => 'O',
                'Ö' => 'O',
                'Ø' => 'O',
                'Ù' => 'U',
                'Ú' => 'U',
                'Û' => 'U',
                'Ü' => 'U',
                '�' => 'Y',
                'Þ' => 'B',
                'ß' => 'Ss',
                'à' => 'a',
                'á' => 'a',
                'â' => 'a',
                'ã' => 'a',
                'ä' => 'a',
                'Ã¥' => 'a',
                'æ' => 'a',
                'ç' => 'c',
                'è' => 'e',
                'é' => 'e',
                'ê' => 'e',
                'ë' => 'e',
                'ì' => 'i',
                'í' => 'i',
                'î' => 'i',
                'ï' => 'i',
                'ð' => 'o',
                'ñ' => 'n',
                'ò' => 'o',
                'ó' => 'o',
                'ô' => 'o',
                'õ' => 'o',
                'ö' => 'o',
                'ø' => 'o',
                'ù' => 'u',
                'ú' => 'u',
                'û' => 'u',
                'ý' => 'y',
                'ý' => 'y',
                'þ' => 'b',
                'ÿ' => 'y'
            );

            $str = utf8_encode(strtr($str, $replacements));
            $str = strip_tags($str);

            return str_replace(array(' ', '-', '/', "\\", "'", '"', "\r", "\n", '&', '?', '!', '%', ',', '.'), '', $str);
        }

        // APCal���ѥ?����ե�������ɤ߹���
        public function read_locale()
        {
            if (file_exists("$this->base_path/locales/{$this->locale}.php")) {
                include "$this->base_path/locales/{$this->locale}.php";
            }
        }

        // year,month,day,caldate,unixtime �򥻥åȤ���

        /**
         * @param $setdate
         */
        public function set_date($setdate)
        {
            if (!(preg_match("/^([0-9][0-9]+)[-.\/]?([0-1]?[0-9])[-.\/]?([0-3]?[0-9])$/", $setdate, $regs)
                  && checkdate($regs[2], $regs[3], $regs[1]))
            ) {
                preg_match('/^([0-9]{4})-([0-9]{2})-([0-9]{2})$/', date('Y-m-d'), $regs);
                $this->use_server_TZ = true;
            }
            $this->year     = $year = (int)$regs[1];
            $this->month    = $month = (int)$regs[2];
            $this->date     = $date = (int)$regs[3];
            $this->caldate  = "$year-$month-$date";
            $this->unixtime = mktime(0, 0, 0, $month, $date, $year);

            // ��������ե����פΥ��å�
            // �ĥ��顼�θ�
            if ($month <= 2) {
                $year--;
                $month += 12;
            }
            $day = ($year + floor($year / 4) - floor($year / 100) + floor($year / 400) + floor(2.6 * $month + 1.6) + $date) % 7;

            $this->day = $day;
            if ($day == 0) {
                $this->daytype = 2;
            } elseif ($day == 6) {
                $this->daytype = 1;
            } else {
                $this->daytype = 0;
            }

            if (isset($this->holidays[$this->caldate])) {
                $this->daytype = 3;
            }
        }

        // �������μ��फ���طʿ���ʸ�������

        /**
         * @param $daytype
         * @return array
         */
        public function daytype_to_colors($daytype)
        {
            switch ($daytype) {
                case 3:
                    //  Holiday
                    return array($this->holiday_bgcolor, $this->holiday_color);
                case 2:
                    //  Sunday
                    return array($this->sunday_bgcolor, $this->sunday_color);
                case 1:
                    //  Saturday
                    return array($this->saturday_bgcolor, $this->saturday_color);
                case 0:
                default:
                    // Weekday
                    return array($this->weekday_bgcolor, $this->weekday_color);
            }
        }

        // SQL���������դ��顢�������μ������륯�饹�ؿ�

        /**
         * @param $date
         * @return int
         */
        public function get_daytype($date)
        {
            preg_match("/^([0-9][0-9]+)[-.\/]?([0-1]?[0-9])[-.\/]?([0-3]?[0-9])$/", $date, $regs);
            $year  = (int)$regs[1];
            $month = (int)$regs[2];
            $date  = (int)$regs[3];

            // �����3
            if (isset($this->holidays["$year-$month-$date"])) {
                return 3;
            }

            // �ĥ��顼�θ�
            if ($month <= 2) {
                $year--;
                $month += 12;
            }
            $day = ($year + floor($year / 4) - floor($year / 100) + floor($year / 400) + floor(2.6 * $month + 1.6) + $date) % 7;

            if ($day == 0) {
                return 2;
            } elseif ($day == 6) {
                return 1;
            } else {
                return 0;
            }
        }

        /*******************************************************************/
        /*        �֥�å���ɽ���ؿ�                                       */
        /*******************************************************************/

        // $this->caldate���ͽ�� ���֤�
        /**
         * @param  string $get_target
         * @return string
         */
        public function get_date_schedule($get_target = '')
        {
            // if( $get_target == '' ) $get_target = $_SERVER['SCRIPT_NAME'] ;

            $ret = '';

            // ������׻����Ĥġ�WHERE��δ�֤˴ؤ���������
            $tzoffset = ($this->user_TZ - $this->server_TZ) * 3600;
            if ($tzoffset == 0) {
                // �������ʤ���� ��MySQL����٤򤫤������ʤ����ᡢ�����Ǿ��ʬ�����Ȥ�)
                $whr_term = "start<'" . ($this->unixtime + 86400) . "' AND end>'$this->unixtime'";
            } else {
                // ������������ϡ�allday�ˤ�äƾ��ʬ��
                $whr_term = "( allday AND start<='$this->unixtime' AND end>'$this->unixtime') || ( ! allday AND start<'" . ($this->unixtime + 86400 - $tzoffset) . "' AND end>'" . ($this->unixtime
                                                                                                                                                                                    - $tzoffset) . "')";
            }

            // ���ƥ��꡼��Ϣ��WHERE������
            $whr_categories = $this->get_where_about_categories();

            // CLASS��Ϣ��WHERE������
            $whr_class = $this->get_where_about_class();

            // ����Υ������塼�����
            $yrs      = $GLOBALS['xoopsDB']->query("SELECT start,end,summary,id,allday FROM $this->table WHERE admission>0 AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start,end");
            $num_rows = $GLOBALS['xoopsDB']->getRowsNum($yrs);

            if ($num_rows == 0) {
                $ret .= _APCAL_MB_NOEVENT . "\n";
            } else {
                while ($event = $GLOBALS['xoopsDB']->fetchObject($yrs)) {
                    $summary = $this->text_sanitizer_for_show($event->summary);

                    if ($event->allday) {
                        // ����٥��
                        $ret .= "
           <table border='0' cellpadding='0' cellspacing='0' width='100%'>
             <tr>
               <td><img border='0' src='$this->images_url/dot_allday.gif' /> &nbsp; </td>
               <td><span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Daily&amp;action=View&amp;event_id=$event->id&amp;caldate=$this->caldate' class='calsummary_allday'>$summary</a></span></td>
             </tr>
           </table>\n";
                    } else {
                        // �̾磻�٥��
                        $event->start += $tzoffset;
                        $event->end   += $tzoffset;
                        $ret          .= "
           <dl>
             <dt>
               <span style='font-size: x-small; '>" . $this->get_todays_time_description($event->start, $event->end, $this->caldate, false, true) . "</span>
             </dt>
             <dd>
               <span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Daily&amp;action=View&amp;event_id=$event->id&amp;caldate=$this->caldate' class='calsummary'>$summary</a></span>
             </dd>
           </dl>\n";
                    }
                }
            }

            // ͽ����ɲáʱ�ɮ���������
            if ($this->insertable) {

This code seems to be duplicated across your project.

                $ret .= "
           <dl>
             <dt>
               &nbsp; <span style='font-size: x-small; '><a href='$get_target?smode=Daily&amp;action=Edit&amp;caldate=$this->caldate'><img src='$this->images_url/addevent.gif' border='0' width='14' height='12' />"
                        . _APCAL_MB_ADDEVENT
                        . "</a></span>
             </dt>
           </dl>\n";
            }

            return $ret;
        }

        // $this->caldate�ʹߤ�ͽ�� ����� $num ���֤�

        /**
         * @param  string $get_target
         * @param  int    $num
         * @return string
         */
        public function get_coming_schedule($get_target = '', $num = 5)
        {
            // if( $get_target == '' ) $get_target = $_SERVER['SCRIPT_NAME'] ;

            $ret = '';

            // ������׻����Ĥġ�WHERE��δ�֤˴ؤ���������
            $tzoffset = ($this->user_TZ - $this->server_TZ) * 3600;
            if ($tzoffset == 0) {
                // �������ʤ���� ��MySQL����٤򤫤������ʤ����ᡢ�����Ǿ��ʬ�����Ȥ�)
                $whr_term = "end>'$this->unixtime'";
            } else {
                // ������������ϡ�allday�ˤ�äƾ��ʬ��
                $whr_term = "(allday AND end>'$this->unixtime') || ( ! allday AND end>'" . ($this->unixtime - $tzoffset) . "')";
            }

            // ���ƥ��꡼��Ϣ��WHERE������
            $whr_categories = $this->get_where_about_categories();

            // CLASS��Ϣ��WHERE������
            $whr_class = $this->get_where_about_class();

            // ����ʹߤΥ������塼�����
            $yrs      = $GLOBALS['xoopsDB']->query("SELECT start,end,summary,id,allday FROM $this->table WHERE admission>0 AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start");
            $num_rows = $GLOBALS['xoopsDB']->getRowsNum($yrs);

            if ($num_rows == 0) {
                $ret .= _APCAL_MB_NOEVENT . "\n";
            } else {
                for ($i = 0; $i < $num; ++$i) {
                    $event = $GLOBALS['xoopsDB']->fetchObject($yrs);
                    if ($event === false) {
                        break;
                    }
                    $summary = $this->text_sanitizer_for_show($event->summary);

                    if ($event->allday) {
                        // ����٥��
                        $ret .= "
           <dl>
             <dt>
               <span style='font-size: x-small; '><img border='0' src='$this->images_url/dot_allday.gif' /> " . $this->get_middle_md($event->start) . "</span>
             </dt>
             <dd>
               <span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Daily&amp;action=View&amp;event_id=$event->id&amp;caldate=$this->caldate' class='calsummary_allday'>$summary</a></span>
             </dd>
           </dl>\n";
                    } else {
                        // �̾磻�٥��
                        $event->start += $tzoffset;
                        $event->end   += $tzoffset;
                        $ret          .= "
           <dl>
             <dt>
               <span style='font-size: x-small; '>" . $this->get_coming_time_description($event->start, $this->unixtime) . "</span>
             </dt>
             <dd>
               <span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Daily&amp;action=View&amp;event_id=$event->id&amp;caldate=$this->caldate' class='calsummary'>$summary</a></span>
             </dd>
           </dl>\n";
                    }
                }
            }

            // �Ĥ�����ɽ��
            if ($num_rows > $num) {
                $ret .= "
           <table border='0' cellspacing='0' cellpadding='0' width='100%'>
            <tr>
             <td align='right'><small>" . _APCAL_MB_RESTEVENT_PRE . ($num_rows - $num) . _APCAL_MB_RESTEVENT_SUF . "</small></td>
            </tr>
           </table>\n";
            }

            // ͽ����ɲáʱ�ɮ���������
            if ($this->insertable) {

This code seems to be duplicated across your project.

                $ret .= "
           <dl>
             <dt>
               &nbsp; <span style='font-size: x-small; '><a href='$get_target?smode=Daily&amp;action=Edit&amp;caldate=$this->caldate'><img src='$this->images_url/addevent.gif' border='0' width='14' height='12' />"
                        . _APCAL_MB_ADDEVENT
                        . "</a></span>
             </dt>
           </dl>\n";
            }

            return $ret;
        }

        // �ߥ˥��������ѥ��٥�ȼ����ؿ�

        /**
         * @param         $range_start_s
         * @param         $range_end_s
         * @param  string $mode
         * @return mixed
         */
        public function get_flags_date_has_events($range_start_s, $range_end_s, $mode = '')
        {
            // ���餫����������������Ƥ���
            /* for ($time = $start ; $time < $end ; $time += 86400) {
        $ret[ date( 'j' , $time ) ] = 0 ;
    } */
            for ($i = 0; $i <= 31; ++$i) {
                $ret[$i] = 0;

$ret was never initialized. Although not strictly required by PHP, it is generally a good practice to add $ret = array(); before regardless.

            }

            // add margin -86400 and +86400
            $range_start_s -= 86400;
            $range_end_s   += 86400;

            // �����׻�
            $tzoffset_s2u = (int)(($this->user_TZ - $this->server_TZ) * 3600);
            //$gmtoffset = (int)( $this->server_TZ * 3600 ) ;

            // ���ƥ��꡼��Ϣ��WHERE������
            $whr_categories = $this->get_where_about_categories();

            // CLASS��Ϣ��WHERE������
            $whr_class = $this->get_where_about_class();

            /*  $yrs = mysqli_query( "SELECT start,end,allday FROM $this->table WHERE admission > 0 AND start < ".($end + 86400)." AND end > ".($start - 86400)." AND ($whr_categories) AND ($whr_class)" , $this->conn ) ;
    while ( $event = $xoopsDB->fetchObject( $yrs ) ) {
        $time = $event->start > $start ? $event->start : $start ;
        if (! $event->allday) {
            $time += $tzoffset ;
            $event->end += $tzoffset ;
        }
        $time -= ( $time + $gmtoffset ) % 86400 ;
        while ($time < $end && $time < $event->end) {
            $ret[ date( 'j' , $time ) ] = 1 ;
            $time += 86400 ;
        }
    }*/

            // ����٥�Ȱʳ��ν���
            $result = $GLOBALS['xoopsDB']->query("SELECT summary,id,start,location,contact,gmlat,gmlong FROM $this->table WHERE admission > 0 AND start >= $range_start_s AND start < $range_end_s AND ($whr_categories) AND ($whr_class) AND allday <= 0");
            while (list($title, $id, $server_time, $location, $contact, $gmlat, $gmlong) = $GLOBALS['xoopsDB']->fetchRow($result)) {
                if ($mode === 'NO_YEAR' && ($gmlat > 0 || $gmlong > 0)) {

This code seems to be duplicated across your project.

                    $this->gmPoints[] = array(
                        'summary'   => $title,
                        'gmlat'     => $gmlat,
                        'gmlong'    => $gmlong,
                        'location'  => $location,
                        'contact'   => $contact,
                        'startDate' => date('j', $server_time),
                        'event_id'  => $id
                    );
                }
                $user_time = $server_time + $tzoffset_s2u;
                if (date('n', $user_time) != $this->month) {
                    continue;
                }
                $ret[date('j', $user_time)] = 1;

The variable $ret does not seem to be defined for all execution paths leading up to this point.

            }

            // ����٥�����Ѥν���
            $result = $GLOBALS['xoopsDB']->query("SELECT summary,id,start,end,location,contact,gmlat,gmlong FROM $this->table WHERE admission > 0 AND start >= $range_start_s AND start < $range_end_s AND ($whr_categories) AND ($whr_class) AND allday > 0");

            while (list($title, $id, $start_s, $end_s, $location, $contact, $gmlat, $gmlong) = $GLOBALS['xoopsDB']->fetchRow($result)) {
                if ($start_s < $range_start_s) {
                    $start_s = $range_start_s;
                }
                if ($end_s > $range_end_s) {
                    $end_s = $range_end_s;
                }

                while ($start_s < $end_s) {
                    $user_time = $start_s + $tzoffset_s2u;
                    if (date('n', $user_time) == $this->month) {
                        if ($mode === 'NO_YEAR' && ($gmlat > 0 || $gmlong > 0)) {

This code seems to be duplicated across your project.

                            $this->gmPoints[] = array(
                                'summary'   => $title,
                                'gmlat'     => $gmlat,
                                'gmlong'    => $gmlong,
                                'location'  => $location,
                                'contact'   => $contact,
                                'startDate' => date('j', $user_time),
                                'event_id'  => $id
                            );
                        }
                        $ret[date('j', $user_time)] = 1;
                    }
                    $start_s += 86400;
                }
            }

            return $ret;
        }

        // �ߥ˥�������ɽ����ʸ������֤�

        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  string $mode
         * @return string
         */
        public function get_mini_calendar_html($get_target = '', $query_string = '', $mode = '')
        {
            // �¹Ի��ַ�¬��������
            // list( $usec , $sec ) = explode( " " , microtime() ) ;
            // $apcalstarttime = $sec + $usec ;

            // $PHP_SELF = $_SERVER['SCRIPT_NAME'] ;
            // if( $get_target == '' ) $get_target = $PHP_SELF ;

            require_once "$this->base_path/include/patTemplate.php";
            $tmpl = new PatTemplate();
            $tmpl->setBasedir("$this->images_path");

            // ɽ���⡼�ɤ˱����ơ��ƥ�ץ졼�ȥե�����򿶤�ʬ��
            switch ($mode) {
                case 'NO_YEAR':
                    // ǯ��ɽ����
                    $tmpl->readTemplatesFromFile('minical_for_yearly.tmpl.html');
                    $target_highlight_flag = false;
                    break;
                case 'NO_NAVIGATE':
                    // ��֤β���������
                    $tmpl->readTemplatesFromFile('minical_for_monthly.tmpl.html');
                    $target_highlight_flag = false;
                    break;
                default:
                    // �̾�Υߥ˥��������֥�å���
                    $tmpl->readTemplatesFromFile('minical.tmpl.html');
                    $target_highlight_flag = true;
                    break;
            }

            // ����γ���٥�Ȥ��äƤ��뤫�ɤ��������
            $event_dates = $this->get_flags_date_has_events(mktime(0, 0, 0, $this->month, 1, $this->year), mktime(0, 0, 0, $this->month + 1, 1, $this->year), $mode);

            // ����Ϸ��������Ϸ��Ȥ���
            $prev_month = date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year));
            $next_month = date('Y-n-j', mktime(0, 0, 0, $this->month + 1, 1, $this->year));

            // $tmpl->addVar( "WholeBoard" , "PHP_SELF" , '' ) ;
            $tmpl->addVar('WholeBoard', 'DAY_URL', substr($this->make_cal_link($get_target, 'Monthly', $this->now_cid, ' '), 0, -1));
            $tmpl->addVar('WholeBoard', 'GET_TARGET', $get_target);
            $tmpl->addVar('WholeBoard', 'QUERY_STRING', $query_string);

            $tmpl->addVar('WholeBoard', 'MB_PREV_MONTH', _APCAL_MB_PREV_MONTH);
            $tmpl->addVar('WholeBoard', 'MB_NEXT_MONTH', _APCAL_MB_NEXT_MONTH);
            $tmpl->addVar('WholeBoard', 'MB_LINKTODAY', _APCAL_MB_LINKTODAY);

            $tmpl->addVar('WholeBoard', 'SKINPATH', $this->images_url);
            $tmpl->addVar('WholeBoard', 'FRAME_CSS', $this->frame_css);
            //  $tmpl->addVar( "WholeBoard" , "YEAR" , $this->year ) ;
            //  $tmpl->addVar( "WholeBoard" , "MONTH" , $this->month ) ;
            $tmpl->addVar('WholeBoard', 'MONTH_NAME', $this->month_middle_names[$this->month]);
            $tmpl->addVar('WholeBoard', 'YEAR_MONTH_TITLE', sprintf(_APCAL_FMT_YEAR_MONTH, $this->year, $this->month_middle_names[$this->month]));
            $tmpl->addVar('WholeBoard', 'PREV_MONTH', $prev_month);
            $tmpl->addVar('WholeBoard', 'NEXT_MONTH', $next_month);

            $tmpl->addVar('WholeBoard', 'CALHEAD_BGCOLOR', $this->calhead_bgcolor);
            $tmpl->addVar('WholeBoard', 'CALHEAD_COLOR', $this->calhead_color);

            $first_date = getdate(mktime(0, 0, 0, $this->month, 1, $this->year));
            $date       = (-$first_date['wday'] + $this->week_start - 7) % 7;
            $wday_end   = 7 + $this->week_start;

            // ����̾�롼��
            $rows = array();
            for ($wday = $this->week_start; $wday < $wday_end; ++$wday) {

This code seems to be duplicated across your project.

                if ($wday % 7 == 0) {
                    //  Sunday
                    $bgcolor = $this->sunday_bgcolor;
                    $color   = $this->sunday_color;
                } elseif ($wday == 6) {
                    //  Saturday
                    $bgcolor = $this->saturday_bgcolor;
                    $color   = $this->saturday_color;
                } else {
                    // Weekday
                    $bgcolor = $this->weekday_bgcolor;
                    $color   = $this->weekday_color;
                }

                // �ƥ�ץ졼��������ؤΥǡ������å�
                array_push($rows, array(
                    'BGCOLOR' => $bgcolor,
                    'COLOR'   => $color,
                    'DAYNAME' => $this->week_short_names[$wday % 7]
                ));
            }

            // �ƥ�ץ졼�Ȥ˥ǡ�����������
            $tmpl->addRows('DayNameLoop', $rows);
            $tmpl->parseTemplate('DayNameLoop', 'w');

            // �� (row) �롼��
            for ($week = 0; $week < 6; ++$week) {
                $rows = array();

                // �� (col) �롼��
                for ($wday = $this->week_start; $wday < $wday_end; ++$wday) {
                    ++$date;
                    if (!checkdate($this->month, $date, $this->year)) {
                        // ����ϰϳ�
                        array_push($rows, array(
                            'GET_TARGET'   => $get_target,
                            'QUERY_STRING' => $query_string,
                            'SKINPATH'     => $this->images_url,
                            'DATE'         => date('j', mktime(0, 0, 0, $this->month, $date, $this->year)),
                            'DATE_TYPE'    => 0
                        ));
                        continue;
                    }

                    $link = "$this->year-$this->month-$date";

                    // ����פˤ�����迧����ʬ��
                    if (isset($this->holidays[$link])) {

This code seems to be duplicated across your project.

                        //  Holiday
                        $bgcolor = $this->holiday_bgcolor;
                        $color   = $this->holiday_color;
                    } elseif ($wday % 7 == 0) {
                        //  Sunday
                        $bgcolor = $this->sunday_bgcolor;
                        $color   = $this->sunday_color;
                    } elseif ($wday == 6) {
                        //  Saturday
                        $bgcolor = $this->saturday_bgcolor;
                        $color   = $this->saturday_color;
                    } else {
                        // Weekday
                        $bgcolor = $this->weekday_bgcolor;
                        $color   = $this->weekday_color;
                    }

                    // ��������طʿ��ϥ��饤�Ƚ���
                    if ($date == $this->date && $target_highlight_flag) {
                        $bgcolor = $this->targetday_bgcolor;
                    }

                    // �ƥ�ץ졼��������ؤΥǡ������å�
                    array_push($rows, array(
                        'GET_TARGET'   => $get_target,
                        'QUERY_STRING' => $query_string,
                        'DAY_URL'      => substr($this->make_cal_link($get_target, ($mode === 'NO_YEAR' ? 'Daily' : 'Monthly'), $this->now_cid, ' '), 0, -1),

                        'BGCOLOR'   => $bgcolor,
                        'COLOR'     => $color,
                        'LINK'      => $link,
                        'DATE'      => $date,
                        'DATE_TYPE' => $event_dates[$date] + 1
                    ));
                }
                // �ƥ�ץ졼�Ȥ˥ǡ�����������
                $tmpl->addRows('DailyLoop', $rows);
                $tmpl->parseTemplate('DailyLoop', 'w');
                $tmpl->parseTemplate('WeekLoop', 'a');
            }

            $ret = $tmpl->getParsedTemplate();

            // �¹Ի��ֵ�Ͽ
            // list( $usec , $sec ) = explode( " " , microtime() ) ;
            // error_log( "MiniCalendar " . ( $sec + $usec - $apcalstarttime ) . "sec." , 0 ) ;
            return $ret;
        }

        /*******************************************************************/
        /*        �ᥤ����ɽ���ؿ�                                         */
        /*******************************************************************/

        // ǯ�֥����������Τ�ɽ����patTemplate����)
        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  bool   $for_print
         * @return string
         */
        public function get_yearly($get_target = '', $query_string = '', $for_print = false)
        {
            // $PHP_SELF = $_SERVER['SCRIPT_NAME'] ;
            // if( $get_target == '' ) $get_target = $PHP_SELF ;

            require_once "$this->base_path/include/patTemplate.php";
            $tmpl = new PatTemplate();
            $tmpl->readTemplatesFromFile("$this->images_path/yearly.tmpl.html");

            // setting skin folder
            $tmpl->addVar('WholeBoard', 'SKINPATH', $this->images_url);

            // Static parameter for the request
            $tmpl->addVar('WholeBoard', 'GET_TARGET', $get_target);
            $tmpl->addVar('WholeBoard', 'QUERY_STRING', $query_string);
            $tmpl->addVar('WholeBoard', 'PRINT_LINK', "$this->base_url/print.php?cid=$this->now_cid&smode=Yearly&caldate=$this->caldate");
            $tmpl->addVar('WholeBoard', 'LANG_PRINT', _APCAL_BTN_PRINT);
            if ($for_print) {
                $tmpl->addVar('WholeBoard', 'PRINT_ATTRIB', "width='0' height='0'");
            }

            $jumpScript = "<script type='text/javascript'>\n";
            $jumpScript .= "function submitCat(cid, smode, caldate)\n";
            $jumpScript .= "{\n";
            if ($this->useurlrewrite) {
                $jumpScript .= "document.selectDate.action = '" . XOOPS_URL . "/' + cid + '/' + smode + '/' + caldate;\n";
                $jumpScript .= "document.selectDate.method = 'POST';\n";
            }
            $jumpScript .= "return true;\n";
            $jumpScript .= "}\n";
            $jumpScript .= "</script>\n";

            $prevYear = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year - 1));
            $nextYear = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year + 1));
            $tmpl->addVar('WholeBoard', 'JUMPLINK', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, date('Y-n-j')));
            $tmpl->addVar('WholeBoard', 'TODAYLINK', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, date('Y-n-j')));
            $tmpl->addVar('WholeBoard', 'PREVIOUSYEARLINK', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, $prevYear));
            $tmpl->addVar('WholeBoard', 'NEXTYEARLINK', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, $nextYear));
            $tmpl->addVar('WholeBoard', 'MONTHLYVIEW', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'WEEKLYVIEW', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'DAILYVIEW', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'LISTVIEW', $this->make_cal_link($get_target, 'List', $this->now_cid, $this->caldate));

            // ���ƥ��꡼����ܥå���
            $tmpl->addVar('WholeBoard', 'CATEGORIES_SELFORM', $this->get_categories_selform($get_target));
            $tmpl->addVar('WholeBoard', 'CID', $this->now_cid);

            // Variables required in header part etc.
            $tmpl->addVars('WholeBoard', $this->get_calendar_information('Y'));

            $tmpl->addVar('WholeBoard', 'LANG_JUMP', _APCAL_BTN_JUMP);

            // �Ʒ�Υߥ˥�������
            // $this->caldate �ΥХå����å�
            $backuped_caldate = $this->caldate;

            // 12����ʬ�Υߥ˥������������롼��
            for ($m = 1; $m <= 12; ++$m) {
                $this->set_date(date('Y-n-j', mktime(0, 0, 0, $m, 1, $this->year)));
                $tmpl->addVar('WholeBoard', "MINICAL$m", $this->get_mini_calendar_html($get_target, $query_string, 'NO_YEAR'));
            }

            // $this->caldate �Υꥹ�ȥ�
            $this->set_date($backuped_caldate);

            // content generated from PatTemplate
            $ret = $tmpl->getParsedTemplate('WholeBoard');

            return $ret;
        }

        // ��֥����������Τ�ɽ����patTemplate����)

        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  bool   $for_print
         * @return string
         */
        public function get_monthly($get_target = '', $query_string = '', $for_print = false)
        {
            // $PHP_SELF = $_SERVER['SCRIPT_NAME'] ;
            // if( $get_target == '' ) $get_target = $PHP_SELF ;

            if (isset($_POST['startDate'])) {
                $date          = explode('-', $_POST['startDate']);
                $this->year    = $date[0];
                $this->month   = $date[1];
                $this->day     = $date[2];
                $this->caldate = $_POST['startDate'];
            }

            require_once "$this->base_path/include/patTemplate.php";
            $tmpl = new PatTemplate();
            $tmpl->readTemplatesFromFile("$this->images_path/monthly.tmpl.html");

            // setting skin folder
            $tmpl->addVar('WholeBoard', 'SKINPATH', $this->images_url);

            // Static parameter for the request
            $tmpl->addVar('WholeBoard', 'GET_TARGET', $get_target);
            $tmpl->addVar('WholeBoard', 'QUERY_STRING', $query_string);
            $tmpl->addVar('WholeBoard', 'YEAR_MONTH_TITLE', sprintf(_APCAL_FMT_YEAR_MONTH, $this->year, $this->month_middle_names[$this->month]));
            $tmpl->addVar('WholeBoard', 'PRINT_LINK', "$this->base_url/print.php?cid=$this->now_cid&amp;smode=Monthly&amp;caldate=$this->caldate");
            $tmpl->addVar('WholeBoard', 'LANG_PRINT', _APCAL_BTN_PRINT);
            if ($for_print) {
                $tmpl->addVar('WholeBoard', 'PRINT_ATTRIB', "width='0' height='0'");
            }

            $prevYear  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year - 1));
            $nextYear  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year + 1));
            $prevMonth = date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year));
            $nextMonth = date('Y-n-j', mktime(0, 0, 0, $this->month + 1, 1, $this->year));
            $tmpl->addVar('WholeBoard', 'TODAYLINK', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, date('Y-n-j')));
            $tmpl->addVar('WholeBoard', 'PREVIOUSYEARLINK', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $prevYear));
            $tmpl->addVar('WholeBoard', 'PREVIOUSMONTHLINK', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $prevMonth));
            $tmpl->addVar('WholeBoard', 'NEXTYEARLINK', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $nextYear));
            $tmpl->addVar('WholeBoard', 'NEXTMONTHLINK', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $nextMonth));
            $tmpl->addVar('WholeBoard', 'YEARLYVIEW', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'WEEKLYVIEW', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'DAILYVIEW', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'LISTVIEW', $this->make_cal_link($get_target, 'List', $this->now_cid, $this->caldate));

            // ���ƥ��꡼����ܥå���
            $tmpl->addVar('WholeBoard', 'CATEGORIES_SELFORM', $this->get_categories_selform($get_target));
            $tmpl->addVar('WholeBoard', 'CID', $this->now_cid);

            // Variables required in header part etc.
            $tmpl->addVars('WholeBoard', $this->get_calendar_information('M'));

            $tmpl->addVar('WholeBoard', 'LANG_JUMP', _APCAL_BTN_JUMP);

            // BODY of the calendar
            $tmpl->addVar('WholeBoard', 'CALENDAR_BODY', $this->get_monthly_html($get_target, $query_string, $for_print));

            // legends of long events
            foreach ($this->long_event_legends as $bit => $legend) {

This code seems to be duplicated across your project.

                $tmpl->addVar('LongEventLegends', 'BIT_MASK', 1 << ($bit - 1));
                $tmpl->addVar('LongEventLegends', 'LEGEND_ALT', _APCAL_MB_ALLDAY_EVENT . " $bit");
                $tmpl->addVar('LongEventLegends', 'LEGEND', $legend);
                $tmpl->addVar('LongEventLegends', 'SKINPATH', $this->images_url);
                $tmpl->parseTemplate('LongEventLegends', 'a');
            }

            // �����Υߥ˥�������
            // $this->caldate �ΥХå����å�
            $backuped_caldate = $this->caldate;
            // �����������դ򥻥åȤ�������Υߥ˥��������򥻥å�
            $this->set_date(date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year)));
            $tmpl->addVar('WholeBoard', 'PREV_MINICAL', $this->get_mini_calendar_html($get_target, $query_string, 'NO_NAVIGATE'));
            // ���Ϥ����դ򥻥åȤ����ߥ˥���������ɽ��
            $this->set_date(date('Y-n-j', mktime(0, 0, 0, $this->month + 2, 1, $this->year)));
            $tmpl->addVar('WholeBoard', 'NEXT_MINICAL', $this->get_mini_calendar_html($get_target, $query_string, 'NO_NAVIGATE'));
            // $this->caldate �Υꥹ�ȥ�
            $this->set_date($backuped_caldate);

            // content generated from PatTemplate
            $ret = $tmpl->getParsedTemplate('WholeBoard');

            return $ret;
        }

        // ���֥����������Τ�ɽ����patTemplate����)

        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  bool   $for_print
         * @return string
         */
        public function get_weekly($get_target = '', $query_string = '', $for_print = false)

This method seems to be duplicated in your project.

        {
            // $PHP_SELF = $_SERVER['SCRIPT_NAME'] ;
            // if( $get_target == '' ) $get_target = $PHP_SELF ;

            require_once "$this->base_path/include/patTemplate.php";
            $tmpl = new PatTemplate();
            $tmpl->readTemplatesFromFile("$this->images_path/weekly.tmpl.html");

            // setting skin folder
            $tmpl->addVar('WholeBoard', 'SKINPATH', $this->images_url);

            // Static parameter for the request
            $tmpl->addVar('WholeBoard', 'GET_TARGET', $get_target);
            $tmpl->addVar('WholeBoard', 'QUERY_STRING', $query_string);
            $tmpl->addVar('WholeBoard', 'PRINT_LINK', "$this->base_url/print.php?cid=$this->now_cid&smode=Weekly&caldate=$this->caldate");
            $tmpl->addVar('WholeBoard', 'LANG_PRINT', _APCAL_BTN_PRINT);
            if ($for_print) {
                $tmpl->addVar('WholeBoard', 'PRINT_ATTRIB', "width='0' height='0'");
            }

            $prevMonth = date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year));
            $nextMonth = date('Y-n-j', mktime(0, 0, 0, $this->month + 1, 1, $this->year));
            $prevWeek  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date - 7, $this->year));
            $nextWeek  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date + 7, $this->year));
            $tmpl->addVar('WholeBoard', 'TODAYLINK', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, date('Y-n-j')));
            $tmpl->addVar('WholeBoard', 'PREVIOUSMONTHLINK', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $prevMonth));
            $tmpl->addVar('WholeBoard', 'PREVIOUSWEEKLINK', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $prevWeek));
            $tmpl->addVar('WholeBoard', 'NEXTWEEKLINK', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $nextWeek));
            $tmpl->addVar('WholeBoard', 'NEXTMONTHLINK', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $nextMonth));
            $tmpl->addVar('WholeBoard', 'YEARLYVIEW', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'MONTHLYVIEW', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'DAILYVIEW', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'LISTVIEW', $this->make_cal_link($get_target, 'List', $this->now_cid, $this->caldate));

            // ���ƥ��꡼����ܥå���
            $tmpl->addVar('WholeBoard', 'CATEGORIES_SELFORM', $this->get_categories_selform($get_target));
            $tmpl->addVar('WholeBoard', 'CID', $this->now_cid);

            // Variables required in header part etc.
            $tmpl->addVars('WholeBoard', $this->get_calendar_information('W'));

            $tmpl->addVar('WholeBoard', 'LANG_JUMP', _APCAL_BTN_JUMP);

            // BODY of the calendar
            $tmpl->addVar('WholeBoard', 'CALENDAR_BODY', $this->get_weekly_html($get_target, $query_string));

The call to APCal::get_weekly_html() has too many arguments starting with $query_string.

            // content generated from PatTemplate
            $ret = $tmpl->getParsedTemplate('WholeBoard');

            return $ret;
        }

        // ������������Τ�ɽ����patTemplate����)

        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  bool   $for_print
         * @return string
         */
        public function get_daily($get_target = '', $query_string = '', $for_print = false)

This method seems to be duplicated in your project.

        {
            // $PHP_SELF = $_SERVER['SCRIPT_NAME'] ;
            // if( $get_target == '' ) $get_target = $PHP_SELF ;

            require_once "$this->base_path/include/patTemplate.php";
            $tmpl = new PatTemplate();
            $tmpl->readTemplatesFromFile("$this->images_path/daily.tmpl.html");

            // setting skin folder
            $tmpl->addVar('WholeBoard', 'SKINPATH', $this->images_url);

            // Static parameter for the request
            $tmpl->addVar('WholeBoard', 'GET_TARGET', $get_target);
            $tmpl->addVar('WholeBoard', 'QUERY_STRING', $query_string);
            $tmpl->addVar('WholeBoard', 'PRINT_LINK', "$this->base_url/print.php?cid=$this->now_cid&smode=Daily&caldate=$this->caldate");
            $tmpl->addVar('WholeBoard', 'LANG_PRINT', _APCAL_BTN_PRINT);
            if ($for_print) {
                $tmpl->addVar('WholeBoard', 'PRINT_ATTRIB', "width='0' height='0'");
            }

            $prevMonth = date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year));
            $nextMonth = date('Y-n-j', mktime(0, 0, 0, $this->month + 1, 1, $this->year));
            $prevDay   = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date - 1, $this->year));
            $nextDay   = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date + 1, $this->year));
            $tmpl->addVar('WholeBoard', 'TODAYLINK', $this->make_cal_link($get_target, 'Daily', $this->now_cid, date('Y-n-j')));
            $tmpl->addVar('WholeBoard', 'PREVIOUSMONTHLINK', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $prevMonth));
            $tmpl->addVar('WholeBoard', 'PREVIOUSDAYLINK', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $prevDay));
            $tmpl->addVar('WholeBoard', 'NEXTDAYLINK', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $nextDay));
            $tmpl->addVar('WholeBoard', 'NEXTMONTHLINK', $this->make_cal_link($get_target, 'Daily', $this->now_cid, $nextMonth));
            $tmpl->addVar('WholeBoard', 'YEARLYVIEW', $this->make_cal_link($get_target, 'Yearly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'MONTHLYVIEW', $this->make_cal_link($get_target, 'Monthly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'WEEKLYVIEW', $this->make_cal_link($get_target, 'Weekly', $this->now_cid, $this->caldate));
            $tmpl->addVar('WholeBoard', 'LISTVIEW', $this->make_cal_link($get_target, 'List', $this->now_cid, $this->caldate));

            // ���ƥ��꡼����ܥå���
            $tmpl->addVar('WholeBoard', 'CATEGORIES_SELFORM', $this->get_categories_selform($get_target));
            $tmpl->addVar('WholeBoard', 'CID', $this->now_cid);

            // Variables required in header part etc.
            $tmpl->addVars('WholeBoard', $this->get_calendar_information('D'));

            $tmpl->addVar('WholeBoard', 'LANG_JUMP', _APCAL_BTN_JUMP);

            // BODY of the calendar
            $tmpl->addVar('WholeBoard', 'CALENDAR_BODY', $this->get_daily_html($get_target, $query_string));

The call to APCal::get_daily_html() has too many arguments starting with $query_string.

            // content generated from PatTemplate
            $ret = $tmpl->getParsedTemplate('WholeBoard');

            return $ret;
        }

        // ���������Υإå������ɬ�פʾ����Ϣ��������֤��ʷ�֡����֡������̡�

        /**
         * @param  string $mode
         * @return array
         */
        public function get_calendar_information($mode = 'M')
        {
            $ret = array();

            // ���ܾ���
            $ret['TODAY']      = date('Y-n-j');        // GIJ TODO �׼�ľ���ʻȤ�ʤ�����
            $ret['CALDATE']    = $this->caldate;
            $ret['DISP_YEAR']  = sprintf(_APCAL_FMT_YEAR, $this->year);
            $ret['DISP_MONTH'] = $this->month_middle_names[$this->month];
            $ret['DISP_DATE']  = $this->date_long_names[$this->date];
            $ret['DISP_DAY']   = "({$this->week_middle_names[ $this->day ]})";
            list($bgcolor, $color) = $this->daytype_to_colors($this->daytype);

The assignment to $bgcolor is unused. Consider omitting it like so list($first,,$third).

            $ret['DISP_DAY_COLOR'] = $color;
            $ret['COPYRIGHT']      = _MD_APCAL_COPYRIGHT;

            // �إå������Υ��顼
            $ret['CALHEAD_BGCOLOR'] = $this->calhead_bgcolor;
            $ret['CALHEAD_COLOR']   = $this->calhead_color;

            // ���������alt(title)
            $ret['ICON_LIST']    = _APCAL_ICON_LIST;
            $ret['ICON_DAILY']   = _APCAL_ICON_DAILY;
            $ret['ICON_WEEKLY']  = _APCAL_ICON_WEEKLY;
            $ret['ICON_MONTHLY'] = _APCAL_ICON_MONTHLY;
            $ret['ICON_YEARLY']  = _APCAL_ICON_YEARLY;

            // ��å������֥�å�
            $ret['MB_PREV_YEAR']  = _APCAL_MB_PREV_YEAR;
            $ret['MB_NEXT_YEAR']  = _APCAL_MB_NEXT_YEAR;
            $ret['MB_PREV_MONTH'] = _APCAL_MB_PREV_MONTH;
            $ret['MB_NEXT_MONTH'] = _APCAL_MB_NEXT_MONTH;
            $ret['MB_PREV_WEEK']  = _APCAL_MB_PREV_WEEK;
            $ret['MB_NEXT_WEEK']  = _APCAL_MB_NEXT_WEEK;
            $ret['MB_PREV_DATE']  = _APCAL_MB_PREV_DATE;
            $ret['MB_NEXT_DATE']  = _APCAL_MB_NEXT_DATE;
            $ret['MB_LINKTODAY']  = _APCAL_MB_LINKTODAY;

            // �����ؤΥ��
            $ret['PREV_YEAR']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year - 1));
            $ret['NEXT_YEAR']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date, $this->year + 1));
            $ret['PREV_MONTH'] = date('Y-n-j', mktime(0, 0, 0, $this->month, 0, $this->year));
            $ret['NEXT_MONTH'] = date('Y-n-j', mktime(0, 0, 0, $this->month + 1, 1, $this->year));
            $ret['PREV_WEEK']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date - 7, $this->year));
            $ret['NEXT_WEEK']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date + 7, $this->year));
            $ret['PREV_DATE']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date - 1, $this->year));
            $ret['NEXT_DATE']  = date('Y-n-j', mktime(0, 0, 0, $this->month, $this->date + 1, $this->year));

            // ���ե������ѥե�����γƥ���ȥ?��
            // ǯ�������ν����
            if (empty($_POST['apcal_year'])) {
                $year = $this->year;
            } else {
                $year = (int)$_POST['apcal_year'];
            }
            if (empty($_POST['apcal_month'])) {
                $month = $this->month;
            } else {
                $month = (int)$_POST['apcal_month'];
            }
            if (empty($_POST['apcal_date'])) {
                $date = $this->date;
            } else {
                $date = (int)$_POST['apcal_date'];
            }

            // ǯ�������(2001��2020 �Ȥ���)
            $year_options = '';
            for ($y = 2001; $y <= 2020; ++$y) {

This code seems to be duplicated across your project.

                if ($y == $year) {
                    $year_options .= "\t\t\t<option value='$y' selected>" . sprintf(strip_tags(_APCAL_FMT_YEAR), $y) . "</option>\n";
                } else {
                    $year_options .= "\t\t\t<option value='$y'>" . sprintf(strip_tags(_APCAL_FMT_YEAR), $y) . "</option>\n";
                }
            }
            $ret['YEAR_OPTIONS'] = $year_options;

            // ��������
            $month_options = '';
            for ($m = 1; $m <= 12; ++$m) {

This code seems to be duplicated across your project.

                if ($m == $month) {
                    $month_options .= "\t\t\t<option value='$m' selected>{$this->month_short_names[$m]}</option>\n";
                } else {
                    $month_options .= "\t\t\t<option value='$m'>{$this->month_short_names[$m]}</option>\n";
                }
            }
            $ret['MONTH_OPTIONS'] = $month_options;

            // ��������
            if ($mode === 'W' || $mode === 'D') {
                $date_options = '';
                for ($d = 1; $d <= 31; ++$d) {

This code seems to be duplicated across your project.

                    if ($d == $date) {
                        $date_options .= "\t\t\t<option value='$d' selected>{$this->date_short_names[$d]}</option>\n";
                    } else {
                        $date_options .= "\t\t\t<option value='$d'>{$this->date_short_names[$d]}</option>\n";
                    }
                }

                $ret['YMD_SELECTS'] = sprintf(_APCAL_FMT_YMD, "<select name='apcal_year'>{$ret['YEAR_OPTIONS']}</select> &nbsp; ",
                                              "<select name='apcal_month'>{$ret['MONTH_OPTIONS']}</select> &nbsp; ", "<select name='apcal_date'>$date_options</select> &nbsp; ");
                if ($this->week_numbering) {
                    if ($this->day == 0 && !$this->week_start) {
                        $weekno = date('W', $this->unixtime + 86400);
                    } else {
                        $weekno = date('W', $this->unixtime);
                    }
                    $ret['YMW_TITLE'] = sprintf(_APCAL_FMT_YW, $this->year, $weekno);
                } else {
                    $week_number      = floor(($this->date - ($this->day - $this->week_start + 7) % 7 + 12) / 7);
                    $ret['YMW_TITLE'] = sprintf(_APCAL_FMT_YMW, $this->year, $this->month_middle_names[$this->month], $this->week_numbers[$week_number]);
                }
                $ret['YMD_TITLE'] = sprintf(_APCAL_FMT_YMD, $this->year, $this->month_middle_names[$this->month], $this->date_long_names[$date]);
            }

            return $ret;
        }

        /**
         * @param  string $get_target
         * @param  string $query_string
         * @param  bool   $for_print
         * @return mixed|string|
         */
        public function get_monthly_html($get_target = '', $query_string = '', $for_print = false)

The parameter $query_string is not used and could be removed.

        {
            $tpl = new XoopsTpl();

            // Set days width
            $this->widerDays = unserialize($this->widerDays);
            $total           = 0;
            $widths          = array(
                'Monday'    => 1,
                'Tuesday'   => 1,
                'Wednesday' => 1,
                'Thursday'  => 1,
                'Friday'    => 1,
                'Saturday'  => 1,
                'Sunday'    => 1
            );
            foreach ($this->widerDays as $day) {
                $widths[$day] = 1.5;
            }
            foreach ($widths as $width) {
                $total += $width;
            }
            foreach ($widths as $day => $width) {
                $widths[$day] = (100 * $width / $total) . '%';
            }

            // Where clause - Start / End
            $mtop_unixtime = mktime(0, 0, 0, $this->month, 1, $this->year);
            $mtop_weekno   = date('W', $mtop_unixtime);
            if ($mtop_weekno >= 52) {
                $mtop_weekno = 1;
            }
            $first_date     = getdate($mtop_unixtime);
            $date           = (-$first_date['wday'] + $this->week_start - 7) % 7;
            $wday_end       = 7 + $this->week_start;
            $last_date      = date('t', $this->unixtime);
            $mlast_unixtime = mktime(0, 0, 0, $this->month + 1, 1, $this->year);

            $tzoffset = (int)(($this->user_TZ - $this->server_TZ) * 3600);
            if ($tzoffset == 0) {
                $whr_term = "start<='$mlast_unixtime' AND end>'$mtop_unixtime'";
            } else {
                $whr_term = "(allday AND start<='"
                            . ($mlast_unixtime - $tzoffset)
                            . "' AND end>'"
                            . ($mtop_unixtime - $tzoffset)
                            . "') || (!allday AND start<='"
                            . ($mlast_unixtime - $tzoffset)
                            . "' AND end>'"
                            . ($mtop_unixtime - $tzoffset)
                            . "')";
            }

            // Where clause - Categories
            $whr_categories = $this->get_where_about_categories();

            // Where clause - Class
            $whr_class = $this->get_where_about_class();

            // WHERE clause - Admittance
            $whr_admit = $this->isadmin ? '' : 'AND admission=1';

            // ???
            $rs             = $GLOBALS['xoopsDB']->query("SELECT DISTINCT unique_id FROM $this->table WHERE ($whr_term) AND ($whr_categories) AND ($whr_class) AND (allday & 2) LIMIT 4");
            $long_event_ids = array();
            $bit            = 1;
            while ($event = $GLOBALS['xoopsDB']->fetchObject($rs)) {
                $long_event_ids[$bit] = $event->unique_id;
                ++$bit;
            }

            $cats_color['00000'] = $this->allcats_color;

$cats_color was never initialized. Although not strictly required by PHP, it is generally a good practice to add $cats_color = array(); before regardless.

            foreach ($this->canbemain_cats as $i => $cat) {
                $cats_color[$cat->cid]          = $cat->color;
                $this->canbemain_cats[$i]->link = $this->make_cal_link($get_target, 'Monthly', $cat->cid, $this->caldate);
            }

            // Get all events in the month in the category with the class
            $yrs         = $GLOBALS['xoopsDB']->query("SELECT id,start,end,summary,location,contact,id,allday,admission,uid,unique_id,mainCategory,categories,gmlat,gmlong,extkey0 FROM $this->table WHERE ({$whr_term}) AND ({$whr_categories}) AND ({$whr_class}) {$whr_admit} ORDER BY start");
            $numrows_yrs = $GLOBALS['xoopsDB']->getRowsNum($yrs);
            $events      = array();
            $eventsids   = array();
            $slots       = 0;
            if ($numrows_yrs) {
                $lastDay = date('t', mktime(0, 0, 0, $this->month, 1, $this->year));

                while ($event = $GLOBALS['xoopsDB']->fetchObject($yrs)) {
                    $event->start += $tzoffset;
                    $event->end   += $tzoffset;

                    $startDay = date('j', $event->start);
                    $endDay   = date('j', $event->end);
                    $endHour  = date('H:i:s', $event->end);

                    $startDay = $event->start < mktime(0, 0, 0, $this->month, 1, $this->year) ? 1 : $startDay;
                    //$endDay = $endDay != $startDay && $endHour == '00:00:00' ? $endDay - 1 : $endDay;
                    $endDay   = $event->end > mktime(0, 0, 0, $this->month, $lastDay, $this->year) ? $lastDay : $endDay;
                    $week_end = $this->week_start + 6;

                    // Get picture
                    $pic = $GLOBALS['xoopsDB']->fetchObject($GLOBALS['xoopsDB']->query("SELECT picture FROM {$this->pic_table} WHERE event_id={$event->id} AND main_pic=1 LIMIT 0,1"));

                    if ($event->admission) {
                        // Put markers on map
                        if ($event->gmlat > 0 || $event->gmlong > 0) {
                            $this->gmPoints[$event->id] = array(
                                'summary'   => $event->summary,
                                'gmlat'     => $event->gmlat,
                                'gmlong'    => $event->gmlong,
                                'location'  => $event->location,
                                'contact'   => $event->contact,
                                'startDate' => $startDay,
                                'event_id'  => $event->id
                            );
                            if ($endDay != $startDay && $endHour !== '00:00:00') {
                                $nbDays = date('j', $event->end) - $startDay;
                                for ($i = 1; $i <= $nbDays; ++$i) {
                                    $this->gmPoints[$event->id . ($startDay + $i)] = array(
                                        'summary'   => $event->summary,
                                        'gmlat'     => $event->gmlat,
                                        'gmlong'    => $event->gmlong,
                                        'location'  => $event->location,
                                        'contact'   => $event->contact,
                                        'startDate' => $startDay + $i,
                                        'event_id'  => $event->id
                                    );
                                }
                            }
                        }

                        // Categories
                        $categories = explode(',', $event->categories);

$categories is not used, you could remove the assignment.

                        //$e['cat'] = $this->text_sanitizer_for_show($this->categories[(int)($categories[0])]->cat_title);
                        // Summary
                        $event->summary = $this->text_sanitizer_for_show($event->summary);
                        $summary        = /*mb_strcut(*/
                            $event->summary/*, 0, 44)*/
                        ;
                        /*if($summary != $event->summary) $summary .= "..";*/
                        // Event ID
                        $event_id = $event->id;
                        //$e['week'] = date('W', $event->start) - date('W', mktime(0, 0, 0, $this->month, 1, $this->year));
                        // Events array
                        $events[$event_id]['summary'] = $summary;
                        $events[$event_id]['extkey0'] = (int)$event->extkey0; //added by goffy
                    } elseif ($this->isadmin || ($this->user_id > 0 && $this->user_id == $event->uid)) {
                        $event_id                     = $event->id;
                        $events[$event_id]['summary'] = sprintf(_APCAL_NTC_NUMBEROFNEEDADMIT, '');
                    }
                    $events[$event_id]['link']     = $this->make_event_link($event->id, $get_target);

The variable $event_id does not seem to be defined for all execution paths leading up to this point.

                    $events[$event_id]['location'] = $this->text_sanitizer_for_show($event->location);
                    $events[$event_id]['start']    = $this->get_middle_md($event->start /*+ $tzoffset*/) . ' ' . ($event->allday < 1 ? $this->get_middle_hi($event->start /*+ $tzoffset*/) : '');
                    $events[$event_id]['end']      = /*($event->allday != 1 ? */
                        $this->get_middle_md($event->end /*+ $tzoffset*/) /*: $this->get_middle_md($event->end - 3600))*/ . ' ' . ($event->allday
                                                                                                                                   < 1 ? $this->get_middle_hi($event->end/* + $tzoffset*/) : '');
                    $events[$event_id]['cat']      = ($event->mainCategory
                                                      && array_key_exists($event->mainCategory, $cats_color)) ? $event->mainCategory : '00000';
                    $events[$event_id]['duration'] = $endDay - $startDay + 1;
                    $events[$event_id]['picture']  = $pic && $this->showPicMonthly ? XOOPS_UPLOAD_URL . "/apcal/{$pic->picture}" : '';

                    // Find the best slot for the event
                    $i  = 0;
                    $ok = false;
                    while (!$ok) {
                        $ok = true;
                        for ($d = $startDay; $d <= $endDay; ++$d) {
                            if (isset($eventsids[$d][$i])) {
                                $ok = false;
                            }
                        }
                        if (!$ok) {
                            ++$i;
                        }
                    }

                    // Assign event to day
                    for ($d = $startDay; $d <= $endDay; ++$d) {
                        $wday = date('w', mktime(0, 0, 0, $this->month, $d, $this->year));

                        if ($d == $startDay) {
                            $wday_left         = $week_end == 7 && $wday == 0 ? 0 : $week_end - $wday;
                            $duration          = min($events[$event_id]['duration'], $wday_left + 1);
                            $eventsids[$d][$i] = array('id' => $event_id, 'first' => 1, 'duration' => $duration);
                        } elseif ($wday == $this->week_start) {
                            $duration          = min($endDay - $d + 1, 7);
                            $eventsids[$d][$i] = array('id' => $event_id, 'first' => 1, 'duration' => $duration);
                        } else {
                            $eventsids[$d][$i] = array('id' => $event_id, 'first' => 0);
                        }

                        $slots = max($slots, count($eventsids[$d]));
                    }
                }
            }
            $roimage = XOOPS_URL . '/modules/apcal/assets/images/regonline/regonline.png'; // added by goffy: general comments for online registration

            // Header
            $tpl->assign('images_url', $this->images_url);
            $tpl->assign('widths', $widths);
            $tpl->assign('week_start', $this->week_start);
            $tpl->assign('week_middle_names', $this->week_middle_names);

            // Colors
            $tpl->assign('colors', array(
                $this->sunday_color,
                $this->weekday_color,
                $this->weekday_color,
                $this->weekday_color,
                $this->weekday_color,
                $this->weekday_color,
                $this->saturday_color,
                $this->sunday_color
            ));
            $tpl->assign('bgcolors', array(
                $this->sunday_bgcolor,
                $this->weekday_bgcolor,
                $this->weekday_bgcolor,
                $this->weekday_bgcolor,
                $this->weekday_bgcolor,
                $this->weekday_bgcolor,
                $this->saturday_bgcolor,
                $this->sunday_bgcolor
            ));
            $tpl->assign('frame_css', $this->frame_css);
            $tpl->assign('holiday_color', $this->holiday_color);
            $tpl->assign('holiday_bgcolor', $this->holiday_bgcolor);
            $tpl->assign('targetday_bgcolor', $this->targetday_bgcolor);
            $tpl->assign('event_color', $this->event_color);
            $tpl->assign('event_bgcolor', $this->event_bgcolor);

            $tpl->assign('categories', $this->canbemain_cats);
            $tpl->assign('cats_color', $cats_color);

            // Loops
            $tpl->assign('week_start', $this->week_start);
            $tpl->assign('week_end', $wday_end);
            $tpl->assign('day', $date);
            $tpl->assign('last_day', $last_date);
            $tpl->assign('week_numbering', $this->week_numbering);
            $tpl->assign('weekno', $mtop_weekno);
            $tpl->assign('selectedday', (int)$this->date);
            $tpl->assign('holidays', $this->holidays);

            // Days
            $tpl->assign('insertable', $this->insertable);
            $tpl->assign('days', array('Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday', 'Sunday'));

            // Links
            $tpl->assign('cid', $this->now_cid);
            $tpl->assign('year', $this->year);
            $tpl->assign('month', $this->month);
            $tpl->assign('cal_date', $this->caldate);

            // Events
            $tpl->assign('slots', $slots);
            $tpl->assign('events', $events);
            $tpl->assign('e', $eventsids);

            $tpl->assign('for_print', $for_print);

            $tpl->assign('cal', $this);

            //added by goffy: registration online
            $tpl->assign('ro_image', $roimage);

            return $tpl->fetch(XOOPS_ROOT_PATH . '/modules/apcal/templates/apcal_monthly.tpl');
        }

        // HTML output for weekly view

        /**
         * @param  string $get_target
         * @return string
         */
        public function get_weekly_html($get_target = '')
        {
            $roimage = XOOPS_URL . '/modules/apcal/assets/images/regonline/regonline.png'; // added by goffy: image for online registration
            $ret     = "
     <table border='0' cellspacing='0' cellpadding='0' width='100%' style='border-collapse:collapse;margin:0px;'>
     <tr>
       <td><img src='$this->images_url/spacer.gif' alt='' width='10' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
       <td><img src='$this->images_url/spacer.gif' alt='' width='80' height='10' /></td>
     </tr>\n";

            $wtop_date      = $this->date - ($this->day - $this->week_start + 7) % 7;
            $wtop_unixtime  = mktime(0, 0, 0, $this->month, $wtop_date, $this->year);
            $wlast_unixtime = mktime(0, 0, 0, $this->month, $wtop_date + 7, $this->year);

            // get the result of plugins
            $plugin_returns = array();
            if (strtolower(get_class($this)) === 'apcal_xoops') {
                $db       = XoopsDatabaseFactory::getDatabaseConnection();
                $myts     = MyTextSanitizer::getInstance();
                $now      = time();
                $just1gif = 0;

                $tzoffset_s2u = (int)(($this->user_TZ - $this->server_TZ) * 3600);
                $plugins      = $this->get_plugins('weekly');

It seems like you code against a specific sub-type and not the parent class APCal as the method get_plugins() does only exist in the following sub-classes of APCal: APCal_xoops. Maybe you want to instanceof check for one of these explicitly?

                foreach ($plugins as $plugin) {
                    $include_ret = @include $this->base_path . '/' . $this->plugins_path_weekly . '/' . $plugin['file'];
                    if ($include_ret === false) {
                        // weekly emulator by monthly plugin
                        $wtop_month   = date('n', $wtop_unixtime);
                        $wlast_month  = date('n', $wlast_unixtime - 86400);
                        $year_backup  = $this->year;
                        $month_backup = $this->month;
                        if ($wtop_month == $wlast_month) {
                            @include $this->base_path . '/' . $this->plugins_path_monthly . '/' . $plugin['file'];

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                        } else {
                            $plugin_returns_backup = $plugin_returns;
                            $this->year            = date('Y', $wtop_unixtime);
                            $this->month           = $wtop_month;
                            @include $this->base_path . '/' . $this->plugins_path_monthly . '/' . $plugin['file'];

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                            for ($d = 1; $d < 21; ++$d) {

This code seems to be duplicated across your project.

                                $plugin_returns[$d] = @$plugin_returns_backup[$d];
                            }
                            $plugin_returns_backup = $plugin_returns;
                            $this->year            = date('Y', $wlast_unixtime);
                            $this->month           = $wlast_month;
                            @include $this->base_path . '/' . $this->plugins_path_monthly . '/' . $plugin['file'];

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                            for ($d = 8; $d < 32; ++$d) {

This code seems to be duplicated across your project.

                                $plugin_returns[$d] = @$plugin_returns_backup[$d];
                            }
                            $this->year  = $year_backup;
                            $this->month = $month_backup;
                        }
                    }
                }
            }

            $tzoffset = (int)(($this->user_TZ - $this->server_TZ) * 3600);
            if ($tzoffset == 0) {
                $whr_term = "start<='$wlast_unixtime' AND end>'$wtop_unixtime'";
            } else {
                $whr_term = "(allday AND start<='$wlast_unixtime' AND end>'$wtop_unixtime') || ( ! allday AND start<='"
                            . ($wlast_unixtime - $tzoffset)
                            . "' AND end>'"
                            . ($wtop_unixtime - $tzoffset)
                            . "')";
            }

            $whr_categories = $this->get_where_about_categories();
            $whr_class      = $this->get_where_about_class();

            $ars         = $GLOBALS['xoopsDB']->query("SELECT * FROM $this->table WHERE admission>0 AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start");
            $numrows_ars = $GLOBALS['xoopsDB']->getRowsNum($ars);
            $wrs         = $GLOBALS['xoopsDB']->query("SELECT * FROM $this->table WHERE admission=0 AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start");
            $numrows_wrs = $GLOBALS['xoopsDB']->getRowsNum($wrs);

            $now_date = $wtop_date;
            $wday_end = 7 + $this->week_start;
            for ($wday = $this->week_start; $wday < $wday_end; ++$wday, ++$now_date) {
                $now_unixtime      = mktime(0, 0, 0, $this->month, $now_date, $this->year);
                $toptime_of_day    = $now_unixtime + $this->day_start - $tzoffset;
                $bottomtime_of_day = $toptime_of_day + 86400;
                $link              = date('Y-n-j', $now_unixtime);
                $date              = date('j', $now_unixtime);
                $disp              = $this->get_middle_md($now_unixtime);
                $disp              .= "<br>({$this->week_middle_names[$wday]})";
                $date_part_append  = '';
                $event_str         = "
                <table cellpadding='0' cellspacing='2' style='margin:0px;'>
                  <tr>
                    <td><img src='$this->images_url/spacer.gif' alt='' border='0' width='120' height='4' /></td>
                    <td><img src='$this->images_url/spacer.gif' alt='' border='0' width='360' height='4' /></td>
                  </tr>
        \n";

                if ($numrows_ars > 0) {
                    mysqli_data_seek($ars, 0);
                }
                while ($event = $GLOBALS['xoopsDB']->fetchObject($ars)) {
                    if ($event->allday & 4) {
                        $event->end += 86400;
                    }
                    if ($event->gmlat > 0 || $event->gmlong > 0) {

This code seems to be duplicated across your project.

                        $this->gmPoints[] = array(
                            'summary'   => $event->summary,
                            'gmlat'     => $event->gmlat,
                            'gmlong'    => $event->gmlong,
                            'location'  => $event->location,
                            'contact'   => $event->contact,
                            'startDate' => date('j', $event->start + $tzoffset),
                            'event_id'  => $event->id
                        );
                    }

                    if ($event->allday) {

This code seems to be duplicated across your project.

                        if ($event->start + $tzoffset >= $now_unixtime + 86400
                            || $event->end + $tzoffset <= $now_unixtime
                        ) {
                            continue;
                        }
                    } else {
                        if ($event->start + $tzoffset >= $bottomtime_of_day
                            || $event->start + $tzoffset != $toptime_of_day
                               && $event->end + $tzoffset <= $toptime_of_day
                        ) {
                            continue;
                        }

                        $event->is_start_date = $event->start + $tzoffset >= $toptime_of_day;
                        $event->is_end_date   = $event->end + $tzoffset <= $bottomtime_of_day;
                    }

                    $summary = $this->text_sanitizer_for_show($event->summary);

                    // Get picture
                    $pic     = $GLOBALS['xoopsDB']->fetchObject($GLOBALS['xoopsDB']->query("SELECT picture FROM {$this->pic_table} WHERE event_id={$event->id} AND main_pic=1 LIMIT 0,1"));
                    $picture = $pic && $this->showPicWeekly ? "<img src='" . XOOPS_UPLOAD_URL . "/apcal/{$pic->picture}' alt='{$summary}' height='50' style='vertical-align: middle;' />" : '';

                    if ($event->allday) {
                        if ($event->allday & 4) {
                            $date_part_append .= "<span style='font-size: x-small; '><a href='{$this->make_event_link($event->id, $get_target)}' class='cal_summary_specialday'><font color='$this->holiday_color'>$summary</a></span>";
                            if ($event->extkey0 == 1) {

This code seems to be duplicated across your project.

                                $event_str .= "&nbsp;&nbsp;<img src='{$roimage}' height='15px' alt='" . _APCAL_RO_ONLINE_POSS . "' title='" . _APCAL_RO_ONLINE_POSS . "' />";
                            } // added by goffy: mark this event, that online registration is active
                            $event_str .= "</a></font><br>\n";
                            continue;
                        } else {
                            $time_part     = "             <img border='0' src='$this->images_url/dot_allday.gif' />";
                            $summary_class = 'calsummary_allday';
                        }
                    } else {

This code seems to be duplicated across your project.

                        $time_part     = $this->get_time_desc_for_a_day($event, $tzoffset, $bottomtime_of_day - $this->day_start, true, true);
                        $summary_class = 'calsummary';
                    }

                    $event_str .= "
                  <tr>
                    <td valign='top' align='center'>
                      <pre style='margin:0px;'><span style='font-size: x-small; '>$time_part</span></pre>
                    </td>
                    <td valign='top'>
                      $picture
                      <span style='font-size: x-small; '><a href='{$this->make_event_link($event->id, $get_target)}' class='$summary_class'>$summary</a></span>";
                    if ($event->extkey0 == 1) {

This code seems to be duplicated across your project.

                        $event_str .= "&nbsp;&nbsp;<img src='{$roimage}' height='15px' alt='" . _APCAL_RO_ONLINE_POSS . "' title='" . _APCAL_RO_ONLINE_POSS . "' />";
                    } // added by goffy: mark this event, that online registration is active
                    $event_str .= "
                    </td>
                  </tr>
            \n";
                }

                if ($this->isadmin || $this->user_id > 0) {
                    if ($numrows_wrs > 0) {
                        mysqli_data_seek($wrs, 0);
                    }
                    while ($event = $GLOBALS['xoopsDB']->fetchObject($wrs)) {
                        if ($event->allday) {

This code seems to be duplicated across your project.

                            if ($event->start + $tzoffset >= $now_unixtime + 86400
                                || $event->end + $tzoffset <= $now_unixtime
                            ) {
                                continue;
                            }
                        } else {
                            if ($event->start + $tzoffset >= $bottomtime_of_day
                                || $event->start + $tzoffset != $toptime_of_day
                                   && $event->end + $tzoffset <= $toptime_of_day
                            ) {
                                continue;
                            }
                            $event->is_start_date = $event->start + $tzoffset >= $toptime_of_day;
                            $event->is_end_date   = $event->end + $tzoffset <= $bottomtime_of_day;
                        }

                        $summary = $this->text_sanitizer_for_show($event->summary);

                        // Get picture
                        $pic     = $GLOBALS['xoopsDB']->fetchObject($GLOBALS['xoopsDB']->query("SELECT picture FROM {$this->pic_table} WHERE event_id={$event->id} AND main_pic=1 LIMIT 0,1"));
                        $picture = $pic && $this->showPicWeekly ? "<img src='" . XOOPS_UPLOAD_URL . "/apcal/{$pic->picture}' alt='{$summary}' height='50' style='vertical-align: middle;' />" : '';

                        if ($event->allday) {
                            $time_part     = "             <img border='0' src='$this->images_url/dot_notadmit.gif' />";
                            $summary_class = 'calsummary_allday';
                        } else {

This code seems to be duplicated across your project.

                            $time_part     = $this->get_time_desc_for_a_day($event, $tzoffset, $bottomtime_of_day - $this->day_start, true, false);
                            $summary_class = 'calsummary';
                        }

                        $event_str .= "
                      <tr>
                        <td valign='top' align='center'>
                          <pre style='margin:0px;'><span style='font-size: x-small; '>$time_part</span></pre>
                        </td>
                        <td valign='top'>
                          $picture
                          <span style='font-size: x-small; '><a href='{$this->make_event_link($event->id, $get_target)}' class='$summary_class'><font color='#00FF00'>$summary("
                                      . _APCAL_MB_EVENT_NEEDADMIT
                                      . ')</a></span>';
                        if ($event->extkey0 == 1) {

This code seems to be duplicated across your project.

                            $event_str .= "&nbsp;&nbsp;<img src='{$roimage}' height='15px' alt='" . _APCAL_RO_ONLINE_POSS . "' title='" . _APCAL_RO_ONLINE_POSS . "' />";
                        } // added by goffy: mark this event, that online registration is active
                        $event_str .= "
                        </td>
                      </tr>
                \n";
                    }
                }

                // drawing the result of plugins
                if (!empty($plugin_returns[$date])) {
                    foreach ($plugin_returns[$date] as $item) {

This code seems to be duplicated across your project.

                        $event_str .= "
                  <tr>
                    <td></td>
                    <td valign='top'>
                      <span style='font-size: x-small; '><a href='{$item['link']}' class='$summary_class'><img src='$this->images_url/{$item['dotgif']}' alt='{$item['title']}>' />{$item['title']}</a></span>

The variable $summary_class does not seem to be defined for all execution paths leading up to this point.

                    </td>
                  </tr>\n";
                    }
                }

                if ($this->insertable) {
                    $event_str .= "
                  <tr>
                    <td valign='bottom' colspan='2'>
                      &nbsp; <span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Weekly&amp;action=Edit&amp;caldate=$link'><img src='$this->images_url/addevent.gif' border='0' width='14' height='12' />"
                                  . _APCAL_MB_ADDEVENT
                                  . "</a></span>
                    </td>
                  </tr>
        \n";
                }

                $event_str .= "\t\t\t\t</table>\n";

                if (isset($this->holidays[$link])) {
                    //  Holiday
                    $bgcolor = $this->holiday_bgcolor;
                    $color   = $this->holiday_color;
                    if ($this->holidays[$link] != 1) {
                        $date_part_append .= "<span color='$this->holiday_color'>{$this->holidays[ $link ]}</span>\n";
                    }
                } elseif ($wday % 7 == 0) {
                    //  Sunday
                    $bgcolor = $this->sunday_bgcolor;
                    $color   = $this->sunday_color;
                } elseif ($wday == 6) {
                    //  Saturday
                    $bgcolor = $this->saturday_bgcolor;
                    $color   = $this->saturday_color;
                } else {
                    // Weekday
                    $bgcolor = $this->weekday_bgcolor;
                    $color   = $this->weekday_color;
                }

                // ��������طʿ��ϥ��饤�Ƚ���
                if ($link == $this->caldate) {
                    $body_bgcolor = $this->targetday_bgcolor;
                } else {
                    $body_bgcolor = $bgcolor;
                }

                $ret .= "
     <tr>
       <td><img src='$this->images_url/spacer.gif' alt='' width='10' height='80' /></td>
       <td bgcolor='$bgcolor' align='center' valign='middle' style='vertical-align:middle;text-align:center;$this->frame_css background-color:$bgcolor;'>
         <a href='{$this->make_cal_link($get_target, 'Daily', $this->now_cid, $link)}' class='calbody'><font size='3' color='$color'><b><span class='calbody'>$disp</span></b></font></a><br>
         $date_part_append
       </td>
       <td valign='top' colspan='6' bgcolor='$body_bgcolor' style='$this->frame_css background-color:$body_bgcolor'>
         $event_str
       </td>
     </tr>\n";
            }

            $ret .= "\t </table>\n";

            return $ret;
        }

        // Get the html for the daily view

        /**
         * @param  string $get_target
         * @return string
         */
        public function get_daily_html($get_target = '')
        {
            $roimage = XOOPS_URL . '/modules/apcal/assets/images/regonline/regonline.png'; // added by goffy: image for online registration
            // get the result of plugins
            $plugin_returns = array();
            if (strtolower(get_class($this)) === 'apcal_xoops') {
                $db       = XoopsDatabaseFactory::getDatabaseConnection();
                $myts     = MyTextSanitizer::getInstance();
                $now      = time();
                $just1gif = 0;

                $tzoffset_s2u = (int)(($this->user_TZ - $this->server_TZ) * 3600);
                $plugins      = $this->get_plugins('daily');

It seems like you code against a specific sub-type and not the parent class APCal as the method get_plugins() does only exist in the following sub-classes of APCal: APCal_xoops. Maybe you want to instanceof check for one of these explicitly?

                foreach ($plugins as $plugin) {
                    $include_ret = @include $this->base_path . '/' . $this->plugins_path_daily . '/' . $plugin['file'];
                    if ($include_ret === false) {
                        // daily emulator by monthly plugin
                        @include $this->base_path . '/' . $this->plugins_path_monthly . '/' . $plugin['file'];

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                    }
                }
            }

            list($bgcolor, $color) = $this->daytype_to_colors($this->daytype);

The assignment to $color is unused. Consider omitting it like so list($first,,$third).

            $ret = "
    <table border='0' cellspacing='0' cellpadding='0' width='100%' style='margin:0px;'>
     <tr>
     <td width='100%' class='calframe'>
     <table border='0' cellspacing='0' cellpadding='0' width='100%' style='margin:0px;'>
     <tr>
       <td colspan='8'><img src='$this->images_url/spacer.gif' alt='' width='570' height='10' /></td>
     </tr>
     <tr>
       <td><img src='$this->images_url/spacer.gif' alt='' width='10' height='350' /></td>
       <td colospan='7' valign='top' bgcolor='$bgcolor' style='$this->frame_css;background-color:$bgcolor'>
         <table border='0' cellpadding='0' cellspacing='0' style='margin:0px;'>
           <tr>
             <td><img src='$this->images_url/spacer.gif' alt='' width='120' height='10' /></td>
             <td><img src='$this->images_url/spacer.gif' alt='' width='440' height='10' /></td>
           </tr>
    \n";

            // WHERE Clause - Date
            $tzoffset          = (int)(($this->user_TZ - $this->server_TZ) * 3600);
            $toptime_of_day    = $this->unixtime + $this->day_start - $tzoffset;
            $bottomtime_of_day = $toptime_of_day + 86400;
            $whr_term          = "(allday AND start<='$this->unixtime' AND end>'$this->unixtime') || ( ! allday AND start<'$bottomtime_of_day' AND (start='$toptime_of_day' OR end>'$toptime_of_day'))";

            // WHERE Clause - Categories
            $whr_categories = $this->get_where_about_categories();

            // WHERE Clause - Class
            $whr_class = $this->get_where_about_class();

            // MySQL Query
            $yrs      = $GLOBALS['xoopsDB']->query("SELECT *,(start>='$toptime_of_day') AS is_start_date,(end<='$bottomtime_of_day') AS is_end_date FROM $this->table WHERE admission>0 AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start,end");
            $num_rows = $GLOBALS['xoopsDB']->getRowsNum($yrs);

            if ($num_rows == 0) {
                $ret .= '<tr><td></td><td>' . _APCAL_MB_NOEVENT . "</td></tr>\n";
            } else {
                while ($event = $GLOBALS['xoopsDB']->fetchObject($yrs)) {
                    // Get picture
                    $pic     = $GLOBALS['xoopsDB']->fetchObject($GLOBALS['xoopsDB']->query("SELECT picture FROM {$this->pic_table} WHERE event_id={$event->id} AND main_pic=1 LIMIT 0,1"));
                    $picture = $pic && $this->showPicDaily ? "<img src='" . XOOPS_UPLOAD_URL . "/apcal/{$pic->picture}' alt='{$summary}' height='50' style='vertical-align: middle;' />" : '';

The variable $summary does not seem to be defined for all execution paths leading up to this point.

                    // Google map
                    if ($event->gmlat > 0 || $event->gmlong > 0) {

This code seems to be duplicated across your project.

                        $this->gmPoints[] = array(
                            'summary'   => $event->summary,
                            'gmlat'     => $event->gmlat,
                            'gmlong'    => $event->gmlong,
                            'location'  => $event->location,
                            'contact'   => $event->contact,
                            'startDate' => date('j', $event->start),
                            'event_id'  => $event->id
                        );
                    }

                    if ($event->allday) {

This code seems to be duplicated across your project.

                        $time_part = "             <img border='0' src='$this->images_url/dot_allday.gif' />";
                    } else {
                        $time_part = $this->get_time_desc_for_a_day($event, $tzoffset, $bottomtime_of_day - $this->day_start, true, true);
                    }

                    $description   = $this->textarea_sanitizer_for_show($event->description);
                    $summary       = $this->text_sanitizer_for_show($event->summary);
                    $summary_class = $event->allday ? 'calsummary_allday' : 'calsummary';

                    $ret .= "
           <tr>
             <td valign='middle' align='center'>
               <pre style='margin:0px;'><font size='3'>$time_part</font></pre>
             </td>
             <td valign='middle'>
               <a href='{$this->make_event_link($event->id, $get_target)}'>{$picture}</a>
               <font size='3'><a href='{$this->make_event_link($event->id, $get_target)}' class='$summary_class'>$summary</a></font>";
                    if ($event->extkey0 == 1) {

This code seems to be duplicated across your project.

                        $ret .= "&nbsp;&nbsp;<img src='{$roimage}' height='15px' alt='" . _APCAL_RO_ONLINE_POSS . "' title='" . _APCAL_RO_ONLINE_POSS . "'>";
                    }    // added by goffy: mark this event, that online registration is active
                    $ret .= "<br>
               <span style='font-size: x-small; '>$description</span><br>
               &nbsp;
             </td>
           </tr>\n";
                }
            }

            if ($this->isadmin || $this->user_id > 0) {
                $whr_uid = $this->isadmin ? '1' : "uid=$this->user_id ";
                $yrs     = $GLOBALS['xoopsDB']->query("SELECT start,end,summary,id,allday,admission,uid,description,(start>='$toptime_of_day') AS is_start_date,(end<='$bottomtime_of_day') AS is_end_date FROM $this->table WHERE admission=0 AND $whr_uid AND ($whr_term) AND ($whr_categories) AND ($whr_class) ORDER BY start,end");

                while ($event = $GLOBALS['xoopsDB']->fetchObject($yrs)) {
                    if ($event->allday) {

This code seems to be duplicated across your project.

                        $time_part = "             <img border='0' src='$this->images_url/dot_notadmit.gif' />";
                    } else {
                        $time_part = $this->get_time_desc_for_a_day($event, $tzoffset, $bottomtime_of_day - $this->day_start, true, false);
                    }

                    $summary = $this->text_sanitizer_for_show($event->summary);

                    $summary_class = $event->allday ? 'calsummary_allday' : 'calsummary';

                    $ret .= "
           <tr>
             <td valign='top' align='center'>
               <pre style='margin:0px;'><font size='3'>$time_part</font></pre>
             </td>
             <td vlalign='top'>
               <font size='3'><a href='{$this->make_event_link($event->id, $get_target)}' class='$summary_class'><font color='#00FF00'>{$summary}</a></font>";
                    if ($event->extkey0 == 1) {

This code seems to be duplicated across your project.

                        $ret .= "&nbsp;&nbsp;<img src='{$roimage}' height='15px' alt='" . _APCAL_RO_ONLINE_POSS . "' title='" . _APCAL_RO_ONLINE_POSS . "'>";
                    }    // added by goffy: mark this event, that online registration is active
                    $ret .= ' (' . _APCAL_MB_EVENT_NEEDADMIT . ")
             </td>
           </tr>\n";
                }
            }

            // drawing the result of plugins
            if (!empty($plugin_returns[$this->date])) {
                foreach ($plugin_returns[$this->date] as $item) {

This code seems to be duplicated across your project.

                    $ret .= "
           <tr>
             <td></td>
             <td valign='top'>
               <font size='3'><a href='{$item['link']}' class='$summary_class'><img src='$this->images_url/{$item['dotgif']}' alt='{$item['title']}>' />{$item['title']}</a></font><br>

The variable $summary_class does not seem to be defined for all execution paths leading up to this point.

               <span style='font-size: x-small; '>{$item['description']}</span><br>
               &nbsp;
             </td>
           </tr>\n";
                }
            }

            // ͽ����ɲáʱ�ɮ���������
            if ($this->insertable) {

This code seems to be duplicated across your project.

                $ret .= "
           <tr>
             <td valign='bottom' colspan='2'>
               &nbsp; <span style='font-size: x-small; '><a href='$get_target?cid=$this->now_cid&amp;smode=Daily&amp;action=Edit&amp;caldate=$this->caldate'><img src='$this->images_url/addevent.gif' border='0' width='14' height='12' />"
                        . _APCAL_MB_ADDEVENT
                        . "</a></span>
             </td>
           </tr>\n";
            }

            $ret .= "
         </table>
       </td>
     </tr>
     </table>
     </td>
     </tr>
    </table>\n";

            return $ret;
        }

        /*******************************************************************/
        /*        �ᥤ���� �ʸ��̥ǡ�������  */
        /*******************************************************************/

        /**
         * @param $event_id
         */
        public function savepictures($event_id)
        {
            xoops_load('xoopsmediauploader');
            $uploader = new XoopsMediaUploader(XOOPS_UPLOAD_PATH . '/apcal', array(
                'image/gif',
                'image/jpeg',
                'image/pjpeg',
                'image/x-png',
                'image/png',
                'image/bmp'
            ), $_POST['MAX_FILE_SIZE'], 4048, 4048);
            $uploader->setPrefix('APCal');
            $err = array();
            foreach ($_POST['files'] as $i => $file) {
                $main_pic = $file === 'picture0' ? 1 : 0;
                if ($uploader->fetchMedia($file)) {
                    if (!$uploader->upload()) {
                        $err[] = $uploader->getErrors();
                    } else {
                        $filename = $uploader->getSavedFileName();
                        $result   = $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table}(event_id, picture, main_pic) VALUES ({$event_id}, '{$filename}', {$main_pic})");
                        if (!$result) {
                            $err[] = sprintf(_FAILSAVEIMG, $i);
                        } else {
                            Thumb::save($filename, $this->picWidth, $this->picHeight);
                        }
                    }
                } else {
                    $err[] = sprintf(_FAILFETCHIMG, $i);
                    $err   = array_merge($err, $uploader->getErrors(false));
                }
            }

            //FOR DEBUG: var_dump($err);
        }

        // Show an event

        /**
         * @param  bool $for_print
         * @return string

Should the return type not be null|string?

         */
        public function get_schedule_view_html($for_print = false)
        {
            global $xoopsTpl;

            $smode     = empty($_GET['smode']) ? 'Monthly' : preg_replace('/[^a-zA-Z0-9_-]/', '', $_GET['smode']);
            $editable  = $this->editable;
            $superedit = $this->superedit;
            $deletable = $this->deletable;

            $whr_categories = $this->get_where_about_categories();

            // CLASS
            $whr_class = $this->get_where_about_class();

            if (empty($_GET['event_id'])) {
                die(_APCAL_ERR_INVALID_EVENT_ID);
            }
            $this->original_id = $event_id = (int)$_GET['event_id'];
            $yrs               = $GLOBALS['xoopsDB']->query("SELECT *,UNIX_TIMESTAMP(dtstamp) AS udtstamp FROM $this->table WHERE id='$event_id' AND ($whr_categories) AND ($whr_class)");
            if ($GLOBALS['xoopsDB']->getRowsNum($yrs) < 1) {
                die(_APCAL_ERR_INVALID_EVENT_ID);
            }
            $event = $GLOBALS['xoopsDB']->fetchObject($yrs);

            // rrule
            if (trim($event->rrule) !== '') {
                if ($event->rrule_pid != $event->id) {
                    $event->id = $event->rrule_pid;
                    $yrs       = $GLOBALS['xoopsDB']->query("SELECT id,start,start_date FROM $this->table WHERE id='$event->rrule_pid' AND ($whr_categories) AND ($whr_class)");
                    if ($GLOBALS['xoopsDB']->getRowsNum($yrs) >= 1) {
                        $event->id           = $event->rrule_pid;
                        $parent_event        = $GLOBALS['xoopsDB']->fetchObject($yrs);
                        $this->original_id   = $parent_event->id;
                        $is_extracted_record = true;
                    } else {
                        $parent_event = $event;
                    }
                }
                $rrule = $this->rrule_to_human_language($event->rrule);
            } else {
                $rrule = '';
            }

            // submitter of event
            if ($event->uid != $this->user_id) {
                $editable  = false;
                $deletable = false;
            }
            // user is admin or has right to edit/delete all events
            if ($this->isadmin || $superedit) {
                $editable  = true;
                $deletable = true;
            }

            // editable
            if (!$event->admission && !$editable) {
                die(_APCAL_ERR_NOPERM_TO_SHOW);
            }

            if ($editable && !$for_print) {
                $edit_button = "
            <form class='apcalForm' method='get' action='" . XOOPS_URL . "/modules/apcal/index.php' style='margin:0px;'>
                <input type='hidden' name='smode' value='$smode' />
                <input type='hidden' name='action' value='Edit' />
                <input type='hidden' name='event_id' value='$event->id' />
                <input type='hidden' name='caldate' value='{$_GET['date']}' />
                <input type='submit' value='" . _APCAL_BTN_EDITEVENT . "' />
            </form>\n";
            } else {
                $edit_button = '';
            }

            if ($deletable && !$for_print) {
                $delete_button = "
            <form class='apcalForm' method='post' action='"
                                 . XOOPS_URL
                                 . "/modules/apcal/index.php' id='MainForm' name='MainForm' style='margin:0px;'>
                <input type='hidden' name='smode' value='$smode' />
                <input type='hidden' name='last_smode' value='$smode' />
                <input type='hidden' name='event_id' value='$event->id' />
                <input type='hidden' name='subevent_id' value='$event_id' />
                <input type='hidden' name='caldate' value='$this->caldate' />
                <input type='hidden' name='last_caldate' value='{$_GET['date']}' />
                <input type='submit' name='delete' value='"
                                 . _APCAL_BTN_DELETE
                                 . "' onclick='return confirm(\""
                                 . _APCAL_CNFM_DELETE_YN
                                 . "\")' />
                "
                                 . (!empty($is_extracted_record) ? "<input type='submit' name='delete_one' value='"
                                                                   . _APCAL_BTN_DELETE_ONE
                                                                   . "' onclick='return confirm(\""
                                                                   . _APCAL_CNFM_DELETE_YN
                                                                   . "\")' />" : '')
                                 . '
                '
                                 . $GLOBALS['xoopsGTicket']->getTicketHtml(__LINE__)
                                 . "
            </form>\n";
            } else {
                $delete_button = '';
            }

            // iCalendar
            if ($this->can_output_ics && !$for_print) {
                $php_self4disp     = strtr(@$_SERVER['PHP_SELF'], '<>\'"', '    ');
                $ics_output_button = "
            <a href='http://{$_SERVER['HTTP_HOST']}$php_self4disp?fmt=single&amp;event_id=$event->id&amp;output_ics=1' target='_blank'><img border='0' src='$this->images_url/output_ics_win.gif' alt='"
                                     . _APCAL_BTN_OUTPUTICS_WIN
                                     . "' title='"
                                     . _APCAL_BTN_OUTPUTICS_WIN
                                     . "' /></a>
            <a href='webcal://{$_SERVER['HTTP_HOST']}$php_self4disp?fmt=single&amp;event_id=$event->id&amp;output_ics=1' target='_blank'><img border='0' src='$this->images_url/output_ics_mac.gif' alt='"
                                     . _APCAL_BTN_OUTPUTICS_MAC
                                     . "' title='"
                                     . _APCAL_BTN_OUTPUTICS_MAC
                                     . "' /></a>\n";
            } else {
                $ics_output_button = '';
            }

            if ($event->allday) {
                $tzoffset = (int)(($this->user_TZ - $this->server_TZ) * 3600);
                //$event->end -= 300 ;
                $start_time_str = /*"("._APCAL_MB_ALLDAY_EVENT.")"*/
                    '';
                $end_time_str   = '';
            } else {
                $tzoffset       = (int)(($this->user_TZ - $this->server_TZ) * 3600);
                $disp_user_tz   = $this->get_tz_for_display($this->user_TZ);
                $start_time_str = $this->get_middle_hi($event->start + $tzoffset) . " $disp_user_tz";
                $end_time_str   = $this->get_middle_hi($event->end + $tzoffset) . " $disp_user_tz";
                if ($this->user_TZ != $event->event_tz) {
                    $tzoffset_s2e   = (int)(($event->event_tz - $this->server_TZ) * 3600);
                    $disp_event_tz  = $this->get_tz_for_display($event->event_tz);
                    $start_time_str .= ' &nbsp; &nbsp; <small>' . $this->get_middle_dhi($event->start + $tzoffset_s2e) . " $disp_event_tz</small>";
                    $end_time_str   .= ' &nbsp; &nbsp; <small>' . $this->get_middle_dhi($event->end + $tzoffset_s2e) . " $disp_event_tz</small>";
                }
            }

            $start_date_str = $this->get_long_ymdn($event->start + $tzoffset);
            $end_date_str   = $this->get_long_ymdn($event->end + $tzoffset);

            $start_datetime_str = "$start_date_str&nbsp;$start_time_str";
            $end_datetime_str   = "$end_date_str&nbsp;$end_time_str";

            if (trim($event->rrule) !== '') {
                if (isset($parent_event) && $parent_event != $event) {
                    if (isset($parent_event->start_date)) {
                        $parent_date_str = $parent_event->start_date; // GIJ TODO
                    } else {
                        $parent_date_str = $this->get_long_ymdn($parent_event->start + $tzoffset);
                    }
                    $rrule .= "<br><a href='?action=View&amp;event_id=$parent_event->id' target='_blank'>" . _APCAL_MB_LINK_TO_RRULE1ST . " $parent_date_str</a>";
                } else {
                    $rrule .= '<br> ' . _APCAL_MB_RRULE1ST;
                }
            }

            $cat_titles4show = '';
            $cids            = explode(',', $event->categories);
            foreach ($cids as $cid) {
                $cid = (int)$cid;
                if (isset($this->categories[$cid])) {
                    $cat_titles4show .= "<a href='{$this->make_cal_link('', '', $cid, date('Y-n-j', $event->start))}'>" . $this->text_sanitizer_for_show($this->categories[$cid]->cat_title) . '</a>, ';
                }
            }
            if ($cat_titles4show !== '') {
                $cat_titles4show = substr($cat_titles4show, 0, -2);
            }

            $submitter_info = $this->get_submitter_info($event->uid);

            if ($event->class === 'PRIVATE') {
                $groupid = (int)$event->groupid;
                if ($groupid == 0) {
                    $group = _APCAL_OPT_PRIVATEMYSELF;
                } elseif (isset($this->groups[$groupid])) {
                    $group = sprintf(_APCAL_OPT_PRIVATEGROUP, $this->groups[$groupid]);
                } else {
                    $group = _APCAL_OPT_PRIVATEINVALID;
                }
                $class_status = _APCAL_MB_PRIVATE . sprintf(_APCAL_MB_PRIVATETARGET, $group);
            } else {
                $class_status = _APCAL_MB_PUBLIC;
            }

            $admission_status = $event->admission ? _APCAL_MB_EVENT_ADMITTED : _APCAL_MB_EVENT_NEEDADMIT;
            $last_modified    = $this->get_long_ymdn($event->udtstamp - (int)(($this->user_TZ - $this->server_TZ) * 3600));
            $description      = $this->textarea_sanitizer_for_show($event->description);
            $summary          = $this->text_sanitizer_for_show($event->summary);
            $location         = $this->text_sanitizer_for_show($event->location);
            $contact          = $this->text_sanitizer_for_show($event->contact);
            $contact          = convertmycontacts($contact); // added one line by goffy: converting the contact name(s) into a link to member account this is not necessary for online registration
            $email            = $this->text_sanitizer_for_show($event->email);
            $url              = $this->text_sanitizer_for_show($event->url);
            $url              = $url !== '' && substr($url, 0, 4) !== 'http' ? 'http://' . $url : $url;
            $otherHour        = explode('-', $event->otherHours);
            if ($otherHour[0] !== '') {
                //$event->end += 300 ;
                $h          = array(
                    0,
                    date('H', $event->start + $tzoffset),
                    date('i', $event->start + $tzoffset),
                    date('H', $event->end + $tzoffset),
                    date('i', $event->end + $tzoffset)
                );
                $d          = $this->get_long_ymdn($event->start + ($h[0] * 3600 * 24) + $tzoffset);
                $otherHours = '<br>' . $d . '&nbsp;&nbsp;&nbsp;&nbsp;' . sprintf('%02d', $h[1]) . ':' . sprintf('%02d', $h[2]) . ' - ' . sprintf('%02d', $h[3]) . ':' . sprintf('%02d', $h[4]);
                foreach ($otherHour as $day) {
                    $h          = explode(':', $day);
                    $d          = $this->get_long_ymdn($event->start + ($h[0] * 3600 * 24) + $tzoffset);
                    $otherHours .= '<br>' . $d . '&nbsp;&nbsp;&nbsp;&nbsp;' . sprintf('%02d', $h[1]) . ':' . sprintf('%02d', $h[2]) . ' - ' . sprintf('%02d', $h[3]) . ':' . sprintf('%02d', $h[4]);
                }
            }

            $this->last_summary = $summary;

            /********************************************************************/
            /* added by goffy: code for online registration                     */
            /********************************************************************/
            $this->regonline = (int)$event->extkey0;
            $registered      = 0;
            if ($this->regonline == 1) {
                $result_ro  = $GLOBALS['xoopsDB']->query('SELECT ' . XOOPS_DB_PREFIX . $this->table_ro_events . '.roe_number
                FROM ' . XOOPS_DB_PREFIX . $this->table_ro_events . '
                WHERE (((roe_eventid)=' . $event->id . '))');
                $row        = $GLOBALS['xoopsDB']->fetchRow($result_ro);
                $itemstotal = $row[0];
                if ($itemstotal == 0) {
                    //$eventmembersall = "No limit for online registration";
                } else {
                    $eventmembersall = _APCAL_RO_QUANTITY2 . ': ' . $itemstotal . '<br>';
                }

                $result_ro  = $GLOBALS['xoopsDB']->query('SELECT Count(rom_id) AS countevents
                FROM ' . XOOPS_DB_PREFIX . $this->table_ro_members . '
                WHERE (((rom_eventid)=' . $event->id . '))');
                $row        = $GLOBALS['xoopsDB']->fetchRow($result_ro);
                $itemstotal = $row[0];
                if ($itemstotal == 0) {
                    $eventmembersall .= _APCAL_RO_NOMEMBERS;

The variable $eventmembersall does not seem to be defined for all execution paths leading up to this point.

                    $eventmembers    = '';
                } else {
                    $eventmembersall .= _APCAL_RO_ONLINE . ': ' . $itemstotal;
                    if (!$this->user_id == 0 && $editable) {
                        $eventmembers .= '<br>' . _APCAL_RO_UNAME . ':';

The variable $eventmembers seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

                    } else {
                        $eventmembers = '';
                    }
                }

                if (!$this->user_id == 0) {
                    if ($editable) {
                        $result_ro = $GLOBALS['xoopsDB']->query('SELECT '
                            . XOOPS_DB_PREFIX
                            . '_users.uname,
                    '
                            . XOOPS_DB_PREFIX
                            . '_users.uid, count(rom_id) as counter
                    FROM '
                            . XOOPS_DB_PREFIX
                            . $this->table_ro_members
                            . ' INNER JOIN '
                            . XOOPS_DB_PREFIX
                            . '_users ON '
                            . XOOPS_DB_PREFIX
                            . $this->table_ro_members
                            . '.rom_submitter = '
                            . XOOPS_DB_PREFIX
                            . '_users.uid
                    WHERE ((('
                            . XOOPS_DB_PREFIX
                            . $this->table_ro_members
                            . '.rom_eventid)='
                            . $event->id
                            . ')) GROUP BY 1,2');
                        $num_rows = $GLOBALS['xoopsDB']->getRowsNum($result_ro);

$num_rows is not used, you could remove the assignment.

                        $baseurl = XOOPS_URL;

$baseurl is not used, you could remove the assignment.

                        while ($row = $GLOBALS['xoopsDB']->fetchRow($result_ro)) {
                            $uname = $row[0];
                            $uid = $row[1];
                            $counter = $row[2];
                            $eventmembers = (substr($eventmembers, strlen($eventmembers) - 1, 1) === ':') ? $eventmembers .= ' ' : $eventmembers .= ', ';
                            $eventmembers .= "<a href='" . XOOPS_URL . '/userinfo.php?uid=' . $uid . "' title=" . $uname . '>' . $uname . '</a>';

                            if ($this->user_id == $uid) {
                                $registered = 1;
                            }
                            if ($counter > 1) {
                                $eventmembers .= ' (' . $counter . ')';
                            }
                        }
                    }

                    if (!empty($_SERVER['HTTPS'])) {

This code seems to be duplicated across your project.

                        $this->redirecturl = 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                    } else {
                        $this->redirecturl = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                    }
                    
                    $eventmembers_only = '';
                    $eventmembers_form = '';
                    //if ($editable && !$for_print) {
                    if (!$for_print) {
                        $eventmembers_form = "
                            <form class='apcalForm' method='post' id='RegOnlineForm' action='ro_regonlinehandler.php' name='roformmembers1' style='margin:0px;'>
                                <input type='hidden' name='eventid' value='$event->id' />
                                <input type='hidden' name='event_uid' value='$event->uid' />
                                <input type='hidden' name='uid' value='$this->user_id' />
                                <input type='hidden' name='eventurl' value='$this->redirecturl' />
                                <input type='hidden' name='summary' value='$summary' />
                                <input type='hidden' name='date' value='$start_date_str' />
                                <input type='hidden' name='eventdate' value='$event->start' />
                                <input type='hidden' name='location' value='$location' />
                                <div style='float:right;'>";
                        if ($registered == 1) {
                            $eventmembers_form .= "<input type='submit' name='form_add' value='" . _APCAL_RO_BTN_ADDMORE . "' />";
                        } else {
                            $eventmembers_form .= "<input type='submit' name='form_add' value='" . _APCAL_RO_BTN_ADD . "' />&nbsp;";
                        }
                        if ($editable && !$for_print && $itemstotal > 0) {
                            $eventmembers_form .= "<input type='submit' name='list' value='" . _APCAL_RO_BTN_LISTMEMBERS . "' />";
                        }
                        $eventmembers_form .= "</div></form>\n";
                    }
                } else {
                    $eventmembers_only = '<p>' . _APCAL_RO_ONLY_MEMBERS . '</p>';
                    $eventmembers_only .= "<a class='btn btn-primary' href='" . XOOPS_URL . "/modules/profile/user.php?xoops_redirect=/modules/apcal/?event_id=$event->id&action=View' title=''>Einloggen</a>";
                    $eventmembers_only .= "<br>Sie sind noch nicht als User registriert? Dann bitte zuerst <a class='btn btn-info cal-btn' href='" . XOOPS_URL . "/modules/profile/register.php' title=''>Registrieren</a>";

                }

                $eventmembertable = "
        <tr>
            <td class='head'>" . _APCAL_RO_ONLINE . "</td>
            <td class='even'>
                <div style='float:left; margin: 2px;'>$eventmembersall$eventmembers";
                if ('' !== $eventmembers_only) {
                    $eventmembertable .= $eventmembers_only;
                }
                $eventmembertable .= "</div>
                <div style='float:left; margin: 2px;'>$eventmembers_form</div>

The variable $eventmembers_form does not seem to be defined for all execution paths leading up to this point.

            </td>
        </tr>";
            } else {
                $eventmembertable = "
        <tr>
            <td class='head'>" . _APCAL_RO_ONLINE . "</td>
            <td class='even'>
                <div style='float:left; margin: 2px;'>" . _APCAL_RO_ONLINE_NO . '</div>
            </td>
        </tr>';
            }
            /*******************************************************************/
            /* end added by goffy:                                             */
            /*******************************************************************/

            $pictures = '';
            $pics     = $GLOBALS['xoopsDB']->query("SELECT picture FROM {$this->pic_table} WHERE event_id={$event_id} ORDER BY main_pic DESC, id ASC LIMIT 0,{$this->nbPictures}");
            while ($pic = $GLOBALS['xoopsDB']->fetchObject($pics)) {
                if (!Thumb::exists($pic->picture)) {
                    Thumb::save($pic->picture, $this->picWidth, $this->picHeight);
                }
                $pictures .= '<div style="padding: 10px 0;">
                <a href="' . XOOPS_UPLOAD_URL . '/apcal/' . $pic->picture . '" class="highslide" onclick="return hs.expand(this)">
                    <img src="' . XOOPS_UPLOAD_URL . '/apcal/thumbs/' . $pic->picture . '" alt="Image" />
                </a>
             </div>';
            }

            if ($xoopsTpl) {
                $prevEvent = $GLOBALS['xoopsDB']->query("SELECT id,start FROM $this->table WHERE id<{$event->id} AND start={$event->start} ORDER BY id DESC LIMIT 0,1");
                $prevEvent = $GLOBALS['xoopsDB']->fetchObject($prevEvent);
                if (!$prevEvent) {

This code seems to be duplicated across your project.

                    $prevEvent = $GLOBALS['xoopsDB']->query("SELECT id,start FROM $this->table WHERE start<{$event->start} ORDER BY start DESC LIMIT 0,1");
                    $prevEvent = $GLOBALS['xoopsDB']->fetchObject($prevEvent);
                }
                $prevEvent = $prevEvent ? $this->make_event_link($prevEvent->id) : false;
                $xoopsTpl->assign('prevEvent', $prevEvent);

                $nextEvent = $GLOBALS['xoopsDB']->query("SELECT id,start FROM $this->table WHERE id>{$event->id} AND start={$event->start} ORDER BY id ASC LIMIT 0,1");
                $nextEvent = $GLOBALS['xoopsDB']->fetchObject($nextEvent);
                if (!$nextEvent) {

This code seems to be duplicated across your project.

                    $nextEvent = $GLOBALS['xoopsDB']->query("SELECT id,start FROM $this->table WHERE start>{$event->start} ORDER BY start ASC LIMIT 0,1");
                    $nextEvent = $GLOBALS['xoopsDB']->fetchObject($nextEvent);
                }
                $nextEvent = $nextEvent ? $this->make_event_link($nextEvent->id) : false;
                $xoopsTpl->assign('nextEvent', $nextEvent);

                $xoopsTpl->assign('title', $summary);
                $xoopsTpl->assign('location', $location);
                $xoopsTpl->assign('contact', $contact);
                $xoopsTpl->assign('email', $email);
                $xoopsTpl->assign('url', $url);
                $xoopsTpl->assign('startdate', date('Y-n-j', $event->start));
                $xoopsTpl->assign('calLink', $this->make_cal_link('', '', 0, date('Y-n-j', $event->start)));
                $xoopsTpl->assign('GMLat', $event->gmlat);
                $xoopsTpl->assign('GMLong', $event->gmlong);
                $xoopsTpl->assign('GMZoom', $event->gmzoom);
                $xoopsTpl->assign('GMheight', $this->gmheight . 'px');
                $xoopsTpl->assign('eventNavEnabled', $this->eventNavEnabled);
                $xoopsTpl->assign('picsWidth', $pictures !== '' ? ($this->picWidth + 10) . 'px' : 0);
                $xoopsTpl->assign('picsMargin', $pictures !== '' ? ($this->picWidth + 20) . 'px' : 0);
                $xoopsTpl->assign('pictures', $pictures);
                $xoopsTpl->assign('showPrint', $this->enableprint);
            }

            $ret = "
    <table border='0' cellpadding='0' cellspacing='2'>";
            $ret .= ($summary !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_SUMMARY . "</td>
        <td class='even'>$summary</td>
    </tr>" : '';
            $ret .= "
    <tr>
        <td class='head'>" . _APCAL_TH_STARTDATETIME . "</td>
        <td class='even'>$start_datetime_str</td>
    </tr>
    <tr>
        <td class='head'>" . _APCAL_TH_ENDDATETIME . "</td>
        <td class='even'>$end_datetime_str</td>
        </tr>";
            $ret .= ($location !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_LOCATION . "</td>
        <td class='even'>$location</td>
    </tr>" : '';
            $ret .= ($contact !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_CONTACT . "</td>
        <td class='even'>$contact</td>
    </tr>" : '';
            $ret .= ($email !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_EMAIL . "</td>
        <td class='even'><a href='mailto:$email'>$email</a></td>
    </tr>" : '';
            $ret .= ($url !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_URL . "</td>
        <td class='even'><a href='$url' target='_blank'>$url</a></td>
    </tr>" : '';
            $ret .= ($description !== '' || $otherHours !== '') ? "

The variable $otherHours does not seem to be defined for all execution paths leading up to this point.

    <tr>
        <td class='head'>" . _APCAL_TH_DESCRIPTION . "</td>
        <td class='even'>$description<br>$otherHours</td>
    </tr>" : '';
            $ret .= ($cat_titles4show !== '') ? "
    <tr>
        <td class='head'>" . _APCAL_TH_CATEGORIES . "</td>
        <td class='even'>$cat_titles4show</td>
    </tr>" : '';
            $ret .= ($this->superedit ? "
    <tr>
        <td class='head'>" . _APCAL_TH_SUBMITTER . "</td>
        <td class='even'>$submitter_info</td>
    </tr>
    <tr>
        <td class='head'>" . _APCAL_TH_CLASS . "</td>
        <td class='even'>$class_status</td>
    </tr>
    <tr>
        <td class='head'>" . _APCAL_TH_RRULE . "</td>
        <td class='even'>$rrule</td>
    </tr>
    <tr>
        <td class='head'>" . _APCAL_TH_ADMISSIONSTATUS . "</td>
        <td class='even'>$admission_status</td>
    </tr>
    " : '') . "
    <tr>
        <td class='head'>" . _APCAL_TH_LASTMODIFIED . "</td>
        <td class='even'>$last_modified</td>
    </tr>" . ($this->enableregistration ? $eventmembertable : '') // goffy
                    . "<tr>
        <td></td>
        <td align='center'>
            <div style='float:left; margin: 2px;'>$edit_button</div>
            <div style='float:left; margin: 2px;'>$delete_button</div>
            <div style='float:left; margin: 2px;'>$ics_output_button</div>
        </td>
    </tr>
    <tr>
        <td><img src='$this->images_url/spacer.gif' alt='' width='150' height='4' /></td>       <td width='100%'></td>
    </tr>
    <tr>
        <td width='100%' align='right' colspan='2'>" . _MD_APCAL_COPYRIGHT . "</td>
    </tr>
    </table>
    \n";

            return $ret;
        }

        // Edit an event form

        /**
         * @return string

Should the return type not be null|string?

         */
        public function get_schedule_edit_html()
        {
            $editable  = $this->editable;
            $superedit = $this->superedit;
            $deletable = $this->deletable;
            $smode     = empty($_GET['smode']) ? 'Monthly' : preg_replace('/[^a-zA-Z0-9_-]/', '', $_GET['smode']);

            if (!empty($_GET['event_id'])) {
                if (!$this->editable) {
                    die('Not allowed');
                }

                $event_id = (int)$_GET['event_id'];
                $yrs      = $GLOBALS['xoopsDB']->query("SELECT * FROM $this->table WHERE id='$event_id'");
                if ($GLOBALS['xoopsDB']->getRowsNum($yrs) < 1) {
                    die(_APCAL_ERR_INVALID_EVENT_ID);
                }
                $event = $GLOBALS['xoopsDB']->fetchObject($yrs);

                // submitter of event
                if ($event->uid != $this->user_id) {
                    $editable  = false;
                    $deletable = false;
                }
                // user is admin or has right to edit/delete all events
                if ($this->isadmin || $superedit) {
                    $editable  = true;
                    $deletable = true;
                }

                $description  = $this->textarea_sanitizer_for_edit($event->description);
                $summary      = $this->text_sanitizer_for_edit($event->summary);
                $location     = $this->text_sanitizer_for_edit($event->location);
                $gmlat        = $event->gmlat != 0 ? $event->gmlat : 0;
                $gmlong       = $event->gmlong != 0 ? $event->gmlong : 0;
                $gmzoom       = $event->gmzoom > 0 ? $event->gmzoom : 0;
                $contact      = $this->text_sanitizer_for_edit($event->contact);
                $email        = $this->text_sanitizer_for_edit($event->email);
                $url          = $this->text_sanitizer_for_edit($event->url);
                $categories   = $event->categories;
                $mainCategory = $event->mainCategory;
                if ($event->class === 'PRIVATE') {
                    $class_private           = 'checked';
                    $class_public            = '';
                    $select_private_disabled = '';
                } else {
                    $class_private           = '';
                    $class_public            = 'checked';
                    $select_private_disabled = "disabled='disabled'";
                }
                $groupid          = $event->groupid;
                $rrule            = $event->rrule;
                $admission_status = $event->admission ? _APCAL_MB_EVENT_ADMITTED : _APCAL_MB_EVENT_NEEDADMIT;
                $update_button    = $editable ? "<input name='update' type='submit' value='" . _APCAL_BTN_SUBMITCHANGES . "' />" : '';
                $insert_button    = "<input name='saveas' type='submit' value='" . _APCAL_BTN_SAVEAS . "' onclick='return confirm(\"" . _APCAL_CNFM_SAVEAS_YN . "\")' />";
                $delete_button    = $deletable ? "<input name='delete' type='submit' value='" . _APCAL_BTN_DELETE . "' onclick='return confirm(\"" . _APCAL_CNFM_DELETE_YN . "\")' />" : '';
                $tz_options       = $this->get_tz_options($event->event_tz);
                $poster_tz        = $event->poster_tz;

                // added by goffy for online registration
                if (!empty($_SERVER['HTTPS'])) {

This code seems to be duplicated across your project.

                    $this->redirecturl = 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                } else {
                    $this->redirecturl = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                }

                $regonline_label = _APCAL_RO_ENABLE_ONLINE;

$regonline_label is not used, you could remove the assignment.

                $regonline_state = ($event->extkey0 == 1) ? _APCAL_RO_ONLINE_YES : _APCAL_RO_ONLINE_NO;

                $regonline_state .= "
        <form class='apcalForm' method='post' id='RegOnlineForm' action='ro_regonlinehandler.php' name='roformactivate1' style='margin:0px;'>
            <input type='hidden' name='eventid' value='$event->id' />
            <input type='hidden' name='uid' value='$this->user_id' />
            <input type='hidden' name='eventurl' value='$this->redirecturl' />
            <input type='hidden' name='title' value='$event->summary' />
            <input type='hidden' name='eventdate' value='$event->start' />
            <input type='hidden' name='location' value='$event->location' />
            <div align='left'>";
                if ($event->extkey0 == 1) {
                    $regonline_state .= "
                <input type='submit' name='form_activate' value='" . _APCAL_RO_BTN_RO_EDIT . "' />
                <input type='submit' name='deactivate_x' value='" . _APCAL_RO_BTN_RO_DEACTIVATE . "' />";
                } else {
                    $regonline_state .= "<input type='submit' name='form_activate' value='" . _APCAL_RO_BTN_RO_ACTIVATE . "' />";
                }
                $regonline_state .= '</div>
        </form>';

                $ro_form_edit = "<table>
            <tr>
                <td class='odd' colspan='2'></td>
            </tr>
            <tr>
                <td class='head'>" . _APCAL_RO_ENABLE_ONLINE . "</td>
                <td class='even'>" . $regonline_state . '</td>
            </tr></table>';
                $ro_form_new  = '';
                // end added by goffy

                //$tmpEnd = date('H:i', $event->end) == '00:00' ? $event->end - 300 : $event->end;
                $diff = date('j', $event->end) - date('j', $event->start);
                if ($event->otherHours !== '' /*&& $event->allday <= 0*/) {
                    $diffhours_checkbox = 'checked';
                    $otherHours         = explode('-', $event->otherHours);
                    foreach ($otherHours as $h) {
                        $h          = explode(':', $h);
                        $startHours .= "<span name='StartSpan'>" . _APCAL_DAY . '&nbsp;' . ($h[0] + 1);

The variable $startHours does not seem to be defined for all execution paths leading up to this point.

                        $startHours .= "<select name='StartH[]'>" . $this->get_options_for_hour($h[1]) . '</select>';
                        $startHours .= "<select name='StartM[]'>" . $this->get_options_for_min($h[2]) . '</select></span>';
                        $endHours   .= "<span name='EndSpan'>" . _APCAL_DAY . '&nbsp;' . ($h[0] + 1);

The variable $endHours does not seem to be defined for all execution paths leading up to this point.

                        $endHours   .= "<select name='EndH[]'>" . $this->get_options_for_hour($h[3]) . '</select>';
                        $endHours   .= "<select name='EndM[]'>" . $this->get_options_for_min($h[4]) . '</select></span>';
                    }
                } elseif ($diff > 0 /*&& $event->allday == 0*/) {
                    //$samehours_checkbox = "checked";
                    for ($i = 0; $i < $diff; ++$i) {
                        $startHours .= '<span>' . _APCAL_DAY . '&nbsp;' . ($i + 2);
                        $startHours .= "<select name='StartH[]' disabled>" . $this->get_options_for_hour(9) . '</select>';
                        $startHours .= "<select name='StartM[]' disabled>" . $this->get_options_for_min(0) . '</select></span>';
                        $endHours   .= '<span>' . _APCAL_DAY . '&nbsp;' . ($i + 2);
                        $endHours   .= "<select name='EndH[]' disabled>" . $this->get_options_for_hour(17) . '</select>';
                        $endHours   .= "<select name='EndM[]' disabled>" . $this->get_options_for_min(0) . '</select></span>';
                    }
                }

                if ($event->allday) {
                    $select_timezone_disabled = "disabled='disabled'";
                    $tzoffset_s2e             = (int)(($event->event_tz - $this->server_TZ) * 3600);
                    $event->start             += $tzoffset_s2e;
                    $event->end               += $tzoffset_s2e;
                    $allday_checkbox          = 'checked';
                    $allday_select            = $event->allday == 5 ? "disabled='disabled'" : '';
                    $allday_bit1              = ($event->allday & 2) ? 'checked' : '';

$allday_bit1 is not used, you could remove the assignment.

                    $allday_bit2              = ($event->allday & 4) ? 'checked' : '';

$allday_bit2 is not used, you could remove the assignment.

                    $allday_bit3              = ($event->allday & 8) ? 'checked' : '';

$allday_bit3 is not used, you could remove the assignment.

                    $allday_bit4              = ($event->allday & 16) ? 'checked' : '';

$allday_bit4 is not used, you could remove the assignment.

                    if (isset($event->start_date)) {
                        $start_ymd = $start_long_ymdn = $event->start_date;
                    } else {
                        $start_ymd       = date('Y-m-d', $event->start);
                        $start_long_ymdn = $this->get_long_ymdn($event->start);
                    }
                    $start_hour = date('H', $event->start);
                    $start_min  = date('i', $event->start);
                    if (isset($event->end_date)) {
                        $end_ymd = $end_long_ymdn = $event->end_date;
                    } else {
                        $end_ymd       = date('Y-m-d', $event->end);
                        $end_long_ymdn = $this->get_long_ymdn($event->end);
                    }
                    $end_hour = date('H', $event->end);
                    $end_min  = date('i', $event->end);
                } else {
                    $select_timezone_disabled = '';
                    $tzoffset_s2e             = (int)(($event->event_tz - $this->server_TZ) * 3600);
                    $event->start             += $tzoffset_s2e;
                    $event->end               += $tzoffset_s2e;
                    $allday_checkbox          = '';
                    if (!isset($samehours_checkbox) && !isset($samehours_checkbox)) {

The variable $samehours_checkbox seems only to be defined at a later point. As such the call to isset() seems to always evaluate to false.

                        $samehours_checkbox = 'checked';
                    }
                    $allday_select   = '';
                    $allday_bit1     = $allday_bit2 = $allday_bit3 = $allday_bit4 = '';

$allday_bit4 is not used, you could remove the assignment.

$allday_bit3 is not used, you could remove the assignment.

$allday_bit2 is not used, you could remove the assignment.

$allday_bit1 is not used, you could remove the assignment.

                    $start_ymd       = date('Y-m-d', $event->start);
                    $start_long_ymdn = $this->get_long_ymdn($event->start);
                    $start_hour      = date('H', $event->start);
                    $start_min       = date('i', $event->start);
                    $end_ymd         = date('Y-m-d', $event->end);
                    $end_long_ymdn   = $this->get_long_ymdn($event->end);
                    $end_hour        = date('H', $event->end);
                    $end_min         = date('i', $event->end);
                }
            } else {
                if (!$this->insertable) {
                    die('Not allowed');
                }

                $event_id = 0;

                $editable                 = true;
                $summary                  = '';
                $select_timezone_disabled = '';
                $location                 = '';
                $gmlat                    = 0;
                $gmlong                   = 0;
                $gmzoom                   = 0;
                $contact                  = '';
                $email                    = '';
                $url                      = '';
                $class_private            = '';
                $class_public             = 'checked';
                $select_private_disabled  = "disabled='disabled'";
                $groupid                  = 0;
                $rrule                    = '';
                $description              = '';
                $categories               = $this->now_cid > 0 ? sprintf('%05d,', $this->now_cid) : '';
                $mainCategory             = $this->now_cid > 0 ? sprintf('%05d,', $this->now_cid) : 0;
                $start_ymd                = $end_ymd = $this->caldate;
                $start_long_ymdn          = $end_long_ymdn = $this->get_long_ymdn($this->unixtime);
                $start_hour               = 9;
                $start_min                = 0;
                $end_hour                 = 17;
                $end_min                  = 0;
                $admission_status         = _APCAL_MB_EVENT_NOTREGISTER;
                $update_button            = '';
                $insert_button            = "<input name='insert' type='submit' value='" . _APCAL_BTN_NEWINSERTED . "' />";
                $delete_button            = '';
                $allday_checkbox          = $allday_select = '';
                $allday_bit1              = $allday_bit2 = $allday_bit3 = $allday_bit4 = '';

$allday_bit4 is not used, you could remove the assignment.

$allday_bit3 is not used, you could remove the assignment.

$allday_bit2 is not used, you could remove the assignment.

$allday_bit1 is not used, you could remove the assignment.

                $tz_options               = $this->get_tz_options($this->user_TZ);
                $poster_tz                = $this->user_TZ;

                // added by goffy for online registration
                $regonline_label = _APCAL_RO_ONLINE2;

$regonline_label is not used, you could remove the assignment.

                $regonline_state = _APCAL_RO_ONLINE_NO;

$regonline_state is not used, you could remove the assignment.

                $ro_form_edit    = '';
                $ro_form_new     = "
            <tr>
                <td class='head'>" . _APCAL_RO_ONLINE2 . "</td>
                <td class='even'>
                    <input type='radio' name='ro_activate' value='yes' > " . _APCAL_RO_ONLINE_ACTIVATE . "<br>
                    <input type='radio' name='ro_activate' value='no' checked> " . _APCAL_RO_ONLINE_DEACTIVATE . '
                </td>
            </tr>';
                // end goffy
            }

            // Start Date
            $textbox_start_date = $this->get_formtextdateselect('StartDate', $start_ymd, $start_long_ymdn);

The call to APCal::get_formtextdateselect() has too many arguments starting with $start_long_ymdn.

            // Start Hour
            $select_start_hour = "<select name='StartHour' $allday_select>\n";
            $select_start_hour .= $this->get_options_for_hour($start_hour);
            $select_start_hour .= '</select>';

            // Start Minutes
            $select_start_min = "<select name='StartMin' $allday_select>\n";
            for ($m = 0; $m < 60; $m += 5) {
                if ($m == $start_min) {
                    $select_start_min .= "<option value='$m' selected>" . sprintf('%02d', $m) . "</option>\n";
                } else {
                    $select_start_min .= "<option value='$m'>" . sprintf('%02d', $m) . "</option>\n";
                }
            }
            $select_start_min .= '</select>';

            // End Date
            $textbox_end_date = $this->get_formtextdateselect('EndDate', $end_ymd, $end_long_ymdn);

The call to APCal::get_formtextdateselect() has too many arguments starting with $end_long_ymdn.

            // End Hour
            $select_end_hour = "<select name='EndHour' $allday_select>\n";
            $select_end_hour .= $this->get_options_for_hour($end_hour);
            $select_end_hour .= '</select>';

            // End Minutes
            $select_end_min = "<select name='EndMin' $allday_select>\n";
            for ($m = 0; $m < 60; $m += 5) {
                if ($m == $end_min) {
                    $select_end_min .= "<option value='$m' selected>" . sprintf('%02d', $m) . "</option>\n";
                } else {
                    $select_end_min .= "<option value='$m'>" . sprintf('%02d', $m) . "</option>\n";
                }
            }
            $select_end_min .= '</select>';

            // Checkbox for selecting Categories
            $category_checkboxes = '';
            foreach ($this->categories as $cid => $cat) {
                $cid4sql        = sprintf('%05d,', $cid);
                $cat_title4show = $this->text_sanitizer_for_show($cat->cat_title);
                if ($cat->cat_depth < 2) {
                    $category_checkboxes .= "<div style='float:left; margin:2px;'>\n";
                }
                $category_checkboxes .= str_repeat('-', $cat->cat_depth - 1)
                                        . "<input type='checkbox' name='cids[]' value='$cid' "
                                        . (strstr($categories, $cid4sql) ? 'checked' : '')
                                        . " />$cat_title4show<br>\n";
            }
            $category_checkboxes = substr(str_replace('<div', '</div><div', $category_checkboxes), 6) . "</div>\n";

            // Select for selecting main category
            $category_select = "<select name='mainCategory'>\n";
            $category_select .= "<option  value='0' " . ($mainCategory == 0 ? 'selected' : '') . ' />' . _APCAL_NONE . "</option>\n";
            foreach ($this->canbemain_cats as $cid => $cat) {
                $cat_title4show  = $this->text_sanitizer_for_show($cat->cat_title);
                $category_select .= "<option  value='$cid' " . ($mainCategory == $cid ? 'selected' : '') . ' />' . str_repeat('&nbsp;&nbsp;', $cat->cat_depth - 1) . " $cat_title4show</option>\n";
            }
            $category_select .= "</select>\n";

            // target for "class = PRIVATE"
            $select_private = "<select name='groupid' $select_private_disabled>\n<option value='0'>" . _APCAL_OPT_PRIVATEMYSELF . "</option>\n";
            foreach ($this->groups as $sys_gid => $gname) {
                $option_desc = sprintf(_APCAL_OPT_PRIVATEGROUP, $gname);
                if ($sys_gid == $groupid) {
                    $select_private .= "<option value='$sys_gid' selected>$option_desc</option>\n";
                } else {
                    $select_private .= "<option value='$sys_gid'>$option_desc</option>\n";
                }
            }
            $select_private .= '</select>';

            if (defined('XOOPS_ROOT_PATH')) {
                require_once XOOPS_ROOT_PATH . '/include/xoopscodes.php';
                ob_start();
                $GLOBALS['description_text'] = $description;
                xoopsCodeTarea('description_text', 50, 6);
                $description_textarea = ob_get_contents();
                ob_end_clean();
            } else {
                $description_textarea = "<textarea name='description' cols='50' rows='6' wrap='soft'>$description</textarea>";
            }

            // MAIN PICTURE
            $picture = $event_id > 0 ? $GLOBALS['xoopsDB']->query("SELECT id, picture FROM {$this->pic_table} WHERE event_id={$event_id} AND main_pic=1 LIMIT 0,1") : false;
            if ($GLOBALS['xoopsDB']->getRowsNum($picture)) {
                $picture = $GLOBALS['xoopsDB']->fetchObject($picture);
                $mainPic = '<div id=mainPicture>
                <a href="' . XOOPS_UPLOAD_URL . '/apcal/' . $picture->picture . '">
                    <img src="' . XOOPS_URL . '/modules/apcal/thumbs/phpThumb.php?src=' . XOOPS_UPLOAD_PATH . '/apcal/' . $picture->picture . '&h=120&w=120" alt="" />
                 </a>
                 <a href="javascript:deletePic(\'' . XOOPS_URL . '\', ' . $picture->id . ', ' . $event_id . ', 1, ' . $this->nbPictures . ');" title="Delete picture">
                     <img src="' . XOOPS_URL . '/modules/apcal/assets/images/delete.png" border="0" alt="Delete picture" />
                 </a>
             </div>';
            } else {
                $mainPic = '<input type="hidden" name="MAX_FILE_SIZE" value="5000000" />
            <input type="file" name="picture0" id="picture0" />
            <input type="hidden" name="files[]" id="files[]" value="picture0">';
            }

            // OTHER PICTURES
            $nbPictures   = $event_id
                            > 0 ? $GLOBALS['xoopsDB']->fetchObject($GLOBALS['xoopsDB']->query("SELECT COUNT(id) AS count FROM {$this->pic_table} WHERE event_id={$event_id} AND main_pic=0"))->count : 0;
            $picturesList = '';
            if ($nbPictures > 0) {
                $pictures = $GLOBALS['xoopsDB']->query("SELECT id, picture FROM {$this->pic_table} WHERE event_id={$event_id} AND main_pic=0 ORDER BY id ASC");
                while ($pic = $GLOBALS['xoopsDB']->fetchObject($pictures)) {
                    $picturesList .= '<span id="pic' . $pic->id . '">
                    <a href="' . XOOPS_UPLOAD_URL . '/apcal/' . $pic->picture . '">
                        <img src="' . XOOPS_URL . '/modules/apcal/thumbs/phpThumb.php?src=' . XOOPS_UPLOAD_PATH . '/apcal/' . $pic->picture . '&h=120&w=120" alt="" />
                     </a>
                     <a href="javascript:deletePic(\'' . XOOPS_URL . '\', ' . $pic->id . ', ' . $event_id . ', 0, ' . $this->nbPictures . ');" title="Delete the picture">
                         <img src="' . XOOPS_URL . '/modules/apcal/assets/images/delete.png" border="0" alt="Delete the picture" />
                     </a>
                 </span>';
                }
            }
            $pictures = '<div id="picList">';
            $maxInput = $this->nbPictures - $nbPictures;
            for ($i = 1; $i < $maxInput; ++$i) {
                $pictures .= '<input type="hidden" name="MAX_FILE_SIZE" value="5000000" />
            <input type="file" name="picture' . $i . '" id="picture' . $i . '" />
            <input type="hidden" name="files[]" id="files[]" value="picture' . $i . '">
            <br>';
            }
            $pictures .= '</div>';

            // FORM DISPLAY
            $caldate = explode('-', $_GET['caldate']);
            $caldate = strlen($caldate[0]) > 2 ? $caldate[0] . '-' . $caldate[1] . '-' . $caldate[2] : $caldate[2] . '-' . $caldate[1] . '-' . $caldate[0];
            $ret     = '
<h2>'
                       . _APCAL_MB_TITLE_EVENTINFO
                       . ' <small>-'
                       . _APCAL_MB_SUBTITLE_EVENTEDIT
                       . "-</small></h2>
<form class='apcalForm' action='{$this->make_cal_link('', $smode, 0, $caldate)}' method='post' id='MainForm' name='MainForm' enctype='multipart/form-data'>
    "
                       . $GLOBALS['xoopsGTicket']->getTicketHtml(__LINE__)
                       . "
    <input type='hidden' name='caldate' value='{$caldate}' />
    <input type='hidden' name='event_id' value='$event_id' />
    <input type='hidden' name='last_smode' value='$smode' />
    <input type='hidden' name='last_caldate' value='$this->caldate' />
    <input type='hidden' name='poster_tz' value='$poster_tz' />
    <input type='hidden' name='gmlatitude' value='$this->gmlat' />
    <input type='hidden' name='gmlongitude' value='$this->gmlng' />
    <input type='hidden' name='gmzoomlevel' value='$this->gmzoom' />
    <table border='0' cellpadding='0' cellspacing='2'>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_SUMMARY
                       . "</td>
        <td class='even'><input type='text' name='summary' size='60' maxlength='250' value='$summary' /></td>
    </tr>"
                       . ($this->displayTimezone ? "<tr>
        <td class='head'>" . _APCAL_TH_TIMEZONE . "</td>
        <td class='even'><select name='event_tz' $select_timezone_disabled>$tz_options</select></td>
    </tr>" : '')
                       . "<tr>
        <td class='head'>"
                       . _APCAL_TH_STARTDATETIME
                       . "</td>
        <td class='even'>
            $textbox_start_date &nbsp;
            {$select_start_hour} {$select_start_min}"
                       . _APCAL_MB_MINUTE_SUF
                       . "</select>
            <span id='start_datetime'>$startHours</span>
        </td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_ENDDATETIME
                       . "</td>
        <td class='even'>
            $textbox_end_date &nbsp;
            {$select_end_hour} {$select_end_min}"
                       . _APCAL_MB_MINUTE_SUF
                       . "
            <span id='end_datetime'>$endHours</span>
        </td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_ALLDAYOPTIONS
                       . "</td>
        <td class='even'>
            <input type='radio' name='allday_bits[]' value='2' {$allday_checkbox} onClick='document.MainForm.StartHour.disabled=document.MainForm.StartMin.disabled=document.MainForm.EndHour.disabled=document.MainForm.EndMin.disabled=true;enableSelects(true);' />"
                       . _APCAL_MB_ALLDAY_EVENT
                       . " &nbsp;
            <input type='radio' name='allday_bits[]' value='0' {$samehours_checkbox} onClick='document.MainForm.StartHour.disabled=document.MainForm.StartMin.disabled=document.MainForm.EndHour.disabled=document.MainForm.EndMin.disabled=false;enableSelects(true);' />"

The variable $samehours_checkbox does not seem to be defined for all execution paths leading up to this point.

                       . _APCAL_SAMEHOURS
                       . "  
            <input type='radio' name='allday_bits[]' value='8' {$diffhours_checkbox} onClick='document.MainForm.StartHour.disabled=document.MainForm.StartMin.disabled=document.MainForm.EndHour.disabled=document.MainForm.EndMin.disabled=false;enableSelects(false);' />"

The variable $diffhours_checkbox does not seem to be defined for all execution paths leading up to this point.

                       . _APCAL_DIFFERENTHOURS
                       . "
        </td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_LOCATION
                       . "</td>
        <td class='even'><input type='text' id='location' name='location' size='40' maxlength='250' value='$location' /></td>
    </tr>
        <tr>
        <td class='head'></td>
        <td class='even' valign='top'>
                    <a href='' onclick=\"window.open('"
                       . XOOPS_URL
                       . "/modules/apcal/getCoords.php', '_blank', 'height=450,width=550,modal=yes,alwaysRaised=yes');return false;\">
                        <img src='"
                       . XOOPS_URL
                       . "/modules/apcal/assets/images/gmap.png' />"
                       . _APCAL_TH_GETCOORDS
                       . "</a>
                </td>
    </tr>
        <tr>
        <td class='head'>"
                       . _APCAL_TH_LATITUDE
                       . "</td>
        <td class='even'><input type='text' name='gmlat' size='40' maxlength='250' value='$gmlat' /></td>
    </tr>
        <tr>
        <td class='head'>"
                       . _APCAL_TH_LONGITUDE
                       . "</td>
        <td class='even'><input type='text' name='gmlong' size='40' maxlength='250' value='$gmlong' /></td>
    </tr>
        <tr>
        <td class='head'>"
                       . _APCAL_TH_ZOOM
                       . "</td>
        <td class='even'><input type='text' name='gmzoom' size='40' maxlength='250' value='$gmzoom' /></td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_CONTACT
                       . "</td>
        <td class='even'><input type='text' name='contact' size='50' maxlength='250' value='$contact' /></td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_EMAIL
                       . "</td>
        <td class='even'><input type='text' name='email' size='50' maxlength='250' value='$email' /></td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_URL
                       . "</td>
        <td class='even'><input type='text' name='url' size='50' maxlength='250' value='$url' /></td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_DESCRIPTION
                       . "</td>
        <td class='even'>$description_textarea</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_MAINPICTURE
                       . "</td>
        <td class='even'>$mainPic</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_PICTURES
                       . "</td>
        <td class='even'>$pictures<br>$picturesList</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_MAINCATEGORY
                       . "</td>
        <td class='even'>$category_select</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_CATEGORIES
                       . "</td>
        <td class='even'>$category_checkboxes</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_CLASS
                       . "</td>
        <td class='even'><input type='radio' name='class' value='PUBLIC' $class_public onClick='document.MainForm.groupid.disabled=true' />"
                       . _APCAL_MB_PUBLIC
                       . " &nbsp;  &nbsp; <input type='radio' name='class' value='PRIVATE' $class_private onClick='document.MainForm.groupid.disabled=false' />"
                       . _APCAL_MB_PRIVATE
                       . sprintf(_APCAL_MB_PRIVATETARGET, $select_private)
                       . "</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_RRULE
                       . "</td>
        <td class='even'>"
                       . $this->rrule_to_form($rrule, $end_ymd)
                       . "</td>
    </tr>
    <tr>
        <td class='head'>"
                       . _APCAL_TH_ADMISSIONSTATUS
                       . "</td>
        <td class='even'>$admission_status</td>
    </tr>\n";

            if ($this->enableregistration) {
                $ret .= $ro_form_new;
            } //added one line by goffy

            if ($editable) {
                $ret .= "
    <tr>
        <td style='text-align:center' colspan='2'>
            <input name='reset' type='reset' value='" . _APCAL_BTN_RESET . "' />
            $update_button
            $insert_button
            $delete_button
        </td>
    </tr>\n";
            }

            $ret .= "
    <tr>
        <td><img src='$this->images_url/spacer.gif' alt='' width='150' height='4' /></td>       <td width='100%'></td>
    </tr>
    </table>
</form>
\n";

            if ($this->enableregistration) {
                $ret .= $ro_form_edit;
            } // splitted and added one line by goffy
            $ret .= "<table>
        <tr><td><img src='$this->images_url/spacer.gif' alt='' height='4' /></td></tr>
        <tr><td width='100%' align='right'>" . _MD_APCAL_COPYRIGHT . '</td></tr>
    </table>';

            $ret .= "
<script type='text/javascript'>
    function addHours()
    {
        var startDate = document.MainForm.StartDate.value.split('-');
        var endDate = document.MainForm.EndDate.value.split('-');
        startDate = new Date(startDate[0], startDate[1]-1, startDate[2]).getTime();
        endDate = new Date(endDate[0], endDate[1]-1, endDate[2]).getTime();
        var diff = (endDate - startDate) / 3600000 / 24;
        var diffBefore = document.getElementsByName('StartH[]').length;
        var start = document.getElementById('start_datetime');
        var end = document.getElementById('end_datetime');
        var maxDays = 30;

        if (diffBefore < diff) {
            for (var i=diffBefore; i<diff&&i<=maxDays; i++) {
                var startNode = document.createElement('span');
                var endNode = document.createElement('span');

                startNode.innerHTML += \"" . _APCAL_DAY . "&nbsp;\"+(i+2);
                startNode.innerHTML += \"<select name='StartH[]' disabled>" . str_replace("\n", '', $this->get_options_for_hour($start_hour)) . "</select>\";
                startNode.innerHTML += \"<select name='StartM[]' disabled>" . str_replace("\n", '', $this->get_options_for_min($start_min)) . '</select>";
                endNode.innerHTML += "' . _APCAL_DAY . "&nbsp;\"+(i+2);
                endNode.innerHTML += \"<select name='EndH[]' disabled>" . str_replace("\n", '', $this->get_options_for_hour($end_hour)) . "</select>\";
                endNode.innerHTML += \"<select name='EndM[]' disabled>" . str_replace("\n", '', $this->get_options_for_min($end_min)) . "</select>\";

                start.appendChild(startNode);
                end.appendChild(endNode);
            }
        } elseif (diff >= 0 && diff<=maxDays) {
            var StartSpan = document.getElementById('start_datetime').getElementsByTagName('span');
            var EndSpan = document.getElementById('end_datetime').getElementsByTagName('span');
            for (var i=diffBefore-1; i>=diff; i--) {
                StartSpan[i].outerHTML = '';
                EndSpan[i].outerHTML = '';
            }
        }
        enableSelects(!document.getElementsByName('allday_bits[]')[2].checked);
    }

    function enableSelects(disabled)
    {
        var StartH = document.getElementsByName('StartH[]');
        var StartM = document.getElementsByName('StartM[]');
        var EndH = document.getElementsByName('EndH[]');
        var EndM = document.getElementsByName('EndM[]');
        var nbItems = StartH.length;

        for (var i=0; i<nbItems; i++) {
            StartH[i].disabled = disabled;
            StartM[i].disabled = disabled;
            EndH[i].disabled = disabled;
            EndM[i].disabled = disabled;
        }
    }

    function checkChange()
    {
        var newStart = document.MainForm.StartDate.value;
        var newEnd = document.MainForm.EndDate.value;
        if (oldStart != newStart || oldEnd != newEnd) {addHours();}
        oldStart = newStart;
        oldEnd = newEnd;
    }
    var oldStart = document.MainForm.StartDate.value;
    var oldEnd = document.MainForm.EndDate.value;
    setInterval(checkChange, 750);
</script>\n
";

            return $ret;
        }

        // Save an event

        /**
         * @param string $set_sql_append
         * @param string $whr_sql_append
         * @param null   $notify_callback
         */
        public function update_schedule($set_sql_append = '', $whr_sql_append = '', $notify_callback = null)
        {
            if ($_POST['summary'] === '') {
                $_POST['summary'] = _APCAL_MB_NOSUBJECT;
            }

            list($start, $start_date, $use_default) = $this->parse_posted_date($this->mb_convert_kana($_POST['StartDate'], 'a'), $this->unixtime);

The assignment to $use_default is unused. Consider omitting it like so list($first,,$third).

            list($end, $end_date, $use_default) = $this->parse_posted_date($this->mb_convert_kana($_POST['EndDate'], 'a'), $this->unixtime);

The assignment to $use_default is unused. Consider omitting it like so list($first,,$third).

            $allday = 1;
            if (isset($_POST['allday_bits'])) {
                $bits = $_POST['allday_bits'];
                if (is_array($bits)) {
                    foreach ($bits as $bit) {
                        if ($bit > 0 && $bit < 8) {
                            $allday += pow(2, (int)$bit);
                        }
                    }
                }
            }

            $tzoffset_e2s = (int)(($this->server_TZ - $_POST['event_tz']) * 3600);
            if ($start_date || $end_date) {
                if ($start_date) {
                    $date_append = ", start_date='$start_date'";
                } else {
                    $date_append = ', start_date=null';
                }
                if ($end_date) {
                    $date_append .= ", end_date='$end_date'";
                } else {
                    $date_append .= ', end_date=null';
                    $end         += 86400;
                }
                $set_sql_date = "start='$start', end='$end', allday='$allday' $date_append";
                $allday_flag  = true;
            } elseif ($_POST['allday_bits'][0] > 0) {
                $start += $_POST['StartHour'] * 3600 + $_POST['StartMin'] * 60 + $tzoffset_e2s;
                $end   += $_POST['EndHour'] * 3600 + $_POST['EndMin'] * 60 + $tzoffset_e2s;
                if ($start > $end) {
                    list($start, $end) = array($end, $start);
                } elseif ($start == $end) {
                    $start += 60;
                    $end   += (23 * 3600) + (59 * 60);
                }
                //$end += 86400 ;
                $set_sql_date = "start='$start', end='$end', allday='$allday', start_date=null, end_date=null";
                $allday_flag  = true;
            } else {
                if (!isset($_POST['event_tz'])) {
                    $_POST['event_tz'] = $this->user_TZ;
                }
                $tzoffset_e2s = (int)(($this->server_TZ - $_POST['event_tz']) * 3600);
                //$tzoffset_e2s = (int)( date( 'Z' , $start ) - $_POST['event_tz'] * 3600 ) ;

                $start += $_POST['StartHour'] * 3600 + $_POST['StartMin'] * 60 + $tzoffset_e2s;
                $end   += $_POST['EndHour'] * 3600 + $_POST['EndMin'] * 60 + $tzoffset_e2s;
                if ($start > $end) {
                    list($start, $end) = array($end, $start);
                }
                $set_sql_date = "start='$start', end='$end', allday=0, start_date=null, end_date=null";
                $allday_flag  = false;
            }

            $otherHours = '';
            if (isset($_POST['allday_bits'][0]) && $_POST['allday_bits'][0] == '8') {
                $otherHours = array();
                foreach ($_POST['StartH'] as $i => $startH) {
                    $otherHours[] = ($i + 1) . ':' . $startH . ':' . $_POST['StartM'][$i] . ':' . $_POST['EndH'][$i] . ':' . $_POST['EndM'][$i];
                }
                $otherHours = implode('-', $otherHours);
            }

            $set_sql_date .= ",server_tz='$this->server_TZ'";

            if (!isset($_POST['description']) && isset($_POST['description_text'])) {
                $_POST['description'] = $_POST['description_text'];
            }

            $_POST['categories'] = '';
            $cids                = is_array(@$_POST['cids']) ? $_POST['cids'] : array();
            if (!in_array($_POST['mainCategory'], $cids)) {
                $cids[] = $_POST['mainCategory'];
            }
            foreach ($cids as $cid) {
                $cid = (int)$cid;
                while (isset($this->categories[$cid])) {
                    $cid4sql = sprintf('%05d,', $cid);
                    if (stristr($_POST['categories'], $cid4sql) === false) {
                        $_POST['categories'] .= sprintf('%05d,', $cid);
                    }
                    $cid = (int)$this->categories[$cid]->pid;
                }
            }

            // RRULE
            $rrule = $this->rrule_from_post($start, $allday_flag);

            $cols = array(
                'summary'     => '255:J:1',
                'location'    => '255:J:0',
                'contact'     => '255:J:0',
                'email'       => '255:J:0',
                'url'         => '255:J:0',
                'description' => 'A:J:0',
                'categories'  => '255:E:0',
                'class'       => '255:E:0',
                'groupid'     => 'I:N:0',
                'poster_tz'   => 'F:N:0',
                'event_tz'    => 'F:N:0'
            );

            $set_str = $this->get_sql_set($cols) . ", $set_sql_date $set_sql_append";
            $set_str .= ",shortsummary='" . $this->makeShort(utf8_decode($_POST['summary'])) . "'";
            $set_str .= ",mainCategory='" . $_POST['mainCategory'] . "'";
            $set_str .= ",otherHours='" . $otherHours . "'";

            // Check update or insert
            $event_id = (int)$_POST['event_id'];
            if ($event_id > 0) {
                $rs = $GLOBALS['xoopsDB']->query("SELECT rrule_pid FROM $this->table WHERE id='$event_id' $whr_sql_append");
                if (!($event = $GLOBALS['xoopsDB']->fetchObject($rs))) {
                    die('Record Not Exists.');
                }
                if ($event->rrule_pid > 0) {

This code seems to be duplicated across your project.

                    if (!$GLOBALS['xoopsDB']->query("DELETE FROM $this->table WHERE rrule_pid='$event->rrule_pid' AND id<>'$event_id'")) {
                        echo $GLOBALS['xoopsDB']->error();
                    }
                }

                // UPDATE
                if ($rrule !== '') {
                    $set_str .= ', rrule_pid=id';
                }
                $sql = "UPDATE $this->table SET $set_str , rrule='$rrule' , sequence=sequence+1, gmlat='{$_POST['gmlat']}', gmlong='{$_POST['gmlong']}', gmzoom='{$_POST['gmzoom']}' WHERE id='$event_id' $whr_sql_append";
                if (!$GLOBALS['xoopsDB']->query($sql)) {
                    echo $GLOBALS['xoopsDB']->error();
                }

                // RRULE
                if ($rrule !== '') {
                    $this->rrule_extract($event_id);
                }

                // ���٤Ƥ򹹿��塢���������դΥ����������?��
                $last_smode = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_smode']);

$last_smode is not used, you could remove the assignment.

                //$last_caldate = preg_replace( '/[^a-zA-Z0-9_-]/' , '' , @$_POST['last_caldate'] ) ;
                $new_caldate = $start_date ?: date('Y-n-j', $start);

$new_caldate is not used, you could remove the assignment.

                //$this->redirect( "smode=$last_smode&caldate=$new_caldate" ) ;
                if (isset($_POST['saveas'])) {

This code seems to be duplicated across your project.

                    $result = $GLOBALS['xoopsDB']->query("SELECT * FROM {$this->pic_table} WHERE event_id={$_POST['event_oldid']}");
                    while ($pic = $GLOBALS['xoopsDB']->fetchObject($result)) {
                        $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table}(event_id, picture, main_pic) VALUES ({$event_id}, '{$pic->picture}', {$pic->main_pic})");
                    }
                    $this->savepictures($event_id);
                } else {
                    $this->savepictures($event_id);
                }
            } else {
                $sql = "INSERT INTO $this->table SET $set_str , rrule='$rrule' , sequence=0, gmlat='{$_POST['gmlat']}', gmlong='{$_POST['gmlong']}', gmzoom='{$_POST['gmzoom']}'";
                if (!$GLOBALS['xoopsDB']->query($sql)) {
                    echo $GLOBALS['xoopsDB']->error();
                }
                // unique_id,rrule_pid
                $event_id  = $GLOBALS['xoopsDB']->getInsertId($this->conn);
                $unique_id = 'apcal060-' . md5("{$_SERVER['HTTP_HOST']}{$_SERVER['PHP_SELF']}$event_id");
                $rrule_pid = $rrule ? $event_id : 0;
                $GLOBALS['xoopsDB']->query("UPDATE $this->table SET unique_id='$unique_id',rrule_pid='$rrule_pid' WHERE id='$event_id'");

                // RRULE
                if ($rrule !== '') {
                    $this->rrule_extract($event_id);
                }

                if (isset($notify_callback)) {
                    $this->$notify_callback($event_id);
                }

                $last_smode   = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_smode']);
                $last_caldate = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_caldate']);
                //$this->redirect( "smode=$last_smode&caldate=$last_caldate" ) ;

                // Save pictures
                if (isset($_POST['saveas'])) {

This code seems to be duplicated across your project.

                    $result = $GLOBALS['xoopsDB']->query("SELECT * FROM {$this->pic_table} WHERE event_id={$_POST['event_oldid']}");
                    while ($pic = $GLOBALS['xoopsDB']->fetchObject($result)) {
                        $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table}(event_id, picture, main_pic) VALUES ({$event_id}, '{$pic->picture}', {$pic->main_pic})");
                    }
                    $this->savepictures($event_id);
                } else {
                    $this->savepictures($event_id);
                }

                // added by goffy for registration online automatically redirect to form for set up parameters for online registration, if online registration is selected
                $ro_redirect = $_POST['ro_activate'];
                if ($ro_redirect === 'yes') {
                    if (!empty($_SERVER['HTTPS'])) {

This code seems to be duplicated across your project.

                        $this->redirecturl = 'https://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                    } else {
                        $this->redirecturl = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
                    }

                    $call_ro = 'ro_regonlinehandler.php?op=show_form_activate';
                    $call_ro .= "&uid=$uid";

The variable $uid does not exist. Did you forget to declare it?

                    $call_ro .= "&eventid=$event_id";
                    $call_ro .= '&title=' . $_POST['summary'];
                    $call_ro .= "&eventdate=$start";//.$_POST[ 'StartDate' ]." ".$_POST[ 'StartHour' ].":".$_POST[ 'StartMin' ];
                    $call_ro .= '&eventurl=' . $this->redirecturl;
                    $call_ro .= "&smode=$last_smode";
                    $call_ro .= "&caldate=$last_caldate";
                    redirect_header($call_ro, 3, _APCAL_RO_SUCCESS_NEW_EVENT . '<br>' . _APCAL_RO_REDIRECT);
                } else {
                    redirect_header($this->redirecturl . "?smode=$last_smode&caldate=$last_caldate", 3, _APCAL_RO_SUCCESS_NEW_EVENT);
                }
                // end goffy
            }
        }

        // Delete an event

        /**
         * @param string $whr_sql_append
         * @param null   $eval_after
         */
        public function delete_schedule($whr_sql_append = '', $eval_after = null)
        {
            if (!empty($_POST['event_id'])) {
                $event_id = (int)$_POST['event_id'];

                $this->delete_regonline($event_id); // added one line by goffy
                $rs = $GLOBALS['xoopsDB']->query("SELECT rrule_pid FROM $this->table WHERE id='$event_id' $whr_sql_append");
                if (!($event = $GLOBALS['xoopsDB']->fetchObject($rs))) {
                    die('Record Not Exists.');
                }
                if ($event->rrule_pid > 0) {
                    if (!$GLOBALS['xoopsDB']->query("DELETE FROM $this->table WHERE rrule_pid='$event->rrule_pid' $whr_sql_append")) {

This code seems to be duplicated across your project.

                        echo $GLOBALS['xoopsDB']->error();
                    }
                    // ����������ɲý����eval�Ǽ����� (XOOPS�Ǥϡ������Ȥκ���
                    if ($GLOBALS['xoopsDB']->getAffectedRows() > 0 && isset($eval_after)) {
                        $id = $event->rrule_pid;

$id is not used, you could remove the assignment.

                        eval($eval_after);
                    }
                } else {
                    if (!$GLOBALS['xoopsDB']->query("DELETE FROM $this->table WHERE id='$event_id' $whr_sql_append")) {

This code seems to be duplicated across your project.

                        echo $GLOBALS['xoopsDB']->error();
                    }
                    // ����������ɲý����eval�Ǽ����� (XOOPS�Ǥϡ������Ȥκ���
                    if ($GLOBALS['xoopsDB']->getAffectedRows() == 1 && isset($eval_after)) {
                        $id = $event_id;

$id is not used, you could remove the assignment.

                        eval($eval_after);
                    }
                }
            }
            $last_smode   = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_smode']);
            $last_caldate = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_caldate']);
            $this->redirect("smode=$last_smode&caldate=$last_caldate");
        }

        // �������塼��ΰ�����RRULE�λҶ��쥳���ɡ�

        /**
         * @param string $whr_sql_append
         */
        public function delete_schedule_one($whr_sql_append = '')
        {
            if (!empty($_POST['subevent_id'])) {
                $event_id = (int)$_POST['subevent_id'];
                $this->delete_regonline($event_id); // added one line by goffy

                if (!$GLOBALS['xoopsDB']->query("DELETE FROM $this->table WHERE id='$event_id' AND rrule_pid <> id $whr_sql_append")) {

This code seems to be duplicated across your project.

                    echo $GLOBALS['xoopsDB']->error();
                }
            }
            $last_smode   = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_smode']);
            $last_caldate = preg_replace('/[^a-zA-Z0-9_-]/', '', @$_POST['last_caldate']);
            $this->redirect("smode=$last_smode&caldate=$last_caldate");
        }

        //added function by goffy

        /**
         * @param $event_id
         */
        public function delete_regonline($event_id)
        {
            //delete data from table apcal_ro_members
            $sql = 'DELETE '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_members
                   . '.* FROM '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_members
                   . ' WHERE (('
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_members
                   . ".rom_eventid)=$event_id)";
            $res = $GLOBALS['xoopsDB']->query($sql);

$res is not used, you could remove the assignment.

            //delete data from table apcal_ro_notify
            $sql = 'DELETE '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_notify
                   . '.* FROM '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_notify
                   . ' WHERE (('
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_notify
                   . ".ron_eventid)=$event_id)";
            $res = $GLOBALS['xoopsDB']->query($sql);

$res is not used, you could remove the assignment.

            //delete data from table apcal_ro_events
            $sql = 'DELETE '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_events
                   . '.* FROM '
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_events
                   . ' WHERE (('
                   . XOOPS_DB_PREFIX
                   . $this->table_ro_events
                   . ".roe_eventid)=$event_id)";
            $res = $GLOBALS['xoopsDB']->query($sql);

$res is not used, you could remove the assignment.

        }

        /**
         * @param $query
         */
        public function redirect($query)
        {
            // character white list and black list against 'javascript'
            if (!preg_match('/^[a-z0-9=&_-]*$/i', $query) || stristr($query, 'javascript')) {
                header(strtr("Location: $this->connection://{$_SERVER['HTTP_HOST']}{$_SERVER['PHP_SELF']}", "\r\n\0", '   '));
                exit;
            }

            if (headers_sent()) {
                echo "
            <html>
            <head>
            <title>redirection</title>
            <meta http-equiv='Refresh' content='0; url=?$query' />
            </head>
            <body>
            <p>
                <a href='?$query'>push here if not redirected</a>
            </p>
            </body>
            </html>";
            } else {
                header(strtr("Location: $this->connection://{$_SERVER['HTTP_HOST']}{$_SERVER['PHP_SELF']}?$query", "\r\n\0", '   '));
            }
            exit;
        }

        // -12.0��12.0�ޤǤ��ͤ�����ơ�(GMT+HH:MM) �Ȥ���ʸ������֤�

        /**
         * @param $offset
         * @return string
         */
        public function get_tz_for_display($offset)
        {
            return $this->displayTimezone ? '(GMT' . ($offset >= 0 ? '+' : '-') . sprintf('%02d:%02d', abs($offset), abs($offset) * 60 % 60) . ')' : '';
        }

        // -12.0��12.0�ޤǤ�Timzone SELECT�ܥå�����Optionʸ������֤�

        /**
         * @param  int $selected
         * @return string
         */
        public function get_tz_options($selected = 0)
        {
            $tzs = array(
                '-12',
                '-11',
                '-10',
                '-9',
                '-8',
                '-7',
                '-6',
                '-5',
                '-4',
                '-3.5',
                '-3',
                '-2',
                '-1',
                '0',
                '1',
                '2',
                '3',
                '3.5',
                '4',
                '4.5',
                '5',
                '5.5',
                '6',
                '7',
                '8',
                '9',
                '9.5',
                '10',
                '11',
                '12'
            );

            $ret = '';
            foreach ($tzs as $tz) {
                if ($tz == $selected) {
                    $ret .= "\t<option value='$tz' selected>" . $this->get_tz_for_display($tz) . "</option>\n";
                } else {
                    $ret .= "\t<option value='$tz'>" . $this->get_tz_for_display($tz) . "</option>\n";
                }
            }

            return $ret;
        }

        // -12.0��12.0�ޤǤ��ͤ�����ơ�array(TZOFFSET,TZID)���֤�

        /**
         * @param $tz
         * @return array
         */
        public function get_timezone_desc($tz)
        {
            if ($tz == 0) {
                $tzoffset = '+0000';
                $tzid     = 'GMT';
            } elseif ($tz > 0) {
                $tzoffset = sprintf('+%02d%02d', $tz, $tz * 60 % 60);
                $tzid     = 'Etc/GMT-' . sprintf('%d', $tz);
            } else {
                $tz       = abs($tz);
                $tzoffset = sprintf('-%02d%02d', $tz, $tz * 60 % 60);
                $tzid     = 'Etc/GMT+' . sprintf('%d', $tz);
            }

            return array($tzoffset, $tzid);
        }

        // ���ƥ��꡼����ʸ��ܥå�����ե����ऴ�Ⱥ�������

        /**
         * @param  string $get_target
         * @param  null   $smode
         * @return string
         */
        public function get_categories_selform($get_target = '', $smode = null)
        {
            global $xoopsModule;

            if (empty($this->categories)) {
                return '';
            }

            if (empty($smode)) {
                $smode = isset($_GET['smode']) ? $_GET['smode'] : 'Monthly';
            }
            $smode = preg_replace('/[^a-zA-Z0-9_-]/', '', $smode);

            $op = empty($_GET['op']) ? '' : preg_replace('/[^a-zA-Z0-9_-]/', '', $_GET['op']);

            $ret = "<script type='text/javascript'>\n";
            $ret .= "function submitCat(cid, smode, caldate)\n";
            $ret .= "{\n";
            if ($this->useurlrewrite) {
                $ret .= "var defaultView = '" . $this->default_view . "';\n";
                $ret .= "var today = '" . date('Y-n-j') . "';\n";

                $ret .= "if (cid != 'All' && smode != defaultView && caldate != today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + cid + '-' + smode + '-' + caldate;}\n";
                $ret .= "else if (cid != 'All' && smode != defaultView && caldate == today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + cid + '-' + smode;}\n";
                $ret .= "else if (cid != 'All' && smode == defaultView && caldate != today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + cid + '-' + caldate;}\n";
                $ret .= "else if (cid == 'All' && smode != defaultView && caldate != today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + smode + '-' + caldate;}\n";
                $ret .= "else if (cid == 'All' && smode != defaultView && caldate == today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + smode;}\n";
                $ret .= "else if (cid == 'All' && smode == defaultView && caldate != today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + caldate;}\n";
                $ret .= "else if (cid != 'All' && smode == defaultView && caldate == today) {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/' + cid;}\n";
                $ret .= "else {document.catSel.action = '" . XOOPS_URL . "/modules/apcal/';}\n";

                //$ret .= "document.catSel.action = '".XOOPS_URL."/' + cid + '/' + smode + '/' + caldate;\n";
                $ret .= "document.catSel.method = 'POST';\n";
            }
            $ret .= "document.catSel.submit();\n";
            $ret .= "}\n";
            $ret .= "</script>\n";
            $ret .= "<form class='apcalForm' action='$get_target' name='catSel' method='GET' style='margin:0px;'>\n";
            $ret .= "<input type='hidden' name='caldate' value='$this->caldate' />\n";
            $ret .= "<input type='hidden' name='smode' value='$smode' />\n";
            $ret .= "<input type='hidden' name='op' value='$op' />\n";
            $ret .= "<select name='cid' onchange='submitCat(document.catSel.cid.value, document.catSel.smode.value, document.catSel.caldate.value);'>\n";
            $ret .= $this->useurlrewrite ? "\t<option value='All'>" . _APCAL_MB_SHOWALLCAT . "</option>\n" : "\t<option value='0'>" . _APCAL_MB_SHOWALLCAT . "</option>\n";
            foreach ($this->categories as $cid => $cat) {
                $selected       = $this->now_cid == $cid ? 'selected' : '';
                $depth_desc     = str_repeat('-', (int)$cat->cat_depth);
                $cat_title4show = $this->text_sanitizer_for_show($cat->cat_title);
                $ret            .= $this->useurlrewrite ? "\t<option value='"
                                                          . urlencode(urlencode($cat->cat_shorttitle))
                                                          . "' $selected>$depth_desc $cat_title4show</option>\n" : "\t<option value='$cid' $selected>$depth_desc $cat_title4show</option>\n";
            }
            $ret .= "</select>\n</form>\n";

            return $ret;
        }

        // ǯ����Υƥ����ȥܥå������Ϥ�����ơ�UnixTimestamp���֤�

        /**
         * @param $date_desc
         * @param $default_unixtime
         * @return array
         */
        public function parse_posted_date($date_desc, $default_unixtime)
        {
            if (!preg_match('#^([0-9][0-9]+)[-./]?([0-1]?[0-9])[-./]?([0-3]?[0-9])$#', $date_desc, $regs)) {
                $unixtime    = $default_unixtime;
                $use_default = true;
                $iso_date    = '';
            } elseif ($regs[1] >= 2038) {
                // 2038ǯ�ʹߤξ�� 2038/1/1 �˥��å�
                $unixtime    = mktime(0, 0, 0, 1, 1, 2038);
                $use_default = false;
                $iso_date    = "{$regs[1]}-{$regs[2]}-{$regs[3]}";
            } elseif ($regs[1] <= 1970) {
                // 1970ǯ�����ξ�� 1970/12/31�˥��å�
                $unixtime    = mktime(0, 0, 0, 12, 31, 1970);
                $use_default = false;
                $iso_date    = "{$regs[1]}-{$regs[2]}-{$regs[3]}";
            } elseif (!checkdate($regs[2], $regs[3], $regs[1])) {
                $unixtime    = $default_unixtime;
                $use_default = true;
                $iso_date    = '';
            } else {
                $unixtime    = mktime(0, 0, 0, $regs[2], $regs[3], $regs[1]);
                $use_default = false;
                $iso_date    = '';
            }

            return array($unixtime, $iso_date, $use_default);
        }

        // timezone���������ơ�RFC2445��VTIMEZONE��ʸ������֤�

        /**
         * @param $timezones
         * @return string
         */
        public function get_vtimezones_str($timezones)
        {
            if (empty($timezones)) {
                return "BEGIN:VTIMEZONE\r
TZID:GMT\r
BEGIN:STANDARD\r
DTSTART:19390101T000000\r
TZOFFSETFROM:+0000\r
TZOFFSETTO:+0000\r
TZNAME:GMT\r
END:STANDARD\r
END:VTIMEZONE\r\n";
            } else {
                $ret = '';
                foreach ($timezones as $tz => $dummy) {
                    list($for_tzoffset, $for_tzid) = $this->get_timezone_desc($tz);

                    $ret .= "BEGIN:VTIMEZONE\r
TZID:$for_tzid\r
BEGIN:STANDARD\r
DTSTART:19390101T000000\r
TZOFFSETFROM:$for_tzoffset\r
TZOFFSETTO:$for_tzoffset\r
TZNAME:$for_tzid\r
END:STANDARD\r
END:VTIMEZONE\r\n";
                }

                return $ret;
            }
        }

        // Ϣ����������˼�ꡢ$_POST����INSERT,UPDATE�Ѥ�SETʸ���������륯�饹�ؿ�

        /**
         * @param $cols
         * @return string

Should the return type not be null|string?

         */
        public function get_sql_set($cols)
        {
            $ret = '';

            foreach ($cols as $col => $types) {
                list($field, $lang, $essential) = explode(':', $types);

                // ̤����ʤ�''�ȸ��ʤ�
                if (!isset($_POST[$col])) {
                    $data = '';
                } elseif (get_magic_quotes_gpc()) {
                    $data = stripslashes($_POST[$col]);
                } else {
                    $data = $_POST[$col];
                }

                // ɬ�ܥե�����ɤΥ����å�
                if ($essential && $data === '') {
                    die(sprintf(_APCAL_ERR_LACKINDISPITEM, $col));
                }

                // ���졦����ʤɤ��̤ˤ�����
                switch ($lang) {

This code seems to be duplicated across your project.

                    case 'N':    // ���� (����� , ����)
                        $data = (int)str_replace(',', '', $data);
                        break;
                    case 'J':    // ���ܸ�ƥ����� (Ⱦ�ѥ��ʢ����Ѥ���)
                        $data = $this->mb_convert_kana($data, 'KV');
                        break;
                    case 'E':    // Ⱦ�ѱѿ���Τ�
                        $data = $this->mb_convert_kana($data, 'as');
                        break;
                }

                // �ե�����ɤη��ˤ�����
                switch ($field) {
                    case 'A':    // textarea
                        $ret .= "$col='" . addslashes($data) . "',";
                        break;
                    case 'I':    // integer
                        $data = (int)$data;
                        $ret  .= "$col='$data',";
                        break;
                    case 'F':    // float
                        $data = (float)$data;
                        $ret  .= "$col='$data',";
                        break;
                    default:    // varchar(�ǥե����)�Ͽ��ͤˤ��ʸ�������
                        if ($field < 1) {
                            $field = 255;
                        }
                        $data = mb_strcut($data, 0, $field);
                        $ret  .= "$col='" . addslashes($data) . "',";
                }
            }

            // �Ǹ�� , ����
            $ret = substr($ret, 0, -1);

            return $ret;
        }

        // unixtimestamp���顢���ߤθ����ɽ�����줿Ĺ��ɽ���� YMDN ������

        /**
         * @param $time
         * @return string
         */
        public function get_long_ymdn($time)
        {
            return sprintf(_APCAL_FMT_YMDN, // format
                           date('Y', $time), // Y
                           $this->month_long_names[date('n', $time)], // M
                           $this->date_long_names[date('j', $time)], // D
                           $this->week_long_names[date('w', $time)] // N
            );
        }

        // unixtimestamp���顢���ߤθ����ɽ�����줿ɸ��Ĺɽ���� MD ������

        /**
         * @param $time
         * @return string
         */
        public function get_middle_md($time)
        {
            return sprintf(_APCAL_FMT_MD, // format
                           $this->month_middle_names[date('n', $time)], // M
                           $this->date_short_names[date('j', $time)] // D
            );
        }

        // unixtimestamp���顢���ߤθ����ɽ�����줿 DHI ������

        /**
         * @param         $time
         * @param  bool   $is_over24
         * @return string
         */
        public function get_middle_dhi($time, $is_over24 = false)

This method seems to be duplicated in your project.

        {
            $hour_offset = $is_over24 ? 24 : 0;

            $hour4disp = $this->use24 ? $this->hour_names_24[date('G', $time) + $hour_offset] : $this->hour_names_12[date('G', $time) + $hour_offset];

The property hour_names_24 does not exist. Did you maybe forget to declare it?

The property hour_names_12 does not seem to exist. Did you mean hour_names_24?

            return sprintf(_APCAL_FMT_DHI, $this->date_short_names[date('j', $time)], // D
                           $hour4disp, // H
                           date(_APCAL_DTFMT_MINUTE, $time) // I
            );
        }

        // unixtimestamp���顢���ߤθ����ɽ�����줿 HI ������

        /**
         * @param         $time
         * @param  bool   $is_over24
         * @return string
         */
        public function get_middle_hi($time, $is_over24 = false)

This method seems to be duplicated in your project.

        {
            $hour_offset = $is_over24 ? 24 : 0;

            $hour4disp = $this->use24 ? $this->hour_names_24[date('G', $time) + $hour_offset] : $this->hour_names_12[date('G', $time) + $hour_offset];

The property hour_names_12 does not seem to exist. Did you mean hour_names_24?

            return sprintf(_APCAL_FMT_HI, $hour4disp, // H
                           date(_APCAL_DTFMT_MINUTE, $time) // I
            );
        }

        // Make <option>s for selecting "HOUR" (default_hour must be 0-23)

        /**
         * @param  int $default_hour
         * @return string
         */
        public function get_options_for_hour($default_hour = 0)
        {
            $ret = '';
            for ($h = 0; $h < 24; ++$h) {
                $ret .= $h == $default_hour ? "<option value='$h' selected>" : "<option value='$h'>";
                $ret .= $this->use24 ? $this->hour_names_24[$h] : $this->hour_names_12[$h];

The property hour_names_12 does not seem to exist. Did you mean hour_names_24?

                $ret .= "</option>\n";
            }

            return $ret;
        }

        // Make <option>s for selecting "MIN" (default_min must be 0-60 by 5)

        /**
         * @param  int $default_min
         * @return string
         */
        public function get_options_for_min($default_min = 0)
        {
            $ret = '';
            for ($m = 0; $m < 60; $m += 5) {
                $ret .= $m == $default_min ? "<option value='$m' selected>" : "<option value='$m'>";
                $ret .= sprintf('%02d', $m) . '</option>';
            }

            return $ret;
        }

        // unixtimestamp���顢�������(timestamp����)�ʹߤ�ͽ�������ʸ���������

        /**
         * @param         $start
         * @param         $now
         * @param  bool   $admission
         * @return string
         */
        public function get_coming_time_description($start, $now, $admission = true)
        {
            // ��ǧ��̵ͭ�ˤ�äƥɥå�GIF���ؤ���
            if ($admission) {
                $dot = '';
            } else {
                $dot = "<img border='0' src='$this->images_url/dot_notadmit.gif' />";
            }

            if ($start >= $now && $start - $now < 86400) {
                // 24���ְ���Υ��٥��
                if (!$dot) {
                    $dot = "<img border='0' src='$this->images_url/dot_today.gif' />";
                }
                $ret = "$dot <b>" . $this->get_middle_hi($start) . '</b>' . _APCAL_MB_TIMESEPARATOR;
            } elseif ($start < $now) {
                // ���Ǥ˳��Ϥ��줿���٥��
                if (!$dot) {
                    $dot = "<img border='0' src='$this->images_url/dot_started.gif' />";
                }
                $ret = "$dot " . _APCAL_MB_CONTINUING;
            } else {
                // ����ʹߤ˳��Ϥˤʤ륤�٥��
                if (!$dot) {
                    $dot = "<img border='0' src='$this->images_url/dot_future.gif' />";
                }
                //      $ret = "$dot " . date( "n/j H:i" , $start ) . _APCAL_MB_TIMESEPARATOR ;
                $ret = "$dot " . $this->get_middle_md($start) . ' ' . $this->get_middle_hi($start) . _APCAL_MB_TIMESEPARATOR;
            }

            return $ret;
        }

        // ���Ĥ�unixtimestamp���顢������(Y-n-j����)��ͽ����֤�ʸ���������ʴ�˥��ߡ�

        /**
         * @param         $start
         * @param         $end
         * @param         $ynj
         * @param  bool   $justify
         * @param  bool   $admission
         * @param  null   $is_start_date
         * @param  null   $is_end_date
         * @param  null   $border_for_2400
         * @return string
         */
        public function get_todays_time_description(
            $start,
            $end,
            $ynj,
            $justify = true,
            $admission = true,
            $is_start_date = null,
            $is_end_date = null,
            $border_for_2400 = null
        ) {
            if (!isset($is_start_date)) {
                $is_start_date = (date('Y-n-j', $start) == $ynj);
            }
            if (!isset($is_end_date)) {
                $is_end_date = (date('Y-n-j', $end) == $ynj);
            }
            if (!isset($border_for_2400)) {
                $this->unixtime - (int)(($this->user_TZ - $this->server_TZ) * 3600) + 86400;
            }

            // $day_start ���꤬������Ρ�24:00�ʹߤν���
            if ($is_start_date && $start > $border_for_2400) {
                $start_desc = $this->get_middle_hi($start, true);
            } else {
                $start_desc = $this->get_middle_hi($start);
            }

            if ($is_end_date && $end > $border_for_2400) {

This code seems to be duplicated across your project.

                $end_desc = $this->get_middle_hi($end, true);
            } else {
                $end_desc = $this->get_middle_hi($end);
            }

            $stuffing = $justify ? '     ' : '';

            // ͽ����ֻ����̵ͭ����ǧ��̵ͭ�ˤ�äƥɥå�GIF���ؤ���
            if ($admission) {

This code seems to be duplicated across your project.

                if ($is_start_date) {
                    $dot = "<img border='0' src='$this->images_url/dot_startday.gif' />";
                } elseif ($is_end_date) {
                    $dot = "<img border='0' src='$this->images_url/dot_endday.gif' />";
                } else {
                    $dot = "<img border='0' src='$this->images_url/dot_interimday.gif' />";
                }
            } else {
                $dot = "<img border='0' src='$this->images_url/dot_notadmit.gif' />";
            }

            if ($is_start_date) {

This code seems to be duplicated across your project.

                if ($is_end_date) {
                    $ret = "$dot {$start_desc}" . _APCAL_MB_TIMESEPARATOR . "{$end_desc}";
                } else {
                    $ret = "$dot {$start_desc}" . _APCAL_MB_TIMESEPARATOR . "{$stuffing}";
                }
            } else {
                if ($is_end_date) {
                    $ret = "$dot {$stuffing}" . _APCAL_MB_TIMESEPARATOR . "{$end_desc}";
                } else {
                    $ret = "$dot " . _APCAL_MB_CONTINUING;
                }
            }

            return $ret;
        }

        // $event�������̤��顢�������ͽ����֤�ʸ�����������̾磻�٥�ȤΤߡ�

        /**
         * @param         $event
         * @param         $tzoffset
         * @param         $border_for_2400
         * @param  bool   $justify
         * @param  bool   $admission
         * @return string
         */
        public function get_time_desc_for_a_day(
            $event,
            $tzoffset,
            $border_for_2400,
            $justify = true,
            $admission = true
        ) {
            $start = $event->start + $tzoffset;
            $end   = $event->end + $tzoffset;

            // $day_start ���꤬������Ρ�24:00�ʹߤν���
            if ($event->is_start_date && $event->start >= $border_for_2400) {

This code seems to be duplicated across your project.

                $start_desc = $this->get_middle_hi($start, true);
            } else {
                $start_desc = $this->get_middle_hi($start);
            }

            if ($event->is_end_date && $event->end >= $border_for_2400) {

This code seems to be duplicated across your project.

                $end_desc = $this->get_middle_hi($end, true);
            } else {
                $end_desc = $this->get_middle_hi($end);
            }

            $stuffing = $justify ? '     ' : '';

            // ͽ����ֻ����̵ͭ����ǧ��̵ͭ�ˤ�äƥɥå�GIF���ؤ���
            if ($admission) {

This code seems to be duplicated across your project.

                if ($event->is_start_date) {
                    $dot = "<img border='0' src='$this->images_url/dot_startday.gif' />";
                } elseif ($event->is_end_date) {
                    $dot = "<img border='0' src='$this->images_url/dot_endday.gif' />";
                } else {
                    $dot = "<img border='0' src='$this->images_url/dot_interimday.gif' />";
                }
            } else {
                $dot = "<img border='0' src='$this->images_url/dot_notadmit.gif' />";
            }

            if ($event->is_start_date) {

This code seems to be duplicated across your project.

                if ($event->is_end_date) {
                    $ret = "$dot {$start_desc}" . _APCAL_MB_TIMESEPARATOR . "{$end_desc}";
                } else {
                    $ret = "$dot {$start_desc}" . _APCAL_MB_TIMESEPARATOR . "{$stuffing}";
                }
            } else {
                if ($event->is_end_date) {
                    $ret = "$dot {$stuffing}" . _APCAL_MB_TIMESEPARATOR . "{$end_desc}";
                } else {
                    $ret = "$dot " . _APCAL_MB_CONTINUING;
                }
            }

            return $ret;
        }

        // �������ϥܥå����δؿ� (JavaScript�����Ϥ���ݤ�Override�о�)

        /**
         * @param $name
         * @param $value
         * @return string
         */
        public function get_formtextdateselect($name, $value)
        {
            return "<input type='text' name='$name' size='12' value='$value' style='ime-mode:disabled' />";
        }

        // $this->images_url���ˤ���style.css���ɤ߹��ߡ����˥��������ư��Ϥ�

        /**
         * @return string
         */
        public function get_embed_css()
        {
            $css_filename = "$this->images_path/style.css";
            if (!is_readable($css_filename)) {
                return '';
            } else {
                return strip_tags(implode('', file($css_filename)));
            }
        }

        // ��ƼԤ�ɽ��ʸ������֤� (Override�о�)

        /**
         * @param $uid
         * @return string
         */
        public function get_submitter_info($uid)
        {
            return '';
        }

        // ���ƥ���ط���WHERE�Ѿ�������

        /**
         * @return string
         */
        public function get_where_about_categories()
        {
            if ($this->isadmin) {
                if (empty($this->now_cid)) {
                    // �����Ԥ�����Ԥ�$cid���꤬�ʤ���о��True
                    return '1';
                } else {
                    // �����Ԥ�����Ԥ�$cid���꤬����С���������LIKE����
                    return "categories LIKE '%" . sprintf('%05d,', $this->now_cid) . "%'";
                }
            } else {
                if (empty($this->now_cid)) {
                    // �����Ԥ�����԰ʳ���$cid���꤬�ʤ���С�CAT2GROUP�ˤ������
                    $limit_from_perm = "categories='' OR ";
                    foreach ($this->categories as $cid => $cat) {
                        $limit_from_perm .= "categories LIKE '%" . sprintf('%05d,', $cid) . "%' OR ";
                    }
                    $limit_from_perm = substr($limit_from_perm, 0, -3);

                    return $limit_from_perm;
                } else {
                    // �����Ԥ�����԰ʳ���$cid���꤬����С����¥����å�����$cid����
                    if (isset($this->categories[$this->now_cid])) {
                        return "categories LIKE '%" . sprintf('%05d,', $this->now_cid) . "%'";
                    } else {
                        // ���ꤵ�줿cid�����¤ˤʤ�
                        return '0';
                    }
                }
            }
        }

        // CLASS(�����)�ط���WHERE�Ѿ�������

        /**
         * @return string
         */
        public function get_where_about_class()
        {
            if ($this->isadmin) {
                // �����Ԥ�����Ԥʤ���True
                return '1';
            } elseif ($this->user_id <= 0) {
                // �����Ԥ������Ȥʤ��(PUBLIC)�쥳���ɤΤ�
                return "class='PUBLIC'";
            } else {
                // �̾�桼���ʤ顢PUBLIC�쥳���ɤ����桼��ID�����פ���쥳���ɡ��ޤ��ϡ���°���Ƥ��륰�롼��ID�Τ����ΰ�Ĥ��쥳���ɤΥ��롼��ID�Ȱ��פ���쥳����
                $ids = ' ';
                foreach ($this->groups as $id => $name) {
                    $ids .= "$id,";
                }
                $ids = substr($ids, 0, -1);
                if ((int)$ids == 0) {
                    $group_section = '';
                } else {
                    $group_section = "OR groupid IN ($ids)";
                }

                return "(class='PUBLIC' OR uid=$this->user_id $group_section)";
            }
        }

        // mb_convert_kana���

        /**
         * @param $str
         * @param $option
         * @return string
         */
        public function mb_convert_kana($str, $option)

This method seems to be duplicated in your project.

        {
            // convert_kana �ν���ϡ����ܸ�ǤΤ߹Ԥ�
            if ($this->language !== 'japanese' || !function_exists('mb_convert_kana')) {
                return $str;
            } else {
                return mb_convert_kana($str, $option);
            }
        }

        /*******************************************************************/
        /*   ���˥�������Ϣ�δؿ� (���֥��饹������������Override�о�)   */
        /*******************************************************************/

        /**
         * @param $data
         * @return string
         */
        public function textarea_sanitizer_for_show($data)
        {
            return nl2br(htmlspecialchars($data, ENT_QUOTES));
        }

        /**
         * @param $data
         * @return string
         */
        public function text_sanitizer_for_show($data)
        {
            return htmlspecialchars($data, ENT_QUOTES);
        }

        /**
         * @param $data
         * @return string
         */
        public function textarea_sanitizer_for_edit($data)
        {
            return htmlspecialchars($data, ENT_QUOTES);
        }

        /**
         * @param $data
         * @return string
         */
        public function text_sanitizer_for_edit($data)
        {
            return htmlspecialchars($data, ENT_QUOTES);
        }

        /**
         * @param $data
         * @return mixed
         */
        public function textarea_sanitizer_for_export_ics($data)
        {
            return $data;
        }

        /*******************************************************************/
        /*        iCalendar ����ؿ�                                       */
        /*******************************************************************/

        // iCalendar�����ǤΥХå����ϥץ�åȥե����������ѥե�������֤�
        // $_POST['ids']�ǻ���
        /**
         * @param         $post_target
         * @param  string $target
         * @return string
         */
        public function output_ics_confirm($post_target, $target = '_self')
        {
            // POST�Ǽ�����ä�id�����event_ids����Ȥ���POST����
            $hiddens = '';
            foreach ($_POST['ids'] as $id) {
                $id      = (int)$id;
                $hiddens .= "<input type='hidden' name='event_ids[]' value='$id' />\n";
            }
            // webcal�������
            $webcal_url = str_replace('http://', 'webcal://', $post_target);

            // ��ǧ�ե�������֤�
            return "
    <div style='text-align:center;width:100%;'>&nbsp;<br><b>" . _APCAL_MB_ICALSELECTPLATFORM . "</b><br>&nbsp;</div>
    <table border='0' cellpadding='5' cellspacing='2' width='100%'>
    <tr>
    <td align='right' width='50%'>
    <form class='apcalForm' action='$post_target?output_ics=1' method='post' target='$target'>
        $hiddens
        <input type='submit' name='do_output' value='" . _APCAL_BTN_OUTPUTICS_WIN . "' />
    </form>
    </td>
    <td align='left' width='50%'>
    <form class='apcalForm' action='$webcal_url?output_ics=1' method='post' target='$target'>
        $hiddens
        <input type='submit' name='do_output' value='" . _APCAL_BTN_OUTPUTICS_MAC . "' />
    </form>
    </td>
    </tr>
    </table><br><br>\n";
        }

        // iCalendar�����Ǥν��� (mbstringɬ��)
        // ���Ϥ����Τߤξ���$_GET['event_id']������ξ���$_POST['event_ids']
        public function output_ics()
        {
            // $event_id �����ꤵ��Ƥ��ʤ���н�λ
            if (empty($_GET['event_id']) && empty($_POST['event_ids'])) {
                die(_APCAL_ERR_INVALID_EVENT_ID);
            }

            // iCalendar���ϵ��Ĥ��ʤ���н�λ
            if (!$this->can_output_ics) {
                die(_APCAL_ERR_NOPERM_TO_OUTPUTICS);
            }
            if (isset($_GET['event_id'])) {
                // $_GET[ 'event_id' ] �ˤ��������λ���ξ��
                $event_id  = (int)$_GET['event_id'];
                $event_ids = array($event_id);
                //                $rs        = $xoopsDB->query("SELECT summary AS udtstmp FROM $this->table WHERE id='$event_id'");
                $rs = $GLOBALS['xoopsDB']->query("SELECT summary AS udtstmp FROM $this->table WHERE id='$event_id'");

                if ($GLOBALS['xoopsDB']->getRowsNum($rs) < 1) {
                    die(_APCAL_ERR_INVALID_EVENT_ID);
                }
                //                $summary = mysql_result($rs, 0, 0);
                $summary   = 0;
                $resultRow = $GLOBALS['xoopsDB']->fetchRow($rs);
                if (false !== $resultRow && isset($resultRow[$field])) {

The variable $field seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                    $summary = $resultRow[0];
                }
                //                $rs = $xoopsDB->query("SELECT * FROM $cal->table WHERE WHERE id='$event_id'");

                // ��̾ �� X-WR-CALNAME �Ȥ���
                $x_wr_calname = $summary;
                // �ե�����̾�˻Ȥ��ʤ�������ʸ��Ϻ��
                if (function_exists('mb_ereg_replace')) {
                    $summary = mb_ereg_replace('[<>|"?*,:;\\/]', '', $summary);
                } else {
                    $summary = preg_replace('/[<>|"?*,:;\\/]/', '', $summary);
                }
                // �ػ�ʸ����ä���̾.ics ��ե�����̾�Ȥ��� (��SJIS�Ѵ�)
                $output_filename = mb_convert_encoding($summary, 'ASCII') . '.ics';
                $output_filename = str_replace(' ', '', $output_filename);
            } elseif (is_array($_POST['event_ids'])) {
                // $_POST[ 'event_ids' ] �ˤ������ˤ�����ξ��
                $event_ids = array_unique($_POST['event_ids']);
                // events-�������(GMT) �� X-WR-CALNAME �Ȥ���
                $x_wr_calname = 'events-' . gmdate('Ymd\THis\Z');
                // events-�������.ics ��ե�����̾�Ȥ���
                $output_filename = $x_wr_calname . '.ics';
            } else {
                die(_APCAL_ERR_INVALID_EVENT_ID);
            }

            // HTTP header
            header('Pragma: public');
            header('Expires: 0');
            header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
            header('Cache-Control: private', false);
            header('Content-Type: text/calendar');
            header("Content-Disposition: attachment; filename=\"{$output_filename}\";");

            // iCalendar�إå�
            $ical_header = "BEGIN:VCALENDAR\r
CALSCALE:GREGORIAN\r
X-WR-TIMEZONE;VALUE=TEXT:GMT\r
PRODID:ANTIQUES PROMOTION - APCal -\r";
            $ical_header .= $this->ics_new_cal ? "X-WR-CALNAME;VALUE=TEXT:$x_wr_calname\r" : '';
            $ical_header .= "VERSION:2.0\r
METHOD:PUBLISH\r\n";

            // ���ƥ��꡼��Ϣ��WHERE������
            $whr_categories = $this->get_where_about_categories();

            // CLASS��Ϣ��WHERE������
            $whr_class = $this->get_where_about_class();

            // ���٥����Υ롼��
            $vevents_str = '';
            $timezones   = array();
            foreach ($event_ids as $event_id) {
                $event_id = (int)$event_id;
                $sql      = "SELECT *,UNIX_TIMESTAMP(dtstamp) AS udtstmp,DATE_ADD(end_date,INTERVAL 1 DAY) AS end_date_offseted FROM $this->table WHERE id='$event_id' AND ($whr_categories) AND ($whr_class)";
                if (!$rs = $GLOBALS['xoopsDB']->query($sql)) {
                    echo $GLOBALS['xoopsDB']->error();
                }
                $event = $GLOBALS['xoopsDB']->fetchObject($rs);
                if (!$event) {
                    continue;
                }

                if (isset($event->start_date)) {
                    // 1970������2038ǯ�ʹߤ����դ��������ü������٥��
                    $dtstart = str_replace('-', '', $event->start_date);
                    if (isset($event->end_date_offseted)) {

This code seems to be duplicated across your project.

                        $dtend = str_replace('-', '', $event->end_date_offseted);
                    } else {
                        $dtend = date('Ymd', $event->end);
                    }
                    $dtstart_opt = $dtend_opt = ';VALUE=DATE';
                } elseif ($event->allday) {
                    // ����٥�ȡʻ�������ʤ���
                    $dtstart = date('Ymd', $event->start);
                    if (isset($event->end_date_offseted)) {

This code seems to be duplicated across your project.

                        $dtend = str_replace('-', '', $event->end_date_offseted);
                    } else {
                        $dtend = date('Ymd', $event->end);
                    }
                    // ���ϤȽ�λ��Ʊ��ξ��ϡ���λ������ˤ��餹
                    if ($dtstart == $dtend) {
                        $dtend = date('Ymd', $event->end + 86400);
                    }
                    $dtstart_opt = $dtend_opt = ';VALUE=DATE';
                } else {
                    if ($event->rrule) {
                        // �̾磻�٥�Ȥ�RRULE������С����٥��TZ�ǽ���
                        $tzoffset = (int)(($this->server_TZ - $event->event_tz) * 3600);
                        list(, $tzid) = $this->get_timezone_desc($event->event_tz);
                        $dtstart     = date('Ymd\THis', $event->start - $tzoffset);
                        $dtend       = date('Ymd\THis', $event->end - $tzoffset);
                        $dtstart_opt = $dtend_opt = ";TZID=$tzid";
                        // ����ˡ�����VTIMEZONE�����
                        $timezones[$event->event_tz] = 1;
                    } else {
                        // �̾磻�٥�Ȥ�RRULE��̵����С������Фλ��������������GMTɽ��
                        $tzoffset    = $this->server_TZ * 3600;
                        $dtstart     = date('Ymd\THis\Z', $event->start - $tzoffset);
                        $dtend       = date('Ymd\THis\Z', $event->end - $tzoffset);
                        $dtstart_opt = $dtend_opt = '';
                    }
                }

                // DTSTAMP�Ͼ��GMT
                $dtstamp = date('Ymd\THis\Z', $event->udtstmp - $this->server_TZ * 3600);

                // DESCRIPTION�� folding , \r��� ����� \n -> \\n �Ѵ�, ���˥�����
                // (folding ̤����) TODO
                $description = str_replace("\r", '', $event->description);
                $description = str_replace("\n", '\n', $description);
                $description = $this->textarea_sanitizer_for_export_ics($description);

                // ���ƥ��꡼��ɽ��
                $categories = '';
                $cids       = explode(',', $event->categories);
                foreach ($cids as $cid) {
                    $cid = (int)$cid;
                    if (isset($this->categories[$cid])) {
                        $categories .= $this->categories[$cid]->cat_title . ',';
                    }
                }
                if ($categories !== '') {
                    $categories = substr($categories, 0, -1);
                }

                // RRULE�Ԥϡ�RRULE����Ȥ��������������
                $rrule_line = $event->rrule ? "RRULE:{$event->rrule}\r\n" : '';

                // ���٥�ȥǡ����ν���
                $vevents_str .= "BEGIN:VEVENT\r
DTSTART{$dtstart_opt}:{$dtstart}\r
DTEND{$dtend_opt}:{$dtend}\r
LOCATION:{$event->location}\r
TRANSP:OPAQUE\r
SEQUENCE:{$event->sequence}\r
UID:{$event->unique_id}\r
DTSTAMP:{$dtstamp}\r
CATEGORIES:{$categories}\r
DESCRIPTION:{$description}\r
SUMMARY:{$event->summary}\r
{$rrule_line}PRIORITY:{$event->priority}\r
CLASS:{$event->class}\r
END:VEVENT\r\n";
            }

            // VTIMEZONE
            $vtimezones_str = $this->get_vtimezones_str($timezones);

            // iCalendar�եå�
            $ical_footer = "END:VCALENDAR\r\n";

            $ical_data = "$ical_header$vtimezones_str$vevents_str$ical_footer";

            // mbstring ��������Τߡ�UTF-8 �ؤ��Ѵ�
            if (extension_loaded('mbstring')) {
                mb_http_output('pass');
                $ical_data = mb_convert_encoding($ical_data, 'UTF-8');
            }

            echo $ical_data;

            exit;
        }

        /**
         * @param         $uri
         * @param  bool   $force_http
         * @param  string $user_uri
         * @return string
         */
        public function import_ics_via_fopen($uri, $force_http = true, $user_uri = '')
        {
            if (strlen($uri) < 5) {
                return '-1:';
            }
            $user_uri = empty($user_uri) ? '' : $uri;
            // webcal://* �� connection̤����⡢���٤� http://* �����
            $uri = str_replace('webcal://', 'http://', $uri);

            if ($force_http) {
                //                if (substr($uri, 0, 7) !== 'http://') {
                if (0 !== strpos($uri, 'http://')) {
                    $uri = 'http://' . $uri;
                }
            }

            // iCal parser �ˤ�����
            require_once "$this->base_path/class/iCal_parser.php";
            $ical           = new iCal_parser();
            $ical->language = $this->language;
            $ical->timezone = ($this->server_TZ >= 0 ? '+' : '-') . sprintf('%02d%02d', abs($this->server_TZ), abs($this->server_TZ) * 60 % 60);
            list($ret_code, $message, $filename) = explode(':', $ical->parse($uri, $user_uri), 3);
            if ($ret_code != 0) {
                // �ѡ������Ԥʤ�-1�ȥ��顼��å��������֤�
                return "-1: $message : $filename";
            }
            $setsqls = $ical->output_setsqls();

            $count = 0;
            foreach ($setsqls as $setsql) {

This code seems to be duplicated across your project.

                $sql = "INSERT INTO $this->table SET $setsql,admission=1,uid=$this->user_id,poster_tz='$this->user_TZ',server_tz='$this->server_TZ'";

                if (!$GLOBALS['xoopsDB']->query($sql)) {
                    die($GLOBALS['xoopsDB']->error());
                }
                $this->update_record_after_import($GLOBALS['xoopsDB']->getInsertId($this->conn));

                ++$count;
            }

            return "$count: $message:";
        }

        /**
         * @param $userfile
         * @return string
         */
        public function import_ics_via_upload($userfile)
        {
            // ics�ե�����򥯥饤����ȥޥ��󤫤饢�åץ?�ɤ����ɹ���
            require_once "$this->base_path/class/iCal_parser.php";
            $ical           = new iCal_parser();
            $ical->language = $this->language;
            $ical->timezone = ($this->server_TZ >= 0 ? '+' : '-') . sprintf('%02d%02d', abs($this->server_TZ), abs($this->server_TZ) * 60 % 60);
            list($ret_code, $message, $filename) = explode(':', $ical->parse($_FILES[$userfile]['tmp_name'], $_FILES[$userfile]['name']), 3);
            if ($ret_code != 0) {
                // �ѡ������Ԥʤ�-1�ȥ��顼��å��������֤�
                return "-1: $message : $filename";
            }
            $setsqls = $ical->output_setsqls();

            $count = 0;
            foreach ($setsqls as $setsql) {

This code seems to be duplicated across your project.

                $sql = "INSERT INTO $this->table SET $setsql,admission=1,uid=$this->user_id,poster_tz='$this->user_TZ',server_tz='$this->server_TZ'";

                if (!$GLOBALS['xoopsDB']->query($sql)) {
                    die($GLOBALS['xoopsDB']->error());
                }
                $this->update_record_after_import($GLOBALS['xoopsDB']->getInsertId($this->conn));

                ++$count;
            }

            return "$count: $message :";
        }

        // ���쥳���ɤ��ɤ߹��߸�˹Ԥ����� ��rrule��Ÿ����categories��cid���ʤɡ�

        /**
         * @param $event_id
         */
        public function update_record_after_import($event_id)
        {
            $rs    = $GLOBALS['xoopsDB']->query("SELECT categories,rrule FROM $this->table WHERE id='$event_id'");
            $event = $GLOBALS['xoopsDB']->fetchObject($rs);

            // categories �� cid�� ( '\,' -> ',' ��Outlook�к�)
            $event->categories = str_replace('\,', ',', $event->categories);
            $cat_names         = explode(',', $event->categories);
            for ($i = 0, $iMax = count($cat_names); $i < $iMax; ++$i) {
                $cat_names[$i] = trim($cat_names[$i]);
            }
            $categories = '';
            foreach ($this->categories as $cid => $cat) {
                if (in_array($cat->cat_title, $cat_names)) {
                    $categories .= sprintf('%05d,', $cid);
                }
            }

            // rrule_pid ���
            $rrule_pid = $event->rrule ? $event_id : 0;

            // �쥳���ɹ���
            $GLOBALS['xoopsDB']->query("UPDATE $this->table SET categories='$categories',rrule_pid='$rrule_pid' WHERE id='$event_id'");

            // RRULE���顢�ҥ쥳���ɤ�Ÿ��
            if ($event->rrule !== '') {
                $this->rrule_extract($event_id);
            }

            // GIJ TODO category �μ�ư��Ͽ class,groupid �ν���
        }

        /*******************************************************************/
        /*        RRULE ����ؿ�                                           */
        /*******************************************************************/

        // rrule����������������륯�饹�ؿ�
        /**
         * @param $rrule
         * @return string
         */
        public function rrule_to_human_language($rrule)
        {
            $rrule = trim($rrule);
            if ($rrule === '') {
                return '';
            }

            // rrule �γ����Ǥ��ѿ���Ÿ��
            $rrule = strtoupper($rrule);
            $rules = explode(';', $rrule);
            foreach ($rules as $rule) {

This code seems to be duplicated across your project.

                list($key, $val) = explode('=', $rule, 2);
                $key  = trim($key);
                $$key = trim($val);
            }

            if (empty($FREQ)) {

The variable $FREQ seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                $FREQ = 'DAILY';
            }
            if (empty($INTERVAL) || $INTERVAL <= 0) {

The variable $INTERVAL seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                $INTERVAL = 1;
            }

            // ���پ�����
            $ret_freq = '';
            $ret_day  = '';
            switch ($FREQ) {
                case 'DAILY':
                    if ($INTERVAL == 1) {
                        $ret_freq = _APCAL_RR_EVERYDAY;
                    } else {
                        $ret_freq = sprintf(_APCAL_RR_PERDAY, $INTERVAL);
                    }
                    break;
                case 'WEEKLY':
                    if (empty($BYDAY)) {

The variable $BYDAY seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

                        break;
                    }    // BYDAY ɬ��
                    $ret_day = strtr($BYDAY, $this->byday2langday_w);
                    if ($INTERVAL == 1) {
                        $ret_freq = _APCAL_RR_EVERYWEEK;
                    } else {
                        $ret_freq = sprintf(_APCAL_RR_PERWEEK, $INTERVAL);
                    }
                    break;
                case 'MONTHLY':
                    if (isset($BYMONTHDAY)) {

The variable $BYMONTHDAY seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                        $ret_day   = '';
                        $monthdays = explode(',', $BYMONTHDAY);
                        foreach ($monthdays as $monthday) {
                            $ret_day .= $this->date_long_names[$monthday] . ',';
                        }
                        $ret_day = substr($ret_day, 0, -1);
                    } elseif (isset($BYDAY)) {
                        $ret_day = strtr($BYDAY, $this->byday2langday_m);
                    } else {
                        break;        // BYDAY �ޤ��� BYMONTHDAY ɬ��
                    }
                    if ($INTERVAL == 1) {
                        $ret_freq = _APCAL_RR_EVERYMONTH;
                    } else {
                        $ret_freq = sprintf(_APCAL_RR_PERMONTH, $INTERVAL);
                    }
                    break;
                case 'YEARLY':
                    $ret_day = '';
                    if (!empty($BYMONTH)) {

The variable $BYMONTH seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

                        $months = explode(',', $BYMONTH);
                        foreach ($months as $month) {
                            $ret_day .= $this->month_long_names[$month] . ',';
                        }
                        $ret_day = substr($ret_day, 0, -1);
                    }
                    if (isset($BYDAY)) {
                        $ret_day .= ' ' . strtr($BYDAY, $this->byday2langday_m);
                    }
                    if ($INTERVAL == 1) {
                        $ret_freq = _APCAL_RR_EVERYYEAR;
                    } else {
                        $ret_freq = sprintf(_APCAL_RR_PERYEAR, $INTERVAL);
                    }
                    break;
            }

            // �������
            $ret_terminator = '';
            // UNTIL �� COUNT ��ξ������ COUNT ͥ��
            if (isset($COUNT) && $COUNT > 0) {

The variable $COUNT seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                $ret_terminator = sprintf(_APCAL_RR_COUNT, $COUNT);
            } elseif (isset($UNTIL)) {

The variable $UNTIL seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

This code seems to be duplicated across your project.

                // UNTIL �ϡ�������Ǥ����̵���Ǹ��ʤ�
                $year           = substr($UNTIL, 0, 4);
                $month          = substr($UNTIL, 4, 2);
                $date           = substr($UNTIL, 6, 2);
                $ret_terminator = sprintf(_APCAL_RR_UNTIL, "$year-$month-$date");
            }

            return "$ret_freq $ret_day $ret_terminator";
        }

        // rrule���Խ��ѥե������Ÿ�����륯�饹�ؿ�

        /**
         * @param $rrule
         * @param $until_init
         * @return string
         */
        public function rrule_to_form($rrule, $until_init)
        {
            // �ƽ���ͤ�����
            $norrule_checked       = '';

$norrule_checked is not used, you could remove the assignment.

            $daily_checked         = '';
            $weekly_checked        = '';
            $monthly_checked       = '';
            $yearly_checked        = '';
            $norrule_checked       = '';
            $noterm_checked        = '';
            $count_checked         = '';
            $until_checked         = '';
            $daily_interval_init   = 1;
            $weekly_interval_init  = 1;
            $monthly_interval_init = 1;
            $yearly_interval_init  = 1;
            $count_init            = 1;
            $wdays_checked         = array(
                'SU' => '',
                'MO' => '',
                'TU' => '',
                'WE' => '',
                'TH' => '',
                'FR' => '',
                'SA' => ''
            );
            $byday_m_init          = '';
            $bymonthday_init       = '';
            $bymonths_checked      = array(1 => '', '', '', '', '', '', '', '', '', '', '', '');

            if (trim($rrule) === '') {
                $norrule_checked = 'checked';
            } else {

                // rrule �γ����Ǥ��ѿ���Ÿ��
                $rrule = strtoupper($rrule);
                $rules = explode(';', $rrule);
                foreach ($rules as $rule) {

This code seems to be duplicated across your project.

                    list($key, $val) = explode('=', $rule, 2);
                    $key  = trim($key);
                    $$key = trim($val);
                }

                if (empty($FREQ)) {

The variable $FREQ seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                    $FREQ = 'DAILY';
                }
                if (empty($INTERVAL) || $INTERVAL <= 0) {

The variable $INTERVAL seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                    $INTERVAL = 1;
                }

                // ���پ�����
                switch ($FREQ) {
                    case 'DAILY':
                        $daily_interval_init = $INTERVAL;
                        $daily_checked       = 'checked';
                        break;
                    case 'WEEKLY':
                        if (empty($BYDAY)) {

The variable $BYDAY seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

                            break;
                        }    // BYDAY ɬ��
                        $weekly_interval_init = $INTERVAL;
                        $weekly_checked       = 'checked';
                        $wdays                = explode(',', $BYDAY, 7);
                        foreach ($wdays as $wday) {
                            if (isset($wdays_checked[$wday])) {
                                $wdays_checked[$wday] = 'checked';
                            }
                        }
                        break;
                    case 'MONTHLY':
                        if (isset($BYDAY)) {
                            $byday_m_init = $BYDAY;
                        } elseif (isset($BYMONTHDAY)) {

The variable $BYMONTHDAY does not exist. Did you mean $bymonthday_init?

                            $bymonthday_init = $BYMONTHDAY;
                        } else {
                            break;    // BYDAY �ޤ��� BYMONTHDAY ɬ��
                        }
                        $monthly_interval_init = $INTERVAL;
                        $monthly_checked       = 'checked';
                        break;
                    case 'YEARLY':
                        if (empty($BYMONTH)) {

The variable $BYMONTH seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                            $BYMONTH = '';
                        }
                        if (isset($BYDAY)) {
                            $byday_m_init = $BYDAY;
                        }
                        $yearly_interval_init = $INTERVAL;
                        $yearly_checked       = 'checked';
                        $months               = explode(',', $BYMONTH, 12);
                        foreach ($months as $month) {
                            $month = (int)$month;
                            if ($month > 0 && $month <= 12) {
                                $bymonths_checked[$month] = 'checked';
                            }
                        }
                        break;
                }

                // �������
                // UNTIL �� COUNT ��ξ������ COUNT ͥ��
                if (isset($COUNT) && $COUNT > 0) {

The variable $COUNT seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                    $count_init    = $COUNT;
                    $count_checked = 'checked';
                } elseif (isset($UNTIL)) {

The variable $UNTIL seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

This code seems to be duplicated across your project.

                    // UNTIL �ϡ�����ǡ����Ǥ����̵���Ǹ��ʤ�
                    $year          = substr($UNTIL, 0, 4);
                    $month         = substr($UNTIL, 4, 2);
                    $date          = substr($UNTIL, 6, 2);
                    $until_init    = "$year-$month-$date";
                    $until_checked = 'checked';
                } else {
                    // ξ�ԤȤ���꤬�ʤ���С���λ���ʤ�
                    $noterm_checked = 'checked';
                }
            }

            // UNTIL ����ꤹ�뤿��Υܥå���
            $textbox_until = $this->get_formtextdateselect('rrule_until', $until_init);

            // ������������å��ܥå�����Ÿ��
            $wdays_checkbox = '';
            foreach ($this->byday2langday_w as $key => $val) {
                $wdays_checkbox .= "<input type='checkbox' name='rrule_weekly_bydays[]' value='$key' {$wdays_checked[$key]} />$val &nbsp; \n";
            }

            // ����������å��ܥå�����Ÿ��
            $bymonth_checkbox = "<table border='0' cellpadding='2'><tr>\n";
            foreach ($bymonths_checked as $key => $val) {
                $bymonth_checkbox .= "<td><input type='checkbox' name='rrule_bymonths[]' value='$key' $val />{$this->month_short_names[$key]}</td>\n";
                if ($key == 6) {
                    $bymonth_checkbox .= "</tr>\n<tr>\n";
                }
            }
            $bymonth_checkbox .= "</tr></table>\n";

            // ��N��������OPTION��Ÿ��
            $byday_m_options = '';
            foreach ($this->byday2langday_m as $key => $val) {
                if ($byday_m_init == $key) {
                    $byday_m_options .= "<option value='$key' selected>$val</option>\n";
                } else {
                    $byday_m_options .= "<option value='$key'>$val</option>\n";
                }
            }

            return "
            <input type='radio' name='rrule_freq' value='none' $norrule_checked />"
                   . _APCAL_RR_R_NORRULE
                   . "<br>
            <br>
            <fieldset>
                <legend class='blockTitle'>"
                   . _APCAL_RR_R_YESRRULE
                   . "</legend>
                <fieldset>
                    <legend class='blockTitle'><input type='radio' name='rrule_freq' value='daily' $daily_checked />"
                   . _APCAL_RR_FREQDAILY
                   . '</legend>
                    '
                   . _APCAL_RR_FREQDAILY_PRE
                   . " <input type='text' size='2' name='rrule_daily_interval' value='$daily_interval_init' /> "
                   . _APCAL_RR_FREQDAILY_SUF
                   . "
                </fieldset>
                <br>
                <fieldset>
                    <legend class='blockTitle'><input type='radio' name='rrule_freq' value='weekly' $weekly_checked />"
                   . _APCAL_RR_FREQWEEKLY
                   . '</legend>
                    '
                   . _APCAL_RR_FREQWEEKLY_PRE
                   . "<input type='text' size='2' name='rrule_weekly_interval' value='$weekly_interval_init' /> "
                   . _APCAL_RR_FREQWEEKLY_SUF
                   . " <br>
                    $wdays_checkbox
                </fieldset>
                <br>
                <fieldset>
                    <legend class='blockTitle'><input type='radio' name='rrule_freq' value='monthly' $monthly_checked />"
                   . _APCAL_RR_FREQMONTHLY
                   . '</legend>
                    '
                   . _APCAL_RR_FREQMONTHLY_PRE
                   . "<input type='text' size='2' name='rrule_monthly_interval' value='$monthly_interval_init' /> "
                   . _APCAL_RR_FREQMONTHLY_SUF
                   . " &nbsp;
                    <select name='rrule_monthly_byday'>
                        <option value=''>"
                   . _APCAL_RR_S_NOTSELECTED
                   . "</option>
                        $byday_m_options
                    </select> &nbsp; "
                   . _APCAL_RR_OR
                   . " &nbsp;
                    <input type='text' size='10' name='rrule_bymonthday' value='$bymonthday_init' />"
                   . _APCAL_NTC_MONTHLYBYMONTHDAY
                   . "
                </fieldset>
                <br>
                <fieldset>
                    <legend class='blockTitle'><input type='radio' name='rrule_freq' value='yearly' $yearly_checked />"
                   . _APCAL_RR_FREQYEARLY
                   . '</legend>
                    '
                   . _APCAL_RR_FREQYEARLY_PRE
                   . "<input type='text' size='2' name='rrule_yearly_interval' value='$yearly_interval_init' /> "
                   . _APCAL_RR_FREQYEARLY_SUF
                   . " <br>
                    $bymonth_checkbox <br>
                    <select name='rrule_yearly_byday'>
                        <option value=''>"
                   . _APCAL_RR_S_SAMEASBDATE
                   . "</option>
                        $byday_m_options
                    </select>
                </fieldset>
                <br>
                <input type='radio' name='rrule_terminator' value='noterm' $noterm_checked onClick='document.MainForm.rrule_until.disabled=true;document.MainForm.rrule_count.disabled=true;' />"
                   . _APCAL_RR_R_NOCOUNTUNTIL
                   . ' &nbsp; '
                   . sprintf(_APCAL_NTC_EXTRACTLIMIT, $this->max_rrule_extract)
                   . "  <br>
                <input type='radio' name='rrule_terminator' value='count' $count_checked onClick='document.MainForm.rrule_until.disabled=true;document.MainForm.rrule_count.disabled=false;' />"
                   . _APCAL_RR_R_USECOUNT_PRE
                   . " <input type='text' size='3' name='rrule_count' value='$count_init' /> "
                   . _APCAL_RR_R_USECOUNT_SUF
                   . "<br>
                <input type='radio' name='rrule_terminator' value='until' $until_checked onClick='document.MainForm.rrule_until.disabled=false;document.MainForm.rrule_count.disabled=true;' />"
                   . _APCAL_RR_R_USEUNTIL
                   . " $textbox_until
            </fieldset>
  \n";
        }

        // POST���줿rrule��Ϣ�������ͤ�RRULEʸ������Ȥ߾夲�륯�饹�ؿ�

        /**
         * @param $start
         * @param $allday_flag
         * @return string

Should the return type not be string|null?

         */
        public function rrule_from_post($start, $allday_flag)
        {
            // �����֤�̵���ʤ顢̵���Ƕ�ʸ������֤�
            if ($_POST['rrule_freq'] === 'none') {
                return '';
            }

            // ���پ��
            switch (strtoupper($_POST['rrule_freq'])) {
                case 'DAILY':
                    $ret_freq = 'FREQ=DAILY;INTERVAL=' . abs((int)$_POST['rrule_daily_interval']);
                    break;
                case 'WEEKLY':
                    $ret_freq = 'FREQ=WEEKLY;INTERVAL=' . abs((int)$_POST['rrule_weekly_interval']);
                    if (empty($_POST['rrule_weekly_bydays'])) {
                        // ����λ��꤬��Ĥ�ʤ���С��������Ʊ������ˤ���
                        $bydays = array_keys($this->byday2langday_w);
                        $byday  = $bydays[date('w', $start)];
                    } else {
                        $byday = '';
                        foreach ($_POST['rrule_weekly_bydays'] as $wday) {
                            if (preg_match('/[^\w]+/', $wday)) {
                                die('Some injection was tried');
                            }
                            $byday .= substr($wday, 0, 2) . ',';
                        }
                        $byday = substr($byday, 0, -1);
                    }
                    $ret_freq .= ";BYDAY=$byday";
                    break;
                case 'MONTHLY':
                    $ret_freq = 'FREQ=MONTHLY;INTERVAL=' . abs((int)$_POST['rrule_monthly_interval']);
                    if ($_POST['rrule_monthly_byday'] !== '') {
                        // ��N����ˤ�����
                        $byday = substr(trim($_POST['rrule_monthly_byday']), 0, 4);
                        if (preg_match('/[^\w-]+/', $byday)) {
                            die('Some injection was tried');
                        }
                        $ret_freq .= ";BYDAY=$byday";
                    } elseif ($_POST['rrule_bymonthday'] !== '') {
                        // ���դˤ�����
                        $bymonthday = preg_replace('/[^0-9,]+/', '', $_POST['rrule_bymonthday']);
                        $ret_freq   .= ";BYMONTHDAY=$bymonthday";
                    } else {
                        // ��N��������դλ��꤬�ʤ���С��������Ʊ�����դȤ���
                        $ret_freq .= ';BYMONTHDAY=' . date('j', $start);
                    }
                    break;
                case 'YEARLY':
                    $ret_freq = 'FREQ=YEARLY;INTERVAL=' . abs((int)$_POST['rrule_yearly_interval']);
                    if (empty($_POST['rrule_bymonths'])) {
                        // ��λ��꤬��Ĥ�ʤ���С��������Ʊ����ˤ���
                        $bymonth = date('n', $start);
                    } else {
                        $bymonth = '';
                        foreach ($_POST['rrule_bymonths'] as $month) {
                            $bymonth .= (int)$month . ',';
                        }
                        $bymonth = substr($bymonth, 0, -1);
                    }
                    if ($_POST['rrule_yearly_byday'] !== '') {
                        // ��N����ˤ�����
                        $byday = substr(trim($_POST['rrule_yearly_byday']), 0, 4);
                        if (preg_match('/[^\w-]+/', $byday)) {
                            die('Some injection was tried');
                        }
                        $ret_freq .= ";BYDAY=$byday";
                    }
                    $ret_freq .= ";BYMONTH=$bymonth";
                    break;
                default:
                    return '';
            }

            // ����
            if (empty($_POST['rrule_terminator'])) {
                $_POST['rrule_terminator'] = '';
            }
            switch (strtoupper($_POST['rrule_terminator'])) {
                case 'COUNT':
                    $ret_term = ';COUNT=' . abs((int)$_POST['rrule_count']);
                    break;
                case 'UNTIL':
                    // UNTIL��Unixtime��
                    list($until, $until_date, $use_default) = $this->parse_posted_date($this->mb_convert_kana($_POST['rrule_until'], 'a'), $this->unixtime);

The assignment to $use_default is unused. Consider omitting it like so list($first,,$third).

                    // 1970������2038ǯ�ʹߤʤ顢UNTIL̵��
                    if ($until_date) {
                        $ret_term = '';
                    } else {
                        if (!$allday_flag) {
                            // ����٥�ȤǤʤ����Ʊ���23:59:59��λ����ȸ��ʤ��ơ� UTC �ػ����׻�����
                            $event_tz = isset($_POST['event_tz']) ? $_POST['event_tz'] : $this->user_TZ;
                            $until    = $until - (int)($event_tz * 3600) + 86400 - 1;
                        }
                        $ret_term = ';UNTIL=' . date('Ymd\THis\Z', $until);
                    }
                    break;
                case 'NOTERM':
                default:
                    $ret_term = '';
                    break;
            }

            // WKST�ϡ���ư�������
            $ret_wkst = $this->week_start ? ';WKST=MO' : ';WKST=SU';

            return $ret_freq . $ret_term . $ret_wkst;
        }

        // �Ϥ��줿event_id����(��)�Ȥ��ơ�RRULE��Ÿ�����ƥǡ����١�����ȿ��

        /**
         * @param $event_id
         */
        public function rrule_extract($event_id)
        {
            $yrs = $GLOBALS['xoopsDB']->query("SELECT *,TO_DAYS(end_date)-TO_DAYS(start_date) AS date_diff FROM $this->table WHERE id='$event_id'");
            if ($GLOBALS['xoopsDB']->getRowsNum($yrs) < 1) {
                return;
            }
            $event = $GLOBALS['xoopsDB']->fetchObject($yrs);

            if ($event->rrule === '') {
                return;
            }

            // rrule �γ����Ǥ��ѿ���Ÿ��
            $rrule = strtoupper($event->rrule);
            $rules = explode(';', $rrule);
            foreach ($rules as $rule) {

This code seems to be duplicated across your project.

                list($key, $val) = explode('=', $rule, 2);
                $key  = trim($key);
                $$key = trim($val);
            }

            // �����ˤ�äơ�RRULE�����ջ��꤬�ɤ��֤�����뤫�η׻�
            if ($event->allday) {
                $tzoffset_date = 0;
            } else {
                // ���٥�ȼ��Ȥ�TZ��Ÿ������
                $tzoffset_s2e  = (int)(($event->event_tz - $this->server_TZ) * 3600);
                $tzoffset_date = date('z', $event->start + $tzoffset_s2e) - date('z', $event->start);
                if ($tzoffset_date > 1) {
                    $tzoffset_date = -1;
                } elseif ($tzoffset_date < -1) {
                    $tzoffset_date = 1;
                }
            }

            if (empty($FREQ)) {

The variable $FREQ seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                $FREQ = 'DAILY';
            }
            if (empty($INTERVAL) || $INTERVAL <= 0) {

The variable $INTERVAL seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                $INTERVAL = 1;
            }

            // �١����Ȥʤ�SQLʸ
            $base_sql = "INSERT INTO $this->table SET uid='$event->uid',groupid='$event->groupid',shortsummary='"
                        . $this->makeShort(utf8_decode(addslashes($event->summary)))
                        . "',summary='"
                        . addslashes($event->summary)
                        . "',location='"
                        . addslashes($event->location)
                        . "',gmlat='{$event->gmlat}',gmlong='{$event->gmlong}',gmzoom='{$event->gmzoom}',organizer='"
                        . addslashes($event->organizer)
                        . "',sequence='$event->sequence',contact='"
                        . addslashes($event->contact)
                        . "',email='"
                        . addslashes($event->email)
                        . "',url='"
                        . addslashes($event->url)
                        . "',tzid='$event->tzid',description='"
                        . addslashes($event->description)
                        . "',dtstamp='$event->dtstamp',mainCategory='{$event->mainCategory}',categories='"
                        . addslashes($event->categories)
                        . "',transp='$event->transp',priority='$event->priority',admission='$event->admission',class='$event->class',rrule='"
                        . addslashes($event->rrule)
                        . "',unique_id='$event->unique_id',allday='$event->allday',start_date=null,end_date=null,cid='$event->cid',event_tz='$event->event_tz',server_tz='$event->server_tz',poster_tz='$event->poster_tz',extkey0='$event->extkey0',extkey1='$event->extkey1',rrule_pid='$event_id'";

            // �������
            // �������
            $count = $this->max_rrule_extract;
            if (isset($COUNT) && $COUNT > 0 && $COUNT < $count) {

The variable $COUNT seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                $count = $COUNT;
            }
            // Ÿ����λ��
            if (isset($UNTIL)) {

The variable $UNTIL seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                // UNTIL �ϡ�������Ǥ����̵���Ǹ��ʤ�
                $year  = substr($UNTIL, 0, 4);
                $month = substr($UNTIL, 4, 2);
                $date  = substr($UNTIL, 6, 2);
                if (!checkdate($month, $date, $year)) {
                    $until = 0x7FFFFFFF;
                } else {
                    $until = gmmktime(23, 59, 59, $month, $date, $year);
                    if (!$event->allday) {
                        // �����л��֤ȥ��٥�Ȼ��֤����դ��ۤʤ���ˤ�UNTIL�⤺�餹
                        $until -= (int)($tzoffset_date * 86400);
                        // UTC -> server_TZ �λ����׻��ϹԤ�ʤ�
                        // $until -= (int)( $this->server_TZ * 3600 ) ;
                    }
                }
            } else {
                $until = 0x7FFFFFFF;
            }

            // WKST
            if (empty($WKST)) {

The variable $WKST seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                $WKST = 'MO';
            }

            // UnixTimestamp�ϰϳ��ν���
            if (isset($event->start_date)) {
                // ���Ϥ佪λ��2038ǯ�ʹߤʤ�Ÿ�����ʤ�
                if (date('Y', $event->start) >= 2038) {
                    return;
                }
                if (date('Y', $event->end) >= 2038) {
                    return;
                }

                // 1971ǯ��Ʊ��Ʊ���Ÿ���١�����start�Ȥ���
                $event->start = mktime(0, 0, 0, substr($event->start_date, 5, 2), substr($event->start_date, 8, 2), 1970 + 1);

                // end��1970�����ʤ顢����Ȥä�ȿ�ǡ������Ǥʤ����ϤȤꤢ�������� TODO
                if (isset($event->end_date)) {
                    $event->end = $event->start + ($event->date_diff + 1) * 86400;
                }
            }

            // ���پ�����
            $sqls = array();
            switch ($FREQ) {
                case 'DAILY':
                    $gmstart = $event->start + date('Z', $event->start);
                    $gmend   = $event->end + date('Z', $event->end);
                    for ($c = 1; $c < $count; ++$c) {
                        $gmstart += $INTERVAL * 86400;
                        $gmend   += $INTERVAL * 86400;
                        if ($gmstart > $until) {
                            break;
                        }
                        $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                    }
                    break;

                case 'WEEKLY':
                    $gmstart     = $event->start + date('Z', $event->start);
                    $gmstartbase = $gmstart;
                    $gmend       = $event->end + date('Z', $event->end);
                    $duration    = $gmend - $gmstart;
                    $wtop_date   = gmdate('j', $gmstart) - gmdate('w', $gmstart);
                    if ($WKST !== 'SU') {
                        $wtop_date = $wtop_date == 7 ? 1 : $wtop_date + 1;
                    }
                    $secondofday = $gmstart % 86400;
                    $month       = gmdate('m', $gmstart);
                    $year        = gmdate('Y', $gmstart);
                    $week_top    = gmmktime(0, 0, 0, $month, $wtop_date, $year);
                    $c           = 1;
                    // ���Ͳ���������κ���
                    $temp_dates = explode(',', $BYDAY);

The variable $BYDAY does not exist. Did you forget to declare it?

                    $wdays      = array_keys($this->byday2langday_w);
                    if ($WKST !== 'SU') {
                        // rotate wdays for creating array starting with Monday
                        $sun_date = array_shift($wdays);
                        array_push($wdays, $sun_date);
                    }
                    $dates = array();
                    foreach ($temp_dates as $date) {
                        // measure for bug of PHP<4.2.0
                        if (in_array($date, $wdays)) {
                            $dates[] = array_search($date, $wdays);
                        }
                    }
                    sort($dates);
                    $dates = array_unique($dates);
                    if (!count($dates)) {
                        return;
                    }
                    while (1) {
                        foreach ($dates as $date) {
                            // �����л��֤ȥ��٥�Ȼ��֤�����ۤʤ���ν����ɲ�
                            $gmstart = $week_top + ($date - $tzoffset_date) * 86400 + $secondofday;
                            if ($gmstart <= $gmstartbase) {
                                continue;
                            }
                            $gmend = $gmstart + $duration;
                            if ($gmstart > $until) {
                                break 2;
                            }
                            if (++$c > $count) {
                                break 2;
                            }
                            $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                        }
                        $week_top += $INTERVAL * 86400 * 7;
                    }
                    break;

                case 'MONTHLY':
                    $gmstart     = $event->start + date('Z', $event->start);
                    $gmstartbase = $gmstart;
                    $gmend       = $event->end + date('Z', $event->end);
                    $duration    = $gmend - $gmstart;
                    $secondofday = $gmstart % 86400;
                    $month       = gmdate('m', $gmstart);
                    $year        = gmdate('Y', $gmstart);
                    $c           = 1;
                    if (isset($BYDAY) && preg_match('/^(-1|[1-4])(SU|MO|TU|WE|TH|FR|SA)/', $BYDAY, $regs)) {
                        // ��N�������(BYDAY)�ξ���ʣ���Բġ�
                        // ��Ū�������ֹ�����
                        $wdays     = array_keys($this->byday2langday_w);
                        $wday      = array_search($regs[2], $wdays);
                        $first_ymw = gmdate('Ym', $gmstart) . (int)((gmdate('j', $gmstart) - 1) / 7);

$first_ymw is not used, you could remove the assignment.

                        if ($regs[1] == -1) {
                            // �ǽ�������ξ��Υ롼��
                            $monthday_bottom = gmmktime(0, 0, 0, $month, 0, $year);
                            while (1) {

This code seems to be duplicated across your project.

                                for ($i = 0; $i < $INTERVAL; ++$i) {
                                    $monthday_bottom += gmdate('t', $monthday_bottom + 86400) * 86400;
                                }
                                // �ǽ���������Ĵ�٤�
                                $last_monthdays_wday = gmdate('w', $monthday_bottom);
                                $date_back           = $wday - $last_monthdays_wday;
                                if ($date_back > 0) {
                                    $date_back -= 7;
                                }
                                // �����л��֤ȥ��٥�Ȼ��֤�����ۤʤ���ν����ɲ�
                                $gmstart = $monthday_bottom + ($date_back - $tzoffset_date) * 86400 + $secondofday;
                                if ($gmstart <= $gmstartbase) {
                                    continue;
                                }
                                $gmend = $gmstart + $duration;
                                if ($gmstart > $until) {
                                    break;
                                }
                                if (++$c > $count) {
                                    break;
                                }
                                $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                            }
                        } else {
                            // ��N������ξ��Υ롼��
                            $monthday_top       = gmmktime(0, 0, 0, $month, 1, $year);
                            $week_number_offset = ($regs[1] - 1) * 7 * 86400;
                            while (1) {
                                for ($i = 0; $i < $INTERVAL; ++$i) {
                                    $monthday_top += gmdate('t', $monthday_top) * 86400;
                                }
                                // ��N������������Ĵ�٤�
                                $week_numbers_top_wday = gmdate('w', $monthday_top + $week_number_offset);
                                $date_ahead            = $wday - $week_numbers_top_wday;
                                if ($date_ahead < 0) {
                                    $date_ahead += 7;
                                }
                                // �����л��֤ȥ��٥�Ȼ��֤�����ۤʤ���ν����ɲ�
                                $gmstart = $monthday_top + $week_number_offset + ($date_ahead - $tzoffset_date) * 86400 + $secondofday;
                                if ($gmstart <= $gmstartbase) {
                                    continue;
                                }
                                $gmend = $gmstart + $duration;
                                if ($gmstart > $until) {
                                    break;
                                }
                                if (++$c > $count) {
                                    break;
                                }
                                $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                            }
                        }
                    } elseif (isset($BYMONTHDAY)) {

The variable $BYMONTHDAY seems to never exist, and therefore isset should always return false. Did you maybe rename this variable?

                        // ���ջ���(BYMONTHDAY)�ξ���ʣ���ġ�
                        $monthday_top = gmmktime(0, 0, 0, $month, 1, $year);
                        // BYMONTHDAY ��������ơ�$dates����ˤ���
                        $temp_dates = explode(',', $BYMONTHDAY);
                        $dates      = array();
                        foreach ($temp_dates as $date) {
                            if ($date > 0 && $date <= 31) {
                                $dates[] = (int)$date;
                            }
                        }
                        sort($dates);
                        $dates = array_unique($dates);
                        if (!count($dates)) {
                            return;
                        }
                        while (1) {

This code seems to be duplicated across your project.

                            $months_day = gmdate('t', $monthday_top);
                            foreach ($dates as $date) {
                                // ��κǽ���ե?�����å�
                                if ($date > $months_day) {
                                    $date = $months_day;
                                }
                                // �����л��֤ȥ��٥�Ȼ��֤����դ��ۤʤ���ν����ɲ�
                                $gmstart = $monthday_top + ($date - 1 - $tzoffset_date) * 86400 + $secondofday;
                                if ($gmstart <= $gmstartbase) {
                                    continue;
                                }
                                $gmend = $gmstart + $duration;
                                if ($gmstart > $until) {
                                    break 2;
                                }
                                if (++$c > $count) {
                                    break 2;
                                }
                                $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                            }
                            for ($i = 0; $i < $INTERVAL; ++$i) {
                                $monthday_top += gmdate('t', $monthday_top) * 86400;
                            }
                        }
                    } else {
                        // ͭ���$BYDAY��$BYMONTHDAY��̵����С������֤�����ʤ�
                        return;
                    }
                    break;

                case 'YEARLY':
                    $gmstart     = $event->start + date('Z', $event->start);
                    $gmstartbase = $gmstart;
                    $gmend       = $event->end + date('Z', $event->end);
                    $duration    = $gmend - $gmstart;
                    $secondofday = $gmstart % 86400;
                    $gmmonth     = gmdate('n', $gmstart);

                    // empty BYMONTH
                    if (empty($BYMONTH)) {

The variable $BYMONTH seems only to be defined at a later point. As such the call to empty() seems to always evaluate to true.

                        $BYMONTH = $gmmonth;
                    }

                    // BYMONTH ��������ơ�$months����ˤ����BYMONTH��ʣ���ġ�
                    $temp_months = explode(',', $BYMONTH);
                    $months      = array();
                    foreach ($temp_months as $month) {
                        if ($month > 0 && $month <= 12) {
                            $months[] = (int)$month;
                        }
                    }
                    sort($months);
                    $months = array_unique($months);
                    if (!count($months)) {
                        return;
                    }

                    if (isset($BYDAY) && preg_match('/^(-1|[1-4])(SU|MO|TU|WE|TH|FR|SA)/', $BYDAY, $regs)) {
                        // ��N�������ξ���ʣ���Բġ�
                        // ��Ū�������ֹ�����
                        $wdays    = array_keys($this->byday2langday_w);
                        $wday     = array_search($regs[2], $wdays);
                        $first_ym = gmdate('Ym', $gmstart);
                        $year     = gmdate('Y', $gmstart);
                        $c        = 1;
                        if ($regs[1] == -1) {
                            // �ǽ�������ξ��Υ롼��
                            while (1) {
                                foreach ($months as $month) {
                                    // �ǽ���������Ĵ�٤�
                                    $last_monthdays_wday = gmdate('w', gmmktime(0, 0, 0, $month + 1, 0, $year));
                                    $date_back           = $wday - $last_monthdays_wday;
                                    if ($date_back > 0) {
                                        $date_back -= 7;
                                    }
                                    $gmstart = gmmktime(0, 0, 0, $month + 1, $date_back - $tzoffset_date, $year) + $secondofday;
                                    // ����Ʊ����������ɤ��������å�
                                    if (gmdate('Ym', $gmstart) <= $first_ym) {
                                        continue;
                                    }
                                    $gmend = $gmstart + $duration;
                                    if ($gmstart > $until) {
                                        break 2;
                                    }
                                    if (++$c > $count) {
                                        break 2;
                                    }
                                    $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                                }
                                $year += $INTERVAL;
                                if ($year >= 2038) {
                                    break;
                                }
                            }
                        } else {
                            // ��N������ξ��Υ롼��
                            $week_numbers_top_date = 1 + ($regs[1] - 1) * 7;
                            while (1) {
                                foreach ($months as $month) {
                                    // ��N������������Ĵ�٤�
                                    $week_numbers_top_wday = gmdate('w', gmmktime(0, 0, 0, $month, $week_numbers_top_date, $year));
                                    $date_ahead            = $wday - $week_numbers_top_wday;
                                    if ($date_ahead < 0) {
                                        $date_ahead += 7;
                                    }
                                    $gmstart = gmmktime(0, 0, 0, $month, $week_numbers_top_date + $date_ahead - $tzoffset_date, $year) + $secondofday;
                                    // ����Ʊ����������ɤ��������å�
                                    if (gmdate('Ym', $gmstart) <= $first_ym) {
                                        continue;
                                    }
                                    $gmend = $gmstart + $duration;
                                    if ($gmstart > $until) {
                                        break 2;
                                    }
                                    if (++$c > $count) {
                                        break 2;
                                    }
                                    $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                                }
                                $year += $INTERVAL;
                                if ($year >= 2038) {
                                    break;
                                }
                            }
                        }
                    } else {
                        // ���ջ���ξ��Υ롼�ס�ʣ���Բġ�
                        $first_date = gmdate('j', $gmstart);
                        $year       = gmdate('Y', $gmstart);
                        $c          = 1;
                        while (1) {
                            foreach ($months as $month) {
                                $date = $first_date;
                                // ��κǽ���ե?�����å�
                                while (!checkdate($month, $date, $year) && $date > 0) {
                                    $date--;
                                }
                                // $date �� gmdate('j') �������Ƥ��뤿�ᡢ$tzoffset_date �ν��������
                                $gmstart = gmmktime(0, 0, 0, $month, $date, $year) + $secondofday;
                                if ($gmstart <= $gmstartbase) {
                                    continue;
                                }
                                $gmend = $gmstart + $duration;
                                if ($gmstart > $until) {
                                    break 2;
                                }
                                if (++$c > $count) {
                                    break 2;
                                }
                                $sqls[] = $base_sql . ",start=$gmstart ,end=$gmend ";
                            }
                            $year += $INTERVAL;
                            if ($year >= 2038) {
                                break;
                            }
                        }
                    }
                    break;

                default:
                    return;
            }

            // echo "<pre>" ; var_dump( $sqls ) ; echo "</pre>" ; exit ;
            foreach ($sqls as $sql) {
                $GLOBALS['xoopsDB']->query($sql);
            }

            $result = $GLOBALS['xoopsDB']->query("SELECT id FROM {$this->table} WHERE rrule_pid={$event_id}");
            $pics   = $GLOBALS['xoopsDB']->query("SELECT * FROM {$this->pic_table} WHERE event_id={$event_id}");
            while ($event = $GLOBALS['xoopsDB']->fetchObject($result)) {
                $GLOBALS['xoopsDB']->query("DELETE FROM {$this->pic_table} WHERE event_id={$event->id}");
                mysqli_data_seek($pics, 0);
                while ($pic = $GLOBALS['xoopsDB']->fetchObject($pics)) {
                    $GLOBALS['xoopsDB']->query("INSERT INTO {$this->pic_table} SET event_id='{$event->id}', picture='{$pic->picture}', main_pic='{$pic->main_pic}'");
                }
            }
        }

        // The End of Class
    }
}