include/onupdate.php ➔ xoops_module_update_apcal()

Complexity

Conditions	26
Paths	9216

Size

Total Lines

198

Duplication

Lines	21
Ratio	10.61 %

Importance

Changes

0

<?php
function xoops_module_update_apcal(XoopsModule $module)

The return type could not be reliably inferred; please add a @return annotation.

{
    //    global $xoopsDB;
    $moduleDirName = basename(dirname(__DIR__));
    $capsDirName   = strtoupper($moduleDirName);

$capsDirName is not used, you could remove the assignment.

    if (!$GLOBALS['xoopsDB']->queryF("SELECT shortsummary FROM {$GLOBALS['xoopsDB']->prefix('apcal_event')}")) {

This code seems to be duplicated across your project.

        if ($GLOBALS['xoopsDB']->queryF("ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_event')} ADD shortsummary VARCHAR(255) AFTER groupid")) {
        }
    }
    $result = $GLOBALS['xoopsDB']->queryF("SELECT id, summary FROM {$GLOBALS['xoopsDB']->prefix('apcal_event')}");
    while ($row = $GLOBALS['xoopsDB']->fetchArray($result)) {
        $shortsummary = makeShort($row['summary']);
        $GLOBALS['xoopsDB']->queryF("UPDATE {$GLOBALS['xoopsDB']->prefix('apcal_event')} SET shortsummary='{$shortsummary}' WHERE id={$row['id']}");
    }

    if (!$GLOBALS['xoopsDB']->queryF("SELECT cat_shorttitle FROM {$GLOBALS['xoopsDB']->prefix('apcal_cat')}")) {

This code seems to be duplicated across your project.

        if ($GLOBALS['xoopsDB']->queryF("ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_cat')} ADD cat_shorttitle VARCHAR(255) AFTER enabled")) {
        }
    }
    $result = $GLOBALS['xoopsDB']->queryF("SELECT cid, cat_title FROM {$GLOBALS['xoopsDB']->prefix('apcal_cat')}");
    while ($row = $GLOBALS['xoopsDB']->fetchArray($result)) {
        $cat_shorttitle = makeShort($row['cat_title']);
        $GLOBALS['xoopsDB']->queryF("UPDATE {$GLOBALS['xoopsDB']->prefix('apcal_cat')} SET cat_shorttitle='{$cat_shorttitle}' WHERE cid={$row['cid']}");
    }

    if (!$GLOBALS['xoopsDB']->queryF("SELECT email,url,mainCategory, otherHours FROM {$GLOBALS['xoopsDB']->prefix('apcal_event')}")) {
        $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_event')} ";
        $sql .= 'ADD url VARCHAR( 255 ) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL DEFAULT \'\' AFTER location,';
        $sql .= 'ADD email VARCHAR( 255 ) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL DEFAULT \'\' AFTER url,';
        $sql .= 'ADD mainCategory SMALLINT( 5 ) UNSIGNED ZEROFILL NOT NULL DEFAULT \'00000\' AFTER dtstamp,';
        $sql .= 'ADD otherHours VARCHAR( 255 ) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL DEFAULT \'\' AFTER end';
        $GLOBALS['xoopsDB']->queryF($sql);
    }

    if (!$GLOBALS['xoopsDB']->queryF("SELECT color,canbemain FROM {$GLOBALS['xoopsDB']->prefix('apcal_cat')}")) {
        $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_cat')} ";
        $sql .= 'ADD color VARCHAR( 7 ) CHARACTER SET utf8 COLLATE utf8_general_ci NOT NULL DEFAULT \'#5555AA\' AFTER cat_desc,';
        $sql .= 'ADD canbemain TINYINT( 1 ) UNSIGNED NOT NULL DEFAULT \'0\' AFTER autocreated';
        $GLOBALS['xoopsDB']->queryF($sql);
    }

    $sql = "CREATE TABLE IF NOT EXISTS {$GLOBALS['xoopsDB']->prefix('apcal_pictures')} ";
    $sql .= '(id int(10) unsigned NOT NULL AUTO_INCREMENT,';
    $sql .= 'event_id int(10) unsigned zerofill NOT NULL,';
    $sql .= 'picture varchar(255) NOT NULL,';
    $sql .= 'main_pic tinyint(1) unsigned NOT NULL DEFAULT \'0\',';
    $sql .= 'PRIMARY KEY (id)) ';
    $sql .= 'ENGINE=MyISAM DEFAULT CHARSET=utf8';
    $GLOBALS['xoopsDB']->queryF($sql);

    $sql = "CREATE TABLE IF NOT EXISTS {$GLOBALS['xoopsDB']->prefix('apcal_ro_events')} (
            roe_id int(10) unsigned NOT NULL AUTO_INCREMENT,
            roe_eventid mediumint(8) unsigned zerofill NOT NULL DEFAULT '00000000',
            roe_number int(10) NOT NULL DEFAULT '0',
            roe_datelimit int(10) NOT NULL DEFAULT '0',
            roe_needconfirm INT(10) NOT NULL DEFAULT '0',
            roe_waitinglist INT(10) NOT NULL DEFAULT '0',
            roe_submitter int(10) NOT NULL DEFAULT '0',
            roe_date_created int(10) NOT NULL DEFAULT '0',
            PRIMARY KEY (roe_id),
            KEY event (roe_eventid))
            ENGINE=MyISAM  DEFAULT CHARSET=utf8 AUTO_INCREMENT=1";
    $GLOBALS['xoopsDB']->queryF($sql);

    $sql = "CREATE TABLE IF NOT EXISTS {$GLOBALS['xoopsDB']->prefix('apcal_ro_members')} (
            rom_id int(10) unsigned NOT NULL AUTO_INCREMENT,
            rom_eventid mediumint(8) unsigned zerofill NOT NULL DEFAULT '00000000',
            rom_firstname varchar(200) DEFAULT NULL,
            rom_lastname varchar(200) DEFAULT NULL,
            rom_email varchar(200) DEFAULT NULL,
            rom_extrainfo1 varchar(200) DEFAULT NULL,
            rom_extrainfo2 varchar(200) DEFAULT NULL,
            rom_extrainfo3 varchar(200) DEFAULT NULL,
            rom_extrainfo4 varchar(200) DEFAULT NULL,
            rom_extrainfo5 varchar(200) DEFAULT NULL,
            rom_poster_ip  varchar(200) DEFAULT NULL,
            rom_status int(10) NOT NULL DEFAULT '0',
            rom_submitter int(10) NOT NULL DEFAULT '0',
            rom_date_created int(10) NOT NULL DEFAULT '0',
            PRIMARY KEY (rom_id),
            UNIQUE KEY UNQ_EMAIL (rom_eventid, rom_email),
            KEY event (rom_eventid))
            ENGINE=MyISAM  DEFAULT CHARSET=utf8 AUTO_INCREMENT=1";
    $GLOBALS['xoopsDB']->queryF($sql);

    $sql = "CREATE TABLE IF NOT EXISTS {$GLOBALS['xoopsDB']->prefix('apcal_ro_notify')} (
            ron_id int(10) unsigned NOT NULL AUTO_INCREMENT,
            ron_eventid mediumint(8) unsigned zerofill NOT NULL DEFAULT '00000000',
            ron_email varchar(200) DEFAULT NULL,
            ron_submitter int(10) DEFAULT NULL,
            ron_date_created int(11) NOT NULL DEFAULT '0',
            PRIMARY KEY (ron_id),
            KEY event (ron_eventid))
            ENGINE=MyISAM  DEFAULT CHARSET=utf8 AUTO_INCREMENT=1";
    $GLOBALS['xoopsDB']->queryF($sql);

    $GLOBALS['xoopsDB']->queryF("UPDATE {$GLOBALS['xoopsDB']->prefix('apcal_event')} SET start_date=NULL,end_date=NULL");
    $GLOBALS['xoopsDB']->queryF("UPDATE {$GLOBALS['xoopsDB']->prefix('apcal_event')} t, (SELECT id, shortsummary FROM {$GLOBALS['xoopsDB']->prefix('apcal_event')} x WHERE x.rrule_pid>0 GROUP BY x.shortsummary ORDER BY start) AS e SET t.rrule_pid=e.id WHERE t.shortsummary=e.shortsummary;");

    //    fix problem from removed poster_ip
    $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_ro_members')} ADD `rom_status` INT(1) NOT NULL DEFAULT '0' AFTER `rom_extrainfo5`;";
    $GLOBALS['xoopsDB']->queryF($sql);
    //    fix problem from removed poster_ip
    $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_ro_members')} ADD `rom_poster_ip` VARCHAR(200) NULL DEFAULT '' AFTER `rom_extrainfo5`;";
    $GLOBALS['xoopsDB']->queryF($sql);

    //    fix problem from removed roe_waitinglist
    $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_ro_events')} ADD `roe_waitinglist` INT(10) NOT NULL DEFAULT '0' AFTER `roe_datelimit`;";
    $GLOBALS['xoopsDB']->queryF($sql);

    //    fix problem from removed roe_waitinglist
    $sql = "ALTER TABLE {$GLOBALS['xoopsDB']->prefix('apcal_ro_events')} ADD `roe_needconfirm` INT(10) NOT NULL DEFAULT '0' AFTER `roe_datelimit`;";
    $GLOBALS['xoopsDB']->queryF($sql);

    //    if (!is_dir(XOOPS_UPLOAD_PATH . '/apcal/')) {
    //        mkdir(XOOPS_UPLOAD_PATH . '/apcal/', 0755);
    //    }
    //    if (!is_dir(XOOPS_UPLOAD_PATH . '/apcal/thumbs/')) {
    //        mkdir(XOOPS_UPLOAD_PATH . '/apcal/thumbs/', 0755);
    //    }

    require_once __DIR__ . '/config.php';
    $configurator = new ModuleConfigurator();
    $classUtility = ucfirst($moduleDirName) . 'Utility';
    if (!class_exists($classUtility)) {
        xoops_load('utility', $moduleDirName);
    }

    //delete old HTML templates
    if (count($configurator->templateFolders) > 0) {
        foreach ($configurator->templateFolders as $folder) {
            $templateFolder = $GLOBALS['xoops']->path('modules/' . $moduleDirName . $folder);
            if (is_dir($templateFolder)) {
                $templateList = array_diff(scandir($templateFolder), array('..', '.'));
                foreach ($templateList as $k => $v) {
                    $fileInfo = new SplFileInfo($templateFolder . $v);
                    if ($fileInfo->getExtension() === 'html' && $fileInfo->getFilename() !== 'index.html') {
                        if (file_exists($templateFolder . $v)) {
                            unlink($templateFolder . $v);
                        }
                    }
                }
            }
        }
    }

    //  ---  DELETE OLD FILES ---------------
    if (count($configurator->oldFiles) > 0) {
        //    foreach (array_keys($GLOBALS['uploadFolders']) as $i) {
        foreach (array_keys($configurator->oldFiles) as $i) {
            $tempFile = $GLOBALS['xoops']->path('modules/' . $moduleDirName . $configurator->oldFiles[$i]);
            if (is_file($tempFile)) {
                unlink($tempFile);
            }
        }
    }

    //  ---  DELETE OLD FOLDERS ---------------
    xoops_load('XoopsFile');
    if (count($configurator->oldFolders) > 0) {
        //    foreach (array_keys($GLOBALS['uploadFolders']) as $i) {
        foreach (array_keys($configurator->oldFolders) as $i) {
            $tempFolder = $GLOBALS['xoops']->path('modules/' . $moduleDirName . $configurator->oldFolders[$i]);
            /* @var $folderHandler XoopsObjectHandler */
            $folderHandler = XoopsFile::getHandler('folder', $tempFolder);
            $folderHandler->delete($tempFolder);
        }
    }

    //  ---  CREATE FOLDERS ---------------
    if (count($configurator->uploadFolders) > 0) {

This code seems to be duplicated across your project.

        //    foreach (array_keys($GLOBALS['uploadFolders']) as $i) {
        foreach (array_keys($configurator->uploadFolders) as $i) {
            $classUtility::createFolder($configurator->uploadFolders[$i]);
        }
    }

    //  ---  COPY blank.png FILES ---------------
    if (count($configurator->blankFiles) > 0) {

This code seems to be duplicated across your project.

        $file = __DIR__ . '/../assets/images/blank.png';
        foreach (array_keys($configurator->blankFiles) as $i) {
            $dest = $configurator->blankFiles[$i] . '/blank.png';
            $classUtility::copyFile($file, $dest);
        }
    }

    //delete .html entries from the tpl table
    $sql = 'DELETE FROM ' . $GLOBALS['xoopsDB']->prefix('tplfile') . " WHERE `tpl_module` = '" . $module->getVar('dirname', 'n') . '\' AND `tpl_file` LIKE \'%.html%\'';
    $GLOBALS['xoopsDB']->queryF($sql);

    /** @var XoopsGroupPermHandler $gpermHandler */
    $gpermHandler = xoops_getHandler('groupperm');

    return $gpermHandler->deleteByModule($module->getVar('mid'), 'item_read');

    return true;

return true; does not seem to be reachable.

}