These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | /** |
||
3 | * Adminer Module based on Ghost Module |
||
4 | * |
||
5 | * You may not change or alter any portion of this comment or credits |
||
6 | * of supporting developers from this source code or any supporting source code |
||
7 | * which is considered copyrighted (c) material of the original comment or credit authors. |
||
8 | * This program is distributed in the hope that it will be useful, |
||
9 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
||
10 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. |
||
11 | * |
||
12 | * @copyright The XOOPS Project http://sourceforge.net/projects/xoops/ |
||
13 | * @license http://www.fsf.org/copyleft/gpl.html GNU public license |
||
14 | * @package Adminer Module |
||
15 | * @since 2.3.0 |
||
16 | * @author Kris <http://www.xoofoo.org> |
||
17 | * @version $Id $ |
||
18 | **/ |
||
19 | // connect xoops database |
||
20 | defined('XOOPS_ROOT_PATH') || include dirname(dirname(__DIR__)) . '/mainfile.php'; |
||
21 | |||
22 | $moduleDirName = basename(__DIR__); |
||
23 | include(XOOPS_ROOT_PATH . '/header.php'); |
||
24 | View Code Duplication | if (!is_object($xoopsUser) || !is_object($xoopsModule) || !$xoopsUser->isAdmin($xoopsModule->mid())) { |
|
0 ignored issues
–
show
|
|||
25 | exit(_NOPERM); |
||
26 | } |
||
27 | |||
28 | View Code Duplication | function adminer_object() |
|
0 ignored issues
–
show
This function seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. ![]() The function
adminer_object() has been defined more than once; this definition is ignored, only the first definition in admin/getEditor.php (L26-74) is considered.
This check looks for functions that have already been defined in other files. Some Codebases, like WordPress, make a practice of defining functions multiple times. This
may lead to problems with the detection of function parameters and types. If you really
need to do this, you can mark the duplicate definition with the /**
* @ignore
*/
function getUser() {
}
function getUser($id, $realm) {
}
See also the PhpDoc documentation for @ignore. ![]() |
|||
29 | { |
||
30 | class AdminerKfr extends Adminer |
||
0 ignored issues
–
show
Comprehensibility
Best Practice
introduced
by
The type
AdminerKfr has been defined more than once; this definition is ignored, only the first definition in editor.php (L31-52) is considered.
This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. ![]() |
|||
31 | { |
||
32 | public function name() |
||
33 | { |
||
34 | return 'XOOPS Admin'; |
||
35 | } |
||
36 | |||
37 | public function credentials() |
||
38 | { |
||
39 | return array(XOOPS_DB_HOST, XOOPS_DB_USER, XOOPS_DB_PASS); |
||
40 | } |
||
41 | |||
42 | public function database() |
||
43 | { |
||
44 | return XOOPS_DB_NAME; |
||
45 | } |
||
46 | |||
47 | public function login($login, $password) |
||
48 | { |
||
49 | return ($login == XOOPS_DB_USER); |
||
50 | } |
||
51 | } |
||
52 | |||
53 | return new AdminerKfr; |
||
54 | } |
||
55 | |||
56 | /* |
||
0 ignored issues
–
show
Unused Code
Comprehensibility
introduced
by
49% of this comment could be valid code. Did you maybe forget this after debugging?
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. ![]() |
|||
57 | function adminer_object() { |
||
58 | include_once "./include/plugins/plugin.php"; |
||
59 | foreach (glob("include/plugins/*.php") as $filename) { |
||
60 | include_once "./$filename"; |
||
61 | } |
||
62 | $plugins = array( |
||
63 | new AdminerDumpBz2, |
||
64 | new AdminerDumpJson, |
||
65 | new AdminerDumpZip, |
||
66 | new AdminerDumpXml, |
||
67 | new AdminerEditCalendar, |
||
68 | new AdminerFasterTablesFilter, |
||
69 | new AdminerFrames, |
||
70 | new AdminerLoginServers, |
||
71 | new AdminerLoginTable, |
||
72 | new AdminerVersionNoverify, |
||
73 | new AdminerTinymce, |
||
74 | new AdminerFileUpload("data/"), |
||
75 | new AdminerSlugify, |
||
76 | new AdminerTranslation, |
||
77 | new AdminerForeignSystem, |
||
78 | ); |
||
79 | return new AdminerPlugin($plugins); |
||
80 | } |
||
81 | */ |
||
82 | include __DIR__ . '/include/adminer.php'; |
||
83 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.