action.module.php ➔ xoops_module_update_about() - Code Metrics - Inspection of "Merge pull request #14 from mambax7/master" - XoopsModules25x/about - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6ae33d...022918 )

by Michael

created 2019-02-12 05:21 UTC

action.module.php ➔ xoops_module_update_about() D

↳ Parent: Project

Complexity

Conditions	12
Paths	216

Size

Total Lines	43
Code Lines	23

Duplication

Lines	16
Ratio	37.21 %

Importance

Changes

Metric	Value
cc	12
eloc	23
nc	216
nop	2
dl	16
loc	43
rs	4.4061
c	0
b	0
f	0

How to fix Complexity

<?php

use XoopsModules\About;

defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Prepares system prior to attempting to install module
 *
 * @param \XoopsModule $module
 *
 * @return bool       true if ready to install, false if not
 */
function xoops_module_pre_install_about(\XoopsModule $module)
{
    require_once dirname(__DIR__) . '/preloads/autoloader.php';
    /** @var About\Utility $utility */
    $utility      = new About\Utility();
    $xoopsSuccess = $utility::checkVerXoops($module);
    $phpSuccess   = $utility::checkVerPhp($module);

    if ($xoopsSuccess && $phpSuccess) {
        $moduleTables = &$module->getInfo('tables');
        foreach ($moduleTables as $table) {
            $GLOBALS['xoopsDB']->queryF('DROP TABLE IF EXISTS ' . $GLOBALS['xoopsDB']->prefix($table) . ';');
        }
    }

    return $xoopsSuccess && $phpSuccess;
}

/**
 * @param  \XoopsModule $module
 * @return bool        true if install successful, false if not
 */
function xoops_module_install_about(\XoopsModule $module)
{
    $success   = true;
    $data_file = XOOPS_ROOT_PATH . '/modules/about/sql/mysql.about.sql';
    $GLOBALS['xoopsDB']->queryF('SET NAMES utf8');
    if (!$GLOBALS['xoopsDB']->queryFromFile($data_file)) {
        $module->setErrors('Pre-set data was not installed');
        // preset info not set, but don't 'fail' install because of this
        //$success = false;
    }

    // Delete files from previous version (if they exist)
    // this is only executed if this version copied over old version without running module update
    $oldFiles = [
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/include/xoopsformloader.php',
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/include/blockform.php',
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/class/utilities.php',
    ];
    foreach ($oldFiles as $file) {
        if (is_file($file)) {
            $delOk = unlink($file);
            if (!$delOk) {
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_REMOVE, $file));
            } else {
                $module->setErrors(sprintf(_AM_ABOUT_DELETED, $file));
            }
            $success = $success && $delOk;
        }
    }
    // Create uploads folder
    $dirOk = mkdir(XOOPS_UPLOAD_PATH . '/' . $module->dirname());
    if (!$dirOk) {
        $module->setErrors(_AM_ABOUT_ERROR_BAD_UPLOAD_DIR);
    }

    return $dirOk && $success;
}

/**
 * Prepares system prior to attempting to install module
 *
 * @param \XoopsModule $module
 *
 * @return bool       true if ready to install, false if not
 */
function xoops_module_pre_update_about(\XoopsModule $module)
{
    /** @var About\Helper $helper */
    /** @var About\Utility $utility */
    $moduleDirName = basename(dirname(__DIR__));

    /** @var \XoopsModules\About\Helper $helper */
    $helper  = \XoopsModules\About\Helper::getInstance();

    $utility = new About\Utility();

    $xoopsSuccess = $utility::checkVerXoops($module);
    $phpSuccess   = $utility::checkVerPhp($module);

    return $xoopsSuccess && $phpSuccess;
}

/**
 * @param  XoopsModule $module
 * @param  null        $prev_version

 * @return bool        true if update successful, false if not
 */
function xoops_module_update_about(\XoopsModule $module, $prev_version = null)
function xoops_module_update_about(\XoopsModule $module, /** @scrutinizer ignore-unused */ $prev_version = null)
{
    $success = true;
    // Delete files from previous version (if they exist)
    $oldFiles = [
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/include/xoopsformloader.php',
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/include/blockform.php',
        XOOPS_ROOT_PATH . '/modules/' . $module->dirname() . '/class/utilities.php',
    ];
    foreach ($oldFiles as $file) {
        if (is_file($file)) {
            if (!$delOk = unlink($file)) {
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_REMOVE, $file));
            }
            $success = $success && $delOk;
        }
    }

    // Delete files from previous version (if they exist)
    // this is only executed if this version copied over old version without running module update
    $oldFiles = [
        XOOPS_PATH . '/modules/' . $module->dirname() . '/include/xoopsformloader.php',
        XOOPS_PATH . '/modules/' . $module->dirname() . '/include/blockform.php',
    ];
    foreach ($oldFiles as $file) {
        if (is_file($file)) {
            if (!$delOk = unlink($file)) {
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_REMOVE, $file));
            }
            $success = $success && $delOk;
        }
    }

    // Create uploads folder if it doesn't exist
    $dirOk = true;
    if (!file_exists(XOOPS_UPLOAD_PATH . '/' . $module->dirname())) {
        // File doesn't exist so try and create it
        $dirOk = mkdir(XOOPS_UPLOAD_PATH . '/' . $module->dirname());
        if (!$dirOk) {
            $module->setErrors(_AM_ABOUT_ERROR_BAD_UPLOAD_DIR);
        }
    }

    return $dirOk && $success;
}

/**
 * Function to complete upon module uninstall
 *
 * @param \XoopsModule $module
 *
 * @return bool       true if successfully executed uninstall of module, false if not
 */
function xoops_module_uninstall_about(\XoopsModule $module)
{
    $moduleDirName = $module->dirname();
    /** @var \XoopsModules\About\Helper $helper */
    $helper  = \XoopsModules\About\Helper::getInstance();
    $utility = new \XoopsModules\About\Utility();

    $success = true;
    $helper->loadLanguage('admin');

    //------------------------------------------------------------------
    // Remove module uploads folder (and all subfolders) if they exist
    //------------------------------------------------------------------

    $old_directories = [XOOPS_UPLOAD_PATH . "/{$moduleDirName}"];
    foreach ($old_directories as $old_dir) {
        $dirInfo = new \SplFileInfo($old_dir);
        if ($dirInfo->isDir()) {
            // The directory exists so delete it
            if (!$utility::rrmdir($old_dir)) {
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_DEL_PATH, $old_dir));
                $success = false;
            }
        }
        unset($dirInfo);
    }

    return $success;
}


XoopsModules25x / about

Push — master ( 6ae33d...022918 )

action.module.php ➔ xoops_module_update_about() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like