View GitHub Repository about

Schedule Inspection
Subscribe

Code Duplication    Length = 8-8 lines in 2 locations

include/action.module.php 2 locations

@@ 101-108 (lines=8) @@
98 
                      XOOPS_ROOT_PATH . "/modules/" . $module->dirname() . "/include/blockform.php",
99 
                      XOOPS_ROOT_PATH . "/modules/" . $module->dirname() . "/class/utilities.php"
100 
    );
101 
    foreach($oldFiles as $file) {
102 
        if (is_file($file)) {
103 
            if (false === ($delOk = unlink($file))) {
104 
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_REMOVE, $file));
105 
            }
106 
            $success = $success && $delOk;
107 
        }
108 
    }
109 

                                

                                                            

                                    110
                                    
                                    
    // Delete files from previous version (if they exist)

                                

                                                            

                                    111
                                    
                                    
    // this is only executed if this version copied over old version without running module update

                                

                                                                                

                                
                                
                                    @@ 115-122 (lines=8) @@
                                
                            


                                                            

                                    112
                                    
                                    
    $oldFiles = array(XOOPS_PATH . "/modules/" . $module->dirname() . "/include/xoopsformloader.php",

                                

                                                            

                                    113
                                    
                                    
                      XOOPS_PATH . "/modules/" . $module->dirname() . "/include/blockform.php"

                                

                                                            

                                    114
                                    
                                    
    );

                                

                                                            

                                    115
                                    
                                    
    foreach($oldFiles as $file) {

                                

                                                            

                                    116
                                    
                                    
        if (is_file($file)) {

                                

                                                            

                                    117
                                    
                                    
            if (false === ($delOk = unlink($file))) {

                                

                                                            

                                    118
                                    
                                    
                $module->setErrors(sprintf(_AM_ABOUT_ERROR_BAD_REMOVE, $file));

                                

                                                            

                                    119
                                    
                                    
            }

                                

                                                            

                                    120
                                    
                                    
            $success = $success && $delOk;

                                

                                                            

                                    121
                                    
                                    
        }

                                

                                                            

                                    122
                                    
                                    
    }

                                

                                                            

                                    123
                                    
                                    

                                

                                                            

                                    124
                                    
                                    
    // Create uploads folder if it doesn't exist

                                

                                                            

                                    125
                                    
                                    
    $dirOk = true;